| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-06 | |||
| 15:54:23 | jaypipes | dansmith: count(indexed_col) is the fastest way for innodb tables, yes. | |
| 15:54:23 | stephenfin | mriedem: Only thing that needed changing was a 'nova.conf' option (notes on the review). Thought that was too specific to note but let me know if you think otherwise. | |
| 15:54:39 | dansmith | jaypipes: and count(unindexed_column) is expensive? | |
| 15:55:02 | dansmith | and count(*) ? | |
| 15:58:18 | openstackgerrit | Merged openstack/nova stable/queens: [placement] Add sending global request ID in put (3) https://review.openstack.org/543113 | |
| 15:58:25 | openstackgerrit | Merged openstack/nova stable/queens: Update noVNC deployment docs to mention non-US keymap fix in 1.0.0 https://review.openstack.org/548057 | |
| 15:58:34 | openstackgerrit | Merged openstack/nova stable/queens: [placement] Add functional tests for traits API https://review.openstack.org/547843 | |
| 15:58:50 | jaypipes | dansmith: yes sir | |
| 15:58:54 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646 | |
| 15:58:54 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Resource class set (v1.7) https://review.openstack.org/514644 | |
| 15:58:55 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819 | |
| 15:58:55 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647 | |
| 15:58:56 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675 | |
| 15:58:56 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674 | |
| 15:58:57 | jaypipes | dansmith: (sorry, on a webex concurrently...) | |
| 15:58:57 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | |
| 15:58:57 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043 | |
| 15:59:19 | dansmith | jaypipes: okay, I guess it seems like mysql must keep a row count somewhere that we can get at for free, but it's not critical | |
| 16:01:19 | mriedem | stephenfin: ack | |
| 16:02:30 | stephenfin | dansmith: Given that vnc/spice options are only used by nova-compute, would it make sense to only set them in 'nova-cpu.conf' in DevStack? | |
| 16:02:48 | dansmith | stephenfin: yeah | |
| 16:02:58 | stephenfin | dansmith: Cool. I'll do that | |
| 16:03:59 | mriedem | stephenfin: so novnc 1.0 has a breaking change huh | |
| 16:04:01 | mriedem | on the base url | |
| 16:04:24 | stephenfin | mriedem: Yup. That seems to be the only one I could identify though | |
| 16:05:15 | stephenfin | i.e. it just worked once I changed that | |
| 16:06:08 | openstackgerrit | Merged openstack/nova stable/queens: libvirt: disconnect volume from host during detach https://review.openstack.org/546655 | |
| 16:08:13 | jaypipes | dansmith: innodb keeps a count of records in an index, yes. not for the total table, though. | |
| 16:08:22 | dansmith | jaypipes: okay | |
| 16:10:50 | artom | stephenfin, does xenapi not use VNC? | |
| 16:11:16 | artom | Err, why did I parse "nova-compute" as "libvirt"? | |
| 16:11:25 | artom | Ignore the noise :/ | |
| 16:11:36 | stephenfin | artom: Yeah, unrelated. However, I do think they mostly use XVP instead | |
| 16:13:53 | mriedem | stephenfin: comments inline | |
| 16:14:40 | mriedem | stephenfin: i'm less concerned about the excessive warning logs, but we need to mention the impact to novncproxy_base_url when using novnc >= 1.0.0 | |
| 16:14:54 | openstackgerrit | Merged openstack/nova stable/queens: unquiesce instance on volume snapshot failure https://review.openstack.org/545961 | |
| 16:15:01 | openstackgerrit | Merged openstack/nova stable/queens: Add the ability to get absolute limits from Cinder https://review.openstack.org/546157 | |
| 16:15:42 | stephenfin | mriedem: Fair. I'll address those now | |
| 16:47:31 | mriedem | jgriffith: really small cleanups for https://review.openstack.org/#/c/548427/ - otherwise looks ready | |
| 16:47:36 | mriedem | jgriffith: i can hit those if you're busy | |
| 16:49:02 | openstackgerrit | sahid proposed openstack/nova-specs master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/539605 | |
| 16:50:15 | dansmith | mriedem: did we agree on a specless blueprint for the db purge stuff? | |
| 16:51:03 | mriedem | dansmith: yeah i think so | |
| 16:51:03 | sahid | mriedem: if you can add this in your queue, https://review.openstack.org/#/c/485522/ - we have the code ready so i think it would be nice to make progress | |
| 16:51:19 | dansmith | cool | |
| 16:51:21 | mriedem | sahid: yeah i need to go over that | |
| 16:51:32 | sahid | cool thanks | |
| 16:54:45 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | |
| 16:55:19 | openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 17:01:34 | openstackgerrit | Merged openstack/nova stable/queens: Add resource_class to fields in ironic node cache https://review.openstack.org/546085 | |
| 17:04:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Check for multiattach before removing connections https://review.openstack.org/548427 | |
| 17:04:53 | mriedem | jgriffith: i updated it ^ +2 now, thanks a ton | |
| 17:05:12 | mriedem | cores ^ and the patch below it are needed to fix a pretty severe issue with multiattach to connections on the same host | |
| 17:05:21 | mriedem | gonna need to bakcport that to queens and cut a patch release | |
| 17:07:18 | gibi | Kevin_Zheng: If you have time and interest then you can help me with https://blueprints.launchpad.net/nova/+spec/add-request-id-to-instance-action-notifications | |
| 17:08:04 | gibi | Kevin_Zheng: we can reassing the bp to you so you can propose the implementation and then I will go and review it | |
| 17:09:11 | mnaser | hey, small riddle: you create a vm with nova, it creates ports in a neutron network, you detach those ports using the nova interface detach api .. what happens to those ports?! | |
| 17:10:46 | cfriesen | mnaser: I'd assume they hang around in neutron | |
| 17:10:49 | bauzas | mriedem: looking but a bit complex | |
| 17:11:01 | mnaser | cfriesen: except nova deletes them | |
| 17:11:41 | mnaser | so i did a little research and the preserve_on_delete for neutron ports gets set only if the ports are manually assigned on boot (or later attached) | |
| 17:11:54 | mnaser | if nova creates the port, preserve_on_delete=False so detaching the port via the api destroys it in nova | |
| 17:11:54 | cfriesen | mnaser: I'm guessing someone thought it made sense for nova to delete them since nova created them. not sure I agree in this case. | |
| 17:12:21 | mnaser | well, interface *detach* should be an explicit detach. especially if i'm manually detaching it from a running instance | |
| 17:12:35 | mnaser | i'm trying to understand where i can start fixing this (probably by writing a bug) | |
| 17:13:14 | openstackgerrit | Dan Smith proposed openstack/nova master: Add simple db purge command https://review.openstack.org/550171 | |
| 17:13:23 | bauzas | mriedem: mmmm, that's a big stuff https://review.openstack.org/#/c/548427/9/nova/virt/libvirt/driver.py | |
| 17:13:50 | bauzas | mriedem: so, when disconnecting the volume, we should ask Cinder and look at all the instances ? huh | |
| 17:14:14 | bauzas | I understand why we do this | |
| 17:14:16 | mriedem | bauzas: we have to do connection counting for that volume and instances on the same host | |
| 17:14:21 | mriedem | but only for multiattach volumes | |
| 17:14:28 | bauzas | yeah I understand that | |
| 17:14:29 | mriedem | this patch is also written to be backportable | |
| 17:14:37 | bauzas | but wow, it's a big call, right? | |
| 17:14:42 | mriedem | what is? | |
| 17:15:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'keymap' options https://review.openstack.org/483994 | |
| 17:15:14 | bauzas | every time we would disconnect the volume, we would have to call Cinder *and* verify all the instances | |
| 17:15:19 | stephenfin | mriedem: Done, good sir ^ | |
| 17:15:20 | bauzas | for the host | |
| 17:15:26 | mriedem | bauzas: for multiattach volumes yes | |
| 17:15:55 | mriedem | bauzas: the attached host for the volumes is in the cinder API, | |
| 17:16:15 | mriedem | but as discussed in the nova/cinder session last thursday, cinder is going to add an admin-only policy rule to not return that attached host information | |
| 17:16:17 | mriedem | so we can't rely on it here | |
| 17:16:33 | cfriesen | mnaser: write up a bug and poke mriedem to look at it since he's the neutron contact in the wiki. | |
| 17:16:44 | mriedem | if we did a kind of admin client thing for cinder, like we do for neutron port binding, we could get that information from cinder w/o going to the nova db to get the instances on this host | |
| 17:16:55 | mriedem | cfriesen: mnaser: it's not a bug | |
| 17:17:12 | mriedem | there was a spec from someone at some point about adding a delete_on_termination like flag for ports like we have for bdms | |
| 17:17:18 | mriedem | i can't find it anymore | |
| 17:17:20 | bauzas | mriedem: yeah I was thinking of that | |
| 17:17:22 | bauzas | but anyway | |
| 17:17:37 | bauzas | if you want to backport it, then it could be a problem if we ask Cinder to modify their API | |
| 17:17:48 | bauzas | so I think I'm +1, just need to verify the tests | |
| 17:17:54 | mnaser | the use-case is: user A booted an instance A, user A wants to move the port from instance A and instance B, they can't do it because a detach destroys the port and they need admin api to create ports with specific ips | |
| 17:18:57 | cfriesen | mnaser: currently I think you'd have to create the port first and hand it to nova when booting the instance. Then the detach should leave it around. | |
| 17:19:14 | mriedem | bauzas: if you want to read through the back and forth comments earlier in the review, there are several options here, but not backportable ones | |
| 17:19:17 | mnaser | cfriesen: yeah, but if you created an instance 2 years ago and never thought about this, it gets a bit hectic but yeah | |
| 17:19:28 | mriedem | bauzas: so we have this to backport to queens, it will work out of the box, no operator config needed to fix the bug, | |
| 17:19:28 | bauzas | mriedem: yeah, okay, anyway | |
| 17:19:37 | bauzas | yeah, I'm just writing that comment | |
| 17:19:46 | mriedem | we could optimize in the future if we can rely on cinder admin creds in nova.conf and can escalate our volume api calls like we do for neutron | |