| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-22 | |||
| 16:24:54 | mriedem | don't get me started on awkward dict | |
| 16:25:04 | jaypipes | oh boy, here it comes | |
| 16:25:15 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Explain how filters differ for /r_p vs. /a_c https://review.openstack.org/547056 | |
| 16:25:17 | efried | mriedem: There ya go, ya pedant ^ | |
| 16:25:19 | efried | dansmith: ^ | |
| 16:25:48 | dansmith | efried: disappointed you didn't shame mriedem a little more with commit message snark | |
| 16:26:01 | efried | oh, I forgot my backreference, sec... | |
| 16:26:09 | edleafe | efried: yeah, -1 for lack of snark | |
| 16:26:22 | mriedem | give me a f'ing break | |
| 16:26:32 | mriedem | from the placement people that complain constantly about not documenting decisions enough | |
| 16:26:50 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Explain how filters differ for /r_p vs. /a_c https://review.openstack.org/547056 | |
| 16:26:57 | efried | fixed commit message ^ | |
| 16:27:06 | dansmith | mriedem: I kid, I kid <3 | |
| 16:27:24 | efried | mriedem: You're right, you're right, you're always right. | |
| 16:27:34 | mriedem | dansmith: you're not in the 'we don't document stuff enough' camp | |
| 16:27:47 | efried | (that chant doesn't come across quite the same in IRC as when I have to say it to my wife) | |
| 16:27:53 | dansmith | mriedem: yep, just wild-west cowboy style for me.. pew pew | |
| 16:28:56 | jaypipes | lol | |
| 16:29:25 | mriedem | i assume those chaps are assless | |
| 16:29:34 | mriedem | which is redundant i know | |
| 16:30:04 | efried | It's gonna be low to mid 30s in Dublin. | |
| 16:30:14 | jaypipes | well, assless chaps really are the best place to store an awkward dict. | |
| 16:30:27 | jaypipes | I'll be here all week folks. | |
| 16:30:29 | efried | Please dansmith, for the love of all that is hol(e)y, wear something under those chaps. | |
| 16:30:46 | efried | Not a kilt, either | |
| 16:32:32 | mriedem | easy bug fix here compadres https://review.openstack.org/#/c/546268/ | |
| 16:34:29 | jaypipes | -2 | |
| 16:35:16 | mriedem | hongbin: i was thinking about your simple fix here https://review.openstack.org/#/c/546357/ - we should likely have a functional test change with that too, and i think there might be an easy way to do that with an existing test | |
| 16:35:26 | efried | jaypipes, dansmith: Does GET /resource_providers?resources=... take allocations into account? | |
| 16:35:37 | jaypipes | efried: yes | |
| 16:35:43 | efried | k | |
| 16:36:13 | mriedem | hongbin: see https://review.openstack.org/#/c/546268/1/nova/tests/functional/test_servers.py - you can probably modify that same functional test such that before posting the rebuild action, we change the compute provider's inventory such that placement wouldn't return the provider w/o your fix | |
| 16:36:28 | hongbin | mriedem: sure, will look into it | |
| 16:37:11 | jaypipes | mriedem: done. | |
| 16:37:29 | mriedem | hongbin: thanks for that patch btw, it was a lot simpler than i thought it would be | |
| 16:37:36 | mriedem | jaypipes: thanks | |
| 16:44:21 | openstackgerrit | Eric Fried proposed openstack/nova master: Clarify `resources` query param for /r_p and /a_c https://review.openstack.org/547065 | |
| 16:44:31 | efried | jaypipes, mriedem, dansmith: There's that clarification you asked for ^ | |
| 16:44:45 | mriedem | you missed your reference again | |
| 16:45:06 | jaypipes | lolol | |
| 16:45:22 | efried | the faah? | |
| 16:45:31 | mriedem | efried: but thanks for actually following up with my complaints | |
| 16:45:38 | mriedem | karma points abound | |
| 16:45:51 | efried | High impact:work ratio | |
| 16:46:20 | mriedem | the guy that died via sexual asphyixiation? | |
| 16:46:29 | jaypipes | rofl, no | |
| 16:46:30 | mriedem | oh the white haired guy | |
| 16:46:30 | efried | oy vay, you people. | |
| 16:46:35 | jaypipes | yes | |
| 16:46:45 | jaypipes | thanks goodness I wasn't sipping coffee just nopw | |
| 16:46:54 | mriedem | i was thinking carradine | |
| 16:46:57 | mriedem | isn't that how he died? | |
| 16:47:00 | jaypipes | yes, I got that. | |
| 16:47:01 | mriedem | he's dead right? | |
| 16:47:03 | jaypipes | yes | |
| 16:47:08 | mriedem | ok, whew | |
| 16:47:10 | openstackgerrit | Eric Fried proposed openstack/nova master: Clarify `resources` query param for /r_p and /a_c https://review.openstack.org/547065 | |
| 16:47:19 | efried | Updated commit msg, sheesh ^ | |
| 16:48:05 | openstack | Launchpad bug 1750790 in OpenStack Compute (nova) "resources on target host aren't released if resize fails" [Undecided,New] | |
| 16:48:05 | bauzas | dansmith: https://bugs.launchpad.net/nova/+bug/1750790 should be marked as Wontfix, right? | |
| 16:48:18 | bauzas | dansmith: as it's a Pike bug, and you fixed that in queens | |
| 16:49:19 | dansmith | um | |
| 16:49:41 | kashyap | bauzas: BTW, once distributions upgrade to Linux 4.14 kernel, this will cease to be "Low" priority | |
| 16:49:55 | kashyap | It'll definitely bite us, and cause nuisance | |
| 16:50:16 | dansmith | bauzas: I'm not sure why we wouldn't fix it in pike just because we fixed it in queens | |
| 16:50:52 | efried | dansmith: bauzas may be basing that statement on something I said at 5am. This is about duplicate allocations on source & target. | |
| 16:50:53 | bauzas | dansmith: no worries, I'll leave the bug open | |
| 16:51:11 | bauzas | I'm way off reviewing specs, and I need to | |
| 16:51:16 | dansmith | efried: okay | |
| 16:51:18 | bauzas | so I'll stop looking at bugs | |
| 16:51:27 | dansmith | I expect it's fixed in queens because of migration allocations | |
| 16:51:32 | efried | I didn't know whether we punted fixing that in pike because too complicated, and just fixed it in Queens with cdent's POST allocations business | |
| 16:51:32 | mriedem | bauzas: that's likely a bug that claudiub has a fix up for | |
| 16:51:34 | dansmith | but we probably need a fix for pike still | |
| 16:51:43 | mriedem | dansmith: bauzas: not necessarily | |
| 16:51:46 | mriedem | depends on where the failure happens | |
| 16:51:52 | efried | yeah. But I also didn't know whether resize ~= migration in this case | |
| 16:52:02 | mriedem | resize = cold migrate | |
| 16:52:13 | efried | but still subject to duplicate allocations mriedem? | |
| 16:52:25 | efried | i would spect so | |
| 16:52:27 | mriedem | bauzas: dansmith: this https://review.openstack.org/#/c/543971/ | |
| 16:52:37 | dansmith | mriedem: um, what? we only need a fix depending on where it happens? | |
| 16:52:50 | mriedem | efried: all move operations require an allocation on the source and dest hosts, | |
| 16:53:06 | efried | makes sense. | |
| 16:53:07 | mriedem | pre-queens, we just doubled those rather than split them | |
| 16:53:11 | bauzas | mriedem: excellent, tz | |
| 16:53:17 | bauzas | will close the bug as duplicate | |
| 16:53:21 | mriedem | dansmith: if prep_resize fails, we cleanup the allocations | |
| 16:53:31 | mriedem | if resize_instance fails, we don't, which is https://review.openstack.org/#/c/543971/ | |
| 16:53:42 | mriedem | there are 10 places you can blow off your foot with resize | |
| 16:53:57 | dansmith | sure, sounded like you were disagreeing with me that we need a fix | |
| 16:54:24 | mriedem | i think we're talking about different things | |
| 16:54:33 | mriedem | or different failure scenarios | |
| 16:54:36 | bauzas | right | |
| 16:54:56 | bauzas | anyway, I'm done with triaging bugs for that week | |
| 16:55:02 | mriedem | bauzas: i don't know if it's a duplicate, depends on where it fails | |
| 16:55:18 | mriedem | where does resize fail for missing ssh host keys? | |
| 16:55:25 | bauzas | mriedem: anyhow, the bug was reported because the user forgot to provide SSH keys | |
| 16:55:35 | bauzas | while we ask for that | |
| 16:55:45 | mriedem | ok let's assume it's the same problem then :) | |