Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-22
16:15:06 ansiwen bauzas: mriedem _if_ something breaks, it could take quite a while until it is fixed.
16:15:24 mriedem ansiwen: it takes us 4 years to fix a bug
16:15:26 mriedem so it's fine
16:15:27 bauzas that's exactly what a maintenance state describes
16:15:40 bauzas it doesn't tell you how long you will fix bugs
16:15:46 ansiwen mriedem: he he... ok, fair enough :-)
16:15:57 bauzas it will just say "okay, we know we have bugs and we will provide bugfixes soon"
16:16:18 mriedem soon, or not,
16:16:19 mriedem whatever
16:16:23 bauzas "but for features, don't get me wrong and don't expect a pony"
16:16:34 mriedem unless that pony makes it run at the EDGE
16:17:01 bauzas "unless you have your pockets full of dollars"
16:17:09 bauzas or euros, rather
16:17:12 mriedem right that too
16:17:14 bauzas given the exchange rate
16:18:35 mriedem jaypipes: so on your compute capabilities traits patch, i was thinking,
16:18:43 openstack Launchpad bug 1750790 in OpenStack Compute (nova) "resources on target host aren't released if resize fails" [Undecided,New]
16:18:43 jaypipes uhoh
16:18:43 bauzas mriedem: unrelated, I looked at that bug this EU morning https://bugs.launchpad.net/nova/+bug/1750790
16:19:03 mriedem it should be possible to do my nova patch that adds the custom capabilities traits, then if/when we have them standardized in os-traits, we can swap those out, should be ok...
16:19:04 bauzas mriedem: and I wonder if that would merit a Wontfix given it's a pike change
16:19:15 mriedem although, anything relying on the former would have to change..
16:19:28 bauzas s/pike change/pike bug/
16:19:40 mriedem jaypipes: i'm trying to think through what happens when we add a new capability, if that depends on putting it in os-traits first, and it probably should
16:20:11 mriedem because if we have say a placement request filter adding in required traits for driver capabilities, it has to specify one or the other
16:20:20 mriedem or maybe not...
16:20:22 jaypipes mriedem: I wouldn't advise the "auto-create CUSTOM_COMPUTE" thing for that reason...
16:20:27 mriedem i guess if allocation candidations would return either it'd be fine
16:20:35 mriedem *candidates
16:20:38 openstackgerrit Mathieu Gagné proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.openstack.org/523559
16:20:44 jaypipes mriedem: I'd instead advise having the virt drivers report specific known os-traits compute traits.
16:21:11 mriedem yeah i agree that's the goal
16:21:17 mriedem so probably worth doing that to start
16:21:34 mriedem i.e. land your os-traits patch, release it, and then use it in my patch
16:21:55 jaypipes mriedem: ya. soon as efried stops being such a pedant about it :P
16:22:42 efried oo, that's a good point jaypipes
16:22:45 efried (not about me being a pedant, which is also a good point)
16:22:50 jaypipes :)
16:23:11 efried We should move the capabilities reporting away from the awkward dict and just have virt drivers report as traits directly.
16:23:21 efried (long term)
16:24:54 mriedem don't get me started on awkward dict
16:25:04 jaypipes oh boy, here it comes
16:25:15 openstackgerrit Eric Fried proposed openstack/nova-specs master: Explain how filters differ for /r_p vs. /a_c https://review.openstack.org/547056
16:25:17 efried mriedem: There ya go, ya pedant ^
16:25:19 efried dansmith: ^
16:25:48 dansmith efried: disappointed you didn't shame mriedem a little more with commit message snark
16:26:01 efried oh, I forgot my backreference, sec...
16:26:09 edleafe efried: yeah, -1 for lack of snark
16:26:22 mriedem give me a f'ing break
16:26:32 mriedem from the placement people that complain constantly about not documenting decisions enough
16:26:50 openstackgerrit Eric Fried proposed openstack/nova-specs master: Explain how filters differ for /r_p vs. /a_c https://review.openstack.org/547056
16:26:57 efried fixed commit message ^
16:27:06 dansmith mriedem: I kid, I kid <3
16:27:24 efried mriedem: You're right, you're right, you're always right.
16:27:34 mriedem dansmith: you're not in the 'we don't document stuff enough' camp
16:27:47 efried (that chant doesn't come across quite the same in IRC as when I have to say it to my wife)
16:27:53 dansmith mriedem: yep, just wild-west cowboy style for me.. pew pew
16:28:56 jaypipes lol
16:29:25 mriedem i assume those chaps are assless
16:29:34 mriedem which is redundant i know
16:30:04 efried It's gonna be low to mid 30s in Dublin.
16:30:14 jaypipes well, assless chaps really are the best place to store an awkward dict.
16:30:27 jaypipes I'll be here all week folks.
16:30:29 efried Please dansmith, for the love of all that is hol(e)y, wear something under those chaps.
16:30:46 efried Not a kilt, either
16:32:32 mriedem easy bug fix here compadres https://review.openstack.org/#/c/546268/
16:34:29 jaypipes -2
16:35:16 mriedem hongbin: i was thinking about your simple fix here https://review.openstack.org/#/c/546357/ - we should likely have a functional test change with that too, and i think there might be an easy way to do that with an existing test
16:35:26 efried jaypipes, dansmith: Does GET /resource_providers?resources=... take allocations into account?
16:35:37 jaypipes efried: yes
16:35:43 efried k
16:36:13 mriedem hongbin: see https://review.openstack.org/#/c/546268/1/nova/tests/functional/test_servers.py - you can probably modify that same functional test such that before posting the rebuild action, we change the compute provider's inventory such that placement wouldn't return the provider w/o your fix
16:36:28 hongbin mriedem: sure, will look into it
16:37:11 jaypipes mriedem: done.
16:37:29 mriedem hongbin: thanks for that patch btw, it was a lot simpler than i thought it would be
16:37:36 mriedem jaypipes: thanks
16:44:21 openstackgerrit Eric Fried proposed openstack/nova master: Clarify `resources` query param for /r_p and /a_c https://review.openstack.org/547065
16:44:31 efried jaypipes, mriedem, dansmith: There's that clarification you asked for ^
16:44:45 mriedem you missed your reference again
16:45:06 jaypipes lolol
16:45:22 efried the faah?
16:45:31 mriedem efried: but thanks for actually following up with my complaints
16:45:38 mriedem karma points abound
16:45:51 efried High impact:work ratio
16:46:20 mriedem the guy that died via sexual asphyixiation?
16:46:29 jaypipes rofl, no
16:46:30 mriedem oh the white haired guy
16:46:30 efried oy vay, you people.
16:46:35 jaypipes yes
16:46:45 jaypipes thanks goodness I wasn't sipping coffee just nopw
16:46:54 mriedem i was thinking carradine
16:46:57 mriedem isn't that how he died?
16:47:00 jaypipes yes, I got that.
16:47:01 mriedem he's dead right?
16:47:03 jaypipes yes
16:47:08 mriedem ok, whew
16:47:10 openstackgerrit Eric Fried proposed openstack/nova master: Clarify `resources` query param for /r_p and /a_c https://review.openstack.org/547065
16:47:19 efried Updated commit msg, sheesh ^
16:48:05 openstack Launchpad bug 1750790 in OpenStack Compute (nova) "resources on target host aren't released if resize fails" [Undecided,New]
16:48:05 bauzas dansmith: https://bugs.launchpad.net/nova/+bug/1750790 should be marked as Wontfix, right?

Earlier   Later