Posted	Nick	Remark
#openstack-nova - 2018-02-20
18:55:10	mriedem	mnaser: bfv where nova creates the volume and attaches it, then driver.spawn fails, the compute puts the instance into ERROR state and resets the host/node to None
18:55:23	mriedem	so if you go to delete the instance, instance.host is None but you could have a volume attached
18:55:54	mriedem	mnaser: however, that's also being handled compute-side with this https://review.openstack.org/#/c/545087/
18:57:01	mnaser	fun times..
18:57:19	sean-k-mooney	mriedem: ya that was/is an annowing edge case as you end up with a load of volumes if spawning fails often enven if you asked for the volume to be delted when the vm is deleted
18:57:33	openstackgerrit	Eric Fried proposed openstack/nova-specs master: Filter Resource Provider List for Traits https://review.openstack.org/546009
18:57:52	efried	cdent, jaypipes, edleafe: Fixed that to do 400s on invalid traits ^
18:58:26	cdent	roger
18:59:31	edleafe	efried: ack
19:01:05	sean-k-mooney	efried: is the only difference eventually between /allocation_candidates and /resource_providers going to be that allocation candidate support checking for avilable capasity to claim resouces form the resouce providers
19:01:39	efried	sean-k-mooney: No, I think there's lots of differences.
19:02:12	efried	sean-k-mooney: GET /resource_providers actually already supports capacity filtering
19:02:15	edleafe	efried: https://www.youtube.com/watch?v=galB-OUPfBg
19:02:21	efried	sean-k-mooney: But there's a lot it doesn't do.
19:02:40	efried	Before I clicked, I *knew* it had to be an Airplane scene.
19:03:00	edleafe	efried: but of course!
19:03:27	sean-k-mooney	efried: yes but if we continue adding stuff form /allocation_candidates to /resource_providers in the future for parity could the eventually converge
19:03:49	sean-k-mooney	efried: im not saying we want to do that but they do similar things
19:03:52	mriedem	mnaser: https://review.openstack.org/#/c/545132/ is now approved if you want to backport that also
19:04:04	efried	sean-k-mooney: GET /resource_providers will never do the stuff where we consider groups of multiple providers collectively providing a set of resources.
19:04:19	efried	sean-k-mooney: ...for most values of "never"
19:04:52	efried	sean-k-mooney: Granular resources/traits syntax won't be applied to GET /resource_providers
19:05:38	sean-k-mooney	:) well i think /resource_providers is actully almost a subset of /allocation_candidates but ya thats fine as i said they proably should remain seperate but just wondering what the delta was at this point
19:05:41	cfriesen	mriedem: cool...I was just starting to look at how to make the functional test change.
19:06:35	efried	sean-k-mooney: Yeah, they definitely need to remain separate. And I suspect they'll continue to diverge, though as we can see here, certain enhancements can be applied to both.
19:07:22	sean-k-mooney	efried: ya required traits definetly makes sense to be able to use to filter /resource_providers
19:07:34	efried	Yay, another +1!
19:08:14	efried	You win some, you lose some (/me laments Resource Class Affinity)
19:08:18	sean-k-mooney	efried: by the way this will work for custom_ traits too right not just traits in os-traits
19:08:28	efried	sean-k-mooney: Fo sho.
19:08:42	efried	Anything in the Trait database.
19:08:49	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546218
19:08:50	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Store block device mappings in cell0 https://review.openstack.org/546219
19:08:51	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222
19:08:51	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221
19:08:51	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546220
19:08:52	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/546275
19:09:09	mnaser	(i dun goof'd the first set because i cherry pick'd the wrong functional test, oops.)
19:09:11	sean-k-mooney	cool just checking as i was reading the 400 error bit i assumed the db statement covered them
19:12:16	sean-k-mooney	efried: just one observation. required for /resource_providers will work differently then required for /allocation_candidates as the later with out granular requests looks at the union of all traits in the tree not just on an indivigual resouce provider
19:12:27	cfriesen	mriedem: the test_rebuild_with_new_image() testcase is still failing. I've patched nova/compute/manager.py and restarted devstack@n-cpu.service, am I missing something?
19:12:48	sean-k-mooney	efried: they are two different apis however so that should be fine
19:13:04	efried	sean-k-mooney: In fact in more than just the tree - in the tree plus any sharing providers it's considering for the request.
19:13:29	sean-k-mooney	efried: yep
19:13:33	efried	sean-k-mooney: And yes, a valid observation. Same applies to ?resources=
19:14:05	openstackgerrit	Mohammed Naser proposed openstack/nova stable/queens: Store block device mappings in cell0 https://review.openstack.org/546201
19:14:05	openstackgerrit	Mohammed Naser proposed openstack/nova stable/queens: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546200
19:14:06	openstackgerrit	Mohammed Naser proposed openstack/nova stable/queens: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546203
19:14:06	openstackgerrit	Mohammed Naser proposed openstack/nova stable/queens: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546202
19:14:07	openstackgerrit	Mohammed Naser proposed openstack/nova stable/queens: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/546277
19:14:07	openstackgerrit	Mohammed Naser proposed openstack/nova stable/queens: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546204
19:14:14	mnaser	someone teach me git at the ptg, thanks
19:14:55	mnaser	but at least gerrit can tell its a rebase so it didnt lose the +verified
19:18:49	mriedem	mnaser: git review -R -y
19:18:59	mriedem	cfriesen: not sure what you mean, the functional test passes for me
19:19:07	mriedem	remove the code fix and the test fails as expected
19:21:49	edleafe	mnaser: I always liked this talk: https://www.youtube.com/watch?v=yCh6TSLIQBQ
19:23:36	mnaser	edleafe: cool, i'll give it a listen tonight
19:25:04	cfriesen	mriedem: my bad, I had "if recreate is not None" in the test
19:26:14	cfriesen	all is good now
19:26:16	openstackgerrit	Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729
19:26:16	openstackgerrit	Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728
19:26:17	openstackgerrit	Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002
19:26:17	openstackgerrit	Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730
19:26:18	openstackgerrit	Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282
19:39:34	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221
19:39:35	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/546275
19:39:35	openstackgerrit	Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222
19:48:52	openstackgerrit	Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728
19:48:53	openstackgerrit	Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730
19:48:53	openstackgerrit	Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729
19:48:54	openstackgerrit	Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282
19:48:54	openstackgerrit	Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002
20:14:37	mnaser	mriedem: https://review.openstack.org/#/c/545123/ has coverage case using new attach flow but not with the old one, so it fails in stable/pike. would you like me to update it to use the old flow fixture?
20:14:59	mnaser	i don't think we have to do it for queens or master, because technically we can only have compute releases that are behind by one version
20:15:44	mnaser	or actually that might be unrelated. regardless, i'm open to hearing the options
20:18:00	openstackgerrit	Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002
20:18:01	openstackgerrit	Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282
20:18:33	dansmith	ah jeez
20:20:18	openstackgerrit	Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728
20:20:19	openstackgerrit	Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730
20:20:19	openstackgerrit	Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729
20:20:20	openstackgerrit	Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282
20:20:20	openstackgerrit	Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002
20:25:49	mriedem	mnaser: yeah need to use the CinderFixture in pike
20:25:58	mriedem	mnaser: i realized that would be the case
20:26:06	openstackgerrit	Merged openstack/nova stable/pike: Rollback instance.image_ref on failed rebuild https://review.openstack.org/539003
20:26:25	mriedem	dansmith: you've gone full bore on converting all of the post-placement filters to pre-placement filters haven't you :)
20:26:28	mnaser	mriedem: ok ill change it up to use cinderfixture and modify the code (as it would depend on if volume_id in self.reserved_volumes)
20:26:38	mriedem	mnaser: thanks
20:27:12	dansmith	mriedem: no, I just wanted another example
20:27:22	mriedem	guh why doesn't ctrl+c work inside a cirros shell
20:42:36	mriedem	woot got this multiattach demo working
20:43:03	mriedem	mounting and umounting like a mothertrucker
20:45:21	smcginnis	mriedem: Are you recording a demo?
20:48:37	mriedem	that's the plan
20:48:43	mriedem	finally got the run through working
20:48:56	smcginnis	mriedem: Nice!
20:49:03	mriedem	https://docs.google.com/presentation/d/1bp7IwEubvXqQf7mUE3nlUNW_T04L4c1-AMXELZ45jgg/edit?usp=sharing
20:50:28	mriedem	also uses device tags

Earlier   Later