| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-15 | |||
| 10:39:18 | bauzas | stephenfin: okay, I'll look at your spec once I'm done with jaypipes's one about aggregate ratios | |
| 10:42:42 | openstackgerrit | Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378 | |
| 11:02:23 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'numa-aware-vswitches' spec https://review.openstack.org/541290 | |
| 11:12:57 | openstackgerrit | Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378 | |
| 11:28:37 | openstackgerrit | Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378 | |
| 11:31:56 | openstackgerrit | Merged openstack/nova master: doc: Clarify how to create your own filter https://review.openstack.org/544836 | |
| 12:33:54 | openstackgerrit | Chris Dent proposed openstack/nova-specs master: VMware: add support for live migration https://review.openstack.org/299207 | |
| 13:13:42 | openstackgerrit | Bence Romsics proposed openstack/nova master: Clarify 'capacity' in placement api-ref https://review.openstack.org/544347 | |
| 13:26:52 | openstackgerrit | Thomas Goirand proposed openstack/nova master: Python 3 fix for sphinx doc https://review.openstack.org/544956 | |
| 13:30:57 | ameeda | Hello, what do you think if I take this review and complete on it ? https://review.openstack.org/#/c/525253/ | |
| 13:48:32 | hrw | ameeda: you mean "take it, update, send for review"? | |
| 13:48:57 | hrw | ameeda: if you feel that change is needed but abandoned by original author then why not | |
| 13:48:59 | ameeda | yes | |
| 13:49:48 | hrw | ameeda: my way from 'wth is kolla' to 'kolla core reviewer' started from taking over one patch | |
| 13:49:51 | ameeda | original author doesn't do any activity from awhile "5 weeks" | |
| 13:54:42 | ameeda | hrw: I am not sure if that is legal to take this patch, I want approval, what if I comment on the bug to ask current assignee if he still working on the bug. also I am not sure about the rank of this bug. | |
| 13:55:24 | ameeda | hrw: since I have patches need for review from awhile. | |
| 13:59:30 | hrw | ameeda: do what you think. nova is foss and mia maintainer can be overriden imho with new ver of patch | |
| 14:00:43 | hrw | ameeda: sometimes during review it is easier for reviewer to send new version than comment | |
| 14:02:16 | ameeda | hrw: so you guess me to mark current patch as abandoned then upload new patch | |
| 14:02:20 | jroll | ameeda: cfriesen is the author, he is active in this channel, might as well ask him | |
| 14:02:38 | hrw | ameeda: no. | |
| 14:02:44 | ameeda | cfriesen: are you around ? | |
| 14:03:15 | hrw | ameeda: git review 525253 -d; edit, git commit --amend, git review | |
| 14:03:42 | ameeda | hrw: thanks | |
| 14:04:10 | mriedem | heh, mnaser check out https://review.openstack.org/#/c/525253/ being discussed; look familiar? | |
| 14:05:50 | ameeda | mriedem: Hello :) | |
| 14:06:21 | mnaser | mriedem: lol, well now that I’ve learned a whole lot, I can tell that shouldn’t work for scenarios involving new flow :p | |
| 14:07:07 | mnaser | I don’t think it would be a fun time to replicate all the code used in the clean up section (but maybe it could be moved out to utils somewhere and reused) | |
| 14:07:31 | mnaser | But imho transactionally It feels more correct that bdms for failed instances aren’t disappearing | |
| 14:07:32 | mriedem | mnaser: yup, that's part of my -1 | |
| 14:07:59 | mnaser | If the detach fails there should still be some sort of reference, right now there’s nothing | |
| 14:09:24 | mnaser | mriedem: as much as I’d hate to rebase the series again, should we add a release note for operators that “hey, if you have a lot of failed scheduled instances, your bdm table might get bigger because they’re saved now” | |
| 14:10:03 | mriedem | mnaser: those will be deleted when the failed instance is deleted | |
| 14:10:22 | mnaser | mriedem: oh okay so thats not a big impact, i guess bdms are not soft deleted | |
| 14:10:23 | mriedem | i doubt anyone would need to know that we start putting bdms in cell0 now | |
| 14:10:29 | mriedem | bdms are soft deleted | |
| 14:10:37 | mriedem | like instances and everything else (except tags) in the 'nova' table | |
| 14:10:51 | mriedem | so you'd still have to archive/purge that stuff at some point | |
| 14:10:55 | mnaser | gotcha | |
| 14:11:59 | mnaser | anyways, whole series is ready to be reviewed (and i don't think i have a lot of review karma saved up for my lack of nova reviews to use :p) | |
| 14:12:22 | mriedem | i've got +2s on the first 3 | |
| 14:12:25 | mnaser | it's causing a ton of annoyance for some customers because they cant delete their volumes | |
| 14:12:37 | mriedem | there is a force detach in cinder | |
| 14:12:50 | mnaser | afaik thats an admin op | |
| 14:13:01 | mriedem | yeah maybe | |
| 14:13:57 | mriedem | yup it's an admin action by default os-force_detach | |
| 14:14:01 | mriedem | http://git.openstack.org/cgit/openstack/cinder/tree/cinder/api/contrib/admin_actions.py#n203 | |
| 14:14:08 | mnaser | anyways no worries, i know the first 3 are much more simple, the last one is the tough one but i'm ready to pick up any other work that comes on top so ping me if anything :> | |
| 14:22:46 | efried | melwitt: I have to duck out of the nova meeting around quarter after, FYI. On the hook for school runs again. | |
| 14:44:11 | jaypipes | bauzas: would you mind pinging sahid to hop on #openstack-nova please? just for a few minutes. have a question for him.. | |
| 14:44:25 | bauzas | sure, lemme try ;) | |
| 14:44:37 | jaypipes | merci | |
| 14:44:59 | bauzas | mmm, he's not on our internal IRC, lemme verify if he has some PTO | |
| 14:48:50 | jaypipes | bauzas: ok, no worries. | |
| 14:49:08 | bauzas | jaypipes: well, I don't see any PTO on our agenda | |
| 14:49:24 | jaypipes | bauzas: danpb isn't available is he? | |
| 14:50:03 | jaypipes | bauzas: specifically, I am looking to find out whether Dan's comment here: https://review.openstack.org/#/c/527631/9/nova/virt/libvirt/driver.py@a4299 (that was removed by tetsuro) is still valid. | |
| 14:50:18 | bauzas | jaypipes: I can ask danpb to go here | |
| 14:50:25 | jaypipes | bauzas: cool, cheers :) | |
| 14:50:34 | bauzas | even if he's no longer working on nova | |
| 14:52:36 | stephenfin | jaypipes: kashyap is the person to ask about that | |
| 14:52:47 | stephenfin | Far as I know, that comment is still valid. We've got support or emulator threads enabled but not IO threads | |
| 14:53:02 | kashyap | And clicks on the URL | |
| 14:53:03 | stephenfin | However, iirc, kashyap was in talks where the value of IO threads was called into question | |
| 14:53:22 | stephenfin | Well, IO threads > 1 anyway | |
| 14:53:35 | kashyap | stephenfin: jaypipes: (I have a discussion for it (IO Threads at Dublin too) | |
| 14:53:38 | kashyap | That said... | |
| 14:55:06 | kashyap | Yeah, the IO Threads value is in contention | |
| 14:55:33 | kashyap | Recently, I saw a presentation at KVM Forum where someone from oVirt claimed the "ideal" number of IO Threads is ...1! | |
| 14:55:37 | kashyap | (In their benchmarks) | |
| 14:56:01 | kashyap | But I won't believe it. "Seeing is believing" --> Need `fio` benchmarks for that | |
| 14:57:59 | kashyap | jaypipes: Also see: https://review.openstack.org/#/c/230968/ "iothreads for disk devices" | |
| 14:59:17 | jaypipes | kashyap: so, bottom line, that comment from danpb is still valid, yeah? | |
| 14:59:19 | bauzas | jaypipes: when you have time, I'd also like to discuss abotu https://review.openstack.org/#/c/544683/1 | |
| 14:59:32 | kashyap | jaypipes: Yes, it is still valid; it's better to retain that | |
| 14:59:42 | kashyap | (I.e. I agree with your comment on Gerrit) | |
| 15:00:04 | kashyap | Nova isn't yet using IO Threads. | |
| 15:00:51 | jaypipes | danke | |
| 15:01:13 | jaypipes | kashyap: dan just responded. | |
| 15:02:07 | kashyap | jaypipes: I think you're trying to speak Dutch, in that case: "Dank je" / "Heel erg bedant" :P | |
| 15:02:13 | kashyap | (You wrote German) | |
| 15:02:27 | kashyap | If that was intentional; disreregard me | |
| 15:03:21 | openstackgerrit | Dan Smith proposed openstack/nova-specs master: Support member_of param for allocation candidates https://review.openstack.org/544694 | |
| 15:04:11 | jaypipes | kashyap: oh, I wasn't trying to write Dutch... I just say danke all the time... | |
| 15:04:23 | jaypipes | dansmith: why thank you dan | |
| 15:04:26 | kashyap | True; I've noticed it before | |
| 15:04:31 | dansmith | cha | |
| 15:05:20 | mriedem | melwitt: mnaser: i've gone through the local delete https://review.openstack.org/#/c/340614/ change in detail, lots of questions and head scratching | |
| 15:05:33 | jaypipes | stephenfin: I -W'd https://review.openstack.org/#/c/527630/ since the blueprint isn't yet approved.. | |
| 15:06:13 | stephenfin | Oh, good catch. It is just cleanup though, right? | |
| 15:06:25 | mriedem | 527630 is in the gate | |
| 15:06:29 | efried | cdent, jaypipes: Can we talk about the "2001 providers" issue from https://review.openstack.org/#/c/540111/ ? | |
| 15:06:30 | mriedem | you're going to have to rebase it to pull it out | |
| 15:06:32 | mriedem | or change the commit message | |
| 15:06:37 | stephenfin | Do we want to? | |
| 15:06:37 | mriedem | jaypipes: stephenfin: ^ | |
| 15:07:15 | cdent | efried: I can if you like but it will be partial attention, doing tc office hours then api-s | |
| 15:07:16 | cdent | ig | |
| 15:07:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | |