Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-05
18:19:59 hrw jaypipes: thanks
18:21:53 mriedem cfriesen: damn
18:27:56 dansmith mriedem: so, we have some calls like build_and_run_instances() that has basically all optional arguments, even though they're not really optional
18:28:20 dansmith mriedem: we're removing one in the middle of those due to deprecations, so I was thinking I'd remove the optional/kwarg-ness from them all,
18:28:30 dansmith but that broke a bunch of tests that use the optionalness
18:28:48 dansmith I kinda think we might just want to take the hit now and fix that in the process, but do you have a strong opinion either way?
18:29:12 mriedem i was going to say it might not be worth the trouble to refactor all of that
18:29:26 mriedem but it's not a strong opinion on
18:29:28 mriedem *no
18:29:32 dansmith okay
18:30:30 dansmith well, I guess I'll just be lazy and not do it then
18:35:56 jaypipes hrw: +W
18:36:03 hrw thx
18:36:20 openstackgerrit Yuki Nishiwaki proposed openstack/nova master: Check enable_new_services option in service.py https://review.openstack.org/540962
18:44:49 openstackgerrit Chris Dent proposed openstack/nova-specs master: Add generation support in aggregate association https://review.openstack.org/540447
18:58:08 mriedem dansmith: i'm ok with lazy, cleaning up cruft and dropping deprecated stuff is good for me
18:58:15 mriedem given we're only a few days out from rc1
18:58:27 dansmith ack, yeah I left it alone
18:58:41 dansmith I'm working on all the signature changes for the other stuff in the tests right now
19:06:56 hrw LibvirtConfigGuestPCIeRootPortController is my next class to add. but not today.
19:18:27 openstackgerrit Merged openstack/nova stable/pike: Import the config drive docs from openstack-manuals https://review.openstack.org/515053
19:18:41 ameeda gibi and mriedem Thank you very much, I will upload new patch soon
19:20:31 dansmith mriedem: I already made that cleanup change for a couple of the other calls, which I'm paying for in tests right now, but they're less invasive than build
19:21:59 ameeda mriedem: can you please confirm this for me ? https://review.openstack.org/#/c/540274/ its nova-manager doc
19:30:17 sean-k-mooney dansmith: mriedem so i found a bug at the end of last week that has been in the nova libvirt forever https://bugs.launchpad.net/nova/+bug/1747496
19:30:18 openstack Launchpad bug 1747496 in OpenStack Compute (nova) "MTUs are not set for VIFs if using kernel ovs + hybrid plug = false" [Undecided,New]
19:31:16 sean-k-mooney dansmith: mriedem this is not new in queens but my question is the fix is simple. just set the mtu in the libvirt xml or alternitivly use os-vif which is a little more work
19:31:50 sean-k-mooney dansmith: mriedem will i trow a path up for rocky or is this something ye want to backport?
19:33:45 openstackgerrit Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385
19:34:19 sean-k-mooney using os-vif is not backportable hence why i am leaning towords adding the libvirt element for the mtu. we can always delegate entirly to os-vif in rocky if we like but just wonderin if we want to fix this in queens?
19:36:06 openstackgerrit Merged openstack/nova stable/ocata: Set server status to ERROR if rebuild failed https://review.openstack.org/536904
19:36:16 ameeda mriedem, gibi patch uploaded
19:37:31 ameeda jaypipes, bauzas: could you please review this for me https://review.openstack.org/#/c/526900/
19:39:10 openstackgerrit Eric Fried proposed openstack/nova-specs master: Update Provider Tree https://review.openstack.org/540111
19:39:17 efried edleafe, cdent, jaypipes: ^
19:47:32 sean-k-mooney stephenfin: by the way i know you were looking at mtu suff last year so this might be of interest to you. https://bugs.launchpad.net/nova/+bug/1747496 it will cause issue for anyone with jumboframes who want to upgrade to the ovs conntrack driver.
19:47:33 openstack Launchpad bug 1747496 in OpenStack Compute (nova) "MTUs are not set for VIFs if using kernel ovs + hybrid plug = false" [Undecided,New]
19:48:19 mriedem sean-k-mooney: you can do a 2 part fix where the first uses the xml directly and backport that, and the other fix goes into os-vif and we remove the xml hack
19:49:03 sean-k-mooney mriedem: yep i can is that your prefence? also do we want to backport to queens et al now or wait
19:49:31 sean-k-mooney mriedem: im just heading home but i can see if i can trow up the xml patch tommorow if i get time
19:51:02 mriedem sean-k-mooney: i wouldn't consider it something we have to hold up queens rc1 for
19:51:03 mriedem if it's latent
19:52:16 ameeda mriedem: when I try to git cherry-pick -x c0aca1d333628f9174e8db53674787e281e7e0d7 I got this error -> fatal: bad object c0aca1d333628f9174e8db53674787e281e7e0d7
19:52:18 sean-k-mooney mriedem: oh i was not suggesting we hold it up just is this something ye want to review for a queens backport e.g. i should fix it right away or can be reviewd for back port later e.g. ill try and fix before ptg
19:55:58 mriedem ameeda: git fetch https://git.openstack.org/openstack/nova refs/changes/71/540871/1 && git cherry-pick -x FETCH_HEAD
19:56:48 mriedem stvnoyes: i think i what might be an issue with boot from volume with multiple instances and the new cinder volume attach flow...
19:57:36 sean-k-mooney mriedem: i have 3 patches i need to rebase for rocky later this week so ill add it to the list if it wont effect future backport or ill try to make time to fix it specificlly tomrow if it more urgent. anyway got to run enjoy your evening.
19:59:23 mriedem stvnoyes: we call this for each instance we create in a multi-create request https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1253
19:59:46 mriedem and _validate_bdm will loop over the volumes passed in, and if everything is new enough, create an attachment per volume and store that on the bdm record
20:00:05 mriedem we then make a copy of that list per instance https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1267
20:00:27 mriedem i'm wondering if we're overwriting or losing any of the bdm.attachment_id records when creating multiple instances
20:00:31 mriedem maybe it's ok
20:01:29 mriedem might be a decent test though, create >1 instances in the same request using the same volume and make sure each instance has unique attachments to that volume
20:02:11 mriedem i suppose if you aren't using a multiattach volume, the 2nd instance in the loop would fail to create an attachment to the volume because the volume's attach_status will be 'attaching'
20:04:29 ameeda mriedem: now the commit message have those 2 lines
20:04:30 ameeda (cherry picked from commit eba33a0e2d8aace6fbc889026fb80dc2c208bc8d) (cherry picked from commit c0aca1d333628f9174e8db53674787e281e7e0d7)
20:05:51 mriedem ameeda: those should go on separate lines
20:05:52 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: debug nova-api service version check during boot from volume https://review.openstack.org/540992
20:05:53 mriedem but that's ine
20:05:55 mriedem fine
20:08:13 mriedem dansmith: we haven't been doing proper service version checking in nova-api since pike https://review.openstack.org/#/c/539755/ - should be an easy +W
20:08:21 ameeda mriedem: yes they are , so I can do git review now ?
20:08:27 mriedem ameeda: yes
20:08:42 ameeda mriedem: Thank you !!
20:09:15 openstackgerrit Ameed Ashour proposed openstack/nova stable/ocata: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/540274
20:09:51 ameeda mriedem: could you please give me +2 here https://review.openstack.org/#/c/528385/ :$
20:10:10 melwitt jaypipes: replied
20:12:11 mriedem ameeda: your ocata backport is wrong
20:14:05 ameeda I see
20:23:27 openstackgerrit Ameed Ashour proposed openstack/nova stable/ocata: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/540274
20:27:42 ameeda mriedem: I don't know if I did the correct thing, please check it ^
20:28:33 mriedem ameeda: yes that's correct, thanks
20:29:53 ameeda Thank you !!
20:30:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Add a nova-caching-scheduler job to the experimental queue https://review.openstack.org/539260
20:32:18 ameeda mriedem: please don't forget to review this https://review.openstack.org/#/c/528385/
20:56:55 mriedem efried: i think this might have broken the nova-next job but i'm not sure how https://github.com/openstack-dev/devstack/commit/49144e627120f9ec1cf72dfc84e02b9b81e669b6
20:56:59 openstack Launchpad bug 1747511 in OpenStack Compute (nova) "legacy-tempest-dsvm-neutron-nova-next-full fails with "Can not find requested image" since 1/31" [Undecided,New]
20:56:59 mriedem https://bugs.launchpad.net/nova/+bug/1747511
20:57:51 mriedem the only thing unique about the nova-next job at this point is it sets NOVA_USE_SERVICE_TOKEN=True in devstack
20:59:45 openstackgerrit Dan Smith proposed openstack/nova master: Bump compute RPC API to version 5.0 https://review.openstack.org/541005
20:59:49 dansmith gawd
21:00:00 mriedem ufta
21:06:58 efried mriedem: Is the bustage consistent?
21:07:15 mriedem efried: yeah, 100% fail
21:07:48 efried mriedem: I can propose reversion of the above, then a blank nova patch that Depends-On it, and see if that at least makes it pass. Shall I?
21:08:03 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: debug nova-next image not found failures https://review.openstack.org/541008
21:08:18 mriedem i think we could also just ignore the service_user config in nova as a test
21:08:43 efried I have to jet for a doc appt right now, will catch up with you in an hour or so.
21:12:18 jaypipes thx melwitt
21:15:05 openstackgerrit melanie witt proposed openstack/nova stable/ocata: Add release note for Aggregate[Core|Ram|Disk]Filter change https://review.openstack.org/541013
21:16:25 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: debug nova-next image not found failures https://review.openstack.org/541008
21:30:42 openstackgerrit melanie witt proposed openstack/nova master: Add release note for Aggregate[Core|Ram|Disk]Filter change https://review.openstack.org/541018
21:48:14 mriedem maciejjozefczyk: not sure why you'd +1 this :) https://review.openstack.org/#/c/540992/
21:50:32 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: debug nova-api service version check during boot from volume https://review.openstack.org/540992
21:56:19 openstackgerrit Matthew Edmonds proposed openstack/nova master: Clarify CONF.scheduler.max_attempts https://review.openstack.org/541031
21:56:46 edmondsw_ edleafe noticed this after reading your blog ^
21:59:31 edmondsw mriedem do we have a more general term that encompasses create, resize, and migrate if "build" doesn't do that?
22:02:38 mriedem scheduling?
22:02:41 mriedem like it said
22:02:42 edmondsw we can't say "schedule", because we only talk to the scheduler once.

Earlier   Later