| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-05 | |||
| 17:05:37 | jaypipes | hrw: heh, ok :) | |
| 17:05:56 | jaypipes | hrw: I don't see a followup from sahid which is why I asked.. | |
| 17:06:03 | stephenfin | Probably best to wait for the fixes' fix to be merged though | |
| 17:06:06 | hrw | jaypipes: sure | |
| 17:07:17 | hrw | jaypipes: when 'a reply' would be just message then I write it. If it is simple fix then I mark Done' | |
| 17:07:43 | hrw | jaypipes: if it is complicated then do code mostly | |
| 17:08:09 | hrw | jaypipes: and here comment was more or less 'rewrite the shit' so I did | |
| 17:11:57 | jaypipes | hrw: understood. I'd still like to have sahid's opinion on it, though, since he had the biggest objection to it.. | |
| 17:12:04 | hrw | sure | |
| 17:28:50 | hrw | I have an idea for another 'lets add some device' patch just not found yet where to plug it | |
| 17:29:36 | hrw | on pcie machines (aarch64, x86/q35) more pcie-root-port controllers can be handy if someone wants to add more disks/networks | |
| 17:34:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541 | |
| 17:34:39 | openstackgerrit | Eric Fried proposed openstack/nova master: placement doc: Conflict caveat for DELETE APIs https://review.openstack.org/540919 | |
| 17:37:47 | hrw | it is like: basic VM instance config gets created with (let's say) 4 pcie root ports (think of them as pcie slot on virtual motherboard). then we plug video card, usb host controller (and usb keyboard to it) so we have just 2 slots left. then we add RNG and memory balloon... hm. have to boot an instance and check | |
| 17:44:19 | openstackgerrit | Merged openstack/nova master: Update cells v2 layout doc caveats for Queens https://review.openstack.org/540667 | |
| 17:44:29 | openstackgerrit | Merged openstack/nova stable/ocata: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot https://review.openstack.org/531422 | |
| 17:49:28 | hrw | arm64 guest has 1 pcie slot free when booted with graphical console | |
| 17:59:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242 | |
| 18:00:49 | gibi | mriedem: fixed the bugfix patch as well ^^ | |
| 18:01:42 | mriedem | ok | |
| 18:01:48 | mriedem | will take a look after lunch | |
| 18:02:57 | gibi | mriedem: have nice lunch | |
| 18:03:50 | gibi | mriedem: I'm no checking your idea to use wait_for_versioned_notification instead of the for loop and the sleep int he functional test, but I have to leave soon so cannot promise I finish with that today | |
| 18:04:17 | mriedem | that's fine, it can be a later cleanup | |
| 18:05:03 | gibi | mriedem: OK | |
| 18:08:53 | mriedem | cfriesen: i have an idea about the perf hit in pike, | |
| 18:09:04 | mriedem | maybe versioned notifications? | |
| 18:09:09 | mriedem | cfriesen: are you running with those on? | |
| 18:09:46 | mriedem | default is to send both versioned and unversioned notifications, | |
| 18:10:00 | mriedem | and the versioned notifications have to sometimes lazy-load fields on the instance for the notification payload | |
| 18:10:05 | mriedem | which means more round trips over rpc to the db | |
| 18:12:24 | jaypipes | hrw: reviewed. | |
| 18:15:00 | cfriesen | mriedem: will check | |
| 18:15:56 | hrw | jaypipes: reading | |
| 18:18:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add regression test for bug 1735407 https://review.openstack.org/526095 | |
| 18:18:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add late server group policy check to rebuild https://review.openstack.org/525242 | |
| 18:18:12 | openstack | bug 1735407 in OpenStack Compute (nova) "[Nova] Evacuation doesn't respect anti-affinity rules" [Medium,In progress] https://launchpad.net/bugs/1735407 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 18:18:47 | cfriesen | mriedem: looks like explicitly unversioned. thanks for the suggestion though. | |
| 18:19:25 | gibi | mriedem: managed to remove the sleep from the functional test. | |
| 18:19:32 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have usable input for graphical console https://review.openstack.org/538003 | |
| 18:19:59 | hrw | jaypipes: thanks | |
| 18:21:53 | mriedem | cfriesen: damn | |
| 18:27:56 | dansmith | mriedem: so, we have some calls like build_and_run_instances() that has basically all optional arguments, even though they're not really optional | |
| 18:28:20 | dansmith | mriedem: we're removing one in the middle of those due to deprecations, so I was thinking I'd remove the optional/kwarg-ness from them all, | |
| 18:28:30 | dansmith | but that broke a bunch of tests that use the optionalness | |
| 18:28:48 | dansmith | I kinda think we might just want to take the hit now and fix that in the process, but do you have a strong opinion either way? | |
| 18:29:12 | mriedem | i was going to say it might not be worth the trouble to refactor all of that | |
| 18:29:26 | mriedem | but it's not a strong opinion on | |
| 18:29:28 | mriedem | *no | |
| 18:29:32 | dansmith | okay | |
| 18:30:30 | dansmith | well, I guess I'll just be lazy and not do it then | |
| 18:35:56 | jaypipes | hrw: +W | |
| 18:36:03 | hrw | thx | |
| 18:36:20 | openstackgerrit | Yuki Nishiwaki proposed openstack/nova master: Check enable_new_services option in service.py https://review.openstack.org/540962 | |
| 18:44:49 | openstackgerrit | Chris Dent proposed openstack/nova-specs master: Add generation support in aggregate association https://review.openstack.org/540447 | |
| 18:58:08 | mriedem | dansmith: i'm ok with lazy, cleaning up cruft and dropping deprecated stuff is good for me | |
| 18:58:15 | mriedem | given we're only a few days out from rc1 | |
| 18:58:27 | dansmith | ack, yeah I left it alone | |
| 18:58:41 | dansmith | I'm working on all the signature changes for the other stuff in the tests right now | |
| 19:06:56 | hrw | LibvirtConfigGuestPCIeRootPortController is my next class to add. but not today. | |
| 19:18:27 | openstackgerrit | Merged openstack/nova stable/pike: Import the config drive docs from openstack-manuals https://review.openstack.org/515053 | |
| 19:18:41 | ameeda | gibi and mriedem Thank you very much, I will upload new patch soon | |
| 19:20:31 | dansmith | mriedem: I already made that cleanup change for a couple of the other calls, which I'm paying for in tests right now, but they're less invasive than build | |
| 19:21:59 | ameeda | mriedem: can you please confirm this for me ? https://review.openstack.org/#/c/540274/ its nova-manager doc | |
| 19:30:17 | sean-k-mooney | dansmith: mriedem so i found a bug at the end of last week that has been in the nova libvirt forever https://bugs.launchpad.net/nova/+bug/1747496 | |
| 19:30:18 | openstack | Launchpad bug 1747496 in OpenStack Compute (nova) "MTUs are not set for VIFs if using kernel ovs + hybrid plug = false" [Undecided,New] | |
| 19:31:16 | sean-k-mooney | dansmith: mriedem this is not new in queens but my question is the fix is simple. just set the mtu in the libvirt xml or alternitivly use os-vif which is a little more work | |
| 19:31:50 | sean-k-mooney | dansmith: mriedem will i trow a path up for rocky or is this something ye want to backport? | |
| 19:33:45 | openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | |
| 19:34:19 | sean-k-mooney | using os-vif is not backportable hence why i am leaning towords adding the libvirt element for the mtu. we can always delegate entirly to os-vif in rocky if we like but just wonderin if we want to fix this in queens? | |
| 19:36:06 | openstackgerrit | Merged openstack/nova stable/ocata: Set server status to ERROR if rebuild failed https://review.openstack.org/536904 | |
| 19:36:16 | ameeda | mriedem, gibi patch uploaded | |
| 19:37:31 | ameeda | jaypipes, bauzas: could you please review this for me https://review.openstack.org/#/c/526900/ | |
| 19:39:10 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Update Provider Tree https://review.openstack.org/540111 | |
| 19:39:17 | efried | edleafe, cdent, jaypipes: ^ | |
| 19:47:32 | sean-k-mooney | stephenfin: by the way i know you were looking at mtu suff last year so this might be of interest to you. https://bugs.launchpad.net/nova/+bug/1747496 it will cause issue for anyone with jumboframes who want to upgrade to the ovs conntrack driver. | |
| 19:47:33 | openstack | Launchpad bug 1747496 in OpenStack Compute (nova) "MTUs are not set for VIFs if using kernel ovs + hybrid plug = false" [Undecided,New] | |
| 19:48:19 | mriedem | sean-k-mooney: you can do a 2 part fix where the first uses the xml directly and backport that, and the other fix goes into os-vif and we remove the xml hack | |
| 19:49:03 | sean-k-mooney | mriedem: yep i can is that your prefence? also do we want to backport to queens et al now or wait | |
| 19:49:31 | sean-k-mooney | mriedem: im just heading home but i can see if i can trow up the xml patch tommorow if i get time | |
| 19:51:02 | mriedem | sean-k-mooney: i wouldn't consider it something we have to hold up queens rc1 for | |
| 19:51:03 | mriedem | if it's latent | |
| 19:52:16 | ameeda | mriedem: when I try to git cherry-pick -x c0aca1d333628f9174e8db53674787e281e7e0d7 I got this error -> fatal: bad object c0aca1d333628f9174e8db53674787e281e7e0d7 | |
| 19:52:18 | sean-k-mooney | mriedem: oh i was not suggesting we hold it up just is this something ye want to review for a queens backport e.g. i should fix it right away or can be reviewd for back port later e.g. ill try and fix before ptg | |
| 19:55:58 | mriedem | ameeda: git fetch https://git.openstack.org/openstack/nova refs/changes/71/540871/1 && git cherry-pick -x FETCH_HEAD | |
| 19:56:48 | mriedem | stvnoyes: i think i what might be an issue with boot from volume with multiple instances and the new cinder volume attach flow... | |
| 19:57:36 | sean-k-mooney | mriedem: i have 3 patches i need to rebase for rocky later this week so ill add it to the list if it wont effect future backport or ill try to make time to fix it specificlly tomrow if it more urgent. anyway got to run enjoy your evening. | |
| 19:59:23 | mriedem | stvnoyes: we call this for each instance we create in a multi-create request https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1253 | |
| 19:59:46 | mriedem | and _validate_bdm will loop over the volumes passed in, and if everything is new enough, create an attachment per volume and store that on the bdm record | |
| 20:00:05 | mriedem | we then make a copy of that list per instance https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1267 | |
| 20:00:27 | mriedem | i'm wondering if we're overwriting or losing any of the bdm.attachment_id records when creating multiple instances | |
| 20:00:31 | mriedem | maybe it's ok | |
| 20:01:29 | mriedem | might be a decent test though, create >1 instances in the same request using the same volume and make sure each instance has unique attachments to that volume | |
| 20:02:11 | mriedem | i suppose if you aren't using a multiattach volume, the 2nd instance in the loop would fail to create an attachment to the volume because the volume's attach_status will be 'attaching' | |
| 20:04:29 | ameeda | mriedem: now the commit message have those 2 lines | |
| 20:04:30 | ameeda | (cherry picked from commit eba33a0e2d8aace6fbc889026fb80dc2c208bc8d) (cherry picked from commit c0aca1d333628f9174e8db53674787e281e7e0d7) | |
| 20:05:51 | mriedem | ameeda: those should go on separate lines | |
| 20:05:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: debug nova-api service version check during boot from volume https://review.openstack.org/540992 | |
| 20:05:53 | mriedem | but that's ine | |
| 20:05:55 | mriedem | fine | |