| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-01 | |||
| 17:15:01 | hrw | multiattach is qemu 2.10+ yes | |
| 17:15:09 | hrw | or sth | |
| 17:24:20 | cfriesen | mriedem: release note has been added as per your request for https://review.openstack.org/#/c/520187/ | |
| 17:25:02 | mriedem | cfriesen: ok but i'm not looking at that until after queens | |
| 17:25:48 | mriedem | stephenfin: you can do multiattach if (1) qemu<2.10 or (2) libvirt>=3.10 (regardless of qemu version) | |
| 17:26:00 | mriedem | libvirt 3.10 does a thing to make it work with qemu 2.10+ | |
| 17:26:04 | mriedem | for shared disks | |
| 17:26:52 | mriedem | stephenfin: https://bugzilla.redhat.com/show_bug.cgi?id=1378242 | |
| 17:26:54 | openstack | bugzilla.redhat.com bug 1378242 in libvirt "QEMU image file locking (libvirt)" [Unspecified,Verified] - Assigned to pkrempa | |
| 17:27:08 | stephenfin | mriedem: Right, figured out the source of my confusion. It was this https://review.openstack.org/#/c/532214/ | |
| 17:27:22 | mriedem | totally unrealted | |
| 17:27:27 | mriedem | ^ is because the job runs without pike uca | |
| 17:27:47 | stephenfin | Yup, I know that now. The fact that it talked about libvirt and QEMU versions but with opposite expectations threw me | |
| 17:28:35 | jaypipes | hrw: reviewed. | |
| 17:28:40 | melwitt | mriedem: wanted to bring this to your attention, I think we're not using the newer cinder api when creating instances with multi-cell https://review.openstack.org/#/c/539755/ | |
| 17:29:03 | melwitt | so another set of eyes would be helpful there | |
| 17:29:06 | stephenfin | mriedem: One last question (mirrored from the review): do we want to suggest the behavior on libvirt < 3.10? Is the behaviour of QEMU < 2.10 considered broken or something? | |
| 17:30:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Migrate "launch instance" user guide docs https://review.openstack.org/540048 | |
| 17:30:53 | hrw | jaypipes: thx. updating code and replying | |
| 17:30:57 | mriedem | stephenfin: i'm having a hard time parsing "suggest the behavior" | |
| 17:31:14 | mriedem | stephenfin: the libvirt driver will report the capability as not being supported if those version constraints aren't satisfied | |
| 17:31:40 | mriedem | stephenfin: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L599 | |
| 17:32:19 | stephenfin | I don't even know what I was trying to say there | |
| 17:32:43 | mriedem | melwitt: yes agree, i had noticed that while adding the multiattach support to the api and looking at the version checks; that version check was added in pike before dan's multi-cell in api stuff landed; i just forgot to push a patch for it | |
| 17:32:54 | mriedem | stephenfin: just tell me you love me | |
| 17:33:16 | jaypipes | hrw: cool. my comments make sense ok? | |
| 17:33:21 | hrw | yes | |
| 17:33:23 | stephenfin | A +2 is the most you're getting at this time of evening, Mr Riedemann | |
| 17:33:25 | jaypipes | coolio. | |
| 17:33:36 | stephenfin | That's done now. Sorry about the confusion | |
| 17:33:46 | jaypipes | stephenfin: he prefers Ms. Riedemann. | |
| 17:34:21 | melwitt | lyarwood: I have a feeling that https://bugs.launchpad.net/neutron/+bug/1744361 might be because we don't wait for the unplug event before we plug. my plan for today is to put up a DNM patch in a project where the job is failing with depends-on the logging and see if I can get it to fail in the same way. then I'll test a patch that waits for unplug events | |
| 17:34:22 | openstack | Launchpad bug 1744361 in neutron "test_server_security_groups failed to reboot with "Domain not found: no domain with matching uuid" because of missing vif event from linuxbridge agent" [Undecided,Confirmed] | |
| 17:34:28 | mriedem | melwitt: +2 | |
| 17:34:39 | melwitt | mriedem: ah, cool. thanks | |
| 17:34:51 | mriedem | i prefer herr riedemann btw | |
| 17:34:57 | mriedem | it is a german name | |
| 17:35:23 | hrw | print(cfg.to_xml()) in test ftw | |
| 17:35:45 | hrw | jaypipes: Fraü? | |
| 17:38:21 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Move resource provider objects into placement hierarchy https://review.openstack.org/540049 | |
| 17:40:42 | hrw | jaypipes: first version of patch was using model. Then libvirt guys told me about defaults | |
| 17:44:39 | hrw | ugh. I looked at tests and they look funny in some moments | |
| 17:47:01 | jaypipes | hrw: gotcha | |
| 17:47:24 | jaypipes | efried: reviewed. | |
| 17:47:30 | efried | jaypipes: thx | |
| 18:01:33 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Extending delete_cell --force to delete instance_mappings https://review.openstack.org/540073 | |
| 18:01:47 | efried | stephenfin: Remind me how to sphinx build a single document? | |
| 18:03:00 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have usable input for graphical console https://review.openstack.org/538003 | |
| 18:03:21 | hrw | jaypipes: your suggestions are in. Also test changed to test aarch64 with graphics | |
| 18:03:55 | hrw | probably should add new test so one will check base aarch64 no gfx + new for aarch64 with gfx | |
| 18:04:26 | jaypipes | hrw: lol, did you set the keymap to en-ie just for stephenfin? ;) | |
| 18:04:38 | hrw | jaypipes: copy/pasted from other test | |
| 18:04:46 | jaypipes | hrw: was a good choice! :) | |
| 18:04:58 | hrw | jaypipes: test_get_guest_config_with_vnc() settings | |
| 18:05:30 | hrw | and I dislike all those cfg.devices[X] checks as they look like the order is set in stone | |
| 18:05:54 | jaypipes | hrw: +2 from me :) | |
| 18:06:34 | hrw | jaypipes: thanks! | |
| 18:06:44 | hrw | now to convince mriedem or sahid... | |
| 18:07:06 | jaypipes | hrw: nie ma problemu | |
| 18:08:17 | hrw | jaypipes: added comment about tests | |
| 18:08:32 | hrw | tomorrow I am off, then fosdem so I could forgot | |
| 18:09:15 | hrw | jaypipes: speaking of patience... My first patch to kolla had 50 revisions | |
| 18:09:50 | hrw | jaypipes: I merged 20-30 patches before that one went in | |
| 18:10:52 | jaypipes | hrw: heh, that's just a "middle-aged patch" ;) | |
| 18:11:10 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make the InstanceMapping marker UUID-like https://review.openstack.org/539323 | |
| 18:11:14 | edleafe | gibi: ^^ maybe you'll like this better (my original approach) | |
| 18:11:16 | hrw | jaypipes: helped me learning project code a lot ;D | |
| 18:11:39 | hrw | jaypipes: that nova patch is first time I used tests in openstack | |
| 18:11:55 | hrw | in my previous nova patches Kevin_Zheng wrote tests | |
| 18:12:09 | jaypipes | ah | |
| 18:12:35 | jaypipes | hrw: just be glad you didn't need to touch the functional API tests... | |
| 18:13:39 | hrw | jaypipes: not my area of expertize | |
| 18:24:39 | hrw | see you Monday (or FOSDEM) | |
| 19:28:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Migrate "launch instance" user guide docs https://review.openstack.org/540048 | |
| 19:37:10 | smcginnis | mriedem: Can you confirm: https://review.openstack.org/#/c/540105/1/upper-constraints.txt | |
| 19:37:14 | smcginnis | Line 185 | |
| 19:38:01 | mriedem | smcginnis: yeah we don't, and i thought we actually couldn't do that w/o fixing horizon? | |
| 19:38:15 | mriedem | https://review.openstack.org/#/c/538472/ | |
| 19:38:22 | mriedem | i think the horizon tests will fail if you don't have that | |
| 19:38:48 | smcginnis | mriedem: I don't have all the details, just wanted to make sure there wasn't at least a major bump. | |
| 19:38:57 | smcginnis | mriedem: Makes sense, thanks for checking on it. | |
| 19:39:08 | mriedem | np | |
| 19:42:33 | mriedem | mmedvede: some ppc64 assertions being made in https://review.openstack.org/#/c/538003/ | |
| 19:44:14 | mmedvede | mriedem: thanks, taking a look | |
| 19:47:37 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Update Provider Tree https://review.openstack.org/540111 | |
| 19:47:58 | efried | jaypipes, mriedem: ^ | |
| 19:48:24 | efried | This is a Rocky spec for the work that's basically already been done. Figured we should have something written down. | |
| 19:49:59 | cdent | efried: good idea | |
| 19:50:52 | hrw | mriedem: thanks for review. will take care next week | |
| 19:52:24 | efried | jaypipes: I should really put your name on it somewhere, since the actual design was mostly your brainchild. | |
| 19:55:31 | openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | |
| 19:57:50 | jaypipes | efried: lol, I don't care about that :) as long as we make forward progress, I'm happy. | |
| 19:58:20 | efried | jaypipes: People in the know, know. | |
| 19:59:33 | efried | ya know? | |
| 20:00:15 | jaypipes | heh | |
| 20:14:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup launch instance and manage IPs docs https://review.openstack.org/540121 | |
| 20:17:05 | mriedem | this needs another +2 https://review.openstack.org/#/c/531517/ | |
| 20:29:49 | dansmith | yes, yes it does | |
| 20:44:13 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Update Provider Tree https://review.openstack.org/540111 | |
| 20:47:04 | melwitt | mriedem: do you know what causes neutron to send events? is it reacting to os-vif calls or? | |