| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-01 | |||
| 06:42:32 | openstackgerrit | Merged openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | |
| 06:42:44 | openstackgerrit | Merged openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | |
| 06:44:13 | openstackgerrit | Merged openstack/nova stable/pike: tests: Use correct response type in tests https://review.openstack.org/538938 | |
| 06:45:22 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | |
| 07:20:40 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/539841 | |
| 07:26:20 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | |
| 07:42:46 | ameeda | Hello. I try to alter table in sqlite as following http://paste.openstack.org/show/658280/ , but I got functional test failure | |
| 07:42:53 | ameeda | I got this error 'instances' not in {'instance_system_metadata': 11, 'instance_actions_events': 2, 'block_device_mapping': 1, 'instance_info_caches': 1, 'instance_actions': 2, 'instance_extra': 1, 'security_group_instance_association': 1} | |
| 07:47:46 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter https://review.openstack.org/539469 | |
| 07:49:34 | maciejjozefczyk_ | bauzas: pong :) | |
| 07:58:40 | openstackgerrit | Merged openstack/nova stable/pike: Handle images with no data https://review.openstack.org/538939 | |
| 08:02:54 | hrw | mriedem: asked and left. no one replied anyway | |
| 08:25:12 | hrw | die i440fx, die | |
| 08:33:03 | openstackgerrit | sahid proposed openstack/nova-specs master: virt: allow instances to be booted with trusted VFs https://review.openstack.org/485522 | |
| 08:36:59 | openstackgerrit | sahid proposed openstack/nova-specs master: update: introducing isolate emulthreads on host https://review.openstack.org/511188 | |
| 08:48:35 | openstackgerrit | Brooks Kaminski proposed openstack/nova master: XenAPI: XCP2.1+ Swallow VDI_NOT_IN_MAP Exception https://review.openstack.org/538415 | |
| 08:49:18 | Spaz-Work | jianghuaw: I did go with a swallow here.. I updated the commit message for my reasoning. | |
| 08:49:25 | Spaz-Work | Will get a post on the bug report here in a few too | |
| 08:50:08 | jianghuaw | good. Will review it a little later. | |
| 08:50:16 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: return non-None value for cpuset_reserved https://review.openstack.org/539865 | |
| 08:51:09 | Spaz-Work | No rush, just wanted to let you know :) | |
| 08:52:50 | bauzas | maciejjozefczyk_: hola, was afk | |
| 08:52:58 | bauzas | good morning folks, btw. | |
| 08:53:04 | Spaz-Work | Morning sir | |
| 08:53:29 | tetsuro | morning | |
| 08:55:37 | jianghuaw | bauzas, good morning:-) | |
| 08:57:51 | maciejjozefczyk_ | bauzas: hey | |
| 08:58:00 | maciejjozefczyk_ | bauzas: reading your comments | |
| 08:58:29 | openstackgerrit | Merged openstack/nova master: Fix bug case by none token context https://review.openstack.org/522112 | |
| 08:58:39 | openstackgerrit | Merged openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | |
| 08:58:52 | openstackgerrit | Merged openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | |
| 08:59:00 | bauzas | oh, btw. for folks not in European hours, "good morning" means "good [afternoon,night]" also :p | |
| 08:59:15 | bauzas | maciejjozefczyk_: do you understand the possible problem ? | |
| 08:59:26 | openstackgerrit | Merged openstack/nova master: reno for notification-transformation-queens https://review.openstack.org/518018 | |
| 08:59:33 | bauzas | it will work for Pike computes if the operator didn't modified the nova.conf | |
| 09:00:17 | bauzas | but if the operator modified the compute nova.conf for Pike, then we would possibly change the ratio into the conf opt value of any other service calling it | |
| 09:01:46 | maciejjozefczyk_ | bauzas: yes I see your point | |
| 09:02:21 | maciejjozefczyk_ | Maybe we should do distinguish between serviceand compute calling that method? | |
| 09:02:57 | ameeda | bauzas: I right sqlite migration script to alter column type as following http://paste.openstack.org/show/658286/, but when I run functional test I got this errors http://logs.openstack.org/00/526900/27/check/nova-tox-functional/f6ce415/testr_results.html.gz | |
| 09:02:58 | bauzas | maciejjozefczyk_: my thoughts is maybe we could just look at the ComputeNode object version | |
| 09:03:12 | ameeda | sorry "I write*" | |
| 09:04:02 | ameeda | bauzas: can you help me with that ? | |
| 09:04:11 | maciejjozefczyk_ | hmm bauzas could be good | |
| 09:04:32 | maciejjozefczyk_ | leave the logic for pike, move new one if object is newest one | |
| 09:09:35 | bauzas | maciejjozefczyk: sec, looking at code | |
| 09:09:43 | bauzas | ie. where we are accessing ratios | |
| 09:09:59 | bauzas | AFAIR, we only get or set ratios either in compute service or within the scheduler | |
| 09:10:17 | bauzas | so, the big problem is only for the scheduler | |
| 09:10:19 | maciejjozefczyk | bauzas: I think too thats its only in compute-node or scheduler | |
| 09:10:22 | maciejjozefczyk | bauzas: right | |
| 09:10:44 | bauzas | of course, let's find a solution that would work for any service | |
| 09:11:09 | bauzas | because if we just fix that only for the scheduler, if after some time, someone lookups ratios in the nova-api worker for example, it couldn't owrk | |
| 09:11:28 | maciejjozefczyk | bauzas: yes, it should be complex | |
| 09:11:50 | bauzas | okay, so it's confirmed | |
| 09:12:01 | jianghuaw | Spaz-Work, thanks for updating the patch with well defined commit messages. It looks very reasonable. I totally agreed with you:-) | |
| 09:12:13 | bauzas | we load ComputeNode objects in the scheduler HostManager to correctly set the HostStates | |
| 09:12:45 | Spaz-Work | jianghuaw: Thanks sir. Definately nerve-wracking commit since it's nasty, wanted to make sure I was clear ;) | |
| 09:14:46 | jianghuaw | The commit message did help me to understand why the fix goes with that way:-) | |
| 09:15:19 | bauzas | maciejjozefczyk: so, after looking at the object code, I think checking the object version won't work | |
| 09:16:50 | bauzas | because if we call the object from the scheduler side, it will get the latest version, then calling the remotable method for getting the primitives, then transforming the primitives if necessary and then hydrating the object from the primitive | |
| 09:17:15 | bauzas | but when we hydrate the primitive, we're already having a computenode object version that is the latest | |
| 09:18:23 | maciejjozefczyk | bauzas: the stupid solution is duplicating the fields, right?:) | |
| 09:18:54 | bauzas | what do you mean ? | |
| 09:20:25 | maciejjozefczyk | like adding ram_allocation_ratio_v2 for Rocky and do magic in filtering primitives? If I understand it correctly | |
| 09:21:08 | bauzas | oh please no | |
| 09:21:10 | maciejjozefczyk | but yes, its not a solution, its workaround | |
| 09:21:12 | maciejjozefczyk | :D | |
| 09:21:22 | maciejjozefczyk | bauzas: yes, just kidding | |
| 09:25:21 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | |
| 09:27:31 | kashyap | mriedem: About the question you asked me in the scroll, I asked the libvirt upstream folks, and this was the response: | |
| 09:28:06 | maciejjozefczyk | bauzas: So maybe some if logic from scheduler side? If the object is in version X, and we know that its from Rocky, then we'll not do thing from https://review.openstack.org/#/c/532924/6/nova/objects/compute_node.py L185, | |
| 09:28:11 | kashyap | mriedem: That "note" you pointed out from the OpenStack docs was never the case, so that statement wasn't ever true | |
| 09:28:30 | maciejjozefczyk | bauzas: I'm looking for better solution but I havent found any | |
| 09:28:48 | kashyap | mriedem: One can use `virsh nodedev-dumpxml` on the parent device and it will return a dump of the 'sysfs' attributes. | |
| 09:29:39 | bauzas | maciejjozefczyk: one possible outcome could be to transform in obj_make_compatible the primitive we got from the compute | |
| 09:30:26 | bauzas | maciejjozefczyk: ie. say that if the primitive is having a target version older than me, and if ratio is 0.0, set the value to what we want | |
| 09:32:20 | maciejjozefczyk | bauzas: Yes, obj_make_compatible is right place for that | |
| 09:34:53 | bauzas | maciejjozefczyk: so, when calling _from_db_object, we would get normalized values whatever the compute service version is | |
| 09:35:57 | maciejjozefczyk | bauzas: So the commit messag needs to be changed, to show that we introduce default values | |
| 09:36:11 | maciejjozefczyk | bauzas: and what about min config values? | |
| 09:36:35 | maciejjozefczyk | bauzas: do you agree that in rocky the min should be 0.1 at least? | |
| 09:37:16 | bauzas | 0.0 can be a trick for operatoes | |
| 09:37:36 | bauzas | like, say in my inventory, I don't want to count that resource for that specific compute | |
| 09:37:47 | bauzas | oh wait | |
| 09:37:51 | bauzas | it's the contrary | |
| 09:38:07 | bauzas | if I don't care about that resource class, then just have a ratio equal to 99999.99 | |
| 09:38:29 | bauzas | but if I want to stop allocating that compute, I could use a ratio of 0.0 | |
| 09:38:41 | bauzas | so I dunno | |
| 09:38:53 | bauzas | from a logical perspective, 0.1 makes sense | |
| 09:39:13 | lyarwood | Roamer`: re https://review.openstack.org/#/c/539742/ - looks like we are failing to cherry pick the nova patch in the StorPool job - http://logs.ci-openstack.storpool.com/42/539742/1/check/dsvm-tempest-storpool/f0a700e/console.html#_2018-02-01_06_49_47_306 | |
| 09:39:31 | bauzas | but from an operator perspective, I could say 'if I have a flavor that requires some disk but I want to not allocate that host if disk, then put it to 0.0' | |
| 09:39:46 | lyarwood | Roamer`: I'll try again using the change id but would you be able to manually test the fix from https://review.openstack.org/#/c/539739/ | |
| 09:39:47 | bauzas | I understand that can be sneaky | |
| 09:40:02 | maciejjozefczyk | bauzas: from placement side it makes now calculations ratio*resources=limit_on_host (something like that) | |
| 09:40:15 | maciejjozefczyk | so if we gonna place there 0 - you know what happend :) | |
| 09:41:19 | maciejjozefczyk | so maybe the logic should be also changed from placement side to not raise capacity check exception | |
| 09:42:11 | bauzas | yeah I know, but maybe some people would *want* to get capacity exceptions | |
| 09:42:15 | bauzas | I'm not kidding | |
| 09:42:30 | hrw | http://marcin.juszkiewicz.com.pl/2018/02/01/everyone-loves-90s-pc-hardware/ | |
| 09:43:53 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | |