| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-26 | |||
| 00:34:49 | openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | |
| 00:34:50 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | |
| 00:34:50 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | |
| 00:34:51 | openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | |
| 00:36:19 | efried | tetsuro Bailing out now. If you have the time and inclination, please feel free to recheck stuff all day :P | |
| 00:40:00 | efried | By the way tetsuro-さん, ありがとうございました for all of your excellent and detailed reviews. | |
| 00:40:06 | tetsuro | efried: thank you so much for so kindful and gread explanation! | |
| 00:40:30 | tetsuro | どういたしまして、こちらこそありがとう！笑 | |
| 00:41:21 | efried | tetsuro You did point out a bad copy/paste, which I'll fix in the next rev. | |
| 00:41:28 | efried | I'm really leaving now. See y'all tomorrow. | |
| 00:41:29 | tetsuro | ack. | |
| 00:41:41 | tetsuro | have a good night! | |
| 01:18:20 | gmann | mriedem: +1 on nova multiattach job. tempest one need rebase. rechecked job for testing the latest version of tempest test . ll review them accordingly | |
| 01:33:59 | openstackgerrit | melanie witt proposed openstack/nova master: Log the events we timed out waiting for while plugging vifs https://review.openstack.org/538103 | |
| 02:19:07 | openstackgerrit | Chen Hanxiao proposed openstack/nova master: test: Use assertEqual() instead of assertXXXEqual() https://review.openstack.org/533493 | |
| 02:29:33 | SpazZz | Morning huanxie, i'm heading into work in about an hour, would love to get a chance to talk to you today :) | |
| 02:29:42 | SpazZz | And thanks for the code review :D | |
| 02:30:21 | huanxie | @SpazZz, sure | |
| 02:33:24 | huanxie | There is a ticket about live migration with XenAPI driver https://bugs.launchpad.net/nova/+bug/1704071 and I have made a draft patch fixing this problem, we can have a discuss about this | |
| 02:33:25 | openstack | Launchpad bug 1704071 in OpenStack Compute (nova) "XenAPI: volume VM live migration failed with VDI_NOT_IN_MAP" [Low,Confirmed] | |
| 02:33:39 | SpazZz | Yes ma'am, that's exactly what i'd like to talk about | |
| 02:36:04 | huanxie | SpazZa, wait a moment, let me find some thing for you | |
| 02:41:33 | SpazZz | hey huanxie I gotta get reayd to head to work. If you find something send it ot the Spazmotic nick.. that's my work IRC :) | |
| 02:41:36 | SpazZz | Be back in just al ittle bit. | |
| 02:42:01 | huanxie | Sure, can leave you message | |
| 02:44:23 | gmann | mriedem: saw mail for q-3 tag. will we defer this to Rocky https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-queens | |
| 02:45:33 | mriedem | the remaining parts yeah | |
| 02:46:10 | gmann | k | |
| 02:51:22 | jackie-truong | dansmith: are you still around? | |
| 03:03:22 | openstackgerrit | shuangyang.qian proposed openstack/nova master: Fix the metadata re to match the unicode https://review.openstack.org/536236 | |
| 03:14:47 | openstackgerrit | Merged openstack/os-traits master: Update reno for stable/queens https://review.openstack.org/537512 | |
| 03:14:49 | openstackgerrit | Merged openstack/os-vif master: Update reno for stable/queens https://review.openstack.org/537514 | |
| 03:47:34 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | |
| 03:47:34 | openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | |
| 04:00:58 | Spazmotic-Work | Aigoo~ stupid VPN | |
| 04:03:25 | openstackgerrit | Merged openstack/osc-placement master: Update reno for stable/queens https://review.openstack.org/537698 | |
| 04:52:29 | Spazmotic | Welcome back huanxie | |
| 04:52:39 | Spazmotic | Got some time? | |
| 04:52:58 | Spazmotic | Will put some KPOP and try to remember what all I had to ask you if you do hehe | |
| 05:36:39 | openstackgerrit | Merged openstack/python-novaclient master: Update reno for stable/queens https://review.openstack.org/538061 | |
| 05:47:07 | openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | |
| 07:07:42 | openstackgerrit | Merged openstack/nova master: PowerVM Driver: SEA https://review.openstack.org/523216 | |
| 07:08:40 | openstackgerrit | Andreas Jaeger proposed openstack/nova master: Fix SUSE Install Guide: Placement port https://review.openstack.org/538163 | |
| 07:43:09 | openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | |
| 07:43:09 | openstackgerrit | Ameed Ashour proposed openstack/nova master: detaching volumes when deleted VM is in error state https://review.openstack.org/528069 | |
| 08:31:01 | Spazmotic | Andreas you in here? Any reason why you zvkm rechecked? | |
| 08:34:07 | Spazmotic | You making IBM hate me again hehe | |
| 09:26:31 | Spazmotic | man the tempest zuul and IBM failures plaguing me with snapshots failing to create is driving me into insanity | |
| 09:41:57 | gmann | alex_xu: gibi stephenfin : any other optimized way to get system metadata ?- https://review.openstack.org/#/c/526900/22/nova/tests/functional/regressions/test_bug_1117923.py@124 | |
| 09:45:21 | gmann | ameade: ^^ let's see if other folk can tell better way | |
| 09:50:06 | gibi | gmann: as far as I see there is no way to directly get the instace system_metadata via the nova REST_API | |
| 09:53:33 | openstackgerrit | Merged openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | |
| 09:53:44 | openstackgerrit | Merged openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config https://review.openstack.org/494156 | |
| 09:55:35 | Spazmotic | nova hides that junk pretty well unfortunately from what i've tested in the past | |
| 10:01:00 | Spazmotic | Any UK cores here today? :) | |
| 10:02:02 | Spazmotic | Would love if one had some free cycles for a review. https://review.openstack.org/#/c/533168/4 . Zuul freaking out over some volume stuff but should go back to +1 here soon. Heading on vacation in about 9 days and don't want it to sit idle for 2 weeks | |
| 10:03:27 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'move-nova-cmds-to-cliff' spec https://review.openstack.org/433603 | |
| 10:06:43 | openstackgerrit | lei zhang proposed openstack/nova master: Fix the incorrect RST convention https://review.openstack.org/538208 | |
| 10:12:59 | openstackgerrit | Zengzhi Wang proposed openstack/nova stable/pike: Make eventlet hub use a monotonic clock https://review.openstack.org/537811 | |
| 10:13:33 | jianghuaw | Spazmotic, I guess the zvkm rechecks were done automatically as there was an error in upstream package which caused some CI job failed. | |
| 10:14:18 | Spazmotic | Maybe maybe.. now I Just gotta fight zuul hehe | |
| 10:15:28 | jianghuaw | hehe. Good luck. | |
| 10:26:46 | Roamer` | Spazmotic, if you're seeing Zuul failures in volume backup tests, there's little point in rechecking until https://review.openstack.org/#/c/538027/ merges | |
| 10:27:05 | Spazmotic | ahh something regress? Alrighty roamer, thanks | |
| 10:28:10 | Roamer` | Spazmotic, yep, sporadic, not always, but quite annoying the last couple of days | |
| 10:34:49 | Roamer` | of course, once it merges, you'd wish you had rechecked early enough so that your patch is close to the head of the queue :P | |
| 11:17:41 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Integrate Mypy Type Checking https://review.openstack.org/538217 | |
| 11:21:15 | stephenfin | cdent, mdbooth, sean-k-mooney: Would be interested in your thoughts on this. PoC changes to follow shortly https://review.openstack.org/538217 | |
| 11:41:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Add mypy target https://review.openstack.org/538221 | |
| 11:41:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Store list of converted files https://review.openstack.org/538222 | |
| 11:41:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Move __init__ function https://review.openstack.org/538223 | |
| 11:41:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add 'types' module https://review.openstack.org/538225 | |
| 11:41:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.openstack.org/538224 | |
| 11:42:26 | stephenfin | cdent, mdbooth, sean-k-mooney: Ta-da! ^ That was my evening's work 🙈 | |
| 11:43:29 | Spazmotic | You did all that and i'm just over here smashing my face into xenapi live migrate | |
| 11:50:09 | johnthetubaguy | Spazmotic: xenapi live-migrate... whats up there? | |
| 11:50:38 | Spazmotic | man john i've been crying your name for days :p | |
| 11:50:53 | johnthetubaguy | Spazmotic: your welcome | |
| 11:50:55 | Spazmotic | hehehehe | |
| 11:51:20 | Spazmotic | Looks like it's not working in XS7+ due to the SR not existing during the assert_can_live_migrate for src -> destand XS7 being more insistent that it does. | |
| 11:51:41 | johnthetubaguy | oh, they "fixed" that check | |
| 11:52:02 | Spazmotic | Yep, so it would seem. It actually insists now and throws MAP errors | |
| 11:52:34 | johnthetubaguy | yeah, we don't pass the SR map to the first check call, as it never used to do anything with it | |
| 11:52:37 | Spazmotic | johnthetubaguy: by the by I manually added you to a review with Xenapi the other week, I hope you don't mind. | |
| 11:53:10 | johnthetubaguy | that is no problem, although you might have to ping me to get to that, hoping to ramp my reviewing back up now things are more settled over here | |
| 11:53:15 | Spazmotic | Well in this case it's for our iSCSI volumes only causing an issue since they don't exist yet on the dest during its first pass call through that method | |
| 11:53:33 | Spazmotic | yeah I understand, I mentioned you a few times but figured yo uwere just busy | |
| 11:53:36 | johnthetubaguy | yeah, but I think you will need to send the map for it to find them | |
| 11:53:41 | Spazmotic | IT's pretty simple code but it directly involves things I know yo uworked on, so wanted your advice | |
| 11:54:09 | Spazmotic | I agree, my only real thought here is how to handle it. My best thought now is to generate the SR a little earlier in the code line | |
| 11:54:16 | johnthetubaguy | its a nasty one honestly, as the work isn't done until much later to create the volumes on the dest, as I am sure you saw | |
| 11:54:51 | johnthetubaguy | the problem is Cinder really, that extra connection has tracking info that doesn't get updated till after the check phase | |
| 11:55:29 | johnthetubaguy | the other (very unfortunate but quick) approach is to move the check later, before you call the live-migration | |
| 11:55:40 | Spazmotic | Without a major overhaul, the only thing I was able to think of that wasn't too gross was to use connect_to_volume provider at the destination check. IT would require that code pulling BDMS though.. which doesn't feel right. | |
| 11:55:58 | Spazmotic | at least that way the SR exists, but doesn't need to attach the volume yet..and it generates the map without error. | |
| 11:55:59 | johnthetubaguy | yeah, those BDMs are wrong at that point | |
| 11:56:26 | johnthetubaguy | you need the specific connection params for the destination hypervisor, which could be different credentails, in the general case | |
| 11:56:28 | Spazmotic | It would literally just be a throw away of the variable afterwards, which is a waste | |
| 11:57:16 | Spazmotic | That's true that data is stored in the SR isn't it. | |
| 11:58:05 | Spazmotic | I guess it's still workable since bdms pulls conn_data anyway | |