| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-24 | |||
| 18:25:26 | dansmith | I think I still get something | |
| 18:25:40 | dansmith | Its value may be silently ignored in the future | |
| 18:25:40 | dansmith | /dan/nova/.tox/py27/lib/python2.7/site-packages/oslo_policy/policy.py:623: UserWarning: Policy "os_compute_api:os-extended-volumes":"rule:admin_or_owner" was deprecated for removal in 17.0.0. Reason: Nova API extension concept has been removed in Pike. Those extensions have their own policies enforcement. As there is no extensions now, "os_compute_api:os-extended-volumes" policy which was added for extensions is not needed any more. | |
| 18:25:48 | dansmith | I think the rule:admin_or_owner bit is new now | |
| 18:26:43 | lbragstad | dansmith: oh nice | |
| 18:26:55 | dansmith | hmm, actually, no | |
| 18:27:02 | dansmith | I backed out the change and I get the same exact thing | |
| 18:28:22 | lbragstad | weird - that's still emitting https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L615-L625 | |
| 18:29:48 | lbragstad | huh... | |
| 18:29:51 | lbragstad | actually... | |
| 18:30:01 | lbragstad | it looks like it's writing everything to disk | |
| 18:30:15 | lbragstad | regardless of it being in fake_policy or not | |
| 18:30:22 | lbragstad | https://github.com/openstack/nova/blob/master/nova/tests/unit/policy_fixture.py#L96 | |
| 18:30:34 | dansmith | yup | |
| 18:30:44 | dansmith | per sdague's comment above I assume | |
| 18:30:54 | lbragstad | yeah | |
| 18:31:13 | lbragstad | this must have been around before the default in code efforts | |
| 18:31:33 | dansmith | I feel like it cropped up between when I left last year and popped up this year | |
| 18:31:54 | lbragstad | https://github.com/openstack/nova/commit/eacdbc3d8e9042c584c751d599da59ddcaf98a1c | |
| 18:36:09 | lbragstad | dansmith: trying a workaround hack with http://paste.openstack.org/raw/652502/ | |
| 18:36:14 | lbragstad | checking if i can recreate locally | |
| 18:36:28 | dansmith | ah that seems nice | |
| 18:37:18 | lbragstad | ^ that fixes it for me | |
| 18:38:53 | lbragstad | http://paste.openstack.org/show/652509/ without the fix... | |
| 18:39:07 | lbragstad | er... "fix", no idea if that's how we want to work around it | |
| 18:39:45 | lbragstad | with the workaround http://paste.openstack.org/show/652513/ | |
| 18:40:54 | openstackgerrit | Lance Bragstad proposed openstack/nova master: WIP: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | |
| 18:40:54 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Remove deprecated policies from fake_policy https://review.openstack.org/537602 | |
| 18:42:03 | openstackgerrit | Lance Bragstad proposed openstack/nova master: WIP: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | |
| 18:42:31 | dansmith | lbragstad: remove the WIP? | |
| 18:43:01 | lbragstad | done | |
| 18:43:04 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | |
| 18:43:29 | dansmith | lbragstad: thanks! | |
| 18:44:13 | lbragstad | dansmith: no problem - thanks for the heads up... not sure if all those policies need to be there, but at least it doesn't spam as bad | |
| 18:45:03 | mriedem | dansmith: do we still need https://review.openstack.org/#/c/537600/ ? | |
| 18:45:21 | mriedem | oh i guess so | |
| 18:56:37 | mriedem | stephenfin: melwitt: umm https://review.openstack.org/#/c/523958/ | |
| 18:56:44 | mriedem | could we not have red hat cores approving red hat changes? | |
| 19:01:22 | melwitt | mriedem: sorry about that. I have asked red hatters not to approve red hat changes that I've +2ed so I think this was just an oversight. downgrading my vote to +1 | |
| 19:01:45 | melwitt | er, I guess that doesn't help because I'm not the approver | |
| 19:02:16 | dansmith | yeah, it won't help :( | |
| 19:02:19 | dansmith | a -2 will, but.. | |
| 19:02:39 | dansmith | it will also reset the gate if it's already there | |
| 19:02:59 | mriedem | we do'nt need to pull it out, | |
| 19:03:07 | mriedem | i'm not going to review it in depth at this point | |
| 19:03:38 | mriedem | the commit message obviously shows there was thought put into it | |
| 19:03:46 | dansmith | lol | |
| 19:04:08 | artom | It's that suave British accent, isn't it? | |
| 19:04:23 | mriedem | who wrote the commit message, lee or booth? | |
| 19:04:57 | mriedem | anywho, | |
| 19:05:00 | mriedem | btw, | |
| 19:05:10 | mriedem | the live migration job runs with ceph i think, | |
| 19:05:21 | mriedem | but i guess we don't enable volume-backed live migratoin do we, | |
| 19:05:34 | mriedem | and even if we did, we don't have a tempest test for encrypted volume-backed live migration to run with ceph | |
| 19:05:42 | mriedem | but we do have new enough libvirt and qemu in the pike UCA to test this | |
| 19:06:02 | mriedem | heh https://review.openstack.org/#/c/536177/ | |
| 19:09:30 | melwitt | mriedem: I have a patch up to enable it but it looks like it's hitting legit problems https://review.openstack.org/#/c/528104/ | |
| 19:10:23 | mriedem | melwitt: is there supposed to be at least even a release note anywhere in this series? | |
| 19:10:32 | mriedem | because given the commit message, it seems pretty complicated | |
| 19:10:53 | openstackgerrit | Merged openstack/osc-placement master: CLI for resource classes (v1.2) https://review.openstack.org/511182 | |
| 19:10:53 | mriedem | or some kind of advertisement anywhere about 'hey you can do this thing now with libvirt and encrypted volumes' | |
| 19:14:55 | melwitt | mriedem: I think there's no release note because it's automatic, that is, operators don't have to do anything, it will use native luks decryption if available. but now that you mention it, it might be helpful to mention that it will use native decryption if qemu and libvirt version combination support it | |
| 19:15:41 | mriedem | right, i mean, unless this is totally rock solid, and shit starts randomly failing, operators are probably going to want to know that something new is going on here | |
| 19:16:57 | melwitt | yeah, I agree with that | |
| 19:17:24 | artom | Heh, we talked about this in the spec: https://review.openstack.org/#/c/490824/5/specs/queens/approved/libvirt-qemu-native-luks.rst@98 | |
| 19:17:31 | artom | And then promptly forgot about it :( | |
| 19:20:11 | dhellmann | mriedem : is https://review.openstack.org/516385 of any interest or should I just abandon that? | |
| 19:23:29 | mriedem | dhellmann: it is of the utmost interest | |
| 19:23:55 | dhellmann | mriedem : ok. I'll leave it open then until someone has a minute to review it. | |
| 19:24:01 | mriedem | dhellmann: already did | |
| 19:24:02 | mriedem | :) | |
| 19:24:04 | dhellmann | :-) | |
| 19:24:05 | dhellmann | thanks | |
| 19:24:34 | mriedem | melwitt: didn't lee say he was going to be out a bit this week? do you think you could take a stab at a release note? | |
| 19:24:38 | mriedem | since you know the change | |
| 19:24:43 | mriedem | as a patch on top of course | |
| 19:24:44 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add unit test for non-placement resize https://review.openstack.org/537614 | |
| 19:24:53 | mriedem | edleafe: thanks for that | |
| 19:25:04 | edleafe | mriedem: np | |
| 19:25:22 | melwitt | mriedem: sure, will do | |
| 19:25:28 | mriedem | melwitt: thanks | |
| 19:25:35 | mriedem | then i guess we can close that one out for queens | |
| 19:26:40 | openstackgerrit | Merged openstack/osc-placement master: Address review comments from allocations patch https://review.openstack.org/536871 | |
| 19:27:09 | openstackgerrit | Merged openstack/osc-placement master: Usage docs and initial release note for osc-placement https://review.openstack.org/536858 | |
| 19:28:05 | mriedem | the cinder gate fix has been promoted btw | |
| 19:28:13 | mriedem | so hopefully stuff starts merging again soon | |
| 19:35:35 | melwitt | that's super news ++ | |
| 19:38:39 | openstackgerrit | Mark Goddard proposed openstack/nova master: Unplug all VIFs from ironic nodes during tear down https://review.openstack.org/537626 | |
| 19:49:55 | dansmith | melwitt: mriedem tssurya: do we need to have a cells meeting today? I've got nothing new to talk abotu | |
| 19:50:43 | archit | msg amodi identify titanic123 | |
| 19:51:11 | dansmith | whoopsie :) | |
| 19:51:13 | archit | lol | |
| 19:51:20 | archit | yep .:( | |
| 19:51:27 | melwitt | dansmith: I don't have anything new either | |
| 19:51:28 | efried | swhy I always do those in the status channel | |
| 19:51:35 | mriedem | dansmith: there are no major new bugs that i'm aware of, | |
| 19:51:40 | mriedem | and the resize + alternate hosts change is approved | |
| 19:51:49 | efried | Is this cinder bug going to affect all patches? | |
| 19:51:58 | mriedem | efried: anything that runs tempest api tests | |
| 19:52:01 | mriedem | so all dsvm jobs | |