| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-24 | |||
| 18:09:26 | dansmith | after my hack | |
| 18:09:57 | lbragstad | ah | |
| 18:10:04 | mriedem | bauzas: is this the final piece of the vgpu puzzle for libvirt https://review.openstack.org/#/c/535693/ ? i don't see any other libvirt patches for vgpu - so assuming we're done once that merges | |
| 18:10:15 | dansmith | trying again without the hack, but assume I'll get that same thing again | |
| 18:10:30 | mriedem | do we have any patch that has a feature support matrix update for vgpu support? | |
| 18:11:56 | lbragstad | dansmith: do you have a policy file you're testing with locally, or are you just running nova tests? | |
| 18:12:11 | dansmith | lbragstad: just nova tests | |
| 18:12:18 | mriedem | dansmith: if it's always a handful of rules, it could be something in the policy fixture or a specific test | |
| 18:13:28 | lbragstad | the fix in 1.33.1 just makes it so a warning is logged iff a policy is deprecated *and* you're specifying it in a policy file or somewhere on disk | |
| 18:13:49 | dansmith | mriedem: there are 11 warnings, seemingly regardless of what tests I run | |
| 18:15:12 | mriedem | nova.tests.unit.policy_fixture.PolicyFixture maybe? | |
| 18:15:17 | mriedem | loads things up from some fake rules | |
| 18:15:33 | mriedem | from nova.tests.unit.fake_policy | |
| 18:15:44 | dansmith | mriedem: wouldn't that only affect me if I'm running those tests though? | |
| 18:15:49 | dansmith | I get this if I run a single-shot test | |
| 18:17:03 | lbragstad | so - it is writing them to disk https://github.com/openstack/nova/blob/master/nova/tests/unit/policy_fixture.py#L97 | |
| 18:17:32 | mriedem | dansmith: i think the base test case class loads up the policy fixture | |
| 18:17:33 | mriedem | for all tests | |
| 18:17:47 | lbragstad | which would trip this case - https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L610-L625 | |
| 18:17:59 | mriedem | yup self.policy = self.useFixture(policy_fixture.PolicyFixture()) | |
| 18:18:02 | mriedem | it's loaded for all tests | |
| 18:18:14 | mriedem | dansmith: so you'd have to try and remove the deprecated policy rules from the fake fixture data | |
| 18:18:43 | lbragstad | because oslo.policy thinks it needs to inform an operator about a policy override that is deprecated (i assume https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_policy.py contains some deprecated policies) | |
| 18:19:15 | dansmith | mriedem: it doesn't seem to have a set of rules in the fixture though | |
| 18:20:07 | mriedem | dansmith: what's one of the ones it's complaining about? | |
| 18:20:22 | dansmith | os_compute_api:os-extended-volumes | |
| 18:20:26 | dansmith | maybe it's in fake_policy.py? | |
| 18:20:30 | mriedem | os_compute_api:os-extended-volumes | |
| 18:20:31 | mriedem | yes | |
| 18:20:33 | mriedem | that's the problem, | |
| 18:20:36 | lbragstad | https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_policy.py#L50 | |
| 18:20:40 | lbragstad | ^ that one is deprecated | |
| 18:20:41 | mriedem | it's writing the fixture data to a temp file | |
| 18:20:46 | mriedem | and read in by the policy fixture | |
| 18:21:05 | dansmith | what does that mean though? there's no value set for that | |
| 18:21:11 | dansmith | or do you mean I just need to delete it? | |
| 18:21:16 | mriedem | "" means all i think | |
| 18:21:21 | mriedem | delete those entries | |
| 18:21:38 | lbragstad | i'm working on a patch now | |
| 18:21:41 | mriedem | i'm not sure why we actually even have that fake_policy file anymore | |
| 18:22:10 | mriedem | lbragstad has grown bored with keystone | |
| 18:24:15 | dansmith | lbragstad: I've got one already | |
| 18:24:18 | dansmith | about to push | |
| 18:24:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated policy items from fake_policy https://review.openstack.org/537600 | |
| 18:24:45 | dansmith | lbragstad: mriedem ^ | |
| 18:25:25 | dansmith | hmm | |
| 18:25:26 | dansmith | I think I still get something | |
| 18:25:40 | dansmith | Its value may be silently ignored in the future | |
| 18:25:40 | dansmith | /dan/nova/.tox/py27/lib/python2.7/site-packages/oslo_policy/policy.py:623: UserWarning: Policy "os_compute_api:os-extended-volumes":"rule:admin_or_owner" was deprecated for removal in 17.0.0. Reason: Nova API extension concept has been removed in Pike. Those extensions have their own policies enforcement. As there is no extensions now, "os_compute_api:os-extended-volumes" policy which was added for extensions is not needed any more. | |
| 18:25:48 | dansmith | I think the rule:admin_or_owner bit is new now | |
| 18:26:43 | lbragstad | dansmith: oh nice | |
| 18:26:55 | dansmith | hmm, actually, no | |
| 18:27:02 | dansmith | I backed out the change and I get the same exact thing | |
| 18:28:22 | lbragstad | weird - that's still emitting https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L615-L625 | |
| 18:29:48 | lbragstad | huh... | |
| 18:29:51 | lbragstad | actually... | |
| 18:30:01 | lbragstad | it looks like it's writing everything to disk | |
| 18:30:15 | lbragstad | regardless of it being in fake_policy or not | |
| 18:30:22 | lbragstad | https://github.com/openstack/nova/blob/master/nova/tests/unit/policy_fixture.py#L96 | |
| 18:30:34 | dansmith | yup | |
| 18:30:44 | dansmith | per sdague's comment above I assume | |
| 18:30:54 | lbragstad | yeah | |
| 18:31:13 | lbragstad | this must have been around before the default in code efforts | |
| 18:31:33 | dansmith | I feel like it cropped up between when I left last year and popped up this year | |
| 18:31:54 | lbragstad | https://github.com/openstack/nova/commit/eacdbc3d8e9042c584c751d599da59ddcaf98a1c | |
| 18:36:09 | lbragstad | dansmith: trying a workaround hack with http://paste.openstack.org/raw/652502/ | |
| 18:36:14 | lbragstad | checking if i can recreate locally | |
| 18:36:28 | dansmith | ah that seems nice | |
| 18:37:18 | lbragstad | ^ that fixes it for me | |
| 18:38:53 | lbragstad | http://paste.openstack.org/show/652509/ without the fix... | |
| 18:39:07 | lbragstad | er... "fix", no idea if that's how we want to work around it | |
| 18:39:45 | lbragstad | with the workaround http://paste.openstack.org/show/652513/ | |
| 18:40:54 | openstackgerrit | Lance Bragstad proposed openstack/nova master: WIP: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | |
| 18:40:54 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Remove deprecated policies from fake_policy https://review.openstack.org/537602 | |
| 18:42:03 | openstackgerrit | Lance Bragstad proposed openstack/nova master: WIP: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | |
| 18:42:31 | dansmith | lbragstad: remove the WIP? | |
| 18:43:01 | lbragstad | done | |
| 18:43:04 | openstackgerrit | Lance Bragstad proposed openstack/nova master: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | |
| 18:43:29 | dansmith | lbragstad: thanks! | |
| 18:44:13 | lbragstad | dansmith: no problem - thanks for the heads up... not sure if all those policies need to be there, but at least it doesn't spam as bad | |
| 18:45:03 | mriedem | dansmith: do we still need https://review.openstack.org/#/c/537600/ ? | |
| 18:45:21 | mriedem | oh i guess so | |
| 18:56:37 | mriedem | stephenfin: melwitt: umm https://review.openstack.org/#/c/523958/ | |
| 18:56:44 | mriedem | could we not have red hat cores approving red hat changes? | |
| 19:01:22 | melwitt | mriedem: sorry about that. I have asked red hatters not to approve red hat changes that I've +2ed so I think this was just an oversight. downgrading my vote to +1 | |
| 19:01:45 | melwitt | er, I guess that doesn't help because I'm not the approver | |
| 19:02:16 | dansmith | yeah, it won't help :( | |
| 19:02:19 | dansmith | a -2 will, but.. | |
| 19:02:39 | dansmith | it will also reset the gate if it's already there | |
| 19:02:59 | mriedem | we do'nt need to pull it out, | |
| 19:03:07 | mriedem | i'm not going to review it in depth at this point | |
| 19:03:38 | mriedem | the commit message obviously shows there was thought put into it | |
| 19:03:46 | dansmith | lol | |
| 19:04:08 | artom | It's that suave British accent, isn't it? | |
| 19:04:23 | mriedem | who wrote the commit message, lee or booth? | |
| 19:04:57 | mriedem | anywho, | |
| 19:05:00 | mriedem | btw, | |
| 19:05:10 | mriedem | the live migration job runs with ceph i think, | |
| 19:05:21 | mriedem | but i guess we don't enable volume-backed live migratoin do we, | |
| 19:05:34 | mriedem | and even if we did, we don't have a tempest test for encrypted volume-backed live migration to run with ceph | |