Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-01-23
15:37:40 stephenfin But otherwise, yeah, I figured it wouldn't be super easy but it is a much better design long-term, IMO
15:37:44 sean-k-mooney stephenfin: nope you will get an invalid key exception unless i specificlally add code to drop it
15:38:12 stephenfin sean-k-mooney: I'm working through the CPU pinning code again. Every time I go through this, I have to relearn it
15:38:34 stephenfin sean-k-mooney: But nothing except tests use it
15:38:36 stephenfin *set it
15:39:17 stephenfin and we could just filter it out of any '[pci]spec' options with a warning that it must be manually removed
15:39:20 damini 111Pls can anyone tell me how to write tempest test for shelve instance and unshelve .I am new to openstack.
15:39:50 sean-k-mooney haha well now you mention it the code that is failing is in consume_requests a pop from an empty list.
15:40:17 sean-k-mooney stephenfin: ya its easy to ignore it and log a message the way i have it set up instead of a exception
15:41:49 stephenfin damini: Tempest has a helper function for that. You might want to start there https://github.com/openstack/tempest/blob/master/tempest/common/compute.py#L263
15:42:26 stephenfin sean-k-mooney: (y) that would be my recommendation
15:42:34 alex_xu dansmith: do you have the link? I didn't found in the gerrit
15:42:39 stephenfin No point adding something we're going to immediately deprecate
15:42:49 dansmith alex_xu: link for what?
15:43:17 alex_xu dansmith: the 1.12 which mriedem mentioned, I guess you hit 1.12 by this patch https://review.openstack.org/#/c/531517/2
15:43:53 mriedem yeah that's the one
15:46:11 alex_xu mriedem: ah, I got it, dansmith already said he is working on other things. sorry, i misunderstand few words previously
15:46:38 mriedem np, i'm just pointing out you were both working on part of the same problem i think
15:47:24 dansmith alex_xu: why are you only bumping to 1.12 instead of to current?
15:47:31 dansmith alex_xu: because we're just going to have to bump right after this one
15:47:55 alex_xu dansmith: I have followup patch to support traits https://review.openstack.org/536085, which is 1.17
15:48:57 dansmith alex_xu: okay seems like you could just start calling at 1.17 in the first patch, but okay
15:49:02 dansmith I guess I'll rebase mine on your last change
15:50:29 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Address comments from original inventory patch https://review.openstack.org/521578
15:50:30 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Add missing runtime requirements https://review.openstack.org/536870
15:50:30 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Usage docs and initial release note for osc-placement https://review.openstack.org/536858
15:50:31 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Address review comments from allocations patch https://review.openstack.org/536871
15:50:31 alex_xu dansmith: ok, thanks
16:00:18 openstackgerrit Merged openstack/nova master: Add reference to policy sample https://review.openstack.org/531713
16:00:31 openstackgerrit Merged openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540
16:01:02 openstackgerrit Merged openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168
16:02:36 openstackgerrit melanie witt proposed openstack/nova master: Set server status to ERROR if rebuild failed https://review.openstack.org/536268
16:04:49 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI for resource classes (v1.2) https://review.openstack.org/511182
16:04:49 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI for aggregates (v1.1) https://review.openstack.org/505643
16:04:50 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: RP delete inventories (v1.5) https://review.openstack.org/514642
16:04:50 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: RP list: member_of and resources parameters (v1.3, v1.4) https://review.openstack.org/511183
16:04:51 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Resource class set (v1.7) https://review.openstack.org/514644
16:04:51 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI for traits (v1.6) https://review.openstack.org/514643
16:04:52 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647
16:04:52 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
16:04:53 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: [WIP] Get resource provider by uuid or name https://review.openstack.org/527791
16:07:58 bauzas sorry folks, I just migrated my IRC bouncer
16:08:06 bauzas in case some pinged me, lemme know
16:09:16 openstackgerrit Jackie Truong proposed openstack/python-novaclient master: Microversion 2.61 - Add trusted_image_certificates https://review.openstack.org/500396
16:10:40 openstackgerrit Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347
16:10:40 openstackgerrit Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346
16:10:41 openstackgerrit Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029
16:10:41 openstackgerrit Matthew Booth proposed openstack/nova master: Expose driver_block_device fields consistently https://review.openstack.org/528362
16:10:42 openstackgerrit Matthew Booth proposed openstack/nova master: Fix libvirt volume tests passing invalid disk_info https://review.openstack.org/529328
16:10:42 openstackgerrit Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363
16:10:43 openstackgerrit Matthew Booth proposed openstack/nova master: Expose volume host type and path independent of libvirt config https://review.openstack.org/530786
16:10:43 openstackgerrit Matthew Booth proposed openstack/nova master: Pass disk_info dict to libvirt_info https://review.openstack.org/529329
16:10:44 openstackgerrit Matthew Booth proposed openstack/nova master: Don't generate fake disk_info in swap_volume https://review.openstack.org/530787
16:10:45 openstackgerrit Matthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver https://review.openstack.org/529380
16:16:40 openstackgerrit melanie witt proposed openstack/nova master: Set server status to ERROR if rebuild failed https://review.openstack.org/536268
16:16:49 mriedem melwitt: suggestion in https://review.openstack.org/#/c/536268/
16:16:56 mriedem right before you pushed
16:17:06 mriedem we can assert the fault is set in the functional test that is also being updated
16:17:14 melwitt I think maybe I did what you asked
16:17:31 melwitt oh, nope, different func test
16:17:48 mriedem ah that works too
16:18:00 melwitt k, lemme add that
16:18:03 mriedem that's fine,
16:18:20 mriedem this is better actually because a rebuild can be done for a non-admin and we want to make sure the non-admin can see the fault
16:18:44 mriedem i don't know if we want to say something specific in the fault message about attempting to rebuild with a different image, that could be a slippery slope of assumptions about why we failed
16:18:45 melwitt okay, cool
16:19:13 mriedem like, image might be fine, but some other filter failed because a resource is unavailable or something
16:19:33 melwitt yeah, I was thinking about that too
16:19:46 mriedem +2
16:20:23 mriedem heh stable/newton is still around
16:21:29 melwitt :)
16:22:37 mriedem this is probably not worth yet another newton release before eol though
16:22:46 mriedem tonyb: when you gonna pull that newton-eol trigger?
16:23:27 melwitt wah wah
16:30:05 bauzas wait, Newton is not EOL'd yet ?
16:30:08 bauzas woah
16:30:14 mriedem melwitt: want to start on the backports?
16:30:47 bauzas melwitt: mriedem: dansmith: I think we should document a relnote with https://review.openstack.org/#/c/536268/6
16:30:47 melwitt mriedem: yes
16:31:01 bauzas I was about to say that we will provide a new behaviour
16:31:16 dansmith bauzas: it's really the behavior that every other action has though
16:31:18 bauzas I'm not asking for a microversion, but we need to explain for operators I think
16:31:31 bauzas dansmith: I know
16:31:41 bauzas dansmith: I'm just thinking that it's a game changer
16:31:56 bauzas and documenting it would be IMHO a small thing for a better point
16:32:00 mriedem *shrug* i thought about a "fixes" release note just to point out that if scheduling fails during rebuild the instance will go to ERROR state and a fault will be recorded
16:32:02 bauzas I just don't want to see rants here :p
16:32:20 bauzas mriedem: exactly my point
16:32:26 bauzas not more than that
16:32:35 mriedem i'd be fine with that
16:32:37 bauzas so we can point out the relnote if someone is aking that
16:32:47 dansmith meh.
16:33:03 bauzas backporting that means also that we will change the logic
16:33:27 bauzas hopefully the stable version will be not a .z one
16:33:57 mriedem umm
16:34:00 mriedem it's not a new feature
16:34:03 mriedem it's a bug fix
16:34:16 bauzas sure, but we're changing the API right?
16:34:26 mriedem we didn't bump the .y for the change that made the API fail fast if you tried to rebuild a volume-backed instance and change the image
16:34:28 bauzas again, I'm not asking for a microversion, please

Earlier   Later