Earlier  
Posted Nick Remark
#openstack-nova - 2018-01-22
23:21:39 sean-k-mooney hongbin: so ya all that is missing then is adding support for a partial match on the floating ip so input==<exact_floating_ip> to input.like('%floating_ip_substring%') as you said above
23:22:35 hongbin yes, and also need a clear picture that how nova will use it
23:23:38 sean-k-mooney prosumably nova would call /v2.0/floatingips/?floatingip=<ip substing>&fields=device_id then do a a server list for each insance uuid returned.
23:24:10 sean-k-mooney but mriedem could comment on that better then i ^
23:25:10 mriedem i think i said that like an hour ago
23:25:18 mriedem "do the same thing as the ip filter but with a floating ip"
23:25:28 mriedem question was why does nova need to add this proxy filter support at all
23:27:52 sean-k-mooney i think when this came up in the ptg i liked the idea of the neutorn change but fealt the nova change did not need to be in the api and could be in the client
23:27:58 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.60 - volume multiattach https://review.openstack.org/536621
23:28:48 mriedem sean-k-mooney: this floating ip filtering thing didn't come up in denver
23:29:05 mriedem at least that i can recall - we talked about how to improve the performance of the *existing* ip filter when listing instances
23:29:18 mriedem and that's done: https://review.openstack.org/#/c/525505/
23:29:59 sean-k-mooney mriedem: are you sure im pretty sure i asked migle about adding the api change to neutron in dever
23:30:27 sean-k-mooney mriedem: oh maybe that is what im thinking about
23:31:06 sean-k-mooney mriedem: so this is the same just adding support for floating ip
23:31:53 mriedem sounds like it yes
23:34:19 mriedem melwitt: dansmith: so on https://review.openstack.org/#/c/536546/ we're just wanting to like change the name of an existing cell right?
23:34:44 dansmith mriedem: or puppet is just running update_cell all the time because that's how it works
23:35:09 dansmith s/all the/every/
23:35:30 dansmith like, there's probably a piece of puppet that says "ensure that cell0 has db url $foo and mq url $bar" and they just run update_cell blindly
23:35:32 melwitt mriedem: yeah, the update name would be one but the situation reported in the bug was that update_cell is not idempotent
23:36:26 mriedem alright
23:36:31 melwitt I think it would also fail if you wanted to change only one of DB connection or transport URL with update_cell
23:36:40 dansmith right
23:36:45 dansmith well,
23:36:58 dansmith no, I think it shouldn't because that wouldn't match one of the existing ones right?
23:37:17 melwitt it would match one of them with itself (before the fix) I think
23:37:34 dansmith oh you're right, it's an or
23:37:37 dansmith so yeah
23:38:04 openstackgerrit Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821
23:38:05 openstackgerrit Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260
23:38:05 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246
23:38:06 openstackgerrit Eric Fried proposed openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering https://review.openstack.org/536624
23:38:06 openstackgerrit Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517
23:38:07 openstackgerrit Eric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625
23:38:14 sean-k-mooney mriedem: this makes me sad https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_instance_pci_requests.py#L26-L53 device_id should be product_id according to https://github.com/openstack/nova/blob/master/doc/source/admin/pci-passthrough.rst and other tests
23:38:17 melwitt yeah. historically it was an 'and' but recently it was changed to an 'or' since global MQ can't be a thing anyway and each cell should have unique DB and transport URL combo
23:39:21 sean-k-mooney mriedem: unless wew chanded for device_id to product id a some point. those thest have been using incorrect mocks for 3 years
23:39:43 mriedem sean-k-mooney: that's a pci request, not a port
23:40:09 mriedem or you're just talking about something different and i have no idea
23:40:51 sean-k-mooney mriedem: sorry yes this was what i was working on before the floating ip conversation
23:41:27 melwitt (corrects self) er, or there shouldn't be two cells with dupe DB connection or dupe MQ URL
23:41:28 mriedem sean-k-mooney: well you'll be happy to know it's just a json blob of whackiness so it doesn't matter https://github.com/openstack/nova/blob/master/nova/objects/instance_pci_requests.py#L32
23:41:54 openstackgerrit Merged openstack/nova master: Generalize DB conf group copying https://review.openstack.org/484908
23:41:55 sean-k-mooney mriedem: thats what im changing at stephenfin request
23:42:17 openstackgerrit Merged openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642
23:42:32 sean-k-mooney mriedem: which is why my tests are failing because i dont allow device id since the spec says it product_id
23:43:08 mriedem ok
23:43:10 mriedem ...
23:43:53 sean-k-mooney mriedem: im reworking https://review.openstack.org/#/c/449257 with stephenfin comments since rodolfo had to move on to opnfv work
23:44:30 openstackgerrit melanie witt proposed openstack/nova master: Detach volume after deleting instance with no host https://review.openstack.org/340614
23:45:00 sean-k-mooney i think this is really just at test bug but it still hurts to look at the git blame. anyway i think ill get back to this in the morning since its almost midnight my time
23:57:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
#openstack-nova - 2018-01-23
00:07:38 mriedem i'm +2 on the OSC CLI change for show/set/delete allocations https://review.openstack.org/#/c/457534/ - i think that's a good one to get in before the final client release freeze this week (same day as FF)
00:08:12 mriedem best way to review these i've found is pull them down to your devstack and kick the tires
00:10:31 melwitt mriedem: is there something special that has to be done to use the osc-placement plugin with OSC? I tried to use it last week and failed to figure it out. there were no 'openstack placement' or 'openstack resource' commands available
00:10:54 mriedem melwitt: git clone the repo,
00:10:57 mriedem then pip install it
00:11:02 mriedem then just: openstack resource provider -?
00:11:05 mriedem for the list of commands
00:11:36 melwitt okay. in my devstack it was installed and I even tried pip removing and pip installing it again with no luck. I'll try it again
00:12:14 melwitt that is, the osc-placement package got installed by devstack by itself (I didn't do anything to install it manually)
00:12:20 mriedem hmm, did you have the latest version of the osc-placement repo?
00:12:25 mriedem oh...
00:12:33 melwitt no, it took whatever was on pypi
00:12:34 mriedem i always git clone it into /opt/stack/
00:12:41 melwitt good to know
00:12:45 mriedem the pypi version doesn't have any actual CLIs yet
00:12:55 melwitt oh, no wonder. hah
00:13:01 mriedem i'm waiting to get at least this last allocations one merged before we release for queens
00:14:13 mriedem ideally we could get to https://review.openstack.org/#/c/511182/ yet for queens
00:14:29 mriedem because not being able to work with resource classes in the CLI makes the other existing CLIs can't of hard
00:14:31 mriedem *kind of hard
00:14:58 melwitt ack
00:45:03 openstackgerrit Gao Fei proposed openstack/nova master: Redirects to a valid https link from the old one https://review.openstack.org/535244
01:54:37 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix 'all_tenants' & 'all_projects' type in api-ref https://review.openstack.org/522918
02:12:18 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505
02:15:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
02:19:33 Kevin_Zheng mriedem https://review.openstack.org/525505 <- rebased due to conflict in test_compute_api.py
02:24:52 openstackgerrit Merged openstack/osc-placement master: CLI for allocations https://review.openstack.org/457534
02:30:14 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix 'all_tenants' & 'all_projects' type in api-ref https://review.openstack.org/522918
02:32:37 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - List/Show all server migration types https://review.openstack.org/430839
02:59:52 openstackgerrit Merged openstack/nova master: Fix update_cell to ignore existing identical cells https://review.openstack.org/536546
03:00:01 openstackgerrit Merged openstack/nova master: Start moving users of parted to privsep. https://review.openstack.org/519011
03:59:03 openstackgerrit Merged openstack/nova master: Remove redundant swap_volume tests https://review.openstack.org/531179
05:19:13 takashin
05:52:53 fanzhang hi anyone here
05:56:33 fanzhang I hit a H202 error while running tox pep8 check, it's because my unit test using something like self.assertRaises(Exception,... I was wondering is H202 a mandatory rule or not? Please, if anyone knows about that, please do me a favor :)
06:02:51 jianghuaw fanzhang, it's mandatory I think. You should define a specific exception instead of using the general Exception.
06:03:44 fanzhang cool, thanks a lot. jianghuaw :)
06:03:54 jianghuaw np
06:30:51 Spazmotic You're actually here jianghuaw? :D Didn't think you hung out on IRC
06:31:08 Spazmotic I saw you put some XenAPI notes on the PTG, Did you plan on attending Dublin?
06:31:39 Spazmotic Hoping to get Corporate approval to attend, if so, would be nice to talk to another person interested in the XenAPI drivers
06:31:43 jianghuaw Spazmotic, yes. I'm planning to attend the PTG.
06:32:00 jianghuaw Spazmotic, thanks.
06:32:45 jianghuaw Spazmotic, hope I can see you in Dublin.
06:32:54 Spazmotic Well wonderful to meet you. If you ever want to talk i'm around this time of night. I remain on US Night shift / Seoul time :p
06:33:46 jianghuaw nice to know:-)
06:59:03 Spazmotic Some Tuesday morning KPOP before we start waking up and working on actual serious things. Enjoy your days friends, i'll be around. https://www.youtube.com/watch?v=Ri6wvGjuoOg

Earlier   Later