Earlier  
Posted Nick Remark
#openstack-nova - 2018-01-18
14:07:15 Spazmotic An issue we face a lot in Xen land with xen falling on its face and landing wrong on the curb and never getting back up heh
14:08:04 Spazmotic Will start reviewing the code when I wake up.. time for sleep, thanks for the idea, gentlemen :D
14:09:21 jaypipes Spazmotic: oh, trust me... you do use it. you just may not realize it :)
14:20:10 openstackgerrit Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371
14:21:41 Spazmotic Yeah I'm assuming that is where we are storing our allocation locking, just never thought about it before hehehehe
14:21:48 Spazmotic Excited to look at it.
14:24:59 jaypipes efried: keep bearing with me...
14:25:46 efried jaypipes Still working through my morning review mail.
14:25:54 jaypipes k
14:33:40 Spazmotic Stuck reading this provider code now rather than sleeping
14:33:41 Spazmotic Doomed
14:33:50 Spazmotic Pretty interesting and clean
14:34:31 efried Spazmotic Are you reading the database side?
14:34:38 Spazmotic API side currently
14:34:53 Spazmotic tracing down some calls to get to that point :D
14:35:23 efried Spazmotic If you're a sql wiz, we could sure use some help on that side of things.
14:35:40 efried If jaypipes gets hit by a bus... ahem, wins the lottery, we're effed.
14:35:59 Spazmotic I don't think i'm enough of a wiz to offer what you need..but some of these bugs I think I could at least learn and join the discussion.
14:36:07 efried excellent.
14:36:10 Spazmotic I'll need to take some time to see what all is there at least first
14:42:38 ameeda gmann: I replied to your comments
14:45:49 jaypipes efried: ok, phew.
14:46:03 jaypipes efried: done with reviews on the primary patches in that series.
14:46:16 jaypipes efried: gonna grab some food. back in 30-40 minutes
14:46:21 efried jaypipes Thanks
14:46:47 alex_xu jaypipes: efried after this series finish https://review.openstack.org/#/q/topic:bp/nested-resource-providers+(status:open+OR+status:merged), we still only support single request group, right? we still need some SQL to support multiple request groups?
14:46:59 jaypipes alex_xu: yes sir
14:48:04 efried alex_xu I'm not sure we'll need extra sql per se; I'm hoping to be able to mix and match the existing helper methods including the ones jaypipes is working on now.
14:48:15 alex_xu jaypipes: ok...so I guess granular request isn't target to this release?
14:48:22 jaypipes alex_xu: nope, it never was.
14:48:36 efried uh
14:48:39 efried Yes it was.
14:48:42 efried Approved blueprint.
14:48:53 efried All the foundational code is merged.
14:48:55 alex_xu jaypipes: ok...so we didn't have API patch to expose trait in this release...
14:49:11 jaypipes alex_xu: cdent has a patch proposed for that
14:49:17 jaypipes alex_xu: one sec, grabbing link
14:50:03 jaypipes alex_xu: https://review.openstack.org/#/c/534886/
14:50:06 efried The last pieces of granular enablement are here: https://review.openstack.org/#/c/517757/ (placement side); and https://review.openstack.org/#/c/515811/ (scheduler side)
14:50:29 efried With ^, cdent's patch won't be necessary.
14:50:33 jaypipes alex_xu: you want to take over cdent's patch?
14:50:59 alex_xu jaypipes: yea, if cdent is ok for that
14:51:09 efried Hello? Can you hear me?
14:51:15 jaypipes sorry efried
14:51:27 alex_xu efried: yea, I hear you, sorry about that :)
14:52:02 jaypipes ack, efried's patches are better/further along
14:52:30 efried alex_xu If you've got the bandwidth and inclination to help, I would much rather have you work on https://review.openstack.org/#/c/517757/
14:52:43 jaypipes efried: the issue is that we really want the traits handling to be done even if granular request groups isn't merged in queens
14:52:53 efried jaypipes Yeah, I get that.
14:53:10 efried It would just be a shame to duplicate the effort.
14:53:29 alex_xu efried: it is a little hard to finish that, i guess it still need some more magic sql
14:53:30 efried And the granular stuf is [ ] this close.
14:54:40 efried alex_xu It shouldn't. The idea there is to combine the existing helpers. We have one helper that targets an *individual* provider - that would be used for each granular request. Then we have another helper (the one jaypipes is working on) that targets trees - that would be used for the non-granular request.
14:55:08 efried alex_xu Then when we have the results from all of those, we just have to combine them in permutations such that each result uses the same non-sharing tree.
14:55:44 efried There may be a way to do it "more efficiently" with some magic sql, but we can optimize that laaaaater.
14:58:43 alex_xu efried: I can take a look at that, but we just left one week, I still thought it isn't easy thing
14:59:25 efried alex_xu Nothing is easy :)
15:17:02 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
15:17:04 sean-k-mooney spotz: did you get your question about booting a vm on a subnet answered
15:18:03 sean-k-mooney spotz: today you have to first create the neutron port on the subnet and then add --nic port-id=<uuid of port you created>
15:18:58 sean-k-mooney spotz: nova only supports creating porst for you automatically when specifying a network. anything more advanced and you have to bring your own ports
15:32:34 jaypipes efried: k, back from breakfasting.
15:32:53 efried jaypipes Okay, made it through your comments. Would like to refine on a couple of points before moving forward with deltas.
15:33:38 jaypipes efried: k. hangout?
15:33:48 efried okay.
15:35:38 efried jaypipes Are you setting that up or should I?
15:36:28 amorin hello everybody
15:36:44 amorin I'd like to cherry-pick this commit again:
15:36:46 amorin https://review.openstack.org/#/c/508640/
15:36:48 jaypipes efried: I will, just warming coffeee
15:36:50 amorin how can we reopen it?
15:37:56 efried amorin You should still be able to cherry-pick it even though it's abandoned, nah?
15:38:53 jaypipes efried: https://hangouts.google.com/call/Kkf0T_Tilgyrg2Hctaz8AAEE
15:39:12 amorin efried: both gerrit web interface and git review throw me this error:
15:39:19 amorin ! [remote rejected] HEAD -> refs/publish/stable/ocata/bug/1662626-cp-ocata (change https://review.openstack.org/508640 closed)
15:39:33 efried Okay, a core ought to be able to un-abandon it for you.
15:40:08 amorin efried: ok, who should I ask?
15:40:29 ildikov amorin: efried: this is the original commit: https://review.openstack.org/#/c/430400/
15:41:25 amorin true
15:41:30 ildikov amorin: efried: that should be ok for cherry-picking
15:41:36 amorin ildikov: this is the one I am trying to cherry-pick
15:41:48 amorin Cannot create new patch set of change 508640 because it is abandoned
15:41:51 openstackgerrit Merged openstack/nova master: placement: _get_trees_matching_all_resources() https://review.openstack.org/531512
15:42:01 openstackgerrit Merged openstack/nova master: Fix openstackdocstheme options for api-ref https://review.openstack.org/534712
15:42:02 amorin from web page
15:42:10 ildikov amorin: what I've just linked in that's merged
15:42:33 ildikov amorin: Change 430400
15:43:12 ildikov amorin: you're trying with an already cherry-picked patch which landed on Ocata and got abandoned after Matt's comment that it should've been backported to Pike first
15:43:27 amorin yup
15:43:36 amorin but it's already in pike actually
15:43:52 amorin I think it was merged while pike was the master branch
15:44:52 ildikov I didn't check that
15:45:10 ildikov are you trying to get it landed on Ocata?
15:45:22 gibi amorin, ildikov: yeah it seems that it is in stable/pike according to gerrit
15:45:22 amorin yes, both Ocata and newton if possible
15:45:37 amorin reopen this https://review.openstack.org/#/c/508640/
15:45:37 ildikov gibi: yeah, I've just checked
15:45:42 amorin and this
15:45:44 amorin https://review.openstack.org/#/c/508641/
15:45:58 ildikov amorin: I think Newton is EOL now, but gibi should be smarter

Earlier   Later