Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-01-16
16:01:36 jaypipes gibi: oh hell no, I love it.
16:01:55 jaypipes gibi: much rather find it now than in production!
16:03:32 gibi jaypipes: yeah, totally agree
16:14:17 jaypipes efried: ah, cool, didn't catch there was an _allocate_from_provider helper
16:14:53 efried Mr. Makestuffeasytoread, that's me.
16:15:08 gibi efried: I'm +2 on network part of the PowerVM driver but the rest needs an other day
16:15:28 efried gibi Thank you very much for the review! esberglu ^^
16:16:02 esberglu gibi: Thanks!
16:20:53 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix accumulated nits https://review.openstack.org/534368
16:20:53 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544
16:21:05 edmondsw gibi thanks! the SEA patch is also networking, so it should be easier having built off the ovs patch. When you can get to it :)
16:21:08 stephenfin mriedem, melwitt: Cleanups from the websocket-proxy-to-host-security series ^^^
16:25:42 openstackgerrit Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371
16:30:05 stephenfin sean-k-mooney: Hurrah! ^
16:30:09 stephenfin jaypipes too ^
16:30:18 sean-k-mooney oh cool
16:31:19 melwitt stephenfin: ack
16:33:36 stephenfin melwitt: Might be interested in this, from waaaaay back :) https://github.com/tox-dev/tox/issues/744
16:33:59 melwitt hah, I remember that!
16:41:09 openstackgerrit Mark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532287
16:41:09 openstackgerrit Mark Goddard proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116
16:41:10 openstackgerrit Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288
16:41:10 openstackgerrit Mark Goddard proposed openstack/nova master: Call get_traits() in the resource tracker https://review.openstack.org/532290
16:41:11 openstackgerrit Mark Goddard proposed openstack/nova master: DNM Remove generation from set_traits_for_provider https://review.openstack.org/534375
16:44:48 bauzas just in case people want some karma and have some review cycles, need a +W https://review.openstack.org/#/c/528832/
16:52:13 openstackgerrit Chris Dent proposed openstack/nova master: [placement] use simple FaultWrapper https://review.openstack.org/533752
16:52:14 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797
16:52:45 openstackgerrit Merged openstack/nova master: Increase notification wait timeout in functional tests https://review.openstack.org/532816
17:01:54 openstackgerrit Jacek Tomasiak proposed openstack/python-novaclient master: Fix listing of instances above API max_limit https://review.openstack.org/534222
17:04:39 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383
17:04:39 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Cleanup tox.ini https://review.openstack.org/534382
17:05:02 stephenfin cdent: Might be interested in ^
17:05:34 cdent I get excited whenever I see the word "Cleanup"
17:08:40 edleafe cdent: Cleanup in aisle 5!
17:09:40 openstackgerrit sean mooney proposed openstack/os-vif master: adds iptools driver for ip commands https://review.openstack.org/534307
17:10:46 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384
17:10:53 sean-k-mooney stephenfin: ^ this should work i think. i just finished the fuctional tests and pep8
17:16:12 lyarwood melwitt: any objections to a plain recheck on https://review.openstack.org/#/c/531407/ given the failure looks unrelated? http://logs.openstack.org/07/531407/3/gate/legacy-tempest-dsvm-cells/4480311/job-output.txt.gz#_2018-01-16_04_53_50_389275
17:17:07 melwitt lyarwood: yeah that's fine
17:18:48 jaypipes stephenfin: questions for you on that VNC security doc patch...
17:18:53 stephenfin hit me
17:19:03 jaypipes stephenfin: no, I left them in th ereview :)
17:19:23 stephenfin Ah, gotcha :) Finishing review of efried's OVS patch, but I'll tackle after that
17:19:37 stephenfin By which I mean, I'll go ask danpb what he meant
17:28:00 stephenfin efried: This taskflow integration is pretty neat...
17:28:29 efried stephenfin Thanks, yeah, it's been super useful for rollbacks and batching transactions.
17:28:40 efried thorst gets most of the credit for that work
17:29:03 efried or possibly kylekh
17:31:37 mdbooth lyarwood: If you're still around... I'm not 100% sure of this yet but sharing anyway.
17:32:00 lyarwood mdbooth: still here
17:32:06 mdbooth If we live migrate from a host without native luks to a host with native luks
17:32:21 stephenfin efried: A'ight, two small questions left
17:32:26 efried esberglu ^
17:32:31 stephenfin Other than that, it _looks_ fine. I can't test it though, obv
17:32:41 stephenfin Relying on the third-party CI to do that
17:32:42 mdbooth I think that on the destination we will not have disk/encryptor
17:32:42 efried stephenfin That's okay, our CI does.
17:32:43 efried yup
17:32:47 stephenfin Spot on
17:32:49 mdbooth But we *will* have the secret
17:32:55 stephenfin Just those two so and I'm good
17:33:07 efried stephenfin We can sell you a POWER9 system to test on.
17:33:24 lyarwood mdbooth: I think nova/virt/libvirt/migration.py would take care of that with the XML update
17:33:37 mdbooth Looking
17:33:38 lyarwood mdbooth: we get_volume_config on the dest and then update the volume XML with anything new
17:34:12 lyarwood mdbooth: I had to look into that for the native to native case
17:34:27 lyarwood mdbooth: didn't think of the encryptor to native case but that *should* work
17:34:33 mdbooth Reading... thanks.
17:38:03 openstackgerrit Merged openstack/nova master: conf: Do not inherit image signature props with snapshots https://review.openstack.org/527046
17:39:26 BKaminski Time for my third shift self to head to sleep. If anyone who is familiar with the XenAPI drivers get a chance, would love if you could take a look at my small commit :) https://review.openstack.org/#/c/533168/ Have a great day evreyone.
17:40:28 mdbooth lyarwood: Time for another sanity check: I think that might not work, because get_updated_guest_xml() runs on the source, not the dest.
17:40:57 lyarwood mdbooth: odd, that wouldn't make sense
17:41:11 lyarwood mdbooth: well, to me at least :)
17:41:24 lyarwood mdbooth: I assumed it wanted the updated volume XML from the dest POV
17:41:24 mdbooth It's used to generate the destination xml to pass to the destination in initiating the migration
17:41:57 mdbooth It runs from _live_migration_operation, which I'm pretty sure is on the source
17:42:44 mdbooth But we do call _connect_volume() on the destination
17:42:58 mdbooth in pre_live_migration
17:44:14 lyarwood right but the volume secret lookup would return the src hosts secret UUID
17:44:17 mdbooth And use_native_luks will be true on the destination, so we'll create the host secret
17:44:45 lyarwood that's pretty useless, updating instance XML using the src host
17:44:57 mdbooth No, it's the other way round
17:45:13 mdbooth When we call _attach_encryptor during pre_live_migration on the destination
17:45:27 mdbooth We will create the host secret on the destination
17:46:15 mdbooth Also... we won't actually attach the encryptor
17:46:25 lyarwood right, but _get_volume_config is being called on the src, that does the secret lookup
17:46:39 mdbooth No it doesn't, because the source hasn't been upgraded
17:47:11 lyarwood ah right, in that old to native use case, you're correct
17:47:12 mdbooth I think we're uncovering a design defect in live migration here, tbh
17:47:22 mdbooth But it is what it is
17:47:50 openstackgerrit Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564
17:47:50 openstackgerrit Eric Fried proposed openstack/nova master: ProviderTree.snapshot => ProviderSnapshot https://review.openstack.org/533244
17:47:51 openstackgerrit Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540
17:47:51 openstackgerrit Eric Fried proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539
17:47:52 openstackgerrit Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541
17:47:52 openstackgerrit Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756
17:47:53 openstackgerrit Eric Fried proposed openstack/nova master: SchedulerReportClient.get_provider_tree https://review.openstack.org/521098
17:47:53 openstackgerrit Eric Fried proposed openstack/nova master: SchedulerReportClient.set_aggregates_for_provider https://review.openstack.org/533808
17:47:54 openstackgerrit Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821
17:47:54 openstackgerrit Eric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187

Earlier   Later