| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-16 | |||
| 14:49:18 | openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/534335 | |
| 14:51:02 | damini | Hi while installing newton in devstack enviournment i am getting error of | |
| 14:51:05 | damini | Command "/usr/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-EW0AN9/PyECLib/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-iZslP6-record/install-record.txt --single-version-externally-managed --compile" failed with error code 255 in /tmp/pip-build-EW0AN9/PyECLib/ | |
| 14:51:37 | damini | Can anyone tell me what the problem is ..i am new to this | |
| 14:52:11 | openstackgerrit | Merged openstack/os-vif master: Revert "Move 'ips' field from Subnet object to VIF object" https://review.openstack.org/534206 | |
| 14:52:31 | zioproto | sdague: taking a random line of the file, it looks like this https://pastebin.com/CcQ0bwi8 | |
| 14:52:37 | zioproto | sdague: this is from nova-api | |
| 14:59:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 14:59:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | |
| 15:00:45 | sdague | zioproto: what version? | |
| 15:01:35 | sdague | because I don't see how that could come from current code, there should be a context key | |
| 15:01:42 | sdague | even if it's an empty array | |
| 15:02:09 | sdague | https://github.com/openstack/oslo.log/blob/e29dc73e9eaf009e7fccd17dcb96abdaf787efe7/oslo_log/formatters.py#L246-L251 | |
| 15:11:55 | openstackgerrit | Jay Pipes proposed openstack/nova master: func tests for nested providers in alloc candidate https://review.openstack.org/531443 | |
| 15:11:56 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: _get_trees_matching_all() https://review.openstack.org/531512 | |
| 15:11:56 | openstackgerrit | Jay Pipes proposed openstack/nova master: add _has_provider_trees() utility function https://review.openstack.org/531474 | |
| 15:11:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: add test for scenario with sum of child resources https://review.openstack.org/534339 | |
| 15:11:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: add tests for _get_trees_matching_all() with trait https://review.openstack.org/531899 | |
| 15:12:56 | jaypipes | gibi, efried, edleafe, cdent: ready for your signoff on ^^. gibi, the last patch contains the additional test case you'd asked for (which exposed buggy behaviour, btw) | |
| 15:13:16 | efried | ack | |
| 15:13:34 | edleafe | jaypipes: in meeting hell this morning. Will check it out later | |
| 15:13:41 | jaypipes | edleafe: np | |
| 15:26:39 | lyarwood | mdbooth: https://review.openstack.org/#/c/523958/ - do you have time to go over the LUKS change again, I've had to introduce the _format logic again for block device volumes for now | |
| 15:27:06 | mdbooth | lyarwood: Yep. Looking now. | |
| 15:28:05 | gibi | jaypipes: the whole series looks good to me. Thanks for the extra test case | |
| 15:30:20 | mdbooth | lyarwood: How does that work for rbd volumes? | |
| 15:31:29 | lyarwood | mdbooth: with just this patch it doesn't, still waiting on a c-vol patch that formats and empty rbd volume with LUKS based on my image to volume example - https://review.openstack.org/#/c/527979/ | |
| 15:31:40 | lyarwood | an* | |
| 15:32:18 | mdbooth | lyarwood: Why are we only expecting c-vol to format rbd volumes, not all of them? | |
| 15:33:19 | lyarwood | mdbooth: it's a different flow, you can format anything providing a local block device easily | |
| 15:33:29 | lyarwood | mdbooth: with rbd at the moment you need to recreate the device | |
| 15:33:47 | lyarwood | mdbooth: image even | |
| 15:33:58 | mdbooth | lyarwood: Right, from Nova's side. But why would we expect different contracts from different volume types provided by c-vol? | |
| 15:34:35 | mdbooth | lyarwood: I mean, if we're waiting for c-vol to do rbd, why not just wait for all volume types? | |
| 15:35:09 | lyarwood | mdbooth: if this was earlier in the cycle sure but with limited time before M3 I assume we would only have time to get the rbd flow in | |
| 15:35:29 | lyarwood | mdbooth: and then follow up with others in R, removing this call to format volumes then | |
| 15:35:45 | lyarwood | mdbooth: as it wouldn't run anyway if the volumes already contained a LUKS header | |
| 15:46:28 | mdbooth | lyarwood: What's the thinking behind the volume_use_native_luks tunable? Why would you turn that off? | |
| 15:48:27 | lyarwood | mdbooth: TBH that's only there to allow easier upgrade testing without needing to jump between releases downstream | |
| 15:49:28 | lyarwood | mdbooth: moving it to False once encrypted volumes are attached would cause failures, maybe it's best to drop it? | |
| 15:49:36 | mdbooth | lyarwood: Gotcha. That's really useful info. Where can we stash that such that future generations will find it? | |
| 15:50:45 | mdbooth | I mean, ideally we'd drop an unnecessary tunable. Is there any other way to do this for upgrades testing? | |
| 15:51:59 | jaypipes | gibi: thanks for asking for that test case! it highlighted a breakdown of the method in question :) | |
| 15:52:16 | mdbooth | lyarwood: Thinking about upgrades... do we support upgrading nova-compute without rebooting the host? | |
| 15:52:26 | jaypipes | gibi: you're so good at highlighting cracks in my code :) and alex_xu too. he's very good at that. | |
| 15:52:27 | lyarwood | mdbooth: during an actual upgrade in grenade upstream or tripleo-ci downstream | |
| 15:52:30 | lyarwood | mdbooth: yeah | |
| 15:53:06 | mdbooth | ... I think that's ok. We might leave orphaned encryptors, though. | |
| 15:53:26 | mdbooth | But that might prevent disconnect_volume? | |
| 15:53:35 | lyarwood | mdbooth: how so? | |
| 15:53:50 | lyarwood | mdbooth: the current logic will still try to detach an encryptor if a secret isn't found for the volume | |
| 15:54:10 | lyarwood | mdbooth: and a secret is only created when connecting the volume | |
| 15:54:16 | mdbooth | ... and host secret is only added during connect | |
| 15:54:23 | mdbooth | Nice | |
| 15:56:00 | mdbooth | lyarwood: Just thinking about grenade, when would we set that to false even during testing? | |
| 15:56:30 | mdbooth | Surely the only interesting upgrade is across the no-native to native boundary | |
| 15:56:53 | mdbooth | And libvirt/qemu version before is irrelevant, as we always used cryptsetup | |
| 15:56:57 | lyarwood | mdbooth: yeah you wouldn't set it to false | |
| 15:57:32 | mdbooth | Ok. Assume it's no big deal to remove the config option? | |
| 15:57:54 | lyarwood | mdbooth: not at all | |
| 15:58:13 | lyarwood | mdbooth: feel free to -1 on that and I'll respin shortly, about to jump on yet another call | |
| 16:01:23 | gibi | jaypipes: I like this community. People here does not get offended when I find a crack in a proposed patch | |
| 16:01:36 | jaypipes | gibi: oh hell no, I love it. | |
| 16:01:55 | jaypipes | gibi: much rather find it now than in production! | |
| 16:03:32 | gibi | jaypipes: yeah, totally agree | |
| 16:14:17 | jaypipes | efried: ah, cool, didn't catch there was an _allocate_from_provider helper | |
| 16:14:53 | efried | Mr. Makestuffeasytoread, that's me. | |
| 16:15:08 | gibi | efried: I'm +2 on network part of the PowerVM driver but the rest needs an other day | |
| 16:15:28 | efried | gibi Thank you very much for the review! esberglu ^^ | |
| 16:16:02 | esberglu | gibi: Thanks! | |
| 16:20:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix accumulated nits https://review.openstack.org/534368 | |
| 16:20:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | |
| 16:21:05 | edmondsw | gibi thanks! the SEA patch is also networking, so it should be easier having built off the ovs patch. When you can get to it :) | |
| 16:21:08 | stephenfin | mriedem, melwitt: Cleanups from the websocket-proxy-to-host-security series ^^^ | |
| 16:25:42 | openstackgerrit | Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371 | |
| 16:30:05 | stephenfin | sean-k-mooney: Hurrah! ^ | |
| 16:30:09 | stephenfin | jaypipes too ^ | |
| 16:30:18 | sean-k-mooney | oh cool | |
| 16:31:19 | melwitt | stephenfin: ack | |
| 16:33:36 | stephenfin | melwitt: Might be interested in this, from waaaaay back :) https://github.com/tox-dev/tox/issues/744 | |
| 16:33:59 | melwitt | hah, I remember that! | |
| 16:41:09 | openstackgerrit | Mark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532287 | |
| 16:41:09 | openstackgerrit | Mark Goddard proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116 | |
| 16:41:10 | openstackgerrit | Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | |
| 16:41:10 | openstackgerrit | Mark Goddard proposed openstack/nova master: Call get_traits() in the resource tracker https://review.openstack.org/532290 | |
| 16:41:11 | openstackgerrit | Mark Goddard proposed openstack/nova master: DNM Remove generation from set_traits_for_provider https://review.openstack.org/534375 | |
| 16:44:48 | bauzas | just in case people want some karma and have some review cycles, need a +W https://review.openstack.org/#/c/528832/ | |
| 16:52:13 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] use simple FaultWrapper https://review.openstack.org/533752 | |
| 16:52:14 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 16:52:45 | openstackgerrit | Merged openstack/nova master: Increase notification wait timeout in functional tests https://review.openstack.org/532816 | |
| 17:01:54 | openstackgerrit | Jacek Tomasiak proposed openstack/python-novaclient master: Fix listing of instances above API max_limit https://review.openstack.org/534222 | |
| 17:04:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | |
| 17:04:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Cleanup tox.ini https://review.openstack.org/534382 | |
| 17:05:02 | stephenfin | cdent: Might be interested in ^ | |
| 17:05:34 | cdent | I get excited whenever I see the word "Cleanup" | |
| 17:08:40 | edleafe | cdent: Cleanup in aisle 5! | |
| 17:09:40 | openstackgerrit | sean mooney proposed openstack/os-vif master: adds iptools driver for ip commands https://review.openstack.org/534307 | |
| 17:10:46 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | |
| 17:10:53 | sean-k-mooney | stephenfin: ^ this should work i think. i just finished the fuctional tests and pep8 | |
| 17:16:12 | lyarwood | melwitt: any objections to a plain recheck on https://review.openstack.org/#/c/531407/ given the failure looks unrelated? http://logs.openstack.org/07/531407/3/gate/legacy-tempest-dsvm-cells/4480311/job-output.txt.gz#_2018-01-16_04_53_50_389275 | |