| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-15 | |||
| 19:31:07 | prometheanfire | cool | |
| 19:32:38 | sean-k-mooney | prometheanfire: the issue was only in the unit tests. really execution paths would have worked so this is just a minor change. | |
| 19:39:01 | edleafe | golang flag parse | |
| 19:39:17 | edleafe | wrong channel? | |
| 19:49:28 | cdent | no edleafe, we've started, nova is going go | |
| 19:53:33 | sean-k-mooney | cdent: is that toung and cheek or have we decided nova is not hipster enought lol | |
| 19:54:03 | cdent | if we wanted to be hipster, go is surely too mainstream | |
| 19:54:29 | edleafe | nova is hipster only ironically | |
| 19:55:21 | sean-k-mooney | cdent: but the alternitive would be rust and that too painful | |
| 19:55:48 | edleafe | Ironic should be written in rust | |
| 19:56:02 | cdent | of course | |
| 19:56:22 | sean-k-mooney | edleafe: are you a parent because that right there is a dad joke | |
| 19:56:48 | edleafe | oh, I could dad-joke you to death | |
| 20:16:07 | jaypipes | edleafe: is it wrong that I dad-joke but have no children (that I know of) | |
| 20:17:45 | edleafe | jaypipes: without kids it | |
| 20:17:52 | edleafe | it's just bad-joke | |
| 20:17:54 | cdent | jaypipes: your brother is your twin, yeah? maybe that's it? | |
| 20:25:37 | jaypipes | cdent: yes. yes, that's it. I'll blame him. | |
| 20:26:11 | cdent | always happy so sow brotherly discord | |
| 20:27:08 | openstackgerrit | Matthew Edmonds proposed openstack/nova master: Add taskflow to requirements https://review.openstack.org/533779 | |
| 20:58:27 | openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | |
| 21:10:50 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 21:11:11 | cdent | efried, edleafe, jaypipes: you might find that ^ interesting. Not done yet, but a potentially useful tidy up | |
| 21:11:15 | cdent | will get back to it tomorrow | |
| 21:13:09 | jaypipes | bauzas: https://review.openstack.org/#/c/528832/9/nova/virt/libvirt/config.py :) | |
| 21:13:22 | jaypipes | cdent: ack | |
| 21:13:42 | jaypipes | bauzas: maybe 10th time is the charm? ;P | |
| 21:15:35 | jaypipes | ok, now on to efried' | |
| 21:15:38 | jaypipes | s series :) | |
| 21:20:36 | bauzas | jaypipes: oh fuuuuuuu | |
| 21:20:53 | bauzas | childs is because I stupidly copied some other patch :p | |
| 21:21:03 | bauzas | I have two children | |
| 21:21:06 | bauzas | so I know that :p | |
| 21:22:02 | jaypipes | bauzas: :) | |
| 21:24:50 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | |
| 21:24:50 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | |
| 21:24:57 | bauzas | hop là | |
| 21:25:54 | bauzas | dansmith: just in case you're still around, I'm thinking about hard reboot | |
| 21:26:28 | bauzas | dansmith: I could just ask for the existing mdev before destroying the guest, and then pass it back to _get_guest_xml() like I said | |
| 21:27:45 | bauzas | dansmith: but then, that means that for example, if we have a lot of months in between stopping the instance and restarting it, then we won't verify if that's still okay | |
| 21:28:04 | bauzas | the reason actually why we try to retry the xml | |
| 21:28:14 | bauzas | and not just reusing it | |
| 21:28:31 | bauzas | if we agree with that, fine | |
| 21:28:41 | bauzas | if we don't want that, then we would need to pass again the allocation | |
| 21:28:46 | bauzas | thoughts ? | |
| 21:29:10 | sean-k-mooney | jaypipes: bauzas melwitt dansmith when ye get a chance can ye take a look at https://review.openstack.org/#/c/533766/ to unblock https://review.openstack.org/#/c/532987/ | |
| 21:29:54 | bauzas | sean-k-mooney: easy +2 | |
| 21:30:18 | bauzas | oh wait | |
| 21:30:36 | bauzas | sean-k-mooney: what is the min os-vif version for Nova ? | |
| 21:30:59 | sean-k-mooney | currently 1.6 i think let me check | |
| 21:31:45 | sean-k-mooney | 1.7.0 | |
| 21:34:05 | bauzas | sean-k-mooney: -1 because https://github.com/openstack/os-vif/blob/1.7.0/os_vif/objects/vif.py | |
| 21:34:26 | jaypipes | why do we have open-ended dependencies like >=1.7.0 again? :( | |
| 21:35:08 | sean-k-mooney | well we have a catch 22 then | |
| 21:35:22 | sean-k-mooney | the change that increases the upper constriants need this change | |
| 21:36:08 | sean-k-mooney | jaypipes: they are closed by upper-constratints | |
| 21:36:29 | bauzas | sean-k-mooney: before merging the nova change, we should IMHO first bump the min version | |
| 21:36:50 | bauzas | sean-k-mooney: is g-r accepting >= 1.8.0 ? | |
| 21:36:59 | bauzas | if so, just change directly nova requirements.txt | |
| 21:37:04 | bauzas | in the same change | |
| 21:37:14 | bauzas | if not, you need first to modify g-r | |
| 21:37:51 | sean-k-mooney | bauzas: no g-r is os-vif>=1.7.0 u-c is os-vif===1.7.0 | |
| 21:38:23 | sean-k-mooney | we cant increase g-r without first increaseing u-c and u-c need that patch | |
| 21:42:52 | bauzas | sean-k-mooney: mmm, looks like a Depends-On change then | |
| 21:43:26 | sean-k-mooney | the depends-on is currently from https://review.openstack.org/#/c/532987/ to https://review.openstack.org/#/c/533766/2 | |
| 21:43:27 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Consider hostdev devices when building metadata https://review.openstack.org/533805 | |
| 21:43:27 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Refactor _build_device_metadata https://review.openstack.org/533804 | |
| 21:43:35 | bauzas | sean-k-mooney: I guess the gate is not accepting to upgrade upper-constraints because it tests nova ? | |
| 21:43:46 | sean-k-mooney | yep | |
| 21:43:48 | bauzas | shit | |
| 21:44:11 | sean-k-mooney | we could pin os-vif in nova then increase the upperconstraints then fix the test and bump minium | |
| 21:44:26 | sean-k-mooney | and unpin | |
| 21:45:15 | bauzas | sean-k-mooney: I think we can possibly ask nova to bump os-vif to 1.8.0 and in the meantime have the g-r change that bumps both global-reqs.txt and upper-constraints.txt | |
| 21:45:37 | bauzas | since there will be a depends-on, that should gate correctly | |
| 21:46:03 | bauzas | but I'm not a requirements expert | |
| 21:46:05 | bauzas | tonyb: around ? | |
| 21:46:30 | bauzas | tonyb: questions for a requirements upgrade loop | |
| 21:46:49 | sean-k-mooney | the change that fixes the tests for 1.8 also works on 1.7 because of weird ness with ovo hence why the patch is currently passing zuul without using os-vif 1.8.0 | |
| 21:48:42 | bauzas | sean-k-mooney: no I think the nova change uses 1.8.0 | |
| 21:48:57 | sean-k-mooney | basically https://github.com/openstack/nova/blob/6a5673a16f8329007880b67a6dbecbe62ac368d7/nova/tests/unit/network/test_os_vif_util.py#L34-L38 means that the extra datapath_type field is discarded | |
| 21:48:57 | bauzas | sean-k-mooney: because pypi will give you the last version | |
| 21:49:11 | sean-k-mooney | bauzas: no i checked locally it was using 1.7.0 | |
| 21:49:25 | sean-k-mooney | let me check the test logs | |
| 21:50:05 | bauzas | oh fun, you're right http://logs.openstack.org/66/533766/2/check/openstack-tox-py27/45f0378/job-output.txt.gz#_2018-01-15_20_03_47_088918 | |
| 21:51:00 | sean-k-mooney | yep so normally this would be a pain in the ass and we would have to bump the minium but in this case we dont | |
| 21:51:35 | bauzas | :/ | |
| 21:51:48 | bauzas | wait | |
| 21:52:20 | bauzas | that works because it's using o.vo so maybe it's just downgrading the version | |
| 21:52:28 | bauzas | I mean the object version | |
| 21:52:38 | bauzas | hence why it works | |
| 21:53:38 | sean-k-mooney | well im adding a new filed to the expected value so use if it downgraded it would discard it but os-vif 1.7.0 does not have explcit down grade logic for 1.8.0 objects | |
| 21:54:49 | sean-k-mooney | bauzas: basically it works because of this https://github.com/openstack/oslo.versionedobjects/blob/1.18.0/oslo_versionedobjects/base.py#L514-L520 | |
| 21:55:52 | sean-k-mooney | obj_to_primitive loops over the ovo fields and uses that to generate the dictionary retrunt by obj_to_primitive | |
| 21:56:02 | bauzas | sean-k-mooney: right, it works thanks of the ovo framework, that's it | |
| 21:56:07 | bauzas | soooooo... | |
| 21:56:10 | sean-k-mooney | since datapath_type is not in the 1.7.0 field list it just gets discared | |
| 21:56:13 | bauzas | what to do ? | |
| 21:56:17 | bauzas | I think I'll +2 | |
| 21:56:26 | bauzas | it's harmless | |
| 21:56:40 | bauzas | and unblocks things | |