| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-15 | |||
| 13:43:45 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | |
| 13:43:54 | bauzas | AFAIK, mriedem is not around today, right? | |
| 13:43:58 | mdbooth | lyarwood: Ok, thanks. | |
| 13:48:52 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | |
| 13:49:35 | cdent | edleafe, efried: can I assume we are having the usual scheduler meeting? | |
| 13:50:18 | jaypipes | cdent: yes, but edleafe is commuting. | |
| 13:50:29 | jaypipes | cdent: unless he's off for MLK day? | |
| 13:50:32 | jaypipes | not sure.. | |
| 13:51:25 | efried | IBM doesn't have MLK as a site holiday. But edleafe asked me to run it, so either he's off anyway, or he's commuting. | |
| 13:56:10 | efried | cdent You didn't find the first paragraph of the commit message adequately explanatory? https://review.openstack.org/#/c/533244/ | |
| 13:56:39 | cdent | efried: imagine you didn't know what a _Provider is? | |
| 13:56:50 | cdent | That's what I mean by "in isolation" | |
| 13:57:29 | efried | okay. | |
| 13:58:08 | cdent | efried: I know it is tedious, and I know I dont do that to everyone, but a) I should, b) I feel like you'll take it in good intent intended | |
| 13:58:42 | cdent | (also I didn't -1 it, just commented) | |
| 13:59:22 | efried | cdent I'm planning to slot this change into the existing series, so that would give it some context. But I'll add some words. | |
| 13:59:48 | efried | Scheduler meeting NOW in #openstack-meeting-alt | |
| 13:59:49 | Spazmotic | johnthetubaguy I was going to hit you up about a commit the other day but realized I no longer work with you.. too sad. | |
| 14:00:12 | cdent | efried: imagine yourself in the shoes of a drunk, stupid, tired, angry git bisector | |
| 14:00:21 | Spazmotic | I made a commit with some code against the resize_up xenapi stuff if you want to take a look, you're probably one of the best to review it and offer me some suggestions if you find the chance :) https://review.openstack.org/#/c/533168/ | |
| 14:00:36 | Spazmotic | back after a while, stupid.. house.. not self cleaning.. | |
| 14:05:01 | openstackgerrit | Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type https://review.openstack.org/526900 | |
| 14:06:45 | ameeda | alex_xu: are you around ? | |
| 14:10:05 | openstackgerrit | Merged openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | |
| 14:10:14 | ameeda | gmann: Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type https://review.openstack.org/526900 | |
| 14:10:40 | ameeda | gmann: can you please review the code ? | |
| 14:15:20 | openstackgerrit | Merged openstack/nova master: console: Provide an RFB security proxy implementation https://review.openstack.org/345399 | |
| 14:15:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 14:16:54 | stephenfin | #success After 3 years and 7 (?) releases, encryption between nova's consoleproxy service and compute nodes is finally possible ✌️ | |
| 14:16:56 | openstackstatus | stephenfin: Added success to Success page | |
| 14:17:10 | cdent | stephenfin: | |
| 14:17:13 | cdent | ++ | |
| 14:19:45 | ameeda | stephenfin: Congratulations | |
| 14:28:23 | jaypipes | it's breakfast time. | |
| 14:31:46 | gibi | stephenfin: nice! | |
| 14:33:42 | ildikov | stephenfin: yaaay! nice job! congrats! :) | |
| 14:34:09 | stephenfin | jaypipes: I'll have you know it's basically supper time, actually ;) | |
| 14:34:41 | stephenfin | johnthetubaguy: You're hardly about, are you? | |
| 14:40:00 | openstackgerrit | Eric Fried proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | |
| 14:40:52 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | |
| 14:44:19 | openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.59 - Add trusted_image_certificates https://review.openstack.org/500396 | |
| 14:48:19 | openstackgerrit | Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type https://review.openstack.org/526900 | |
| 14:54:32 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary execute permissions in files https://review.openstack.org/533686 | |
| 15:10:10 | bauzas | dansmith: mdbooth: FYI, just posted a new revision for the VGPU series starting with https://review.openstack.org/#/c/528832/8 that now lookups existing instances when restarting nova-compute | |
| 15:10:38 | bauzas | dansmith: mdbooth: that said, I still need to work around the XML removal when rebooting/restarting/etc. | |
| 15:11:11 | bauzas | wondering if that could be a follow-up patch | |
| 15:11:49 | dansmith | bauzas: yeah I think we just can't merge the first one until that follow-up is ready behind it | |
| 15:12:04 | bauzas | k | |
| 15:12:59 | mdbooth | bauzas: What dansmith said. | |
| 15:19:13 | openstackgerrit | Carlos Goncalves proposed openstack/os-vif master: Git ignore .stestr https://review.openstack.org/533699 | |
| 15:49:03 | lyarwood | stephenfin: https://review.openstack.org/#/c/527046/ - any chance of a +W? Had to rebase over the weekend. | |
| 15:50:55 | dansmith | bauzas: that recreate on boot patch is nice.. and pretty simple.. too simple not to do :) | |
| 15:51:18 | bauzas | dansmith: I'll need to fully rewrite the bottom change | |
| 15:51:38 | stephenfin | lyarwood: Sure, done | |
| 15:51:48 | dansmith | bauzas: because why? | |
| 15:52:07 | bauzas | dansmith: given I'm changing all the interfaces by not passing the allocations to _get_guest_xml() but rather asks to allocate a mdev for spawn() and passing it to _get_guest_xml() | |
| 15:52:14 | dansmith | bauzas: ah okay | |
| 15:52:23 | lyarwood | stephenfin: thanks | |
| 15:52:29 | openstackgerrit | Carlos Goncalves proposed openstack/os-vif master: WIP: vif_plug_ovs: add should_provide_port https://review.openstack.org/533713 | |
| 15:52:34 | bauzas | dansmith: so for hard_reboot(), I'll instead ask for the current mdev for passing it to _get_guest_xml() | |
| 15:53:15 | dansmith | bauzas: aye | |
| 15:58:11 | edleafe | efried: thanks for that huge fix on https://review.openstack.org/#/c/526436/ :) | |
| 15:58:42 | efried | It was an enormous sacrifice of time and mental anguish, but you're worth it edleafe | |
| 15:58:57 | edleafe | Your suffering has not gone unnoticed | |
| 15:59:11 | efried | edleafe Caught up on sched meeting yet? | |
| 15:59:36 | edleafe | no, just poured me a cup of coffee and was getting ready to read back | |
| 16:00:14 | efried | ight. There was some question of how you felt about ProviderTree.snapshot (formerly known as ReadOnlyProvider) | |
| 16:01:11 | bauzas | jaypipes: I think we already discussed about that previously, but someone pinged me about reviewing https://review.openstack.org/#/c/526900/19/nova/db/sqlalchemy/models.py | |
| 16:01:18 | bauzas | jaypipes: would it be a performance issue ? | |
| 16:01:30 | jaypipes | bauzas: no | |
| 16:02:01 | jaypipes | bauzas: shouldn't be a performance issue at all. | |
| 16:02:04 | bauzas | ok, I remembered your point, but I wasn't sure it was for VARCHAR(255) > TEXT | |
| 16:02:23 | bauzas | ok, will review it when I have time then | |
| 16:03:32 | jaypipes | bauzas: that said, doesn't the REST API limit the length of the metadata value? | |
| 16:03:44 | jaypipes | bauzas: in which case a microversion is gonna be necessary | |
| 16:03:52 | bauzas | jaypipes: yup, possibly | |
| 16:04:02 | bauzas | tbh, I haven't reviewed it | |
| 16:04:11 | bauzas | just looking at the main modification | |
| 16:04:39 | bauzas | jaypipes: for your point, that'll depend if we cut the string by the API or not | |
| 16:05:10 | bauzas | but yeah, if it's all about having the API giving more than 255 chars for that, then yes, it's a microversion needed | |
| 16:09:46 | efried | namedtuple. Fabulous. | |
| 16:12:20 | prometheanfire | nova doesn't look like it supports the new os_vif https://review.openstack.org/532987 | |
| 16:12:35 | prometheanfire | will bug the list if you want | |
| 16:12:39 | edleafe | efried: not that fabulous | |
| 16:12:49 | efried | edleafe You don't like? | |
| 16:12:57 | edleafe | efried: see the comment I just posted | |
| 16:14:59 | efried | edleafe You set an attribute on the class, not an instance thereof. | |
| 16:15:31 | edleafe | ugh, was just thinking that through more. Coffee hasn't fully kicked in yet | |
| 16:15:40 | openstackgerrit | Merged openstack/nova master: Do not attempt volume swap when guest is stopped/suspended https://review.openstack.org/389798 | |
| 16:15:55 | openstackgerrit | Merged openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407 | |
| 16:20:25 | stephenfin | prometheanfire: Oh, looking | |
| 16:20:37 | stephenfin | sean-k-mooney, ralonsoh: Seen https://review.openstack.org/#/c/532987/ ? | |
| 16:21:06 | prometheanfire | stephenfin: cool | |
| 16:21:06 | sean-k-mooney | stephenfin: looking now | |
| 16:21:23 | prometheanfire | hopefully it's just a overly specific test | |
| 16:21:38 | ralonsoh | stephenfin: I'm taking a look now | |
| 16:22:35 | sean-k-mooney | stephenfin: at first glance these see unrelated to os-vif | |
| 16:23:00 | stephenfin | sean-k-mooney: Quite possibly. I haven't looked into it in detail | |
| 16:23:12 | stephenfin | Just saw the multiple rechecks. Usually a sign of something more sinister | |
| 16:23:25 | sean-k-mooney | stephenfin: the network basic opts test were failing due to a an ip confict | |