| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-11 | |||
| 16:47:35 | bauzas | mdbooth: very interesting, I'm trying to allocate 2 vGPUs on a single VM | |
| 16:47:45 | bauzas | libvirt fails miserably | |
| 16:48:02 | bauzas | I guess because of the nvidia driver | |
| 16:48:36 | mdbooth | bauzas: Other fun things: allocate 1 vgpu to 2 vms. Create an mdev of each of 2 different types. | |
| 16:49:01 | bauzas | mdbooth: my code prevents that | |
| 16:49:01 | mdbooth | bauzas: It would be awesome to document all these failure modes somewhere in a code comment. Maybe the privsep function? | |
| 16:49:12 | bauzas | mdbooth: we only support one type | |
| 16:49:13 | mdbooth | Yeah, I know. | |
| 16:49:22 | bauzas | and that's documented in the relnote | |
| 16:49:46 | mdbooth | bauzas: Right, but I'm just thinking it's interesting to understand our failure modes, and most people don't have the hardware to hand to test it. | |
| 16:49:58 | bauzas | for the multi-assignment of the same mediated device, that should also be in theory avoided by my code, except if bugs | |
| 16:50:02 | mdbooth | Will help reviewers/maintainers, for eg | |
| 16:50:21 | bauzas | mdbooth: I mean, what would you like to see ? | |
| 16:50:43 | bauzas | mdbooth: I can try to change the conf opt | |
| 16:50:45 | mdbooth | So do we see a failure on creating the mdev? | |
| 16:50:54 | mdbooth | Or subsequently when we try to use it? | |
| 16:50:57 | bauzas | you mean the privsep call ? | |
| 16:51:02 | mdbooth | And in either case, what form does the failure take? | |
| 16:51:06 | mdbooth | Yeah | |
| 16:51:27 | bauzas | what I haven't checked is what happens if I modify the conf opt and ask for another type | |
| 16:51:45 | mdbooth | bauzas: That's an extremely nice to have, btw. | |
| 16:51:49 | bauzas | in theory, it should say 0 available resources | |
| 16:52:13 | bauzas | because some mediated devices are already created for the existing guests, so the other resources are 0 | |
| 16:52:28 | mdbooth | If you're testing this stuff anyway, if you could squirrel away what real failures look like it would be really useful. | |
| 16:52:30 | bauzas | well, for that physical GPU | |
| 16:53:00 | bauzas | mdbooth: well, an instance leading to an ERROR state is okay to me, if that's documented why | |
| 16:53:17 | bauzas | like, if you make a flavor that asks for 2 VGPUs, it won't work | |
| 16:53:32 | bauzas | that's the caveats I mentioned in my note | |
| 17:07:50 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | |
| 17:12:32 | dansmith | mriedem: cdent: I just want to say that us passing around dicts of placement api goo in our scheduler paths is really not ideal | |
| 17:12:46 | dansmith | I'm changing the microversion I make a call at, which changes that format, | |
| 17:12:59 | dansmith | and thus a bunch of obscure dict manipulation code paths have to change in weird ways | |
| 17:13:13 | cdent | yeah, I made a similar comment on a recent bug report | |
| 17:13:14 | dansmith | if we had a proper client-side model of this it would be a lot easier to maintain | |
| 17:13:49 | cdent | of the 'when we bump to the new microversion this stuff gonna go funkity' | |
| 17:13:50 | mriedem | client side model like an object? | |
| 17:13:57 | dansmith | mriedem: yes | |
| 17:14:08 | mriedem | leave a todo in the patch? | |
| 17:14:55 | dansmith | if I ever get it working | |
| 17:29:01 | efried | dansmith An object like ProviderTree? Though also presumably an equivalent for allocation candidates. | |
| 17:29:27 | dansmith | efried: well, kinda yeah | |
| 17:31:10 | edleafe | dansmith: aren't we treating them as opaque blobs, as originally designed? I know there was the doubking up hack, but that should no longer be necessary | |
| 17:31:21 | cdent | edleafe: they've changed shape | |
| 17:31:27 | cdent | and they get manipulated | |
| 17:31:34 | cdent | so not really opaque (last I checked) | |
| 17:32:00 | bauzas | dansmith: not sure you saw the long convo I had with mdbooth but before I leave for 2.5 hours (will be back later), just food for thoughts | |
| 17:32:07 | cdent | I can't remember why they get manipulated | |
| 17:32:20 | cdent | My ability to index this stuff for memory is broken | |
| 17:33:02 | dansmith | edleafe: not in the scheduler | |
| 17:33:12 | dansmith | edleafe: I'm not having any problems with the code that treats it as opaque | |
| 17:33:14 | bauzas | dansmith: since we create mediated devices on the fly (or allocate them) based on allocations, and generate the guest config with that, thanks to allocations, it means that when you power off and then power on again, you get a guest that no longer has VGPUs because we don't pass (yet) the allocations to power_on() | |
| 17:33:37 | dansmith | bauzas: okay | |
| 17:33:56 | bauzas | dansmith: everything works seamlessly when booting, so https://review.openstack.org/#/c/528832/ is ready for reviews, but I'll need to address that issue in a follow-up | |
| 17:34:31 | homeski | Question for anyone ... | |
| 17:34:45 | homeski | I have a instance booted from volume, where the volume gets attached using the IDE bus | |
| 17:34:50 | homeski | is there a way, using OSP CLI, to have the boot device remounted using virtio ? | |
| 17:34:57 | homeski | ight now I have to manually `virsh edit` the XML | |
| 17:35:04 | homeski | Also, if I attach any additional volumes, they always get attached using IDE, even if I have `disk_bus=virtio` set on the volume metadata | |
| 17:35:10 | homeski | I have to keep messing with the XML manually | |
| 17:35:44 | dansmith | edleafe: and we can't get rid of the doubling until rocky, AFAIK, because pike computes still depends on it | |
| 17:36:22 | dansmith | homeski: see topic please | |
| 17:36:40 | homeski | gotcha, thx | |
| 17:36:54 | edleafe | dansmith: sure, what I was asking was if that was a one-off thing, and that we aren't doing any more of it | |
| 17:37:19 | dansmith | edleafe: that's the biggest wart, yeah | |
| 17:39:09 | openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.generation_for https://review.openstack.org/532922 | |
| 17:46:08 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | |
| 17:57:40 | openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: WIP: Do not normalize allocation_ratios https://review.openstack.org/532924 | |
| 17:58:13 | maciejjozefczyk | mriedem: https://review.openstack.org/532924 | |
| 17:58:58 | maciejjozefczyk | mriedem: IMO instead doing additional if statements in RT we should do it clean and set default values in config files as it should be done eariler (starting from newton) - if I understand the problem correctly | |
| 17:59:18 | maciejjozefczyk | its draft, without test changes | |
| 17:59:25 | maciejjozefczyk | tests* | |
| 17:59:51 | mriedem | maciejjozefczyk: i don't know about the implications of changing the defaults in the config file | |
| 17:59:56 | mriedem | that's all bauzas territory | |
| 18:00:11 | mriedem | i don't know the history behind why we had 0.0 in config and hard-coded values in code | |
| 18:01:55 | maciejjozefczyk | mriedem: It was (at least I can read it from comments) about backwards compatibility to Liberty, i think | |
| 18:02:12 | maciejjozefczyk | bauzas: hello :) could you please check https://review.openstack.org/532924 if the idea is ok for you? thanks! | |
| 18:05:43 | dansmith | mriedem: for the overcommit ratios? | |
| 18:05:55 | dansmith | allocation_ratio yeah | |
| 18:06:10 | dansmith | that is our sentinel to the scheduler to obey what the compute reports in the db instead of using config | |
| 18:06:14 | dansmith | when we moved that stuff | |
| 18:06:22 | dansmith | if 0.0, then 16.0 for cpu, etc | |
| 18:06:47 | dansmith | heh that patch just undoes it without historical context I think | |
| 18:06:52 | dansmith | bauzas: ^ | |
| 18:07:00 | dansmith | he has the full story in his head I bet | |
| 18:08:03 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Pass limit to /allocation_requests https://review.openstack.org/531517 | |
| 18:10:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244 | |
| 18:10:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle swapping to a multiattach volume https://review.openstack.org/532928 | |
| 18:10:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 18:10:49 | mriedem | ildikov: gibi: johnthetubaguy: ^ swap volume change is in the middle | |
| 18:11:24 | ildikov | mriedem: gorgeous, thank you! | |
| 19:24:28 | openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | |
| 19:24:29 | openstackgerrit | Eric Fried proposed openstack/nova master: Raise conflict exception on RP create 409 https://review.openstack.org/532563 | |
| 19:24:29 | openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | |
| 19:24:30 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | |
| 19:24:30 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | |
| 19:24:31 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | |
| 19:24:31 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | |
| 19:24:32 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | |
| 19:24:48 | openstackgerrit | Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in test_compute.py https://review.openstack.org/531479 | |
| 19:28:23 | mriedem | edleafe: comments in the resize + alternates patch https://review.openstack.org/#/c/526436/ | |