Posted	Nick	Remark
#openstack-nova - 2018-01-11
02:09:22	Kevin_Zheng	I mean the fixed_ip thing
02:19:15	mriedem	Kevin_Zheng: we should probably have a release note for that,
02:19:26	mriedem	something about how nova will proxy ip filtering to neutron as long as the neutron extension is available
02:19:37	Kevin_Zheng	OK
02:19:45	mriedem	you can do that on top
02:19:49	mriedem	so you don't lose jay's +2
02:19:55	Kevin_Zheng	OK
02:20:10	Kevin_Zheng	what do you think about the fixed_ip thing?
02:20:47	Kevin_Zheng	I was mislead by it at the beginning
02:21:16	mriedem	i'm not sure what you're referring to
02:21:33	Kevin_Zheng	It seems to me that this one is useless https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2304
02:21:45	Kevin_Zheng	09:39 seems strange to me
02:21:45	Kevin_Zheng	09:39 those values didn't got remapped as what has been done for fixed_ip filter
02:21:45	Kevin_Zheng	09:39 as we consider 'ip' and 'ip6' as valid filters
02:21:45	Kevin_Zheng	09:38 after remap, its value is put into filters['ip']
02:21:45	Kevin_Zheng	since fixed_ip is not considered as an valid filter both in schema and api-ref
02:22:05	mriedem	the schema won't block it though
02:22:09	mriedem	because additionalProperties=True
02:22:20	Kevin_Zheng	yeah
02:22:35	mriedem	otherwise yes i agree the fixed_ip filter mapping doesn't really make sense
02:22:51	mriedem	but i wouldn't propose removing that in this same change
02:23:10	Kevin_Zheng	but why it has been mapped but ip and ip6 didn't
02:23:18	mriedem	no idea
02:23:23	Kevin_Zheng	is what I'm curious about
02:23:25	mriedem	probably was written 6 years ago
02:23:38	mriedem	it could predate the ip/ip6 filters
02:23:46	mriedem	or was a rackspace only thing
02:23:46	Kevin_Zheng	yeah, I checked the history
02:23:47	mriedem	who knows
02:23:56	Kevin_Zheng	seems for ec2
02:24:02	mriedem	ah ok
02:24:15	Kevin_Zheng	so probably just leave it alone
02:25:26	mriedem	yeah i would
02:25:35	mriedem	i don't see anything obvious about it in here though https://github.com/openstack/ec2-api/blob/master/ec2api/api/instance.py
02:28:35	openstackgerrit	Chen Hanxiao proposed openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441
02:29:34	mriedem	Kevin_Zheng: comments inline
02:29:43	mriedem	easy stuff though
02:29:47	mriedem	looks really good otherwise
02:30:00	Kevin_Zheng	I missread
02:30:21	Kevin_Zheng	it has a logic bellow in the previous code in 2011
02:30:30	Kevin_Zheng	and it says ec2 specific
02:31:30	mriedem	you said the neutron extension wasn't being caught when you did the performance test right?
02:31:36	mriedem	that's probably because the neutron patch changed the name to "IP address substring filtering"
02:31:42	Kevin_Zheng	yeah
02:31:48	Kevin_Zheng	It should be OK now
02:32:02	mriedem	https://review.openstack.org/#/c/521683/19/neutron/extensions/ip_substring_port_filtering_lib.py#34
02:32:09	mriedem	you're using the old ext name in the nova patch
02:32:32	mriedem	https://review.openstack.org/#/c/521683/19/neutron/extensions/ip_substring_port_filtering_lib.py@34
02:33:01	Kevin_Zheng	oh, no
02:33:12	Kevin_Zheng	the previous error was in neutron
02:33:25	Kevin_Zheng	it cannot list the new extension
02:33:36	Kevin_Zheng	because the name is not correct, in neutron
02:33:47	Kevin_Zheng	now it is good
02:34:13	Kevin_Zheng	I will change the name in nova
02:34:32	mriedem	ok
02:34:42	mriedem	add the missing tests and release note and i think it's ready
02:34:47	mriedem	i can't +2 b/c i'm co-author though
02:39:59	mriedem	alex_xu: i addressed your issue on that migrations changes-since thing https://review.openstack.org/#/c/330406/ - also found a couple of issues in the unit tests that were already in there, so fixed those as well
02:40:18	mriedem	CI has been way backed up all day though
03:03:42	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
03:33:33	openstackgerrit	jichenjc proposed openstack/nova master: WIP: add zvm document into https://review.openstack.org/532720
04:07:54	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505
05:11:41	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell' https://review.openstack.org/513771
05:11:58	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514
05:12:20	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579
05:13:55	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094
05:14:01	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094
05:15:43	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Move body examples to an isolated directory https://review.openstack.org/529998
05:16:09	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289
05:18:40	openstackgerrit	Takashi NATSUME proposed openstack/nova stable/pike: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513717
05:19:12	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix the order of target host checks https://review.openstack.org/526225
05:42:00	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
06:09:42	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post https://review.openstack.org/526823
06:10:02	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (1) https://review.openstack.org/531258
06:10:22	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (2) https://review.openstack.org/531266
06:28:42	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280
06:41:10	openstackgerrit	Chen Hanxiao proposed openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441
07:01:53	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in get https://review.openstack.org/531299
08:15:37	ameeda	Morning :)
08:15:49	maciejjozefczyk	Morning!
08:15:58	ameeda	can you please check this question https://stackoverflow.com/questions/48202352/write-functional-regression-test-for-nova
08:19:13	ameeda	maciejjozefczyk: I try to deploy openstack on baremetal from undercloud installed at vm, I got this error "CREATE_FAILED ResourceInError: resources.NovaCompute: Went to status ERROR due to "Message: No valid host was found. There are not enough hosts available., Code: 500""
08:22:17	ameeda	I found this error "ComputeHostNotFound: Compute host undercloud could not be found." in nova-compute.log
08:31:36	maciejjozefczyk	ameeda: It shoudl be quite similiar to https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1554631.py
08:31:49	maciejjozefczyk	about functional regression test
08:32:11	ameeda	maciejjozefczyk: thanks you very much. I will check it now
08:32:47	maciejjozefczyk	ameeda: I mean you need some mocking and it could be possible to check if the field is not truncated
08:33:57	ameeda	maciejjozefczyk: the problem is that I am beginner with openstack and also I never write regression code, I will do my best to do that
08:34:31	maciejjozefczyk	ameeda: I've never written any regression test also :D
08:34:50	maciejjozefczyk	ameeda: about second question; check scheduler logs
08:35:04	ameeda	maciejjozefczyk: great :D
08:35:14	ameeda	maciejjozefczyk: let me check it now
08:35:38	maciejjozefczyk	ameeda: Do understand it well I recommend to move log_level to debug and then restart scheduler; you'll find which filter removes the host from list
08:37:56	ameeda	let me see how to change log_level :$
08:48:54	openstackgerrit	Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245
08:56:13	maciejjozefczyk	ameeda: /etc/nova/nova.conf - add debug=True
08:57:32	ameeda	maciejjozefczyk: yes I did that, and I restart the services and I need to empty log files contents
09:01:43	bauzas	good morning Novaers
09:01:57	ameeda	Morning :)
09:02:10	ameeda	maciejjozefczyk: I will start openstack deploy.

Earlier   Later