| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-10 | |||
| 23:02:02 | lbragstad | mgagne: responded - yeah the deprecation bits in oslo.policy are pretty new | |
| 23:02:14 | lbragstad | i'm not sure if nova had a pre-existing deprecation implementation in nova | |
| 23:02:28 | mgagne | none that I'm aware of | |
| 23:07:29 | mgagne | lbragstad: ok, finally tested gist I posted above. the alias thing works fine. | |
| 23:07:49 | mgagne | => "compute:create": "rule:os_compute_api:servers:create" | |
| 23:08:03 | lbragstad | sweet | |
| 23:08:11 | mgagne | so legacy policy name "compute:create" becomes an alias of "os_compute_api:servers:create" | |
| 23:08:32 | lbragstad | nice - that makes sense | |
| 23:10:22 | lbragstad | mgagne: pushed a new patch | |
| 23:11:17 | mgagne | this works for me. only use case I'm not sure about is if both name and check string are deprecated. =) | |
| 23:11:33 | mgagne | like you get a new name AND a new check string :D | |
| 23:11:52 | lbragstad | in that case, the policy is being removed all together, right? | |
| 23:12:43 | lbragstad | or it can be the name and the check_str is changing at the same time... | |
| 23:12:56 | mgagne | I don't know tbh. but it would still be a supported use case by oslo policy, won't fail with: can't deprecate both name and check string. | |
| 23:13:10 | mgagne | yes, that's what I'm referring to | |
| 23:17:14 | mgagne | lbragstad: I'm super bad with bug description, feel free to update =) https://bugs.launchpad.net/oslo.policy/+bug/1742569 | |
| 23:17:15 | openstack | Launchpad bug 1742569 in oslo.policy "Including deprecated policy names in sample file" [Undecided,New] | |
| 23:18:21 | lbragstad | mgagne: looks good - thanks for the report | |
| 23:18:45 | lbragstad | mgagne: i'm sure we'll be able to get that addressed before library freeze | |
| 23:19:44 | mgagne | cool, thanks! =) | |
| 23:20:10 | mgagne | for now, will use my legacy mapping, looks to work fine with Horizon Ocata and Nova Newton | |
| 23:27:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the nova-multiattach experimental queue job https://review.openstack.org/532689 | |
| 23:27:32 | mriedem | ildikov: stvnoyes: the new multiattach job ^ | |
| 23:29:22 | ildikov | mriedem: I owe you | |
| 23:39:26 | gmann | mriedem: we can mark this complete now -https://blueprints.launchpad.net/nova/+spec/api-extensions-policy-removal | |
| 23:40:14 | mriedem | gmann: cool thanks | |
| #openstack-nova - 2018-01-11 | |||
| 00:03:37 | openstackgerrit | Hironori Shiina proposed openstack/nova master: [WIP] Ironic: Get IP address for volume connector from ports/portgroups https://review.openstack.org/517322 | |
| 00:16:16 | openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector from ports/portgroups https://review.openstack.org/517322 | |
| 00:32:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | |
| 00:34:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (2) https://review.openstack.org/526263 | |
| 00:34:42 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (3) https://review.openstack.org/526557 | |
| 00:38:58 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | |
| 01:39:13 | Kevin_Zheng | It seems to me that this one is useless https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2304 | |
| 01:39:45 | Kevin_Zheng | since fixed_ip is not considered as an valid filter both in schema and api-ref | |
| 01:40:27 | Kevin_Zheng | after remap, its value is put into filters['ip'] | |
| 01:40:57 | Kevin_Zheng | as we consider 'ip' and 'ip6' as valid filters | |
| 01:41:32 | Kevin_Zheng | those values didn't got remapped as what has been done for fixed_ip filter | |
| 01:41:48 | Kevin_Zheng | seems strange to me | |
| 01:53:04 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | |
| 02:09:09 | Kevin_Zheng | mriedem alex_xu ^^ | |
| 02:09:22 | Kevin_Zheng | I mean the fixed_ip thing | |
| 02:19:15 | mriedem | Kevin_Zheng: we should probably have a release note for that, | |
| 02:19:26 | mriedem | something about how nova will proxy ip filtering to neutron as long as the neutron extension is available | |
| 02:19:37 | Kevin_Zheng | OK | |
| 02:19:45 | mriedem | you can do that on top | |
| 02:19:49 | mriedem | so you don't lose jay's +2 | |
| 02:19:55 | Kevin_Zheng | OK | |
| 02:20:10 | Kevin_Zheng | what do you think about the fixed_ip thing? | |
| 02:20:47 | Kevin_Zheng | I was mislead by it at the beginning | |
| 02:21:16 | mriedem | i'm not sure what you're referring to | |
| 02:21:33 | Kevin_Zheng | It seems to me that this one is useless https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2304 | |
| 02:21:45 | Kevin_Zheng | 09:39 seems strange to me | |
| 02:21:45 | Kevin_Zheng | 09:39 those values didn't got remapped as what has been done for fixed_ip filter | |
| 02:21:45 | Kevin_Zheng | 09:39 as we consider 'ip' and 'ip6' as valid filters | |
| 02:21:45 | Kevin_Zheng | 09:38 after remap, its value is put into filters['ip'] | |
| 02:21:45 | Kevin_Zheng | since fixed_ip is not considered as an valid filter both in schema and api-ref | |
| 02:22:05 | mriedem | the schema won't block it though | |
| 02:22:09 | mriedem | because additionalProperties=True | |
| 02:22:20 | Kevin_Zheng | yeah | |
| 02:22:35 | mriedem | otherwise yes i agree the fixed_ip filter mapping doesn't really make sense | |
| 02:22:51 | mriedem | but i wouldn't propose removing that in this same change | |
| 02:23:10 | Kevin_Zheng | but why it has been mapped but ip and ip6 didn't | |
| 02:23:18 | mriedem | no idea | |
| 02:23:23 | Kevin_Zheng | is what I'm curious about | |
| 02:23:25 | mriedem | probably was written 6 years ago | |
| 02:23:38 | mriedem | it could predate the ip/ip6 filters | |
| 02:23:46 | mriedem | or was a rackspace only thing | |
| 02:23:46 | Kevin_Zheng | yeah, I checked the history | |
| 02:23:47 | mriedem | who knows | |
| 02:23:56 | Kevin_Zheng | seems for ec2 | |
| 02:24:02 | mriedem | ah ok | |
| 02:24:15 | Kevin_Zheng | so probably just leave it alone | |
| 02:25:26 | mriedem | yeah i would | |
| 02:25:35 | mriedem | i don't see anything obvious about it in here though https://github.com/openstack/ec2-api/blob/master/ec2api/api/instance.py | |
| 02:28:35 | openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441 | |
| 02:29:34 | mriedem | Kevin_Zheng: comments inline | |
| 02:29:43 | mriedem | easy stuff though | |
| 02:29:47 | mriedem | looks really good otherwise | |
| 02:30:00 | Kevin_Zheng | I missread | |
| 02:30:21 | Kevin_Zheng | it has a logic bellow in the previous code in 2011 | |
| 02:30:30 | Kevin_Zheng | and it says ec2 specific | |
| 02:31:30 | mriedem | you said the neutron extension wasn't being caught when you did the performance test right? | |
| 02:31:36 | mriedem | that's probably because the neutron patch changed the name to "IP address substring filtering" | |
| 02:31:42 | Kevin_Zheng | yeah | |
| 02:31:48 | Kevin_Zheng | It should be OK now | |
| 02:32:02 | mriedem | https://review.openstack.org/#/c/521683/19/neutron/extensions/ip_substring_port_filtering_lib.py#34 | |
| 02:32:09 | mriedem | you're using the old ext name in the nova patch | |
| 02:32:32 | mriedem | https://review.openstack.org/#/c/521683/19/neutron/extensions/ip_substring_port_filtering_lib.py@34 | |
| 02:33:01 | Kevin_Zheng | oh, no | |
| 02:33:12 | Kevin_Zheng | the previous error was in neutron | |
| 02:33:25 | Kevin_Zheng | it cannot list the new extension | |
| 02:33:36 | Kevin_Zheng | because the name is not correct, in neutron | |
| 02:33:47 | Kevin_Zheng | now it is good | |
| 02:34:13 | Kevin_Zheng | I will change the name in nova | |
| 02:34:32 | mriedem | ok | |
| 02:34:42 | mriedem | add the missing tests and release note and i think it's ready | |
| 02:34:47 | mriedem | i can't +2 b/c i'm co-author though | |
| 02:39:59 | mriedem | alex_xu: i addressed your issue on that migrations changes-since thing https://review.openstack.org/#/c/330406/ - also found a couple of issues in the unit tests that were already in there, so fixed those as well | |
| 02:40:18 | mriedem | CI has been way backed up all day though | |
| 03:03:42 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | |