| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-10 | |||
| 06:00:40 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | |
| 06:11:28 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | |
| 06:40:11 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | |
| 06:50:46 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | |
| 07:04:24 | openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381 | |
| 07:14:13 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | |
| 07:22:16 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | |
| 07:44:09 | openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | |
| 07:59:33 | ameeda | Morning :) | |
| 07:59:44 | ameeda | please review my code here "https://review.openstack.org/#/c/526900/" and let me know if I need to write microversions. | |
| 07:59:46 | ameeda | Yikun Jiang (Kero) asked me to write microversions since he said that I changed a status code on a particular response. | |
| 08:00:02 | ameeda | Thanks ! | |
| 08:05:49 | yikun | @ameeda, actually, I'm not sure we should add a new micro version in this change or not. | |
| 08:05:54 | yikun | yeah, we change the status code and API behaviour when "Metadata property value > 255".(400 ---> 200) | |
| 08:06:03 | yikun | but as @jichen mentioned: we don't accept 255 before and now we accept it , no impact to end user ? | |
| 08:06:22 | yikun | I think you maybe can get some help from @alex_xu or @takashi. | |
| 08:10:00 | ameeda | yikun: thanks alot :) | |
| 08:10:52 | ameeda | alex_xu: are you around ? | |
| 08:10:57 | ameeda | takashi: also ? | |
| 08:12:37 | alex_xu | ameeda: I added it into my review list, will try it asap | |
| 08:13:32 | ameeda | alex_xu: thank you very much :) | |
| 08:36:50 | gmann | ameeda: alex_xu we are all good in term of microversion, this does not change the API behavior | |
| 08:37:09 | gmann | need to check whether it fix the reported bug or not | |
| 08:52:48 | gmann | ameeda: left comment there | |
| 08:55:30 | openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | |
| 08:59:25 | bauzas | morning Novaers | |
| 09:01:15 | gmann | morning | |
| 09:01:22 | ameeda | gmann: Thank you for review, so I need to return the master code, this restrict the length of the value, I removed the limitations for that ? I will change the reno. also add a functional regression test. | |
| 09:03:56 | gmann | ameeda: you mean this? - https://review.openstack.org/#/c/526900/17/nova/compute/api.py | |
| 09:04:14 | ameeda | gmann: yes | |
| 09:04:35 | gmann | ameeda: i checked and it should not have impact but let me confirm again. | |
| 09:05:22 | ameeda | gmann: thanks :) | |
| 09:05:30 | gmann | ameeda: np! | |
| 09:22:30 | gmann | ameeda: i still not find if that code truncated the value in case of system metadata | |
| 09:22:38 | gmann | ameeda: any failure link etc? | |
| 09:24:29 | ameeda | gmann: I am not sure. I still beginner with nova and openstack, so you guess that I need to restore the original code ? | |
| 09:25:14 | gmann | ameeda: np!. let's not change that and see whether bug is fixed or not. you can check locally also and by adding functional tests also | |
| 09:26:03 | gmann | ameeda: if something compute/api.py change needs to do we can do later. but i am sure changing DB field and util function should work | |
| 09:27:42 | ameeda | gmann: what about functional tests. its important ? if so, how I can do that ? | |
| 09:31:37 | gmann | ameeda: yea it is imp to see bug is fixed and it does not regress . example is like these tests - https://github.com/openstack/nova/tree/master/nova/tests/functional/regressions | |
| 09:32:01 | ameeda | gmann: thanks for your help and your time. | |
| 09:32:09 | gmann | ameeda: with that we can get to know whether bug is actually fixed and no more hidden restriction/truncation etc | |
| 09:32:16 | gmann | ameeda: np! | |
| 09:35:47 | openstackgerrit | sahid proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/497457 | |
| 09:53:10 | openstackgerrit | caishan proposed openstack/nova master: Unit testing test_driver.py indent issue https://review.openstack.org/532473 | |
| 09:57:07 | openstackgerrit | caishan proposed openstack/nova master: Unit testing test_driver.py indent issue https://review.openstack.org/532473 | |
| 10:07:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix typo in release note https://review.openstack.org/531854 | |
| 10:24:45 | mdbooth | lyarwood: Could you take a look at https://review.openstack.org/#/c/531524/ ? I'd like to encourage the author to resurrect your stable rescue series instead. | |
| 10:26:55 | lyarwood | mdbooth: sure, there's a spec up for review for this, might provide the feedback there - https://review.openstack.org/#/c/532410/3/specs/rocky/approved/volume-backed-server-rescue.rst | |
| 10:27:39 | mdbooth | Hmm. I didn't see that linked from the bp. | |
| 10:28:13 | lyarwood | mdbooth: it isn't, it's on the gerrit topic. | |
| 10:28:28 | mdbooth | Eurgh. | |
| 10:29:00 | stephenfin | lyarwood: Small question here https://review.openstack.org/#/c/460243/13/nova/virt/libvirt/driver.py@1273 | |
| 10:29:41 | mdbooth | I reviewed the patch anyway, which had issues. I pointed out your series as a much more thorough alternative which was also previously nearly across the line. | |
| 10:36:30 | mdbooth | stephenfin: I answered for him :) | |
| 10:38:29 | stephenfin | mdbooth: Ta! | |
| 10:38:39 | stephenfin | That's done now, as promised | |
| 10:45:37 | openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | |
| 10:50:24 | lyarwood | stephenfin / mdbooth ; yup thanks, context is still required for attach | |
| 11:07:41 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | |
| 11:11:01 | openstackgerrit | Liam Young proposed openstack/nova master: Add exception to no-upcall note of cells doc https://review.openstack.org/532491 | |
| 11:14:20 | sean-k-mooney | did they upgrade gerrit recently? i just commented on a patch set 15 of someting and it included old draft comment i had on patchset 4 also... | |
| 11:15:32 | sean-k-mooney | granted it did at least include them on the patchset 4 version but still that annoying when you cant see that they are there | |
| 11:17:43 | gibi | sean-k-mooney: yeah, this is a new feature from the last gerrit upgrade | |
| 11:17:53 | gibi | sean-k-mooney: but the upgrade happened couple of months ago | |
| 11:30:01 | sean-k-mooney | gibi: oh really i guess i have just been lucky enough not to hit it till now. if i start a review and there are new revions in between i normally start again and copy the comments but dont always delete the old ones since they were ignored | |
| 11:30:29 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | |
| 11:42:13 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova stable/pike: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/532504 | |
| 11:42:31 | hrw | as it went to master it would be good to have it in pike too ;D | |
| 11:44:34 | openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | |
| 11:53:41 | mdbooth | lyarwood: Sorry :/ https://review.openstack.org/#/c/460243/ | |
| 11:54:28 | openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | |
| 12:24:54 | Rambo | Hi,everyone ,Can you help me to review the spec ?The link is https://review.openstack.org/#/c/532410/ | |
| 12:25:03 | Rambo | Another is :https://review.openstack.org/#/c/532407/ | |
| 12:25:09 | Rambo | Thank you very much | |
| 12:29:09 | sean-k-mooney | melwitt: stephenfin bauzas o/ do any of ye know the url to the ptg etherpad matt started. ill grab it from the irc logs if not so noworries if you dont have it to hand. | |
| 12:30:30 | sean-k-mooney | melwitt: stephenfin bauzas found it https://etherpad.openstack.org/p/nova-ptg-rocky | |
| 12:31:54 | lyarwood | mdbooth: np, fired back, I really don't like that comment with the encryptor.detach_volume call removed | |
| 12:32:15 | lyarwood | mdbooth: it should be pretty obvious that you can't disconnect a volume before detaching it from the guest tbh | |
| 12:32:30 | lyarwood | mdbooth: and the tests should catch anyone trying to do this | |
| 12:33:54 | kashyap | lyarwood: Sometimes explicit is better than implicit. What is obvious to you would be a far cry from it for a fresh pair of eyes trying to get up2speed. | |
| 12:34:20 | kashyap | I'm personally a fan of documenting in comments, even if sometimes it's a bit obvious if you're in the know | |
| 12:36:28 | ygl | hi all | |
| 12:36:35 | ygl | can someone help me with my issue | |
| 12:43:13 | openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | |
| 12:51:59 | lyarwood | *sigh* | |
| 12:52:33 | lyarwood | kashyap: so how would the comment help someone reviewing that method for the first time? | |
| 12:52:49 | lyarwood | kashyap: given that the call to detach the encryptor is now hidden from them in _disconnect_volume | |
| 12:53:18 | lyarwood | kashyap: I'm all for helping first time readers through code but it makes the entire thing more confusing IMHO | |
| 12:55:18 | kashyap | lyarwood: Hmm, if you think it'll confuse more, I'll defer to you. | |
| 12:55:35 | kashyap | lyarwood: I noticed what you said is missing in your review comment | |
| 12:56:35 | kashyap | lyarwood: Then maybe you'd want to note that the call to detach the encryptor is elsewhere :-) | |
| 13:01:43 | takashin | alex_xu: Are you aroud? | |
| 13:02:06 | alex_xu | takashin: yea | |
| 13:02:23 | takashin | alex_xu: Is there API meeting today? | |
| 13:03:16 | alex_xu | takashin: yes, but passed few weeks, there is no people show up, then I didn't run it, is there anything you want to discuss, we can discussed at here I think | |
| 13:03:55 | takashin | alex_xu: Okay. I have 2 patches for reviews. | |
| 13:04:07 | takashin | api-ref: Parameter verification for servers.inc: https://review.openstack.org/#/c/528201/ | |
| 13:04:13 | gmann | alex_xu: takashin i was away too since 2-3 weeks. we can resume from next week may be | |
| 13:04:16 | takashin | api-ref: Example verification for servers.inc: https://review.openstack.org/#/c/529520/ | |