Posted	Nick	Remark
#openstack-nova - 2018-01-09
20:51:57	ildikov	I only changed the top patch and downloaded the whole chain fresh before
20:52:09	ildikov	I will check on zuul and see where things are
20:57:13	mriedem	5: (529695,5) Use volume shared_targets to lock during attach/detach (8h17m/++++~+~++++/rem:1h56m)
20:57:29	mriedem	#5 in the gate so should be merged soonish
20:57:56	mriedem	it's only been there for 8.5 hours already..
21:00:25	mriedem	ildikov: ok i guess i'll start working on adding tests for the new flows when the microversion is high enough and multiattach is True
21:02:49	ildikov	mriedem: ok, I'm not touching the chain then
21:03:04	ildikov	mriedem: the unit and functional tests are fixed in the latest version
21:03:10	ildikov	at least it worked for me...
21:14:10	mriedem	mdbooth: damn, i ran that isolated test thing, 178 tests in my worker list to comb through :(
21:14:20	mriedem	the bisect analyzer couldn't figure it out
21:15:45	mriedem	although, i guess the idea is you can continue to wittle the results down with the smaller set of tests each time
21:23:40	openstackgerrit	Merged openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965
21:33:43	openstackgerrit	Merged openstack/nova master: Use volume shared_targets to lock during attach/detach https://review.openstack.org/529695
21:38:20	openstackgerrit	Hongbin Lu proposed openstack/nova master: placement: add API reference for create inventory https://review.openstack.org/511342
21:42:28	openstackgerrit	Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
21:42:50	edleafe	mriedem: ^^ addressed your concerns, and then some
22:14:52	openstackgerrit	Merged openstack/nova stable/pike: doc: Add configuration index page https://review.openstack.org/531042
22:16:12	openstackgerrit	Merged openstack/nova stable/pike: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/526468
22:26:39	openstackgerrit	Merged openstack/nova stable/pike: Add missing unit tests for FilterScheduler._get_all_host_states https://review.openstack.org/529625
22:43:46	openstackgerrit	melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414
22:43:46	openstackgerrit	melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381
22:43:47	openstackgerrit	melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990
22:54:18	SamYaple	which scheduler filter is responsible for the cpu overallocation/ratio filtering?
22:56:14	mriedem	SamYaple: CoreFilter
22:56:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244
22:56:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587
22:56:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api https://review.openstack.org/271047
22:56:40	mriedem	if you're ocata+, we filter VCPUs in placement when using the FilterScheduler, thus making the CoreFilter not necessary
22:56:43	SamYaple	mriedem: was that aroundin mitaka?
22:56:51	mriedem	was what around mitaka?
22:56:54	mriedem	placement was ocata
22:57:00	SamYaple	no sorry, itc lag
22:57:08	mriedem	CoreFilter has been around awhile yes
22:57:11	SamYaple	the corefilter, thats been around since before mitaka, yes
22:57:13	SamYaple	cool
22:57:18	SamYaple	sorry just looking at https://github.com/openstack/nova/blob/mitaka-eol/nova/conf/scheduler.py#L126
22:57:31	mriedem	yeah the CoreFilter was never a default filter for some reason
22:57:43	SamYaple	didnt see it listed and we were removing the retryfilter and now its overcommitting vcpus
22:58:07	SamYaple	we added the corefilter intothe copied list and it started filtering likeit should
22:58:14	SamYaple	was just tryingto trackdown the disconnect
22:58:19	mriedem	ildikov: a rebase and https://review.openstack.org/#/c/271047/51/nova/tests/unit/api/openstack/compute/test_serversV21.py is as far as i got; was trying to get that libvirt test that was race failing to pass, but couldn't after over an hour
22:59:16	mriedem	rechecking the tempest test patch and calling it a day
23:00:22	ildikov	mriedem: sounds good enough, thanks!
23:00:22	mriedem	dansmith: yes i hacked up that comment pretty bad :)
23:00:29	dansmith	mriedem: :P
23:00:37	mriedem	will put a fix on top tomorrow
23:01:02	ildikov	mriedem: I will look into it tomorrow too
23:09:33	openstackgerrit	Merged openstack/nova stable/pike: Fix an error in _get_host_states when deleting a compute node https://review.openstack.org/529626
#openstack-nova - 2018-01-10
00:59:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: Fix comment in MigrationSortContext https://review.openstack.org/532368
01:01:23	mriedem	alex_xu: need another reviewer on https://review.openstack.org/#/c/330406/ - we have +2s on the 2 changes below it
01:11:20	mriedem	efried: i think you're wrong about https://bugs.launchpad.net/nova/+bug/1742311
01:11:22	openstack	Launchpad bug 1742311 in OpenStack Compute (nova) "AttributeError in report client error path" [Undecided,Invalid]
01:11:24	mriedem	because https://github.com/requests/requests/blob/v2.18.4/requests/models.py#L663
01:25:27	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505
02:09:38	alex_xu	mriedem: got it, will get it done today
02:31:24	gmann	alex_xu: if you can check this simple one,we can close the BP - https://review.openstack.org/#/c/531061/
02:32:17	alex_xu	gmann: got it
02:32:29	gmann	alex_xu: thanks
02:32:33	alex_xu	gmann: np
02:35:03	takashin
02:39:13	openstackgerrit	Kevin Zhao proposed openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config https://review.openstack.org/494156
02:58:52	openstackgerrit	Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094
05:25:16	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Transform rescue/unrescue instance notifications https://review.openstack.org/385644
05:34:20	openstackgerrit	Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
05:51:54	openstackgerrit	Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407
06:00:40	openstackgerrit	Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410
06:11:28	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505
06:40:11	openstackgerrit	Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410
06:50:46	openstackgerrit	Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407
07:04:24	openstackgerrit	Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381
07:14:13	openstackgerrit	Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410
07:22:16	openstackgerrit	Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407
07:44:09	openstackgerrit	Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524
07:59:33	ameeda	Morning :)
07:59:44	ameeda	please review my code here "https://review.openstack.org/#/c/526900/" and let me know if I need to write microversions.
07:59:46	ameeda	Yikun Jiang (Kero) asked me to write microversions since he said that I changed a status code on a particular response.
08:00:02	ameeda	Thanks !
08:05:49	yikun	@ameeda, actually, I'm not sure we should add a new micro version in this change or not.
08:05:54	yikun	yeah, we change the status code and API behaviour when "Metadata property value > 255".(400 ---> 200)
08:06:03	yikun	but as @jichen mentioned: we don't accept 255 before and now we accept it , no impact to end user ?
08:06:22	yikun	I think you maybe can get some help from @alex_xu or @takashi.
08:10:00	ameeda	yikun: thanks alot :)
08:10:52	ameeda	alex_xu: are you around ?
08:10:57	ameeda	takashi: also ?
08:12:37	alex_xu	ameeda: I added it into my review list, will try it asap
08:13:32	ameeda	alex_xu: thank you very much :)
08:36:50	gmann	ameeda: alex_xu we are all good in term of microversion, this does not change the API behavior
08:37:09	gmann	need to check whether it fix the reported bug or not
08:52:48	gmann	ameeda: left comment there
08:55:30	openstackgerrit	Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524
08:59:25	bauzas	morning Novaers
09:01:15	gmann	morning
09:01:22	ameeda	gmann: Thank you for review, so I need to return the master code, this restrict the length of the value, I removed the limitations for that ? I will change the reno. also add a functional regression test.
09:03:56	gmann	ameeda: you mean this? - https://review.openstack.org/#/c/526900/17/nova/compute/api.py
09:04:14	ameeda	gmann: yes
09:04:35	gmann	ameeda: i checked and it should not have impact but let me confirm again.
09:05:22	ameeda	gmann: thanks :)
09:05:30	gmann	ameeda: np!
09:22:30	gmann	ameeda: i still not find if that code truncated the value in case of system metadata

Earlier   Later