| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-04 | |||
| 03:12:03 | melwitt | that's how I interpret it too | |
| 03:12:26 | mriedem | suck | |
| 03:12:50 | mriedem | i wonder if i could swindle jamespage and the gang to backport that to libvirt 3.6.0 :) | |
| 03:13:06 | melwitt | yeah, I'm honestly surprised this is all so recent | |
| 03:13:41 | melwitt | with all of the multiattach talk that's been happening for years, I never thought there could be a blocker at the qemu and libvirt level | |
| 03:14:38 | mriedem | sweet revenge | |
| 03:15:02 | melwitt | and the "fixed-in-version 3.9" with the commit in 3.10 doesn't make sense to me either | |
| 03:15:07 | mriedem | did you notice the guy complaining in comment 14 is using oracle RAC? | |
| 03:15:17 | mriedem | which is like the #1 use case for multiattach and why oracle wants it in nova so badly | |
| 03:15:41 | mriedem | comment 13 i should say | |
| 03:15:53 | mriedem | stvnoyes: fyi as this is all going to impact multiattach support in nova in queens ^ | |
| 03:16:08 | melwitt | what a mess | |
| 03:16:10 | mriedem | stvnoyes: if you're looking for something to do, we need some testing for the multiattach patches using qemu 2.10 and libvirt 3.1.0 | |
| 03:16:12 | mriedem | *3.10 | |
| 03:19:06 | mriedem | oh ha | |
| 03:19:07 | mriedem | lyarwood: https://bugzilla.redhat.com/show_bug.cgi?id=1415250 | |
| 03:19:09 | openstack | bugzilla.redhat.com bug 1415250 in openstack-nova "QEMU image file locking (RHOS)" [High,Post] - Assigned to lyarwood | |
| 03:19:10 | mriedem | melwitt: ^ | |
| 03:20:15 | melwitt | oh hello friends | |
| 03:21:33 | mriedem | left a comment because i like to comment in bz's | |
| 03:21:37 | mriedem | feels like i'm part of the team | |
| 03:21:50 | mriedem | ooo cc'ed to markmc@redhat.com | |
| 03:22:16 | mriedem | and eglynn@redhat.com, dansmith@redhat.com, | |
| 03:22:17 | mriedem | heh | |
| 03:23:45 | melwitt | :) | |
| 03:43:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | |
| 03:43:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 03:44:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 03:44:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | |
| 05:39:05 | takashin | ||
| 05:39:12 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | |
| 05:41:30 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | |
| 07:03:50 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | |
| 07:20:22 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795 | |
| 07:42:43 | takashin | git log -1 | |
| 08:14:01 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | |
| 08:14:01 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | |
| 08:25:51 | hrw | morning | |
| 09:51:57 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117 | |
| 09:55:18 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Use volume shared_targets to lock during attach/detach https://review.openstack.org/529695 | |
| 09:55:19 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 09:55:19 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | |
| 09:59:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Move legacy jobs to project https://review.openstack.org/514309 | |
| 10:00:39 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117 | |
| 10:01:23 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table https://review.openstack.org/530429 | |
| 10:06:54 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 10:21:21 | mdbooth | Is today finally going to be the day when https://review.openstack.org/#/c/529037/ doesn't fail spuriously in the gate? | |
| 10:21:42 | mdbooth | This is the fourth attempt, though, each attempt taking a full working day. | |
| 10:21:58 | mdbooth | It's not looking good for the plucky patch. | |
| 10:32:19 | kashyap | ildikov: Hi, do you have some CI Gate log of this -- https://bugzilla.redhat.com/show_bug.cgi?id=1415250#c13 | |
| 10:32:20 | openstack | bugzilla.redhat.com bug 1415250 in openstack-nova "QEMU image file locking (RHOS)" [High,Post] - Assigned to lyarwood | |
| 10:32:40 | kashyap | ildikov: So I could fish through the debug logs to find relevant bits | |
| 10:33:51 | kashyap | ildikov: Actually, disregard me, it's here: https://review.openstack.org/#/c/267587/ | |
| 10:34:09 | ildikov | kashyap: I got the logs from Matt with the following comment yeterday: "<mriedem> i can't link to these n-cpu logs because of how infra has changed where the logs live now, but that's the issue" | |
| 10:34:39 | kashyap | Ah, I didn't even realize openstack-infra has changed the log location | |
| 10:35:16 | ildikov | kashyap: no worries, Matt added a few extra bits to that patch yesterday | |
| 10:35:23 | kashyap | Yeah, just reading the review through | |
| 10:35:35 | ildikov | we haven't tested multi-attach for a while and this got us as a surprise | |
| 10:36:03 | ildikov | I only fixed other easy bits in the chain hoping to get a few small dependencies out of the way | |
| 10:36:06 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | |
| 10:36:55 | hrw | stephenfin: reported bug, added Closes-bug into commit message. | |
| 10:37:24 | hrw | stephenfin: have to check at tests. Will take a while as I do not know nova code | |
| 10:37:54 | ildikov | kashyap: thanks for looking into it | |
| 10:38:52 | kashyap | ildikov: No worries; Matt already did the sluething last night (I was away early yesterday). W.r.t versioning of the 'shareable' lock | |
| 10:39:23 | ArchiFleKs | Hi, this may sound like a trivial question but do you have more information about how nova and neutron dns worked together, I'm using neutron as a dns server, which work fine, I can have instances with .openstacklocal domain or a custom domain, but on ths instances itself, the hostname always get sets to .novalocal anyway, is that a behavior that will change ultimatly ? If I set dhcp_domain to an | |
| 10:39:24 | ArchiFleKs | empty string in nova, will it solve this ? | |
| 10:39:38 | ildikov | kashyap: yeah, I gave up around midnight my time too... :/ :) | |
| 10:39:55 | kashyap | Midnight...Sounds a bit too late :-) | |
| 10:40:22 | kashyap | lyarwood: No action needed; you were prompted because you were the current bug asignee | |
| 10:40:30 | lyarwood | hmmm I don't see what the qemu-img change has to do with this | |
| 10:41:02 | ildikov | kashyap: it's just such a bummer as I remember chatting with Daniel Berrange back at the time about the 'shareable' flag and the support for that is in for ages and kinda thought that the virt layer is a done deal and we "only" need to figure out Cinder and Nova itself... | |
| 10:41:36 | kashyap | lyarwood: It's due to the the versioning in Gate; just have to have some conditional logic in Nova | |
| 10:42:29 | kashyap | ildikov: BTW, some of the image locking stuff was a bit more recent (as recent as last month -- https://bugzilla.redhat.com/show_bug.cgi?id=1378242#c18) | |
| 10:42:30 | openstack | bugzilla.redhat.com bug 1378242 in libvirt "QEMU image file locking (libvirt)" [Unspecified,On_qa] - Assigned to pkrempa | |
| 10:42:50 | kashyap | But yeah, the 'shareable' flag has been around for ages | |
| 10:42:54 | ildikov | kashyap: yeah, I saw that one this morning | |
| 10:43:36 | lyarwood | kashyap: I'm not sure I agree with Matt's point in https://review.openstack.org/#/c/267587/75/nova/virt/libvirt/guest.py re the versions | |
| 10:44:21 | lyarwood | kashyap: https://github.com/libvirt/libvirt/commit/28907b0043fbf71085a798372ab9c816ba043b93 doesn't suggest we need to do anything different here, libvirt and QEMU should work out when to provide the share-rw=on flag | |
| 10:46:46 | kashyap | lyarwood: I think it's too late for that | |
| 10:47:08 | lyarwood | kashyap: for what? | |
| 10:47:17 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | |
| 10:47:22 | kashyap | For libvirt / QEMU to do the "right thing" | |
| 10:47:37 | kashyap | lyarwood: At the moment, Nova simply needs the conditional logic, going by the errors Matt and ildikov are reporting | |
| 10:48:07 | lyarwood | I'm obviously missing something here because what you're saying makes no sense | |
| 10:48:36 | lyarwood | the unsupported flag error is a docs bug | |
| 10:48:51 | hrw | now the worst part - reading nova/libvirt tests to find where it needs to be changed for https://review.openstack.org/530965 patch | |
| 10:48:55 | kashyap | Did you also look at this change: https://review.openstack.org/#/c/505673/ | |
| 10:49:32 | kashyap | hrw: Heya, just saw your change, note that 'host-passthrough' means, migration will completely break *unless* all the CPUs involved are all *identical* | |
| 10:49:39 | lyarwood | kashyap: that's totally unrelated to this isn't it? | |
| 10:49:43 | kashyap | hrw: I'll add some comments | |
| 10:49:56 | kashyap | lyarwood: No, it is related. | |
| 10:49:57 | hrw | kashyap: thanks | |
| 10:50:10 | lyarwood | kashyap: that just allows us to run qemu-img info against a live instance | |
| 10:50:18 | hrw | kashyap: I am aware of that issue. | |
| 10:51:05 | hrw | kashyap: getting that fixed layer after layer. | |
| 10:51:31 | kashyap | lyarwood: That's true; the two aspects here are - file locking from the standalone tool, 'qemu-img', and the locking semantics when running qemu-system-x86_64 | |
| 10:51:39 | kashyap | Give me a few minutes before I coment more | |
| 10:52:03 | lyarwood | ildikov: are we adding <shareable/> to the disk XML of multi-attached disks? | |
| 10:52:35 | hrw | kashyap: Kolla deploys Nova now with cpu_mode set. But not everyone uses Kolla-ansible to deploy. Then libvirt needs to be changed probably. I hope to meet some virt-arm people face-to-face later this month and want to discuss that | |
| 10:53:15 | ildikov | lyarwood: theoretically yes, proposed code change is here: https://review.openstack.org/#/c/267587/78/nova/virt/libvirt/volume/volume.py | |