Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-01-02
16:18:30 stephenfin kashyap: Stick 'basepython=python2' in the requisite tox target
16:18:47 stephenfin I'd say your system Python is python3.x
16:18:53 mriedem yeah ^
16:18:55 kashyap stephenfin: I wanted to do that, but I felt: "wait a moment, it should work with existin master"
16:18:58 kashyap Yeah, it is
16:19:15 stephenfin The gate/Ubuntu uses Python 2 so we'd never see it there
16:20:11 stephenfin So it needs basepython or the requisite changes to be Python3 compatible. Latter is better long term, naturally (one year closer to 2020)
16:21:33 openstackgerrit Stephen Finucane proposed openstack/nova master: Address nits in I46d483f9de6776db1b025f925890624e5e682ada https://review.openstack.org/530462
16:22:05 stephenfin gibi_away, jaypipes: So that ^ should _definitely_ work now, if you fancy sticking it on your review queue (it's cleanup for the PCI policy thing)
16:23:41 kashyap stephenfin: That's it; thanks.
16:24:13 mriedem kashyap: push a patch so others don't hit it
16:24:18 kashyap `tox -epep8 -- -HEAD` succeeds; ( mriedem - `tox -e fast8` was a joke, right
16:24:22 kashyap mriedem: Okido
16:24:28 mriedem kashyap: tox -e fast8 is a nova repo thing
16:24:30 mriedem not nova-specs
16:24:39 kashyap Ah, okay.
16:25:52 kashyap mriedem: Oops on, actually "that's not it". Fast switching between repos, I ran it on Nova upstream
16:26:40 kashyap stephenfin: That's my tox.ini - http://paste.openstack.org/show/636299/
16:26:48 kashyap That should more than do, right?
16:26:53 kashyap (Again, this is for nova-specs)
16:30:38 stephenfin kashyap: Should do, yup
16:30:42 stephenfin You can drop line 21
16:30:47 jaypipes stephenfin: done
16:31:08 stephenfin kashyap: Also line 3-5, but that's another change
16:31:09 mriedem ildikov: are you going to rebase https://review.openstack.org/#/c/267587/ on top of https://review.openstack.org/#/c/529695/ ?
16:31:15 stephenfin jaypipes: Thank you, sir
16:31:20 kashyap stephenfin: Yep
16:31:58 ildikov mriedem: I added it in 'Depends-On'
16:32:15 ildikov mriedem: I can make a chain if you would prefer that
16:32:35 ildikov ?
16:33:30 stephenfin mdbooth: Given the similarities to your own BDM patch, wanna take a shot at https://review.openstack.org/#/c/530487/ this week, once you're feeling better?
16:34:26 mriedem ildikov: the chain is better when it's in the same repo
16:34:33 mriedem IMO
16:35:47 ildikov mriedem: ok, will make it a chain
16:37:09 mriedem stephenfin: is this part of the pci policy bp i just marked as complete? https://review.openstack.org/#/c/530487/
16:37:19 mriedem https://blueprints.launchpad.net/nova/+spec/share-pci-between-numa-nodes
16:37:41 stephenfin mriedem: Nope, nothing to do with that. Just a nice-to-have that was talked about here before Xmas
16:37:50 mriedem ok i seem to remember that
16:38:11 mriedem pcidevice uuid was added for nested RPs?
16:38:22 stephenfin Yup
16:38:24 mriedem ok
16:39:58 kashyap stephenfin: Hmm, bizarre, despite that .tox.ini file you saw, it is still going to 3.6:
16:40:11 kashyap [...] nova-specs/.tox/docs/lib/python3.6/site-packages/yasfb/formatter.py", line 451, in format_rss2_file
16:40:14 kashyap handle.write(string.encode('utf-8'))
16:40:17 kashyap TypeError: write() argument must be str, not byte
16:40:26 kashyap Is there any other way I can force py2.7?
16:40:28 clarkb kashyap: you may need to run with tox -r for it to rebuild the tox env
16:40:44 clarkb if it already ran and built an older env with different python version it won't rebuilt it unless you pass -r
16:41:00 kashyap clarkb: I just nuked the .tox and re-ran, to precisely avoid that
16:41:16 kashyap But let be double-check for sure
16:45:33 openstackgerrit Ildiko Vancsa proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047
16:45:33 openstackgerrit Ildiko Vancsa proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587
16:46:28 ildikov mriedem: you were right as always :) done ^^
16:50:23 kashyap clarkb: Thanks; that was it; after re-building, this succeeds `tox -e py27`
16:52:40 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Add UEFI Secure Boot support for QEMU/KVM guests, using OVMF https://review.openstack.org/506720
16:55:39 cdent jaypipes, edleafe, efried, jroll: I'm home now and mostly free.
16:57:54 openstackgerrit Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/530697
17:00:50 openstackgerrit Matthew Booth proposed openstack/nova master: Add test for assignment of uuid to a deleted BDM https://review.openstack.org/530774
17:04:38 mdbooth mriedem: ^^^
17:04:43 mriedem ack
17:10:43 mdbooth stephenfin: That pci uuid patch screams refactor with library code to me. You?
17:11:08 stephenfin mdbooth: It's getting there, but I could only find the two occurrences
17:11:08 mdbooth I mean, it's a whole bunch of cut/paste.
17:11:17 stephenfin One more and I'd have dragged it out
17:11:35 mdbooth Ok, if it's only 2.
17:11:46 mdbooth Still borderline, though.
17:13:48 mdbooth I just need legacy-tempest-dsvm-py35 to complete for the top patch, then the top 2 will merge.
17:13:59 mdbooth It's taking a suspiciously long time, though :(
17:14:16 mdbooth Perhaps my goat didn't find favour.
17:18:53 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: tox.ini: Add Python 2.7 as 'basepython' for 'pep8' target https://review.openstack.org/530776
17:20:32 openstackgerrit Stephen Finucane proposed openstack/nova master: Handle deprecation of inspect.getargspec https://review.openstack.org/530777
17:31:51 jaypipes kashyap: reviewed.
17:33:13 kashyap jaypipes: Thanks; /me goes to look
17:34:05 kashyap jaypipes: Damn, thought I fixed all the "brain coughs" :P Thanks for catching
17:42:22 kashyap Ah, I think you were writing that comment ("seems like you started one sentence but then switched to another") as I already addressed it :-)
17:44:32 cburgess jaypipes Apparently nic loves pugs too... http://submedia.net
17:46:17 jaypipes cburgess: lol
17:46:32 cburgess Apparently he has had that for years and I just now learned of it.
17:47:11 cdent reminds me: that pug bath plug is the bomb diggity. Except it is a bit disconcerting when he spins around and stares at naked entuberated me with his beady little put eyes
17:47:22 cdent s/put/pug/
17:47:53 jaypipes lmao
17:49:15 cdent does this work (SFW): https://scontent.flhr2-1.fna.fbcdn.net/v/t35.0-12/26236425_10154900649336370_718762856_o.jpg?oh=e3e9ccca81ae034887843abe17781943&oe=5A4DB6DD
18:02:38 jroll amazing
18:06:42 mdbooth What will Zuul do when it times out a job? Restart or fail?
18:06:55 jroll mdbooth: fails
18:08:21 openstackgerrit Merged openstack/python-novaclient master: Remove incorrect legacy QuotaSet.id property https://review.openstack.org/530757
18:14:00 mdbooth Well, that's been stalled for so long I'm almost entirely certain it's going to fail, and when it fails the 2 behind it will also fail.
18:14:23 mdbooth So I'm just gonna do my rebase anyway.
18:14:55 openstackgerrit Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167
18:14:55 openstackgerrit Matthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid https://review.openstack.org/525599
18:14:56 openstackgerrit Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346
18:14:56 openstackgerrit Matthew Booth proposed openstack/nova master: Expose BDM uuid to drivers https://review.openstack.org/529037
18:14:57 openstackgerrit Matthew Booth proposed openstack/nova master: Rename block_device_info_get_root https://review.openstack.org/529028
18:14:57 openstackgerrit Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347
18:14:58 openstackgerrit Matthew Booth proposed openstack/nova master: Expose driver_block_device fields as attributes https://review.openstack.org/528362
18:14:58 openstackgerrit Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029
18:14:59 openstackgerrit Matthew Booth proposed openstack/nova master: Use real block_device_info data in libvirt tests https://review.openstack.org/527916
18:14:59 openstackgerrit Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363
18:15:00 openstackgerrit Matthew Booth proposed openstack/nova master: Pass disk_info dict to libvirt_info https://review.openstack.org/529329
18:15:00 openstackgerrit Matthew Booth proposed openstack/nova master: Fix libvirt volume tests passing invalid disk_info https://review.openstack.org/529328

Earlier   Later