| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-22 | |||
| 13:14:25 | maciejjozefczyk | leakypipes: sorry for saying that but this change https://review.openstack.org/#/c/520024 breaks resource tracking in placement :) I need to dig more | |
| 13:14:28 | maciejjozefczyk | leakypipes: Wroclaw | |
| 13:14:31 | leakypipes | ah | |
| 13:15:37 | leakypipes | maciejjozefczyk: k, I'll take a look at that patch again (on the resource provider issue) shortly. | |
| 13:17:00 | leakypipes | maciejjozefczyk: what you can try in the meantime is just replacing each of those calls to self._update() one by one and see which specific one causes the invalid inventory exception to go away... | |
| 13:17:38 | openstackgerrit | rahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique https://review.openstack.org/527922 | |
| 13:17:47 | maciejjozefczyk | leakypipes: I found that its in _update_inventory_for_provider /opt/stack/nova/nova/objects/resource_provider.py(232 | |
| 13:18:51 | leakypipes | maciejjozefczyk: yes, I see that. but I'm wondering which of the locations in https://review.openstack.org/#/c/520024/8/nova/compute/resource_tracker.py where you removed the call to self._update() causes that exception to be hit. | |
| 13:19:27 | leakypipes | maciejjozefczyk: so you might try replacing (one by one) those call locations of self._update() in the resource tracker and determining which of those calls fixes the reserved inventory invalid exception. | |
| 13:19:32 | leakypipes | that's all I was saying :) | |
| 13:19:55 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | |
| 13:19:56 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | |
| 13:23:31 | maciejjozefczyk | leakypipes: I found that because I've removed duplications the self._resource_change(compute_node) always says false (yeah, thats right) so the ComputeNode object is not updated directly (I mean with cn.save()), and without this call the exceptions is raised by placement | |
| 13:23:33 | maciejjozefczyk | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L854 | |
| 13:23:50 | maciejjozefczyk | leakypipes: anyway, need to switch context because of other tasks... We'll dig it later ;) | |
| 13:24:12 | maciejjozefczyk | s/we/I/ :) | |
| 13:24:13 | leakypipes | k, no prob | |
| 13:24:27 | bauzas | hola, folks | |
| 13:24:58 | bauzas | (yeah, it seems weird that I'm looking to be in an US TZ, but no worries, I was not looking at the IRC this morning :p) | |
| 13:26:32 | leakypipes | bauzas: where are ya? | |
| 13:26:52 | bauzas | just still in Le Versoud, FR :p | |
| 13:27:13 | bauzas | wed, I was off because $skiing | |
| 13:27:39 | bauzas | so, I needed to work off the IRC by this morning for other things :( | |
| 13:28:05 | bauzas | oh, and Friday, right | |
| 13:33:12 | openstackgerrit | Merged openstack/nova master: Don't try to delete build request during a reschedule https://review.openstack.org/528835 | |
| 13:42:40 | mriedem | mdbooth: ping me once https://review.openstack.org/#/c/242602/ is fixed up and i'll +2 | |
| 13:43:03 | mdbooth | mriedem: Thanks, will do. | |
| 13:43:43 | bauwser | mriedem: today is my last day for 2017, how can I help for today ? | |
| 13:44:14 | bauwser | mriedem: I worked most of the time off IRC because *VGPU, but in case you need stable reviews or anything else | |
| 13:45:46 | mriedem | bauwser: we have these ocata and newton backports yet https://review.openstack.org/#/q/I214a44f0eee7d90be5cd89f32f6e0017b19a3fd6 | |
| 13:46:05 | bauwser | ah right, I saw the email | |
| 13:46:22 | bauwser | mriedem: thanks for helping on that bug, btw. | |
| 13:46:38 | mriedem | bauwser: and these https://review.openstack.org/#/q/I0b3ec6bb098ca32ffd32a61d4f9dcf426c3faf46 | |
| 13:46:52 | mriedem | this is my last day for 2017 also | |
| 13:49:20 | finucannot | bauwser: Polite reminder to take a second look at https://review.openstack.org/#/q/topic:bp/share-pci-between-numa-nodes+status:open too, please :) | |
| 13:49:45 | bauwser | mriedem: also, note I'll be off until Jan 8th | |
| 13:49:53 | finucannot | I'm hoping leakypipes will come around on the middle one. I'm almost certain I'm correct in what I'm saying | |
| 13:50:34 | bauwser | finucannot: I did, and I saw you answered to leakypipes | |
| 13:50:42 | bauwser | I need a bit more time to think about the concern | |
| 13:50:56 | leakypipes | finucannot: currently trying to diagnose https://bugs.launchpad.net/nova/+bug/1739517 | |
| 13:50:57 | openstack | Launchpad bug 1739517 in OpenStack Compute (nova) "TestNovaMigrationsMySQL randomly fails with "sqlalchemy.exc.ResourceClosedError: This result object does not return rows. It has been closed automatically."" [High,Confirmed] | |
| 13:51:08 | finucannot | Oh, that beauty | |
| 13:51:12 | figleaf | leakypipes: it would have been cheaper to fly me to FLA and install your dishwasher for you | |
| 13:51:23 | leakypipes | figleaf: yeah, no shit.. | |
| 13:52:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Document testing guide for new API contributions https://review.openstack.org/529618 | |
| 13:55:53 | bauwser | mriedem: tell him some children in the world are still awake for already like 9 hours and that's his time | |
| 13:56:46 | mriedem | i just run in screaming that the house is on fire and we have to get out | |
| 13:58:54 | bauwser | looks like it's an universal NP-problem then | |
| 14:00:34 | openstackgerrit | Ryota MIBU proposed openstack/nova master: vif: look up 'ovs_interfaceid' in vif_details https://review.openstack.org/529831 | |
| 14:02:13 | bauwser | finucannot: leakypipes: remember me, what happens if we want to add a new item for an o.vo Enum field type, do we need to bump the object version using that field type ? | |
| 14:02:24 | bauwser | finucannot: leakypipes: context being https://review.openstack.org/#/c/527470/4/nova/objects/instance_pci_requests.py | |
| 14:02:59 | finucannot | bauwser: You mean if we change 'numa_policy' at a future date? | |
| 14:03:16 | bauwser | if we change the Enum field type, yes | |
| 14:03:24 | bauwser | not the field itself | |
| 14:03:37 | bauwser | like, removing the 'legacy' choice from the enum | |
| 14:03:54 | bauwser | (because I guess that's the direction we want) | |
| 14:12:08 | Roamer` | hm, no response in #openstack, so let me butt in here :) Does anybody know of a tool that reads devstacklog.txt, splits it into phases, and lets me know how long each phase took? Trying to figure out why my latest stack.sh runs take about twice as long as before | |
| 14:12:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use volume shared_targets to lock during attach/detach https://review.openstack.org/529695 | |
| 14:12:58 | finucannot | bauwser: tbh, I've no idea. We haven't done that yet (that I know of), so it depends | |
| 14:13:00 | Roamer` | of course it would be trivial to write such a tool once I know what phases there are, but I haven't looked so deeply into stack.sh yet... has anybody else? | |
| 14:13:08 | mriedem | Roamer`: i'd ask in #openstack-qa | |
| 14:13:18 | Roamer` | mriedem, thanks, that might work | |
| 14:13:20 | mriedem | sdague is the person to ask but he's out for the year, so maybe mtreinish | |
| 14:13:27 | leakypipes | finucannot: we've done that with the ResourceClassField enum. | |
| 14:13:56 | bauwser | finucannot: I guess the problem is more about removing the legacy option | |
| 14:13:59 | leakypipes | finucannot: and I don't believe we've incremented the version for objects that use it... | |
| 14:14:07 | bauwser | say we could just deprecate that option, that's it | |
| 14:14:11 | leakypipes | finucannot: then again, we don't use objects over RPC for placement.. | |
| 14:14:46 | bauwser | leakypipes: well, the ResourceClassFieldType is specific because indeed we don't pass it thru RPC | |
| 14:15:27 | bauwser | we just use o.vo to have a coercing | |
| 14:17:44 | bauwser | finucannot: leakypipes: FWIW, I just +W'd that change because I think it's not a problem | |
| 14:21:00 | cdent | leakypipes: have you seen this and the associated bug: https://review.openstack.org/#/c/529397/ | |
| 14:21:12 | cdent | there was a lot of associated irc discussion about other options, but that was the simplest | |
| 14:21:28 | cdent | wanted to be sure you saw it before I leave to do some dreaded shopping | |
| 14:25:34 | leakypipes | finucannot: it's not that I don't like your code. I'm just having a hard time with the whole cascading policy loop thing... I agree with you that pools != filtered_pools and that my original complaint about coupling is not valid. however it still feels a bit clever for my taste. I'll remove my -1 and leave it to bauzas and gibi to +W | |
| 14:33:00 | leakypipes | mriedem: morning. | |
| 14:39:08 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | |
| 14:39:09 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid https://review.openstack.org/525599 | |
| 14:39:09 | openstackgerrit | Matthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | |
| 14:39:10 | openstackgerrit | Matthew Booth proposed openstack/nova master: Expose BDM uuid to drivers https://review.openstack.org/529037 | |
| 14:39:10 | openstackgerrit | Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167 | |
| 14:42:54 | mdbooth | mriedem: Updated ^^^ I haven't completely re-run all tests locally, though. Just the obvious ones. Been bitten by that a couple of times recently, but I'm being optimistic anyway. | |
| 15:01:16 | cfriesen | what do we expect to happen if you do a resize/migrate, and after completion but before confirmation the dest node dies and we do an evacuate? Should the resize/migrate revert, should the evacuation pass without error, or something else? | |
| 15:23:12 | finucannot | leakypipes: Let me take a second shot at it. If it's too clever for you, it's going to be too clever for others too | |
| 15:23:31 | leakypipes | finucannot: maybe. I'm pretty dumb, though. | |
| 15:23:56 | finucannot | Ah, so am I. All the more reason | |
| 15:23:57 | finucannot | leakypipes: I assume you're gone next week? | |
| 15:24:28 | leakypipes | finucannot: nope, I'm working all next week. I got no vacation this year when i joined Verizon... | |
| 15:24:52 | finucannot | Ouch :( | |
| 15:25:16 | finucannot | four days is _more_ than enough for all involved | |
| 15:25:57 | leakypipes | heh | |
| 15:26:23 | finucannot | I had a look at that bug you mentioned too. Totally out of my area of expertise, I'm afraid, so best of luck with that, heh | |
| 15:27:03 | leakypipes | finucannot: yeah, it's a weird one alright... | |
| 15:28:26 | finucannot | and intermittent too. The worst kind of bug :( | |
| 15:38:34 | mriedem | cfriesen: you can't evacuate an instance in VERIFY_RESIZE state can you? | |
| 15:38:43 | mriedem | leakypipes: hi | |
| 15:38:51 | mriedem | leakypipes: did your xmas dinner party turn out ok? | |
| 15:39:10 | mriedem | cfriesen: @check_instance_state(vm_state=[vm_states.ACTIVE, vm_states.STOPPED, | |
| 15:39:11 | mriedem | def evacuate(self, context, instance, host, on_shared_storage, | |
| 15:39:11 | mriedem | vm_states.ERROR]) | |