Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-12-21
23:32:26 mriedem i guess those are the same
23:33:55 mriedem i would think that if stats.num_instances is wrong, that compute_node.running_vms will also be wrong
23:34:00 mriedem because the latter is set based on the former
23:34:13 Guest98938 so does running_vms include stopped vms ?
23:34:20 mriedem yeah i think so
23:34:49 Guest98938 yea, I think the problem here is self.stats are missing and compute_node.running_vms exists from my observation
23:35:24 Guest98938 which is why I though of relying on running_vms
23:37:33 mriedem it's possible there could be a problem where stats.num_instances doesn't get updated properly for a move operation
23:37:37 mriedem i.e. a migration to another host
23:39:48 mriedem this change might have regressed something in newton
23:39:49 mriedem https://review.openstack.org/#/c/307124/21/nova/compute/resource_tracker.py@245
23:39:52 mriedem see how that comment is wrong
23:40:02 mriedem it might have just meant _update_usage_from_migration
23:40:04 mriedem and was a typo
23:40:33 mriedem i think that's a typo,
23:40:42 mriedem but i also think that a move operation isn't properly updating stats.num_instances
23:41:35 mriedem the update_available_resource periodic task which runs by default every minute should update stats.num_instances for the instances that currently live on that host,
23:41:50 mriedem but you could hit a window between the periodic task running and a move happening
23:41:55 mriedem which throws off your filter
23:43:43 Guest98938 yea, but in my case there is no migration happening
23:50:09 mriedem ok, idk then
23:50:19 mriedem i'd still check this in the filter
23:50:20 mriedem num_instances = host_state.num_instances or len(host_state.instances)
23:50:37 mriedem if those 2 values on the right are different, i'd log a warning
23:50:59 tonyb mriedem: followign up from the meetign I just missed ... I'll do the newton EOL in Jan
23:51:07 mriedem tonyb: ok
23:57:02 Guest98938 yea, I will try the filter approach too, thanks
#openstack-nova - 2017-12-22
00:06:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix functional tests for USE_NEUTRON https://review.openstack.org/529456
00:12:01 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix functional tests for USE_NEUTRON https://review.openstack.org/529456
00:59:59 yikun https://launchpad.net/bugs/1739571 and https://review.openstack.org/#/c/529519/
01:00:00 openstack Launchpad bug 1739571 in OpenStack Compute (nova) "Can't delete root resource provider because of the self foreign key" [Undecided,In progress] - Assigned to Yikun Jiang (yikunkero)
01:00:03 yikun hello, morning or evening, ^^^ I found a bug, but this bug only reproduced in MySQL environment.
01:00:08 yikun but seems our testcases only run in SQLite, so, is there some apporach to test it?
01:44:48 openstackgerrit Minho Ban proposed openstack/nova master: prevent removing numa_topology usage info from DB https://review.openstack.org/529236
02:06:49 alex_xu mriedem: oomichi do you like using the 'controller' instead of 'extension'?
02:31:18 mriedem alex_xu: i'll do either
02:32:04 mriedem sec
02:32:04 mriedem yikun: there is a trick to make foreign keys work with sqlite,
02:33:07 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Fix error when deleting any root resource provider https://review.openstack.org/529519
02:33:12 mriedem sqlite 3.7+ should work with foreign keys
02:33:13 mriedem see TestDatabaseArchive
02:33:36 mriedem engine.connect().execute("PRAGMA foreign_keys = ON")
02:33:48 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633
02:33:49 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189
02:33:49 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982
02:33:50 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409
02:33:50 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407
02:33:51 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737
02:34:03 yikun o? I will take a look, and try it in my local env, thanks. : )
02:34:08 yikun mriedem,
02:34:10 mriedem yw
02:38:33 mriedem yikun: fyi https://review.openstack.org/#/c/529672/
02:38:37 mriedem turns out we needed that after all
02:42:33 yikun mriedem, emm, yes, +1, the deadlock on action event start is possible,
02:42:40 yikun because action and event doesn't have some relation ship, so sqlalchemy session mechanism can't ensure the update order.
02:43:57 yikun some ref: http://www.aosabook.org/en/sqlalchemy.html # 20.9. Unit of Work
02:45:16 Kevin_Zheng consider add relationship?
02:45:34 openstackgerrit Merged openstack/nova master: Fix unit test failures when direct IO not supported https://review.openstack.org/529568
02:46:00 Kevin_Zheng mriedem we were thinking about a full scan about these kind of things in Nova
02:46:37 Kevin_Zheng https://review.openstack.org/#/c/527362/
02:47:33 Kevin_Zheng ^ the deadlock retry method is not perfect, so we might be able to improve performance here
02:58:45 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633
02:58:46 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189
02:58:46 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982
02:58:47 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409
02:58:47 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407
02:58:48 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737
03:04:04 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/529783
03:37:22 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: trivial: use cn instead of rp https://review.openstack.org/529786
05:03:18 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node https://review.openstack.org/523342
09:33:36 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024
09:37:08 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024
10:14:29 ralonsoh stephenfin: hi, about https://review.openstack.org/#/c/449257/52/nova/pci/request.py@93
10:18:34 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/507481
10:18:34 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257
10:49:22 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832
10:55:51 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612
11:01:30 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612
11:05:50 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226
11:16:01 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386
11:22:23 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773
11:33:21 openstackgerrit rahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique https://review.openstack.org/527922
12:55:25 jaypipes good morning nova comrades.
12:57:59 cdent morning jaypipes
12:58:09 cdent get your dishwasher and dinner sorted?
12:58:33 jaypipes no and yes.
12:59:28 jaypipes cdent: friggin electricians hooked up the dishwasher's electric but said they could touch the plumbing. so I hooked up the plumbing and there's a leak. so my wife's uncle is out grabbing plumber's tape and we're going to pull it out and have a look at where the leak is. the saga continues.
12:59:41 cdent argh
12:59:50 jaypipes cdent: cost me almost as much for the 1.25 hours of electrician as for the new dishwasher :(
12:59:53 jaypipes $400...
12:59:57 cdent jeebus
13:00:00 jaypipes ya.
13:00:37 jaypipes so after dinner, the eleven of us just made a Hobbit-dwarf-esque factory line and polished off the dish cleanup team-style.
13:00:58 cdent well if it makes you feel any better, one christmas at my parents, where they had no dishwasher, I was responsible for peeling the potatoes and somehow managed to completely screwn up the garbage disposal such that the sink wouldn't drain
13:01:03 cdent we did the dishes in the bathtub
13:01:31 cdent did you sing?
13:06:33 jaypipes cdent: heh, that's... awesome. :) and no, I did not sign.
13:06:34 jaypipes sing
13:12:37 maciejjozefczyk jaypipes: good morning
13:12:43 jaypipes maciejjozefczyk: mornin!

Earlier   Later