Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-12-21
19:25:34 openstackgerrit Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
19:25:52 edleafe mriedem: jaypipes: ^^ the rebase got 'em all
19:27:38 mriedem oomichi: i think "If you need help debugging" is the correct english
19:27:56 mriedem otherwise "If you need help with debugging"?
19:28:21 mriedem granted, i think most people who have english has a second language are probably more knowledgeable of the actual grammar rules :)
19:28:22 oomichi mriedem: "If you need help with debugging" is more easy for me
19:28:56 jroll another option is "if you need help to debug"
19:28:58 mriedem oomichi: 私はそれを変更する
19:29:00 jroll I like with
19:29:15 oomichi mriedem: ありがとう
19:29:43 mriedem oomichi: as for the "API extension" part,
19:29:47 mriedem i know like 'resource'
19:29:57 mriedem but not sure what to use beside extension. handler? controller? just API?
19:30:03 mriedem "route"?
19:35:07 melwitt mriedem: would it not be a REST API "resource"? that's what ppl told me to call it when I added /usages to placement API for example
19:35:22 oomichi mriedem: I think API is better in them. handler, controller and route are just implementation side
19:36:09 mriedem melwitt: but there are several API extensions under nova/api/openstack/compute/ which work on the same resource
19:36:11 mriedem like servers
19:36:25 mriedem consider the user_data, block_device_mapping_v2, etc extensions
19:36:26 melwitt ah, right
19:36:33 mriedem we have a similar modeling in our api samples directories
19:36:37 mriedem which is why i'm trying to show it's a 1:1
19:36:45 melwitt yeah. I was thinking of the os-blah ones that are separate
19:37:16 oomichi API becomes non-extensible, API means a single API, and we don't need to have separated tests for each extension
19:37:46 melwitt there aren't any separate directories under doc/api_samples/servers/ fwiw. just microversion directories
19:38:38 melwitt it's nice to have them separated for organizing and finding them though, IMHO
19:39:35 mriedem oomichi: then what do we call this? https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/user_data.py
19:39:43 mriedem it's an extension of the servers api
19:40:04 mriedem eventually, one day, these should all be collapsed and removed, which sdague started and gmann was working on
19:40:11 mriedem but i'm not sure what to call those except 'extensions'
19:40:11 oomichi mriedem: hehe, that is a good sample
19:40:53 oomichi mriedem: IIUC alex_xu wants to merge these code into main servers.py with json-schema
19:41:03 oomichi to remove these extension code
19:41:31 mriedem yeah i know
19:41:39 mriedem but until then what do we call these
19:41:59 oomichi at this time, it is difficult to find another word except extension
19:42:30 mriedem ha
19:42:33 mriedem exactly!
19:43:07 mriedem i could put a note about how "extension" doesn't actually mean we support extending the API, and link to the docs about that, but it seems like that would get messy
19:43:20 melwitt the user_data example doesn't have its own directory though, from what I see
19:43:34 mriedem you know what melanie
19:44:00 mriedem ok but https://github.com/openstack/nova/tree/master/doc/api_samples/server-metadata
19:44:01 mriedem does
19:44:12 oomichi mriedem: please don;t put such note, I am fine with current one which is better
19:44:12 mriedem and whatever the hell this thing is https://github.com/openstack/nova/tree/master/doc/api_samples/os-quota-sets-noop
19:44:13 mriedem :)
19:44:36 mriedem oomichi: ok so i'll change the 'debug' part
19:44:37 mriedem and leave the rest
19:44:46 oomichi hehe
19:45:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Document testing guide for new API contributions https://review.openstack.org/529618
19:46:14 mriedem https://docs.openstack.org/nova/latest/contributor/api.html#modularity
19:46:19 mriedem "The Nova REST API is separated into different controllers in the directory ‘nova/api/openstack/compute/’"
19:46:29 openstackgerrit Merged openstack/nova stable/pike: [placement] Fix an error message in API validation https://review.openstack.org/526465
19:46:30 mriedem since the doc already says "controllers" maybe we should just be consistent?
19:50:14 melwitt I was originally going to put the noop quotas directory under os-quota-sets/ but thought maybe the top level one was less confusing. I can try to move it under os-quota-sets/
19:52:32 melwitt another way I tried was putting the noop samples at the same level in os-quota-sets/ without their own directory and have the noop tests look for a noop prefix, but thought maybe that was worse ¯\_(ツ)_/¯
20:00:21 mriedem i was just giving you shit about that
20:03:51 melwitt k :)
20:39:07 openstackgerrit Merged openstack/nova master: Pass RequestSpec to ConductorTaskAPI.build_instances https://review.openstack.org/515495
20:41:12 cfriesen mriedem: do you know why we're calling self._update() at https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L590 ? Having that means that every time we call_update_available_resource() we'll save invalid data, then overwrite it a bit later with valid data.
20:42:30 mriedem cfriesen: oh boy
20:42:39 mriedem you don't know?!
20:42:47 mriedem cfriesen: https://review.openstack.org/#/c/520024/
20:43:04 mriedem feel free to update that change
20:43:08 mriedem maciejjozefczyk: ^
20:43:17 mriedem nova meeting in 17 minutes
20:43:20 mriedem last one for the year
20:43:35 cfriesen mriedem: sweet, thanks
20:49:44 openstackgerrit Merged openstack/nova master: Fix an error in _get_host_states when deleting a compute node https://review.openstack.org/529352
20:49:51 openstackgerrit Merged openstack/nova master: VMware: expose max vCPUs and max memory per ESX host https://review.openstack.org/516635
20:49:58 openstackgerrit Merged openstack/nova master: VMware: implement get_inventory() driver method https://review.openstack.org/506175
20:50:09 openstackgerrit Merged openstack/nova master: Pass mountpoint to volume attachment_create with connector https://review.openstack.org/527479
20:50:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Use volume shared_targets to lock during attach/detach https://review.openstack.org/529695
20:50:24 mriedem ildikov: jgriffith: ^
20:50:53 ildikov mriedem: thanks!
20:51:46 mriedem edleafe: you might hit a merge conflict now that https://review.openstack.org/#/c/515495/ merged
20:56:03 jgriffith mriedem: ack, I'll check it out here shortly. Thanks!
20:56:07 edleafe mriedem: oh joy
20:56:39 mriedem edleafe: maybe, but not sure
20:56:58 mriedem eh, yeah it's in merge conflict
20:57:03 mriedem i can fix it up
20:59:10 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Don't try to delete build request during a reschedule https://review.openstack.org/529697
21:14:57 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Don't try to delete build request during a reschedule https://review.openstack.org/529703
21:37:18 mriedem edleafe: got that rebase done locally, just running tests
21:39:17 edleafe k
21:56:04 openstackgerrit Merged openstack/nova master: conf: libvirt: Cleanup CPU modelling related options https://review.openstack.org/527691
22:04:55 mriedem here it comes
22:05:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
22:05:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Don't try to delete build request during a reschedule https://review.openstack.org/528835
22:05:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
22:09:45 mriedem edleafe: you might want to look this over quick https://review.openstack.org/#/c/511358/48..49/
22:09:48 mriedem make sure i didn't eff anything up
22:14:54 edleafe mriedem: looks sane
22:15:14 mriedem alright, bombs away
22:27:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
22:27:47 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
22:30:10 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: SEA https://review.openstack.org/523216
22:30:37 openstackgerrit Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094
22:33:08 openstackgerrit Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094
22:38:43 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.59 - List/Show all server migration types https://review.openstack.org/430839

Earlier   Later