Posted	Nick	Remark
#openstack-nova - 2017-12-20
00:55:48	mnaser	return (self.host_state_map[host] for host in seen_nodes)
00:56:26	mnaser	why not just "return self.host_state_map[host]" i dont know
00:56:32	mnaser	err i mean "return self.host_state_map"
00:56:49	mriedem	not sure, i don't remember why that change was necessary, would have to ask bauzas
00:56:52	mriedem	but it's clearly wrong
00:57:37	mnaser	lol
00:57:37	mnaser	this only took 41 patchsets to merge
00:57:43	mnaser	https://review.openstack.org/#/c/417961/
00:58:10	mriedem	yeah man, and i was in i think cancun at the time on vacation
01:00:00	mriedem	https://review.openstack.org/#/c/417961/41/nova/scheduler/filter_scheduler.py@100 was also wrong
01:01:52	mnaser	now let me disable versioned notification and see if that gets things moving
01:10:43	mnaser	unversioned notifications did the trick mriedem. that lets me delete the weird vms and live migrate the others. thanks so much for your time, ill track those bugs and hopefully we can get them merged/backported
01:12:03	mriedem	mnaser: can you report a bug for the flavor versioned notification thing?
01:12:09	mnaser	mriedem: oh sure
01:15:04	jaypipes	mriedem, mnaser: just getting back to the house after dinner... have you figured out what was up?
01:15:15	mriedem	jaypipes: https://review.openstack.org/#/q/topic:bug/1739318+(status:open+OR+status:merged)
01:16:35	mriedem	latent bug from newton bites us in the ass starting in pike
01:18:18	mnaser	mriedem: fyi https://bugs.launchpad.net/nova/+bug/1739325
01:18:20	openstack	Launchpad bug 1739325 in OpenStack Compute (nova) "Server operations fail to complete with versioned notifications" [Undecided,New]
01:18:38	mnaser	also thanks for asking jaypipes but yeah i think we're good .. for now, going to wait to get that backported so we can upgrade to latest stable/pike
01:19:03	mriedem	i can feel my wife getting ready to yell at me for still being in my office
01:20:01	mnaser	lol
01:20:11	mnaser	i still have some gift shopping to do..
01:20:14	mnaser	but i guess that's not happening tonight
01:20:35	mnaser	though not looking forward to how much snow is dumped on my car since 8am today and cleaning all that
01:21:33	mriedem	we're virtually snow free in SE minnesota
01:21:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: Default some flavor notification payload fields https://review.openstack.org/529194
01:21:41	mriedem	mnaser: so this is a start on that versioned notification bug ^
01:21:46	mriedem	super hacky though i think,
01:21:53	mriedem	but would need other input, likely from dansmith on that one
01:22:01	mriedem	no idea how we could get in that situation to begin with
01:22:20	mnaser	yeah i tried looking everywhere and i couldnt identify a source of how it ended up happening unfortunately
01:22:59	mnaser	it was def not converted because the creation date matched the vm launch date
01:25:20	openstackgerrit	Matt Riedemann proposed openstack/nova master: Default some flavor notification payload fields https://review.openstack.org/529194
01:27:51	mriedem	as for https://bugs.launchpad.net/nova/+bug/1739323 i don't think ill be able to crack that tonight
01:27:52	openstack	Launchpad bug 1739323 in OpenStack Compute (nova) pike "KeyError in host_manager for _get_host_states" [High,Confirmed]
01:28:10	mriedem	should be a simple 'in' check or .get() to handle the key not being in there
01:29:41	mnaser	mriedem: i would have done it but it seemed weird why it was changed so i figured maybe there was a... purpose to the decision
01:30:20	mriedem	not sure, kind of why i wanted bauzas to look at it
02:32:39	openstackgerrit	Jay Pipes proposed openstack/nova master: Remove server group sched filter support caching https://review.openstack.org/529200
02:32:39	openstackgerrit	Jay Pipes proposed openstack/nova master: allow compute nodes to be associated with host agg https://review.openstack.org/526753
02:32:40	openstackgerrit	Jay Pipes proposed openstack/nova master: WIP Support aggregate affinity filters https://review.openstack.org/529201
03:01:10	openstackgerrit	Chen Hanxiao proposed openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441
03:12:41	openstackgerrit	Alex Xu proposed openstack/nova master: Remove extensions module https://review.openstack.org/529206
03:13:20	alex_xu	oomichi: ^ remove extensions module entirely
03:24:10	openstackgerrit	Alex Xu proposed openstack/nova master: Remove the LoadedExtensionInfo object https://review.openstack.org/529207
03:56:07	openstackgerrit	blkart proposed openstack/nova master: Force delete an instance in any vm_state/task_state https://review.openstack.org/529212
04:22:21	openstackgerrit	Alex Xu proposed openstack/nova master: Merge ResourceV21 obj into Resource obj https://review.openstack.org/529217
04:22:22	openstackgerrit	Alex Xu proposed openstack/nova master: Remove the inherits parameter for the Resource object https://review.openstack.org/529218
05:43:32	jichen	mriedem: hi, canyou please help to take a look at https://review.openstack.org/#/c/523387/ ?
06:12:58	openstackgerrit	Chen Hanxiao proposed openstack/nova master: trivial: conf: libvirt: fix a typo https://review.openstack.org/529229
06:16:07	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795
06:38:15	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
06:38:54	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273
06:42:25	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
06:47:08	openstackgerrit	Minho Ban proposed openstack/nova master: prevent removing numa_topology usage info from DB https://review.openstack.org/529236
07:09:49	openstackgerrit	Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type https://review.openstack.org/526900
07:25:45	openstackgerrit	TommyLike proposed openstack/nova master: Remove redundant try/except block when authorize https://review.openstack.org/528991
07:32:14	openstackgerrit	龚肖 proposed openstack/nova master: compute: Catch binding failed exception while init host https://review.openstack.org/529249
07:44:26	openstackgerrit	Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type https://review.openstack.org/526900
07:47:29	openstackgerrit	guanzuoyu proposed openstack/nova-specs master: Fix an spelling error of driver https://review.openstack.org/529251
07:50:54	openstackgerrit	Chen Hanxiao proposed openstack/nova master: InstanceInfo: store more runtime information of instance https://review.openstack.org/526348
07:53:57	openstackgerrit	Marc Koderer proposed openstack/nova master: Enhance error handling for InvalidBDMVolume https://review.openstack.org/529254
07:56:35	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Fix duplicate allocation candidates https://review.openstack.org/528591
08:16:49	openstackgerrit	Minho Ban proposed openstack/nova master: prevent removing numa_topology usage info from DB https://review.openstack.org/529236
08:17:38	maciejjozefczyk	mriedem: jaypipes thanks for https://review.openstack.org/#/c/520024/
08:22:17	openstackgerrit	龚肖 proposed openstack/nova master: compute: Catch binding failed exception while init host https://review.openstack.org/529249
08:57:15	ameeda	can you please review my code here ? https://review.openstack.org/#/c/528069/ also here https://review.openstack.org/#/c/528385/
09:36:10	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls https://review.openstack.org/460243
09:36:11	openstackgerrit	Lee Yarwood proposed openstack/nova master: WIP libvirt: QEMU native LUKS decryption for volumes https://review.openstack.org/523958
09:36:11	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Introduce disk encryption config classes https://review.openstack.org/464008
09:37:02	lyarwood	mdbooth: ^ updated the config class change, also if you have time reviews of the WIP change would be great, some of the code in there is horrid but required to keep prior behaviour
09:38:03	mdbooth	Did gerrit just die?
09:38:08	mdbooth	Was working a second ago
09:38:19	lyarwood	yeah I think so
09:38:30	lyarwood	Didn't think my change was _that_ bad
09:39:28	mdbooth	Hehe
09:39:35	mdbooth	It's really not happy about something, though
09:41:33	openstackgerrit	Chen Hanxiao proposed openstack/nova master: libvirt: implement NotImplementedError for _set_quiesced https://review.openstack.org/529278
09:55:16	danpawlik	Hi, I have small question: I try to run unit tests on newton, and it raises me an error described here: https://bugs.launchpad.net/nova/+bug/1630420 . My question is: should I cherry-pick patch: https://review.openstack.org/#/c/383524/ to newton or add genisoimage to bindeps?
09:55:18	openstack	Launchpad bug 1630420 in OpenStack Compute (nova) "config_drive unit tests (libvirt driver) aren't mocking genisoimage" [Low,Fix released] - Assigned to Diana Clarke (diana-clarke)
09:58:09	openstackgerrit	Daniel Pawlik proposed openstack/nova stable/newton: Patch mkisofs calls https://review.openstack.org/529284
10:01:48	ebbex	mdbooth: I've created an instance with swap, where both root and swap are on rbd, yet there's a big swap file under nova/instances/_base on the compute-node, and according to the nova-compute logs it get's touched about once every minute (which would prevent _remove_old_enough_file from acting upon it). Is any of this intended behaviour?
10:02:48	mdbooth	It's intended behaviour that it exists, although it could be done much better.
10:03:13	mdbooth	We initialise a swap device on the compute host, then copy it to rbd iirc
10:03:32	mdbooth	It's in _base because that's the cache
10:03:48	mdbooth	Caching swap and ephemeral disks is a bug imho
10:04:15	mdbooth	Not sure why it's being touched every minute, though
10:04:19	mdbooth	Any idea what's touching it?
10:07:23	ebbex	2017-12-20T10:06:22.143079+00:00 oscompute01 sudo: nova : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/opt/openstack/nova/venv/bin/nova-rootwrap /opt/openstack/nova/etc/nova/rootwrap.conf touch -c /opt/openstack/nova/instances/_base/swap_16384
10:09:30	mdbooth	ebbex: Ah... IIRC there's a periodic task which touches cache files of active instances to prevent them from being deleted.
10:09:37	mdbooth	But of course that's irrelevant for rbd.
10:09:46	mdbooth	Another reason that rbd should have its own cache...
10:10:15	mdbooth	Also LVM.
10:10:19	mdbooth	And flat
10:10:33	mdbooth	Everything except qcow2, in fact
10:12:52	ebbex	Super, cause the compute-node has about 120gb storage, while ceph has a couple TBs. And I can see this clog up the disk on compute-node after 5-6 created vms.
10:13:39	ebbex	Any idea for a quick fix? Disable the periodic touching perhaps?
10:14:08	mdbooth	ebbex: If you found the relevant periodic task you could disable it if images_type != qcow2
10:14:23	mdbooth	As long as you accompanied it with a sufficiently explanatory comment

Earlier   Later