Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-12-18
15:37:32 openstackgerrit Artom Lifshitz proposed openstack/nova stable/pike: Make request_spec.spec MediumText https://review.openstack.org/528330
15:40:24 openstackgerrit Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487
15:40:30 openstackgerrit Artom Lifshitz proposed openstack/nova stable/ocata: Make request_spec.spec MediumText https://review.openstack.org/528332
15:41:58 openstackgerrit Artom Lifshitz proposed openstack/nova stable/newton: Make request_spec.spec MediumText https://review.openstack.org/528338
15:42:46 openstackgerrit Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775
15:55:10 openstackgerrit Jay Pipes proposed openstack/nova master: allow compute nodes to be associated with host agg https://review.openstack.org/526753
16:09:44 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
16:11:25 jianghuaw leakypipes, bauzas: ^ Please help to check if it has addressed your comments? Thanks.
16:12:56 mdbooth mriedem: I vaguely recall there's some reason we don't use docstrings in tests. Am I imagining things?
16:13:42 mriedem mdbooth: that's no longer an issue
16:13:46 mriedem it was because of limitations with nose
16:13:49 mriedem but we don't use nose
16:14:23 mdbooth mriedem: Ah, ok. Glad I didn't stick a -1 on lyarwood 's patch :) Figured that stuff should be in HACKING anyway if it's to be enforceable.
16:14:38 mdbooth lyarwood: Ignore that one ^^^
16:14:55 leakypipes jianghuaw: +2 from me. :)
16:15:02 bauzas jianghuaw: sorry, today I'm working on implementing the libvirt change, so tomorrow will look
16:15:21 jianghuaw leakypipes, thanks:-)
16:15:40 jianghuaw bauzas, no worries. tomorrow will be very good also. Thanks.
16:15:42 mdbooth leakypipes: Is this now super Monday?
16:15:45 leakypipes jianghuaw: no problem! hope I picked the correct Chinese characters from Google translate in my review comment ;)
16:15:52 leakypipes oh, crap...
16:16:01 mdbooth Hehe
16:16:02 jaypipes thanks mdbooth :)
16:18:09 jianghuaw jaypipes, haha. I was thinking why your Chinese was so good:-)
16:18:39 kashyap Folks using Ubuntu, there's some repo that provides newer packages than the system packages
16:18:42 kashyap What's it called again?
16:18:59 mdbooth jaypipes: https://boingboing.net/2008/07/15/chinese-restaurant-c.html
16:19:24 jaypipes mdbooth: ha! that's awesome
16:20:03 mriedem kashyap: UCA
16:20:05 mriedem ubuntu cloud archive
16:20:34 jaypipes lol
16:37:26 kashyap mriedem: Ah, thank you.
17:03:14 melwitt stephenfin: hey, are you around?
17:03:19 stephenfin I am
17:04:16 melwitt I was just thinking about the xen ci failure on the patch and I realize, TLS is supposed to be disabled by default and you have to opt-in, and I don't think xen ci is doing anything to opt in. so I'm not sure yet why it's going through that path
17:05:30 melwitt so something is probably wrong there if it's going through the TLS path without being enabled. I'm still looking at it but just wanted to bring it up
17:05:40 stephenfin Yeah, I saw that comment on Thursday. I don't know what it is either
17:05:54 melwitt like, if they didn't enable it, their CI should be passing :\
17:06:06 stephenfin I know sross has some tests merged to DevStack way back related to this, but I don't know how that could possibly trigger it
17:06:27 stephenfin Agreed
17:06:56 stephenfin melwitt: I've been working on the PCI-NUMA policy code all day, but soon as that's done I'll take a look at that and see if I can suss it out
17:08:11 melwitt yeah I'm not yet sure. in devstack you're supposed to have to use NOVA_CONSOLE_PROXY_COMPUTE_TLS=True to turn on TLS, which I have done in a DNM patch dependent on the devstack change https://review.openstack.org/#/c/513160
17:08:41 melwitt okay, cool. I'll look at it some more too
17:20:56 melwitt stephenfin: I think I see what it is, left a comment on the patch. I don't know what to do about it though, I'd want to ask danpb
17:22:31 melwitt or sross/someone who knew how they wanted this to work
17:30:55 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add PCI NUMA policy fields https://review.openstack.org/527470
17:30:56 openstackgerrit Stephen Finucane proposed openstack/nova master: Add PCI NUMA policies https://review.openstack.org/527472
17:30:57 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Modify signature of _filter_non_requested_pfs https://review.openstack.org/527473
17:31:03 stephenfin jaypipes: Ta-da! ^
17:31:14 jaypipes stephenfin: cool, will look in a bit.
17:31:48 stephenfin jaypipes: Cheers :) I think that should satisfy most things. Only odd condition I had was what happened when two similar aliases requested different NUMA policies. I ruled that out as daft
17:32:01 stephenfin and now I've to run home. Ciao o/
17:32:06 jaypipes ciao
17:37:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459
17:37:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297
17:55:26 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.57 microversion https://review.openstack.org/528128
18:00:43 openstackgerrit Jay Pipes proposed openstack/nova master: allow compute nodes to be associated with host agg https://review.openstack.org/526753
18:06:46 cdent that's not what makes you evil mriedem
18:07:11 mriedem |..|_
18:13:34 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.57 microversion https://review.openstack.org/528128
18:26:31 jaypipes mriedem: how exactly can an instance group (server group) have >1 policy? :(
18:27:05 mriedem can't
18:27:29 mriedem https://review.openstack.org/#/c/415482/
18:27:35 jaypipes mriedem: then why is objects.InstanceGroup.policies a ListOfStringsField?
18:27:40 mriedem ^
18:27:43 mriedem "legacy reasons"
18:27:47 jaypipes uhg
18:27:49 jaypipes k
18:29:06 mriedem nice, we also have a separate dedicated table for the policies
18:29:13 mriedem instance_group_policy
18:29:41 jaypipes I know... it's just... sigh...
18:30:02 mriedem we can microversion that out of the api
18:30:14 mriedem and redo things in the data model if we actually cared
18:31:05 mriedem looking at the old wiki for the bp https://wiki.openstack.org/wiki/InstanceGroupApiExtension#API
18:31:14 mriedem it sounds like multiple policies was by design
18:31:23 mriedem for affinity and QoS, as examples
18:35:37 jaypipes mriedem: I'm just trying to get this stuff hacked up and working for Ironic...
18:35:52 jaypipes mriedem: the real solution (distances and stuff like that) probably won't look like this.
18:36:02 jaypipes mriedem: because I hate the server group functionality to begin with.
18:36:14 mriedem i know, i've seen the tatto
18:36:16 mriedem *tatoo
18:36:21 jaypipes attoo? :)
18:36:26 jaypipes tattoo? :)
18:36:27 mriedem no
18:36:38 mriedem i've given up on trying to ever spell it correctly
18:36:42 jaypipes lol
18:36:44 mriedem so now it's just whatever the last thing i said
18:42:16 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: sort parameters for limits, quotas and quota classes https://review.openstack.org/528786
18:44:47 jaypipes mriedem: where is the latest microversion for the compute API found?
18:45:06 jaypipes mriedem: in placement, it's a constant in the nova/api/openstack/placement/microversion.py file.
18:47:06 artom jaypipes, nova/api/openstack/api_version_request.py has _MAX_API_VERSION
18:47:14 jaypipes artom: ty sir!
19:02:15 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM driver: ovs vif https://review.openstack.org/422512
19:22:31 openstackgerrit Chris Dent proposed openstack/nova master: Remove microversion fallback code from report client https://review.openstack.org/528794
19:25:14 cdent that ^ may have some holes
19:30:50 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
19:43:15 kumarmn Could these changes by mriedem get merged? https://review.openstack.org/#/c/527228/ and https://review.openstack.org/#/c/527468/
19:43:31 kumarmn They are holding me from tagging trove for queens-2.
19:43:56 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Make request_spec.spec MediumText https://review.openstack.org/528332
19:44:34 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Make request_spec.spec MediumText https://review.openstack.org/528338

Earlier   Later