| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-18 | |||
| 10:15:14 | lyarwood | only* | |
| 10:59:51 | openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: don't call sync_guest_time if qga is not enabled https://review.openstack.org/524836 | |
| 11:54:24 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination https://review.openstack.org/528601 | |
| 12:22:30 | openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | |
| 12:42:43 | openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | |
| 12:59:30 | openstackgerrit | sahid proposed openstack/nova master: libvirt: disconnect volume from host during detach https://review.openstack.org/515008 | |
| 13:13:59 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Test making column Text -> MediumText without migration https://review.openstack.org/528712 | |
| 13:40:18 | leakypipes | edleafe: mornin. we doing a scheduler meeting today? | |
| 13:41:02 | cdent | leakypipes: do you want one, or are you more about trying to manage your schedule? | |
| 13:41:14 | leakypipes | cdent: more managing my schedule | |
| 13:41:24 | leakypipes | cdent: and just curious who's here :) | |
| 13:41:29 | leakypipes | cdent: and good morning sir | |
| 13:41:38 | cdent | mawrnin' | |
| 13:43:02 | cdent | I am basically here, but still have not shed my cold. | |
| 13:46:02 | bauzas | cdent: leakypipes: honestly, I'm working on implementing the VGPU change, so only if needed, I'd prefer to work | |
| 13:46:17 | leakypipes | ack | |
| 13:46:39 | bauzas | shit for libvirt btw | |
| 13:47:15 | bauzas | cdent: <3 | |
| 13:48:08 | cdent | this is what I'm going to do henceforth: hang out in irc and pass people nice stuff. | |
| 13:52:20 | bauzas | cdent: thanks for the hot cocoa https://photos.app.goo.gl/qLBp2ZnFcJc2pvAp2 | |
| 13:58:15 | edleafe | leakypipes: yes, this is the last meeting of the year | |
| 13:58:26 | edleafe | and plug your leak | |
| 13:58:51 | stephenfin | bauzas, leakypipes: I've a question on the PCI NUMA policies spec for the two of you | |
| 13:59:09 | bauzas | ack | |
| 13:59:20 | leakypipes | stephenfin: yes>? | |
| 13:59:29 | stephenfin | Per leakypipes' comments, I've been moving the storing of the resulting policy to the InstancePCIRequests object | |
| 13:59:52 | alex_xu | leakypipes: morning, do we still need a separate microversionf or the traits parameter in allocationcandidates, or Eric's granular request's patch will cover that? | |
| 14:00:17 | stephenfin | But that's thrown up a question cfriesen had asked me previously - should we be doing this policy configuration on an instance-level basis or on a PCI request-level basis? | |
| 14:00:59 | leakypipes | stephenfin: probably instance-level (i.e. the RequestSpec) | |
| 14:01:08 | leakypipes | alex_xu: scheduler meeting... discuss in there? | |
| 14:01:21 | alex_xu | leakypipes: ok, got it | |
| 14:02:02 | leakypipes | stephenfin: unless the policy knob can be toggled per-device, then of course it would be more appropriate to live in InstancePCIRequest I think. thoughts? | |
| 14:02:30 | stephenfin | leakypipes: I've been avoiding that solely because it involves a lot of rewiring. We don't use RequestSpec objects on any of the code paths where we do NUMA'y scheduling | |
| 14:02:47 | stephenfin | That was cfriesen's suggestion, yes | |
| 14:03:08 | leakypipes | ack | |
| 14:03:18 | leakypipes | stephenfin: InstancePCIRequest it is then. :) | |
| 14:03:29 | leakypipes | stephenfin: it won't *hurt* to put them in there. | |
| 14:04:30 | stephenfin | leakypipes: So that would suggest we don't use flavour extra specs + image metadata, and instead extend '[pci] aliases' to allow for a 'numa_policy' field, right? | |
| 14:05:42 | leakypipes | stephenfin: unfortunately, since that is how PCI device requests are constructed. :( | |
| 14:06:45 | stephenfin | leakypipes: Yeah, that thing is ugly as sin. Cool, I'll rework this as appropriate so and fix up the spec to reflect reality | |
| 14:09:06 | leakypipes | stephenfin: danke | |
| 14:34:32 | bauzas | leakypipes: crazy problem, since libvirt allows the possibility to create mediated devices on the fly and just assign them, I need to introspect all the mediated devices we have and see whether they are assigned to a guest | |
| 14:34:55 | bauzas | leakypipes: in theory, a magical libvirt API would just tell me if it's assigned or not, but that's not existing | |
| 14:35:27 | bauzas | leakypipes: so the only way I found would be to loop over all the instances and see their XML | |
| 14:36:03 | bauzas | leakypipes: worst case scenario, one created mdev and 10K instances on a host, you can imagine the performance to find which guest is assigned to that mdev | |
| 14:36:30 | bauzas | leakypipes: so, tbh, the only reasonable way I see is to persist the guest assignment information we do in nova | |
| 14:37:09 | bauzas | and consider that if for some specific mdev, we don't have the assignment in the Nova DB, then it means it's free to be allocated | |
| 14:37:09 | ildikov | mriedem: hi | |
| 14:37:26 | bauzas | leakypipes: but you see my point, it would require some persistence model... | |
| 14:37:38 | ildikov | mriedem: IIRC you were pointing me at some point to a review that added some locking similar to what I will need to add for multi-attach | |
| 14:37:40 | bauzas | thoughts on that ? | |
| 14:38:18 | ildikov | mriedem: in case it really is a memory and not a dream and you know what I'm talking about it would be great if you could point me to that one again :) | |
| 14:39:48 | ebbex | mdbooth: nova/virt/libvirt/imagecache.py function "_scan_base_images", should that have changes/deprecations in pike? | |
| 14:40:02 | mriedem | ildikov: i think that's pseudocode in the multiattach spec | |
| 14:40:07 | bauzas | leakypipes: wait, I think about a possible way to hack that without needing to persist that | |
| 14:40:17 | mdbooth | ebbex: Yep, but mriedem wanted changes and I never followed it up. | |
| 14:40:30 | mdbooth | ebbex: Lemme dig out the review, maybe you have time | |
| 14:40:44 | ildikov | mriedem: oh, ok, I will re-read that one again then :) | |
| 14:40:47 | bauzas | leakypipes: if we have a config opt that says "here are my already created mdevs", nova can use it and assume all of them as free | |
| 14:42:04 | mdbooth | ebbex: https://review.openstack.org/#/c/423392/ | |
| 14:42:28 | ebbex | mdbooth: Cool, I'll have a look, thanks | |
| 14:43:03 | mdbooth | ebbex: If you want to fix it up just go ahead, btw. No need to ask again. | |
| 14:46:12 | mriedem | artom: are you adding the upgrade reno to https://review.openstack.org/#/c/528330/ or would you like me to wordsmith that? | |
| 14:47:18 | artom | mriedem, yeah - question though about the migration being optional in the pike backport | |
| 14:47:50 | mriedem | artom: i think it's fine | |
| 14:47:53 | mriedem | we've done this before | |
| 14:47:53 | artom | mriedem, so I've pushed https://review.openstack.org/#/c/528712/ to test it | |
| 14:48:03 | artom | mriedem, ok, I just wanted to be sure | |
| 14:48:13 | artom | Dropping kids off at daycare, back in a bit | |
| 14:51:07 | stephenfin | bauzas: That sounds like something that could be libvirt really should have. If it's not present, could we do something with libvirt and carry the change locally til nova libvirt version > libvirt version with your fix? | |
| 14:51:35 | bauzas | stephenfin: WDYM ? | |
| 14:51:48 | bauzas | hacking it with a TODO ? | |
| 14:52:24 | stephenfin | bauzas: Aye. Figure out if it's something we could do with libvirt internals and propose the change upstream if possible | |
| 14:52:38 | bauzas | I dunno | |
| 14:52:47 | bauzas | lemme write something and we'll discuss | |
| 14:52:53 | stephenfin | Neither do I. Just as a suggestion | |
| 14:53:05 | stephenfin | Given that I imagine other people would benefit if libvirt had it too | |
| 15:07:31 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Make request_spec.spec MediumText https://review.openstack.org/528330 | |
| 15:07:34 | mriedem | artom: added the release note to the pike backport | |
| 15:07:36 | mriedem | lyarwood: ^ | |
| 15:11:14 | leakypipes | bauzas: sorry, went for breakfast... reading back now | |
| 15:11:40 | bauzas | leakypipes: no worries, just trying a way to not have a huuuuuuge tech debt because $libvirt | |
| 15:11:57 | bauzas | leakypipes: maybe a hangout would be cool for discussing | |
| 15:11:59 | leakypipes | bauzas: ack. | |
| 15:12:09 | leakypipes | bauzas: gimme about 10 minutes and I can do that, sure | |
| 15:12:30 | bauzas | leakypipes: I'll need to get my girls in 15 but we can discuss that later | |
| 15:12:35 | leakypipes | np | |
| 15:13:11 | bauzas | or prozac | |
| 15:13:22 | leakypipes | lol :) | |
| 15:13:36 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Make request_spec.spec MediumText https://review.openstack.org/528332 | |
| 15:18:22 | openstackgerrit | Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363 | |
| 15:18:22 | openstackgerrit | Matthew Booth proposed openstack/nova master: Expose driver_block_device fields as attributes https://review.openstack.org/528362 | |
| 15:18:39 | mdbooth | lyarwood: That second one ^^^^ | |
| 15:21:10 | mdbooth | lyarwood: It's a bit disruptive in tests, but amongst its advantages is that it will expose both attachment_id and connection_info without further changes. | |
| 15:21:25 | mdbooth | (Also bdm.uuid, which is what I want it for) | |
| 15:23:52 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Make request_spec.spec MediumText https://review.openstack.org/528338 | |
| 15:24:48 | artom | mriedem, ah, thanks | |
| 15:25:34 | artom | mriedem, and https://review.openstack.org/#/c/528712/ passed Zuul, so I think we're good, yeah | |
| 15:26:57 | mriedem | ok i've got the ocata and newton ones updated too | |
| 15:27:49 | openstackgerrit | Mr Rambo proposed openstack/nova master: Fix the problems that volume-backed server rebuild https://review.openstack.org/528740 | |