Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-12-14
02:10:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326
02:10:26 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326
02:14:34 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326
02:19:34 yikun mriedem, another typo fix, so, I update again...now I think it's a final one, ╮(╯▽╰)╭
02:20:13 Kevin_Zheng https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L391 are we ever going to set this to False?
02:24:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Retry _trait_sync on deadlock https://review.openstack.org/527836
02:28:02 mriedem Kevin_Zheng: we can, but it has to be on a microversion
02:28:21 Kevin_Zheng Yeah, thats what I thought
02:29:04 gmann i feel if we do then we can do all together for query things of all APIs
02:30:12 mriedem yikun: got it, thanks
02:30:27 Kevin_Zheng Yeah, so maybe we should add them to all APIs first :)
02:30:34 Kevin_Zheng still alot missing?
02:30:59 mriedem Kevin_Zheng: there is a blacklist of filters that we don't allow
02:31:11 Kevin_Zheng yeah, I know
02:31:35 Kevin_Zheng Just curious :)
02:31:39 mriedem https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L295
02:31:45 mriedem because those will 500
02:33:22 mriedem and this https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L187
02:33:30 mriedem if you try filtering on private properties in the data model
02:38:49 mriedem yikun: looks like http://logs.openstack.org/26/326326/48/check/openstack-tox-functional/496db26/testr_results.html.gz is failing
02:39:01 mriedem i'm guessing it's using an older server create sample which has personality files in it?
02:39:07 Kevin_Zheng https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L186
02:39:25 Kevin_Zheng ^ JOINED_TABLE_QUERY_PARAMS_SERVERS also return 400
02:39:30 Kevin_Zheng not 500
02:39:45 gmann mriedem: is this looks fine now (server whitelist doc) - https://review.openstack.org/#/c/527042/3
02:39:47 mriedem Kevin_Zheng: right, i mean,
02:39:53 mriedem before that blacklist, those would be a 500
02:40:03 Kevin_Zheng Ah ok
02:55:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete https://review.openstack.org/525231
03:15:05 yikun mriedem, a bit confusing, we set version=2.58 (https://review.openstack.org/#/c/326326/48/nova/tests/functional/api_sample_tests/test_instance_actions.py@137), why call 2.1 API?
03:16:27 mriedem yikun: it's calling with 2.58
03:16:34 mriedem but using a 2.1 sample i think
03:16:39 Kevin_Zheng yeah
03:16:41 mriedem and the 2.1 sample has 'personality' files in it,
03:16:45 mriedem which aren't supported past 2.57
03:17:04 Kevin_Zheng _post_server() reads old samples by default
03:17:15 mriedem i think it's sending this https://github.com/openstack/nova/blob/master/doc/api_samples/servers/server-create-req.json#L13
03:17:30 mriedem yikun: you need it to send this request https://github.com/openstack/nova/blob/master/doc/api_samples/servers/v2.57/server-create-req.json
03:17:45 mriedem is there a parameter in _post_server() to override the sample to use?
03:18:48 mriedem i think it might not work if you override it though if you don't have a server-create-req.json sample in the 2.57 directory
03:18:49 mriedem you'd have to try it
03:19:02 mriedem otherwise, there is an easier way
03:19:10 mriedem don't use a sample to create the server
03:19:17 mriedem just use self.api.post_server(...)
03:19:41 mriedem https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L271
03:19:50 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042
03:19:57 Kevin_Zheng just set use_common_server_api_samples to false
03:20:38 mriedem you can build the request using https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L140
03:20:40 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042
03:20:54 mriedem i think use_common_server_api_samples=False might make it look in the 2.57 directory for the sample
03:20:55 mriedem not sure
03:21:41 Kevin_Zheng yeah, have to add a new sample file
03:27:03 gmann mriedem: yikun : if use_common_server_api_samples=False, it will use 'cls.sample_dir + /microversion' to find sample files. which is all set in https://review.openstack.org/#/c/326326/48/nova/tests/functional/api_sample_tests/test_instance_actions.py@137
03:27:25 gmann but you need to put server req and res sample in that dir
03:27:37 openstackgerrit Dai Dang Van proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/267587
03:27:38 yikun yes, use_common_server_api_samples=False look in the dir 2.58. :), and not found if we don't add it
03:27:54 mriedem yeah that's why i'm saying,
03:27:54 gmann current logic does not fallback to previous version directory, it has to be present in all directory you want to tests
03:27:57 mriedem don't use a sample,
03:28:00 mriedem just create the server directly
03:28:06 mriedem https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L271
03:28:09 mriedem https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L140
03:28:19 mriedem the test only cares about the actions, not how the server is created
03:28:28 gmann yea, +1
03:28:34 yikun yea, got it
03:28:37 mriedem can i get a hell yeah?!
03:29:15 Kevin_Zheng everyday is a long day for mriedem
03:31:22 openstackgerrit Matthew Oliver proposed openstack/nova master: Update the obs placement-api port https://review.openstack.org/527846
04:02:48 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
05:31:46 openstackgerrit zhufl proposed openstack/nova master: Fix some typos in nova doc https://review.openstack.org/527856
06:55:23 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Updated common create server sample request because of microversion 2.57 https://review.openstack.org/527878
06:57:07 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Updated common create server sample request because of microversion 2.57 https://review.openstack.org/527878
07:10:18 openstackgerrit Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
07:32:54 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795
07:42:18 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326
07:44:22 openstackgerrit Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
07:59:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
08:01:41 openstackgerrit Chason Chan proposed openstack/nova master: Fix the bug report link of API Guide https://review.openstack.org/527660
09:00:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (2) https://review.openstack.org/526263
09:00:54 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (3) https://review.openstack.org/526557
09:17:53 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post https://review.openstack.org/526823
09:30:11 openstackgerrit Dai Dang Van proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047
09:36:00 openstackgerrit Ya Lian Pan proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
10:01:09 openstackgerrit Matthew Booth proposed openstack/nova master: Improve error message on invalid BDM fields https://review.openstack.org/527915
10:02:28 openstackgerrit Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346
10:02:28 openstackgerrit Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167
10:02:29 openstackgerrit Matthew Booth proposed openstack/nova master: Use real block_device_info data in test_blockinfo https://review.openstack.org/527916
10:02:29 openstackgerrit Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347
10:16:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix possible TypeError in VIF.fixed_ips https://review.openstack.org/527920
10:21:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119
10:21:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617
10:21:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380
10:21:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982
10:21:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633
10:21:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407
10:21:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189
10:21:23 openstackgerrit Balazs Gibizer proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737
10:21:23 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409
10:23:41 gibi jaypipes: ^^ rebased the series as master already has the fix for the frequently failing functional test that prevented these to be merged
10:26:48 openstackgerrit rahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique This happens when 'Others' field is occuring more than once which is not handled in code causing multiple columns having same name. Which throws above exception and does not pretty prints absolute https://review.openstack.org/527922

Earlier   Later