| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-06 | |||
| 21:29:07 | ildikov | mriedem: cool, tnx | |
| 21:29:20 | ildikov | mriedem: replied to your comments | |
| 21:30:51 | ildikov | mriedem: as we're adding a new API microversion I think we can land this and deal with the new Cinder microversion in the multi-attach change | |
| 21:31:20 | ildikov | mriedem: as we will need to do some extra checks for that anyway therefore we might as well add the new Cinder microversion to that one | |
| 21:31:39 | mriedem | i tend to agree, | |
| 21:31:47 | ildikov | mriedem: we can do a version check now independently from the attachment_create call so that's not an issue either | |
| 21:31:51 | mriedem | especially since the point of microversions is that the client can opt into whatever they want when it's available (or not) | |
| 21:31:54 | mriedem | and in this case, nova is the client | |
| 21:32:21 | mriedem | so we just won't support a multiattach volume to >1 instance if the new cinder microversion for shared_targets isn't htere | |
| 21:32:26 | mriedem | because we won't be able to safely detach | |
| 21:32:32 | ildikov | yeah, true, I just wanted to avoid the check_attach-like checks as much as possible, but the API microversion in Nova will require that anyway | |
| 21:32:55 | ildikov | yep | |
| 21:33:03 | mriedem | well, the compute microversoin is mainly just a signal | |
| 21:33:24 | ildikov | I mean the Nova API microversion | |
| 21:33:25 | mriedem | 'i want to attach this multiattach volume to >1 instance and i'm opting into that, but i know it might not work too' | |
| 21:34:00 | mriedem | might not work b/c (1) old cinder (2) old computes (3) policy (4) virt driver doesn't support it (5) volume type doens't support it, etc | |
| 21:34:17 | mriedem | (6) uranus is not aligned with pluto | |
| 21:34:37 | ildikov | yeah, if Cinder is mid-old then they will not be able to create a multi-attach volume on the first place | |
| 21:34:45 | ildikov | lol | |
| 21:34:55 | ildikov | I hope I | |
| 21:35:06 | ildikov | 'll never need to debug (6) :) | |
| 21:36:35 | ildikov | anyway, so if we don't want to hold the new attach patch now we can just check whether the volume is already attached and continue if the Cinder microversion is high enough | |
| 21:38:43 | ildikov | however the new flow currently doesn't allow multi-attach in general so we might not need that check | |
| 21:39:27 | ildikov | I need to think about it, but the point is still that I think we all had enough of this patch by now... | |
| 21:41:04 | mriedem | incoming | |
| 21:41:35 | mriedem | or not | |
| 21:41:39 | mriedem | anyway, new patches are up | |
| 21:41:42 | mriedem | https://review.openstack.org/#/c/330285/174/releasenotes/notes/bp-cinder-new-attach-apis-eca854e27a255e3e.yaml is the reno i added | |
| 21:43:21 | ildikov | mriedem: looks good to me | |
| 21:43:43 | ildikov | not that I would've worded anything so far good enough to judge, but still :) | |
| 21:45:15 | mriedem | +2 on the new attach flow patch | |
| 21:45:41 | mriedem | i think johnthetubaguy is on paternity leave | |
| 21:45:51 | mriedem | so we'll likely need gibi and/or melwitt to go through this | |
| 21:46:09 | ildikov | mriedem: wow, we haven't even reach 200... :) | |
| 21:46:38 | edleafe | so it looks like I need to rebase my series. Will that kill the patches that are in the gate? | |
| 21:46:49 | mriedem | edleafe: i can re-approve | |
| 21:47:08 | ildikov | mriedem: gibi is familiar with the patch, but he might not familiar with the whole Cinder-side new flow to +A this | |
| 21:47:33 | mriedem | ildikov: i don't think anyone from nova besides john will be | |
| 21:47:43 | ildikov | mriedem: can check with him tomorrow or look at melwitt with cat eyes from Shrek :) | |
| 21:48:03 | ildikov | mriedem: I know, I'm here if anyone wants to ask questions | |
| 21:48:18 | mriedem | at this point i think i can answer any questions on the nova patches | |
| 21:48:26 | edleafe | mriedem: sure, but won't that mean restarting the whole CI process? They are mostly through the gate now. | |
| 21:48:33 | mriedem | edleafe: yes if they are rebased | |
| 21:49:19 | edleafe | ok, then I'll wait | |
| 21:50:13 | ildikov | mriedem: if I could have just 1/10 of your brain :) | |
| 21:55:32 | melwitt | ildikov: if gibi is already familiar with the patch, check with him first. if he won't be able to look, let me know and I'll look at it | |
| 21:55:54 | mriedem | melwitt: the bottom 2 patches in the series are non-destructive. | |
| 21:56:07 | mriedem | i.e. they lay some groundwork but aren't run through until the 3rd in the series | |
| 21:56:09 | mriedem | turns it all on | |
| 21:56:38 | mriedem | the first patch is a straight up simple refactor, no functional change | |
| 21:56:50 | melwitt | ah, okay | |
| 21:56:59 | ildikov | melwitt: I will check with him tomorrow on the Implement new attach Cinder flow patch | |
| 21:57:28 | ildikov | melwitt: if you can look into the two under it that mriedem mentioned that would be pretty great | |
| 21:57:51 | melwitt | k, can do | |
| 21:59:18 | melwitt | grrr something weird is going on in the api sample tests I'm trying to do for noop quotas. when I set the noop driver in a derived test class, it seems to leak into the parent class tests where I didn't set it | |
| 22:01:47 | ildikov | melwitt: I had that with a mocked value earlier... | |
| 22:02:21 | ildikov | not 100% sure on the reason still, setting up the mock in a different way helped there | |
| 22:35:06 | _ix | Hello again. I'm having some trouble creating a larger node on my new pike deployment. | |
| 22:35:53 | _ix | Any tips on where I ought to look to get around this dreadful 'No valid host was found. There are not enough hosts available' error? | |
| 22:36:43 | _ix | It's a 10vcpu 112gb 20gb root and 3000gb machine. I've definitely got the resources. | |
| 22:36:45 | efried | _ix The compute log is where I would start. | |
| 22:37:05 | _ix | The request doesn't seem to be making it to the compute log. | |
| 22:37:25 | efried | okay, have you checked the sched or conductor logs? | |
| 22:37:48 | melwitt | in that case, I suggest turning on log level debug on the scheduler node, restart scheduler, try it again and check the scheduler log to see which filter is blocking the request out | |
| 22:38:28 | _ix | Thanks. I'll give that a shot. | |
| 22:48:07 | _ix | I'm trying to force the build on a single host... but it says it can't find it. | |
| 22:49:38 | openstackgerrit | Eric Fried proposed openstack/nova master: Move aggregates from report client to ProviderTree https://review.openstack.org/521685 | |
| 22:49:38 | openstackgerrit | Eric Fried proposed openstack/nova master: Traits ops on ProviderTree https://review.openstack.org/521605 | |
| 22:49:39 | openstackgerrit | Eric Fried proposed openstack/nova master: Aggregate ops on ProviderTree https://review.openstack.org/526216 | |
| 22:49:39 | openstackgerrit | Eric Fried proposed openstack/nova master: Track provider traits in report client https://review.openstack.org/521686 | |
| 22:52:07 | _ix | I'll keep plugging away at this. Thanks again for the suggestions. | |
| 23:00:56 | melwitt | _ix: how are you forcing to a host? like this? https://ask.openstack.org/en/question/47877/how-to-launch-an-instance-on-specific-host/ | |
| 23:01:39 | _ix | Just like that, only with the openstack server create instead. | |
| 23:01:48 | _ix | I found my issue. It's me. It's always me. | |
| 23:02:53 | mriedem | yikun: you might consider splitting the DB API and object changes out of this https://review.openstack.org/#/c/326326/ into a separate patch so the patch with the API changes is not so big | |
| 23:02:59 | melwitt | _ix: okay. I was just gonna say that doing that bypasses the scheduler so the scheduler log might not show much if anything | |
| 23:05:43 | _ix | Haven't looked into this just yet... A CPU model name should not be set when a host CPU model is requested | |
| 23:05:53 | _ix | Oh well, I've got to detach for a few. Have a pleasant day! | |
| 23:17:29 | openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | |
| #openstack-nova - 2017-12-07 | |||
| 00:02:22 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the order of target host checks https://review.openstack.org/526225 | |
| 00:06:24 | openstackgerrit | Merged openstack/nova master: Add PowerVM to compute_driver options https://review.openstack.org/523978 | |
| 00:20:35 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Deduplicate functional test code https://review.openstack.org/526227 | |
| 00:27:33 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete https://review.openstack.org/525231 | |
| 01:46:26 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | |
| 02:13:03 | openstackgerrit | suzhengwei proposed openstack/nova master: send a regular notification when locked flag changing https://review.openstack.org/526251 | |
| 02:16:10 | openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | |
| 02:20:06 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 02:20:07 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 02:20:07 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | |
| 02:32:53 | openstackgerrit | suzhengwei proposed openstack/nova master: send a regular notification when locked flag changing https://review.openstack.org/526251 | |
| 02:56:45 | openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | |
| 02:57:36 | openstackgerrit | suzhengwei proposed openstack/nova master: send a regular notification when locked flag changing https://review.openstack.org/526251 | |
| 03:01:15 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Deprecate API extensions policies https://review.openstack.org/526258 | |
| 03:19:11 | alex_xu | jaypipes: efried have you guys discussed the 'tree=in:[uuid]' in the rest api? | |
| 03:27:56 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Deprecate API extensions policies https://review.openstack.org/526258 | |
| 03:39:14 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | |
| 03:44:08 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for backup instances https://review.openstack.org/523676 | |
| 03:54:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (2) https://review.openstack.org/526263 | |
| 04:03:06 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in delete (2) https://review.openstack.org/526263 | |
| 04:06:18 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Deprecate API extensions policies https://review.openstack.org/526258 | |