| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-01 | |||
| 14:46:27 | fried_rice | coo | |
| 14:46:52 | fried_rice | cdent And this series: https://review.openstack.org/#/c/523932/ | |
| 14:47:11 | openstackgerrit | Jay Pipes proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119 | |
| 14:47:12 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617 | |
| 14:47:12 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | |
| 14:47:13 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | |
| 14:47:13 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | |
| 14:47:14 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add aggregates check in allocation canditates https://review.openstack.org/522407 | |
| 14:47:14 | openstackgerrit | Jay Pipes proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189 | |
| 14:47:15 | openstackgerrit | Jay Pipes proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409 | |
| 14:47:15 | openstackgerrit | Jay Pipes proposed openstack/nova master: Add functional test for get_all_with_shared() https://review.openstack.org/522408 | |
| 14:47:16 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737 | |
| 14:47:54 | cdent | fried_rice: that’ll get covered with the n-r-p topic | |
| 14:48:00 | fried_rice | ight | |
| 14:48:18 | leakypipes | fried_rice, giblet, superdan, mriedem: ok, series starting at https://review.openstack.org/#/c/517119/ is rebased and ready for reviews (mostly new func tests for alloc candidate permutations) | |
| 14:48:28 | fried_rice | leakypipes ack | |
| 14:49:05 | mriedem | i have to spend quality time with https://review.openstack.org/#/c/330285/ this morning | |
| 14:50:53 | leakypipes | hehe | |
| 14:51:19 | leakypipes | coffee_cat: why? it's only on revision 165... that's not even a middle-aged patch. | |
| 14:51:41 | coffee_cat | leakypipes: if you happen to have time while Zuul is chewing on all of those above you could chime in too :) | |
| 14:51:50 | mriedem | guh, MOS bugs from mitaka https://bugs.launchpad.net/nova/+bug/1735407 | |
| 14:51:51 | openstack | Launchpad bug 1735407 in Mirantis OpenStack 9.x "[Nova] Evacuation doesn't respect anti-affinity rules" [High,New] - Assigned to Oleksiy Molchanov (omolchanov) | |
| 14:51:54 | leakypipes | coffee_cat: yeah, I have it open :) | |
| 14:52:02 | coffee_cat | leakypipes: yeah, I appreciate all the time I can spend rebasing it :) | |
| 14:52:14 | mriedem | i think at this point, any MOS bugs from mitaka can just be marked invalid with "can you recreate on master?" | |
| 14:52:32 | coffee_cat | leakypipes: sweet, I can see I will not be bored over the weekend :) | |
| 14:52:43 | leakypipes | mriedem: "can you recreated with Triple-O please?" | |
| 14:53:05 | mriedem | actually this is a latent bug | |
| 14:53:22 | mriedem | since you can't evacuate more than one instance in the same request, | |
| 14:53:27 | mriedem | and they are using the anti-affinity policy, | |
| 14:53:32 | mriedem | which relies on the late affinity check on the compute, | |
| 14:53:37 | mriedem | and even if that fails, we don't reschedule an evacuate | |
| 14:53:40 | mriedem | so :( | |
| 14:54:19 | leakypipes | fun | |
| 14:54:21 | giblet | mriedem: I think there is no late check for rebuild just for boot | |
| 14:54:30 | mriedem | giblet: ah, ok, | |
| 14:54:32 | mriedem | well in this case, | |
| 14:54:49 | mriedem | if they spread out the evacuates, it works - because they give time for the computes to send instance info updates back to the scheduler | |
| 14:55:00 | mriedem | which reminds me, | |
| 14:55:15 | mriedem | there is a CLI in novaclient which just gets all instances from a given host and evacuates them in a for loop right superdan? | |
| 14:55:25 | superdan | yeah | |
| 14:55:35 | mriedem | if those instances were in a server group policy, we are likely destroying those | |
| 14:57:32 | giblet | without the late check we break the group policy, with the late check even nova doesn't reschedule we at least fail the evac instead of breaking the policy | |
| 14:57:43 | giblet | that is already better | |
| 14:58:05 | giblet | of course it would be nice to reschedule | |
| 14:59:32 | mriedem | https://bugs.launchpad.net/mos/+bug/1735407/comments/3 | |
| 14:59:34 | openstack | Launchpad bug 1735407 in Mirantis OpenStack 9.x "[Nova] Evacuation doesn't respect anti-affinity rules" [High,New] - Assigned to Oleksiy Molchanov (omolchanov) | |
| 14:59:37 | mriedem | my analysis | |
| 14:59:50 | mriedem | i don't really want to add a reschedule loop for evacuate | |
| 15:00:20 | mriedem | long-term we model affinity in placement and use that, but i'm not entirely sure that will fix this case either | |
| 15:00:31 | leakypipes | mriedem: ++ | |
| 15:00:48 | giblet | mriedem: +1 for your analysis | |
| 15:01:01 | giblet | mriedem: can we just add the post check without reschedule? | |
| 15:02:01 | mriedem | well i guess the affinity stuff in placement would mean we somehow 'claim' that the instance we're scheduling / evacuating is going to be on some target host, | |
| 15:02:10 | mriedem | so a concurrent request gets that information when asking placement where it should go | |
| 15:02:18 | mriedem | not sure how that is all going to work out | |
| 15:02:23 | mriedem | since we don't want to model server group policies in placement | |
| 15:05:30 | mriedem | giblet: https://bugs.launchpad.net/mos/+bug/1735407/comments/4 | |
| 15:05:31 | openstack | Launchpad bug 1735407 in Mirantis OpenStack 9.x "[Nova] Evacuation doesn't respect anti-affinity rules" [High,New] - Assigned to Oleksiy Molchanov (omolchanov) | |
| 15:05:49 | mriedem | giblet: doing the late check might be reasonable | |
| 15:05:56 | mriedem | fail the evacuate, so the user can retry | |
| 15:06:55 | giblet | I vote for option 1) now and maybe consider prioritizing affinity impl with Placement in the future | |
| 15:07:52 | giblet | mriedem: I have to run soon but I have already looked into adding such late check before so I can take this bug if it can wait until Monday | |
| 15:08:03 | mriedem | sure | |
| 15:08:25 | mriedem | assigned to you | |
| 15:08:45 | giblet | cool, thanks | |
| 15:09:51 | mriedem | superdan: here is belmiro's build request cellsv1 bug https://bugs.launchpad.net/nova/+bug/1735353 | |
| 15:09:52 | openstack | Launchpad bug 1735353 in OpenStack Compute (nova) "build_request not deleted when using cellsV1 and local nova_api DB" [Undecided,New] | |
| 15:16:43 | mriedem | cdent: figleaf: rest api error code question, | |
| 15:16:50 | mriedem | https://bugs.launchpad.net/nova/+bug/1735329 500 is surely not correct in this case, | |
| 15:16:51 | openstack | Launchpad bug 1735329 in OpenStack Compute (nova) "console-log return 500 if n-cpu is shutdown" [Undecided,New] - Assigned to hongbin (hongbin034) | |
| 15:16:54 | mriedem | i'm thinking 409? | |
| 15:17:38 | cdent | s | |
| 15:18:38 | fried_rice | mriedem cdent 503 "Service Unavailable" ? | |
| 15:19:09 | cdent | 503 doesn’t really mean that, we’ve tried to discourage it | |
| 15:19:22 | mriedem | was going to say, i've been told not to use 501, 503, etc | |
| 15:19:23 | cdent | mriedem: I reckon 409 is probably right | |
| 15:19:33 | mriedem | this api already returns 409 so that's a good fit | |
| 15:19:58 | mriedem | hongbin: ^ | |
| 15:20:08 | fried_rice | "conflict" seems weird for this, but whatevs. | |
| 15:20:11 | cdent | 503 is more for when a proxy is involved | |
| 15:20:12 | hongbin | o/ | |
| 15:20:30 | cdent | fried_rice: conflict is that the state of the resource is not aligned with what you need it to be | |
| 15:20:42 | fried_rice | That's a stretch. | |
| 15:20:49 | fried_rice | IMO | |
| 15:20:55 | fried_rice | But I'm no expert. | |
| 15:21:11 | cdent | that’s what conflict really means | |
| 15:21:34 | openstackgerrit | Dan Smith proposed openstack/nova master: Unmap compute nodes when deleting host mapping https://review.openstack.org/524641 | |
| 15:21:41 | mriedem | ooo | |
| 15:25:50 | mriedem | not sure how to find out our default http response timeout | |
| 15:26:03 | superdan | mriedem: ^ | |
| 15:26:12 | mriedem | superdan: i know, already -1ed :) | |
| 15:26:56 | mriedem | or is the http response timeout configurable in uwsgi | |
| 15:26:58 | mriedem | ? | |
| 15:27:21 | superdan | mriedem: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L707 | |
| 15:27:36 | mriedem | superdan: that's not what you want | |
| 15:27:39 | mriedem | that's the nodename | |
| 15:27:44 | mriedem | ComputeNode.host is the hostname | |
| 15:28:02 | mriedem | it's totally confusing | |
| 15:28:45 | superdan | um | |