| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-28 | |||
| 19:25:48 | mriedem | yup, and, flavor 1 might no longer exist | |
| 19:26:09 | dansmith | is it majorly problematic that the user can't see what the resize actually was? | |
| 19:26:19 | dansmith | I mean, it's the migrations api, mostly about moves anyway right? | |
| 19:26:39 | mriedem | it's all about moves | |
| 19:26:42 | mriedem | admin-only by default | |
| 19:27:51 | mriedem | if we added a new column, the api could just check that first, and if not set (old record), we fallback to the existing broken field | |
| 19:28:12 | dansmith | and that's just empty for non-resize moves? | |
| 19:28:53 | mriedem | no, | |
| 19:28:57 | mriedem | :) | |
| 19:28:57 | mriedem | it's just equal for everything else | |
| 19:29:14 | openstackgerrit | Ian Wienand proposed openstack/nova stable/newton: [DNM] Testing d-g automatic -eol tag detection https://review.openstack.org/523509 | |
| 19:29:15 | mriedem | https://github.com/openstack/nova/blob/5b5b5c8df316e4c26b853c80ae8f8ea91f9c05c0/nova/conductor/tasks/migrate.py#L180-L181 | |
| 19:29:25 | dansmith | I just don't see the point I guess | |
| 19:29:51 | mriedem | sure, but, | |
| 19:29:58 | mriedem | it's also dumb | |
| 19:30:02 | dansmith | flavorid doesn't really get you the info you need either | |
| 19:30:08 | mriedem | not if the flavor is deleted | |
| 19:30:11 | mriedem | i agree | |
| 19:30:13 | dansmith | so if you want to do this, we should go all overkill and store the actual flavors | |
| 19:30:18 | dansmith | really fatten out our database | |
| 19:30:19 | mriedem | so we could microversion the fields out of the response | |
| 19:30:38 | mriedem | database, singular? | |
| 19:30:43 | dansmith | yuup | |
| 19:30:44 | dansmith | and/or always return zero there | |
| 19:30:51 | dansmith | heh | |
| 19:34:31 | efried | jaypipes Am I missing something or are these identical? https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L1074-L1091 | |
| 19:34:42 | efried | (other than the name of the alias) | |
| 19:35:05 | zigo | melwitt: Ok, thanks. | |
| 19:35:27 | melwitt | zigo: let me know if you have any questions or if something wasn't clear | |
| 19:35:30 | zigo | I'll do that later on (when my kids sleep...:) | |
| 19:35:39 | melwitt | heh, k | |
| 19:37:15 | jaypipes | efried: nope, you're not missing anything. for explanation of why that's needed, see the comments above about "butterfly join" | |
| 19:37:40 | efried | jaypipes Yeah, totally confused by all of that at the moment. | |
| 19:37:54 | jaypipes | efried: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L890-L949 | |
| 19:38:47 | efried | jaypipes Is there some reason we need two copies of that dict? | |
| 19:39:00 | jaypipes | efried: I'd be happy to walk you through it in a hangout if you need. | |
| 19:39:14 | jaypipes | efried: it's two separate sets of aliased tables. not the same dict. | |
| 19:39:21 | efried | jaypipes Hum, yeah. | |
| 19:39:45 | efried | jaypipes A walkthrough would be great, though I don't think my brain can handle it now. I'll take you up on it at some point when I'm feeling smarter. | |
| 19:39:58 | jaypipes | efried: np, happy to do that. | |
| 19:40:03 | efried | thanks | |
| 19:40:58 | jaypipes | efried: sharing providers are the bane of my existence. | |
| 19:41:20 | efried | Surely not the *only* bane. | |
| 19:41:33 | jaypipes | efried: heh | |
| 19:43:03 | jaypipes | efried: just completed the last of the test runs on n-r-p series. just in time to need to rebase and bump to 1.14 instead of 1.13... | |
| 19:43:20 | efried | jaypipes Fun day. | |
| 19:43:49 | edleafe | efried: if you ever need a sanity check on differences, try https://www.diffchecker.com | |
| 19:44:09 | edleafe | Really helpful when comparing expected vs. actual in tests | |
| 19:44:23 | efried | edleafe Nice, thanks! | |
| 19:44:42 | openstackgerrit | Merged openstack/nova master: Regenerate and pass configdrive when rebuild Ironic nodes https://review.openstack.org/503088 | |
| 19:49:31 | jaypipes | efried: actually... if you are looking for something to do... | |
| 19:49:55 | efried | jaypipes Tell me. I think I could just about handle a deep rebase right now. | |
| 19:50:01 | jaypipes | efried: if you wouldn't mind fixing those little issues you found on https://review.openstack.org/#/c/523192/, that would be super useful since I'm currently rebasing again the n-r-p series. | |
| 19:50:14 | efried | ight | |
| 19:50:20 | jaypipes | efried: since that's an important bug. | |
| 19:50:26 | efried | lemme propose this ksa release and I'll hit that... | |
| 19:50:27 | jaypipes | efried: and will make mriedem happy. | |
| 19:50:30 | jaypipes | ++ | |
| 19:50:33 | jaypipes | thanks much | |
| 19:54:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove deprecated TrustedFilter https://review.openstack.org/506864 | |
| 19:58:09 | openstackgerrit | Eric Fried proposed openstack/nova master: Use oslo_db Session in resource_provider.py https://review.openstack.org/523192 | |
| 19:58:27 | efried | jaypipes ^ -- though I doubt mriedem was witholding his +2 for those issues. | |
| 19:59:03 | mriedem | i'm withholding my +2 for other reasons | |
| 19:59:08 | efried | at least this way we get more test runs. | |
| 19:59:34 | efried | mriedem Care to comment? | |
| 20:00:02 | mriedem | i will leave you in suspense | |
| 20:02:43 | openstackgerrit | Merged openstack/nova master: Remove 'nova-manage quota refresh' command https://review.openstack.org/521829 | |
| 20:05:04 | openstack | Launchpad bug 1731668 in OpenStack Compute (nova) "placement: claim allocations fails with IndexError in _ensure_lookup_table_entry" [High,In progress] - Assigned to Eric Fried (efried) | |
| 20:05:04 | efried | jaypipes https://bugs.launchpad.net/nova/+bug/1731668 got reassigned to me, and I can't seem to punt it back to you. Why is that? | |
| 20:05:36 | mriedem | efried: are you on the nova bug team? | |
| 20:05:52 | efried | mriedem How would I know? | |
| 20:05:55 | mriedem | https://launchpad.net/~nova-bugs | |
| 20:06:00 | efried | Sorry, I didn't mean that to sound rude | |
| 20:06:08 | efried | I literally meant, how would I know if that's the case? | |
| 20:06:30 | mriedem | should show your membership in there somewhere | |
| 20:06:34 | mriedem | or under your launchpad profile | |
| 20:06:46 | mriedem | https://launchpad.net/~efried/+participation | |
| 20:06:47 | mriedem | so no | |
| 20:06:52 | mriedem | so join the nova bug team | |
| 20:06:59 | efried | ight | |
| 20:07:42 | mriedem | there are no rules | |
| 20:08:31 | efried | There's a busted link at https://wiki.openstack.org/wiki/Nova/BugTriage | |
| 20:08:42 | mriedem | wikis are free to update | |
| 20:09:05 | mriedem | but you mean http://138.197.2.61/ yes? | |
| 20:09:19 | efried | yeah | |
| 20:09:26 | efried | I wouldn't know what to update it to. | |
| 20:09:40 | mriedem | let me see if i can find it | |
| 20:10:20 | mriedem | http://45.55.105.55:3000/dashboard/db/openstack-bugs | |
| 20:10:31 | mriedem | 45.55.105.55:8082/bugs-dashboard.html | |
| 20:10:37 | mriedem | http://45.55.105.55:8082/bugs-dashboard.html | |
| 20:11:01 | mriedem | might be dead at this point since markus_z was maintaining that | |
| 20:13:39 | efried | Fix Committed and Fix Released -- this is no longer accurate: https://wiki.openstack.org/wiki/Bugs ? | |
| 20:13:55 | efried | Cause we mark Fix Released as soon as it's in master; and we don't use Fix Committed at all - right? | |
| 20:14:17 | mriedem | once something is merged on master it's marked fix released | |
| 20:14:25 | mriedem | i think things get marked fix committed on stable branches | |
| 20:14:41 | mriedem | there is no auto-release of those for stable releases i don't think, although dhelmann used to run a script for that | |
| 20:14:43 | mriedem | idk anymore | |
| 20:14:59 | mriedem | nor is there a proposed/* branch anymore | |
| 20:15:23 | efried | Since it's OpenStack-wide, I'll refrain from editing that page; long as I have some understanding of what the real deal is. | |
| 20:16:00 | efried | Mebbe I'll mention it to dhellmann | |