| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-28 | |||
| 17:02:41 | jaypipes | efried: no, in all seriousness, reviewing edleafe's series on alternate hosts if you haven't yet will be good. | |
| 17:03:12 | efried | jaypipes Sorry, my wife is the baker. She's out til late tonight. I make a mean curry, though. | |
| 17:03:35 | efried | jaypipes Okay, I've been deliberately avoiding that one for lack of context, but I guess I'll have to dig in at some point. | |
| 17:03:38 | jaypipes | efried: ooh, I love curry. | |
| 17:03:44 | jaypipes | efried: doesn't ship well, though. | |
| 17:03:59 | Anticimex | jaypipes: resize boot volume, ie make it larger | |
| 17:04:05 | jaypipes | efried: also ask dansmith to point you at patches he'd like reeviewed. | |
| 17:04:12 | efried | dansmith ^ | |
| 17:04:28 | dansmith | we're waiting on me for all my patches currently I think | |
| 17:04:41 | jaypipes | Anticimex: just stop the instance, resize the volume, and boot. | |
| 17:04:56 | efried | k, just let me know. | |
| 17:04:57 | edleafe | jaypipes: will have patch addressing your concerns on https://review.openstack.org/#/c/510159/ soon | |
| 17:05:05 | Anticimex | jaypipes: can't while it's attached | |
| 17:05:18 | Anticimex | .oO though that may have been fixed in ocata or something for ceph iirc | |
| 17:05:24 | jaypipes | Anticimex: stop the instance, resize the volume, and start the instance. | |
| 17:05:43 | jaypipes | edleafe: coo, thanks man | |
| 17:06:11 | jaypipes | Anticimex: terminate the instance, not stop it. | |
| 17:06:25 | jaypipes | Anticimex: I mean, if it's boot from volume, you're not losing anything. | |
| 17:06:29 | mriedem | you can resize an attached volume starting in pike | |
| 17:06:34 | mriedem | for libvirt + iscsi/fc | |
| 17:06:49 | Anticimex | jaypipes: no only cumbersome to retype all things, but that's indeed the workaround | |
| 17:07:05 | jaypipes | Anticimex: unless of course, it's a legacy application that relies on a) IP addresses not changing, b) infrastructure for doing disaster recovery, c) infrastructure for doing HA, etc | |
| 17:07:13 | Anticimex | but resize while attached (& stopped) is ok here | |
| 17:07:35 | jaypipes | mriedem: bfv though? | |
| 17:07:35 | mriedem | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/nova-support-attached-volume-extend.html | |
| 17:07:41 | mriedem | jaypipes: not sure about bfv | |
| 17:07:48 | Anticimex | mriedem: ack | |
| 17:07:52 | jaypipes | right... it's always the problem with bfv :) | |
| 17:07:53 | mriedem | the tempest test is not bfv | |
| 17:08:28 | cdent | efried: I’d totally dig on some curry please | |
| 17:10:26 | Anticimex | jaypipes: it is however legacy workload indeed | |
| 17:11:55 | Anticimex | but that wasn't the problem, the problem was the workflow for the resize (grow). but if this works in pike or queens if i got mriedem right, i guess that's always something | |
| 17:11:56 | jaypipes | Anticimex: by legacy, I'm referring to an application that doesn't have the ability to separate its application state from the persistent user data. In other words, an application that can be inserted in an image/ephemeral boot disk and have its user data written to a persistent volume. | |
| 17:12:59 | Anticimex | yeah, it's not capable of that | |
| 17:13:12 | jaypipes | Anticimex: I'd try it out if you can. Hopefully that would be a workaround solution until you can convince the application authors to provide a way to configure data to be written to a filesystem/DB separate from the boot partition. | |
| 17:13:46 | jaypipes | Anticimex: i.e. not on C:\ in a Windows image. ;) | |
| 17:13:49 | Anticimex | it would be nice yeah but not really applicable | |
| 17:14:06 | Anticimex | since it is a ton of C:'s coming in from a customers deprecated local dc | |
| 17:14:08 | Anticimex | :) | |
| 17:14:18 | jaypipes | ya | |
| 17:14:24 | jaypipes | I hear ya. | |
| 17:14:38 | Anticimex | "we'll make it work" | |
| 17:14:46 | jaypipes | :) said the sales guy. | |
| 17:14:50 | Anticimex | just have those +2 coming ;-) | |
| 17:14:51 | Anticimex | hehe yeah | |
| 17:14:56 | jaypipes | :) | |
| 17:14:57 | Anticimex | thx jay, afk | |
| 17:15:01 | jaypipes | ciao | |
| 17:50:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for rebuilding a volume-backed server https://review.openstack.org/521200 | |
| 17:50:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fail fast if changing image on a volume-backed server rebuild https://review.openstack.org/520660 | |
| 17:50:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/521391 | |
| 17:50:08 | mriedem | dansmith: i had to update the regression test at the bottom of this series because of the new RUN_ON_REBUILD=False for the ComputeFilter ^ using the super fun IsolatedHostsFilter now | |
| 17:50:54 | mriedem | the bottom 2 changes in that series are linked to https://review.openstack.org/#/c/521186/ | |
| 17:51:06 | mriedem | linked in that the cve fix introduced that regression | |
| 17:51:34 | mriedem | Kevin_Zheng: did i answer your -1 on https://review.openstack.org/#/c/520660/ ? | |
| 17:51:58 | mriedem | melwitt: i think this simple ironic bp patch is ready to go https://review.openstack.org/#/c/503088/ | |
| 17:52:16 | mriedem | sdague: this is an easy one for the ksa adapter stuff https://review.openstack.org/#/c/507693/ | |
| 17:52:20 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | |
| 17:52:21 | openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | |
| 17:52:21 | openstackgerrit | Ed Leafe proposed openstack/nova master: Refactor the code to check for sufficient hosts https://review.openstack.org/520242 | |
| 17:52:22 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | |
| 17:52:22 | openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | |
| 17:52:23 | melwitt | mriedem: ack, will look | |
| 17:52:23 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | |
| 17:52:23 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | |
| 17:52:24 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492 | |
| 17:52:49 | mriedem | melwitt: it'd also be good if you could help review ed's alternate hosts series above | |
| 17:52:53 | mriedem | since that's related to cells v2 stuff | |
| 17:53:01 | melwitt | sure thing | |
| 17:53:04 | mriedem | thanks | |
| 18:06:40 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492 | |
| 18:06:41 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | |
| 18:06:41 | openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | |
| 18:06:42 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | |
| 18:06:42 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | |
| 18:13:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947 | |
| 18:14:14 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947 | |
| 18:14:23 | efried | ah, seriously? | |
| 18:14:35 | efried | mriedem ^ | |
| 18:16:05 | mriedem | we are sympatico | |
| 18:16:36 | efried | mriedem Want me to unwind mine? | |
| 18:16:42 | mriedem | sure | |
| 18:16:44 | jaypipes | efried: FYI, still running tests on the n-r-p series after rebasing. (had to run tests for all 12 patches separately of course...) | |
| 18:16:55 | efried | jaypipes Of course. | |
| 18:20:33 | efried | mriedem Is there an easy way to revert to a prior patch set? | |
| 18:20:56 | jaypipes | efried: rm -rf / | |
| 18:21:12 | jaypipes | :P | |
| 18:21:57 | mriedem | efried: not sure of an easy way | |
| 18:22:00 | clarkb | efried: git review -d 123456,2 && git commit --amend # make some change to the commit message because gerrit (though new gerrit may not have this restriction any longer) && git review | |
| 18:22:15 | efried | clarkb Cool, thanks. | |
| 18:22:29 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947 | |
| 18:22:42 | clarkb | gerrit in the past has refused to accept old identical patchsets, I think ti may not refuse those anymore so you don't need to make changes but I haven't tested it | |
| 18:22:51 | melwitt | cool, I learned a thing. I wondered if there was a way to pull a specific rev using git review -d | |
| 18:22:54 | efried | clarkb No, it did refuse. | |
| 18:23:06 | efried | Trivial change to the commit message worked. Thanks for that. | |
| 18:23:26 | efried | mriedem done, sorry about that. | |
| 18:27:25 | mriedem | np | |
| 18:30:50 | melwitt | mriedem: if we have a change that introduces a new config option but it's not useful until patch 3 in the series, is it okay to delay the reno until patch 3? example: https://review.openstack.org/#/c/345397/26/nova/conf/vnc.py | |
| 18:34:04 | melwitt | I'm thinking that makes sense (to reno the conf option when the feature represented in the series fully lands) | |
| 18:46:57 | melwitt | would anyone be willing to review this libvirt driver bug fix to save the guest XML after a volume update? has one +2 https://review.openstack.org/#/c/498983 | |