| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-28 | |||
| 16:05:32 | efried | jaypipes Well, my port relies on some of the test helpers, so for that reason alone it won't work until later in the series. IMO not worth the trouble of retrofitting the tests to pre-helper and then having to rebase. | |
| 16:05:51 | jaypipes | efried: ack | |
| 16:06:00 | openstackgerrit | Eric Fried proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737 | |
| 16:06:02 | efried | jaypipes alex_xu ^ | |
| 16:07:40 | openstack | Launchpad bug 1702420 in OpenStack Compute (nova) "The AllocationCandidates.get_by_filters returned wrong combination of AllocationRequests" [High,Fix released] - Assigned to Alex Xu (xuhj) | |
| 16:07:40 | efried | alex_xu FYI I closed https://bugs.launchpad.net/nova/+bug/1702420 | |
| 16:19:39 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.create notification samples https://review.openstack.org/523456 | |
| 16:40:15 | Anticimex | hello, operator here | |
| 16:40:22 | Anticimex | was there ever progress on https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/detach-boot-volume.html since M? | |
| 16:40:42 | Anticimex | we just ran into that as a little nasty bug that made us sad | |
| 16:41:25 | cdent | mriedem: is there a reasonable way to do a test for this or is tempest sufficient? tempest happily blows up when it is wrong (see previous patchsets in the series): https://review.openstack.org/#/c/523403/ | |
| 16:45:28 | jaypipes | Anticimex: what precisely is the use case for attaching/detaching a boot volume? I've read that spec and each use case just describes a poorly-architected legacy application that relies on the infrastructure to do all of its disaster recovery, backup, and HA. | |
| 16:55:43 | mriedem | cdent: i'm lost re https://review.openstack.org/#/c/523403/ | |
| 16:55:51 | mriedem | which other patch in the series? | |
| 16:56:22 | cdent | sorry, not series, same change: ps1 and p2 have failures (but I may have knocked them out before they got a chance to report) | |
| 16:56:45 | cdent | mriedem: my words are a bit broken today, too many of them | |
| 16:57:50 | cdent | mriedem: the short form of my question is: since that didn’t have test coverage (besides tempest) before, is it okay without additional tests? | |
| 16:59:57 | mriedem | might not be bad to have a simple test that mocks out filter_factory and uses autospec to make sure what we're passing to that method is actually in the library | |
| 17:00:11 | efried | jaypipes Series starting at https://review.openstack.org/#/c/517119/ needs a rebase. Want me to hit it? Or mebbe we wait until some more stuff merges? | |
| 17:00:39 | jaypipes | efried: wait on that. | |
| 17:00:45 | efried | jaypipes K. Need to address gibi's -1 too. | |
| 17:01:22 | jaypipes | efried: yeah. | |
| 17:01:49 | jaypipes | efried: still running tests on the n-r-p series... and I'll need to rebase and bump the microversion yet again once cdent's latest patch merges. | |
| 17:01:57 | efried | jaypipes Right. Is there anywhere I can actually be useful at this point? | |
| 17:02:19 | jaypipes | efried: can you bake cookies (chocolate chip) and send them my way? :) | |
| 17:02:41 | jaypipes | efried: no, in all seriousness, reviewing edleafe's series on alternate hosts if you haven't yet will be good. | |
| 17:03:12 | efried | jaypipes Sorry, my wife is the baker. She's out til late tonight. I make a mean curry, though. | |
| 17:03:35 | efried | jaypipes Okay, I've been deliberately avoiding that one for lack of context, but I guess I'll have to dig in at some point. | |
| 17:03:38 | jaypipes | efried: ooh, I love curry. | |
| 17:03:44 | jaypipes | efried: doesn't ship well, though. | |
| 17:03:59 | Anticimex | jaypipes: resize boot volume, ie make it larger | |
| 17:04:05 | jaypipes | efried: also ask dansmith to point you at patches he'd like reeviewed. | |
| 17:04:12 | efried | dansmith ^ | |
| 17:04:28 | dansmith | we're waiting on me for all my patches currently I think | |
| 17:04:41 | jaypipes | Anticimex: just stop the instance, resize the volume, and boot. | |
| 17:04:56 | efried | k, just let me know. | |
| 17:04:57 | edleafe | jaypipes: will have patch addressing your concerns on https://review.openstack.org/#/c/510159/ soon | |
| 17:05:05 | Anticimex | jaypipes: can't while it's attached | |
| 17:05:18 | Anticimex | .oO though that may have been fixed in ocata or something for ceph iirc | |
| 17:05:24 | jaypipes | Anticimex: stop the instance, resize the volume, and start the instance. | |
| 17:05:43 | jaypipes | edleafe: coo, thanks man | |
| 17:06:11 | jaypipes | Anticimex: terminate the instance, not stop it. | |
| 17:06:25 | jaypipes | Anticimex: I mean, if it's boot from volume, you're not losing anything. | |
| 17:06:29 | mriedem | you can resize an attached volume starting in pike | |
| 17:06:34 | mriedem | for libvirt + iscsi/fc | |
| 17:06:49 | Anticimex | jaypipes: no only cumbersome to retype all things, but that's indeed the workaround | |
| 17:07:05 | jaypipes | Anticimex: unless of course, it's a legacy application that relies on a) IP addresses not changing, b) infrastructure for doing disaster recovery, c) infrastructure for doing HA, etc | |
| 17:07:13 | Anticimex | but resize while attached (& stopped) is ok here | |
| 17:07:35 | jaypipes | mriedem: bfv though? | |
| 17:07:35 | mriedem | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/nova-support-attached-volume-extend.html | |
| 17:07:41 | mriedem | jaypipes: not sure about bfv | |
| 17:07:48 | Anticimex | mriedem: ack | |
| 17:07:52 | jaypipes | right... it's always the problem with bfv :) | |
| 17:07:53 | mriedem | the tempest test is not bfv | |
| 17:08:28 | cdent | efried: I’d totally dig on some curry please | |
| 17:10:26 | Anticimex | jaypipes: it is however legacy workload indeed | |
| 17:11:55 | Anticimex | but that wasn't the problem, the problem was the workflow for the resize (grow). but if this works in pike or queens if i got mriedem right, i guess that's always something | |
| 17:11:56 | jaypipes | Anticimex: by legacy, I'm referring to an application that doesn't have the ability to separate its application state from the persistent user data. In other words, an application that can be inserted in an image/ephemeral boot disk and have its user data written to a persistent volume. | |
| 17:12:59 | Anticimex | yeah, it's not capable of that | |
| 17:13:12 | jaypipes | Anticimex: I'd try it out if you can. Hopefully that would be a workaround solution until you can convince the application authors to provide a way to configure data to be written to a filesystem/DB separate from the boot partition. | |
| 17:13:46 | jaypipes | Anticimex: i.e. not on C:\ in a Windows image. ;) | |
| 17:13:49 | Anticimex | it would be nice yeah but not really applicable | |
| 17:14:06 | Anticimex | since it is a ton of C:'s coming in from a customers deprecated local dc | |
| 17:14:08 | Anticimex | :) | |
| 17:14:18 | jaypipes | ya | |
| 17:14:24 | jaypipes | I hear ya. | |
| 17:14:38 | Anticimex | "we'll make it work" | |
| 17:14:46 | jaypipes | :) said the sales guy. | |
| 17:14:50 | Anticimex | just have those +2 coming ;-) | |
| 17:14:51 | Anticimex | hehe yeah | |
| 17:14:56 | jaypipes | :) | |
| 17:14:57 | Anticimex | thx jay, afk | |
| 17:15:01 | jaypipes | ciao | |
| 17:50:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for rebuilding a volume-backed server https://review.openstack.org/521200 | |
| 17:50:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fail fast if changing image on a volume-backed server rebuild https://review.openstack.org/520660 | |
| 17:50:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/521391 | |
| 17:50:08 | mriedem | dansmith: i had to update the regression test at the bottom of this series because of the new RUN_ON_REBUILD=False for the ComputeFilter ^ using the super fun IsolatedHostsFilter now | |
| 17:50:54 | mriedem | the bottom 2 changes in that series are linked to https://review.openstack.org/#/c/521186/ | |
| 17:51:06 | mriedem | linked in that the cve fix introduced that regression | |
| 17:51:34 | mriedem | Kevin_Zheng: did i answer your -1 on https://review.openstack.org/#/c/520660/ ? | |
| 17:51:58 | mriedem | melwitt: i think this simple ironic bp patch is ready to go https://review.openstack.org/#/c/503088/ | |
| 17:52:16 | mriedem | sdague: this is an easy one for the ksa adapter stuff https://review.openstack.org/#/c/507693/ | |
| 17:52:20 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | |
| 17:52:21 | openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | |
| 17:52:21 | openstackgerrit | Ed Leafe proposed openstack/nova master: Refactor the code to check for sufficient hosts https://review.openstack.org/520242 | |
| 17:52:22 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | |
| 17:52:22 | openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | |
| 17:52:23 | melwitt | mriedem: ack, will look | |
| 17:52:23 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | |
| 17:52:23 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | |
| 17:52:24 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492 | |
| 17:52:49 | mriedem | melwitt: it'd also be good if you could help review ed's alternate hosts series above | |
| 17:52:53 | mriedem | since that's related to cells v2 stuff | |
| 17:53:01 | melwitt | sure thing | |
| 17:53:04 | mriedem | thanks | |
| 18:06:40 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492 | |
| 18:06:41 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | |
| 18:06:41 | openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | |
| 18:06:42 | openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | |
| 18:06:42 | openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | |