Posted	Nick	Remark
#openstack-nova - 2017-11-23
14:59:58	mdbooth	johnthetubaguy: Would that allow me to fetch a volume's encryption credentials?
15:00:15	johnthetubaguy	I presume it should, for better or worse
15:00:34	mdbooth	If it does, we might as well just cache them
15:00:42	mdbooth	In which case, we might as well not have them
15:01:21	johnthetubaguy	there was a plan to fetch it from nova-conductor, assuming AMQP gets secured, but you can still get the key
15:01:56	johnthetubaguy	i.e. nova-conductor has the admin token and does the fetch on behalf of nova-compute
15:02:24	mdbooth	That's still not separating the management domains.
15:02:31	johnthetubaguy	agreed
15:02:40	mdbooth	Unless I've completely misunderstood what volume encryption is for
15:03:00	johnthetubaguy	the main use case I heard was when you don't trust the shared storage, rather than securing the hypervisor aas such
15:03:19	johnthetubaguy	or rather, the shared storage is more shared than you would like
15:03:51	mdbooth	Does cinder have an admin token?
15:04:14	mdbooth	Or are we literally just talking about the bit bucket?
15:06:01	johnthetubaguy	mdbooth: not sure what you mean, we don't have one in the conf yet, AFAIK
15:13:12	openstackgerrit	jiangpf proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161
15:23:14	openstackgerrit	Matt Riedemann proposed openstack/nova master: Deprecate file injection https://review.openstack.org/522027
15:29:46	openstackgerrit	Merged openstack/python-novaclient master: Use utils.prepare_query_string instead of duplicated code https://review.openstack.org/515640
15:35:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947
15:38:04	openstackgerrit	Stephen Finucane proposed openstack/nova master: live-mig: Add claims and proper resource tracking https://review.openstack.org/244489
15:43:39	smcginnis	mdbooth: Some would argue he is.
15:55:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: live-mig: Add claims and proper resource tracking https://review.openstack.org/244489
15:55:46	stephenfin	cfriesen: How bored are you today? ^
15:56:49	stephenfin	johnthetubaguy: You talked about upgrade issues around https://review.openstack.org/#/c/244489/ at a previous PTG. Any idea you recall what they were?
15:57:29	johnthetubaguy	stephenfin: it should be in the review comments, let me take a quick peak
15:59:11	stephenfin	johnthetubaguy: Cool. The only open comment I can see is this one, but I'm not sure what you mean https://review.openstack.org/#/c/244489/59/nova/compute/resource_tracker.py@224
15:59:31	stephenfin	The other ones here are resolved https://review.openstack.org/#/c/244489/59/nova/compute/manager.py
15:59:44	johnthetubaguy	oh, my, that was during the PTG, and I wasn't very helpful there
16:02:59	johnthetubaguy	stephenfin: I think the bit I was worried about was the compute manager stuff, making and making sure both nodes are upgraded before expecting the new flow to work
16:03:19	johnthetubaguy	stephenfin: looks like you replied done to those now
16:05:03	stephenfin	johnthetubaguy: So is https://review.openstack.org/#/c/244489/59/nova/compute/resource_tracker.py@224 still relevant?
16:05:30	johnthetubaguy	stephenfin: I am not sure what I mean with that, the thing I remember is the RPC versions and sending extra info
16:06:00	stephenfin	Heh
16:06:23	johnthetubaguy	the DB logic in rpcapi.py is freaking me out a touch, feels like the wrong level of abstraction
16:06:45	johnthetubaguy	I guess we have normally checked the service version to do stuff like that, but checking the compute rpcapi pin is basically the same
16:07:40	stephenfin	Aye, that comment has come up before. I'm not sure how to move it out and Pawel had the same issue :/ https://review.openstack.org/#/c/244489/50/nova/compute/rpcapi.py@455
16:08:14	stephenfin	This is a really horrible patch to review, heh
16:24:41	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217
16:24:42	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
16:27:52	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965
16:27:53	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
16:27:53	openstackgerrit	Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217
16:30:33	jianghuaw_	bauzas, ^these three patches should works for XenAPI vGPU. And have included the restriction which only allows on vGPU type enabled in one compute node.
16:31:14	bauzas	jianghuaw_: well, for me I'm testing my inventory patch but for some reasons, I'm not seeing the new inventory :(
16:32:27	jianghuaw_	bauzas, strange. It should have the new inventory per the source code.
16:32:42	bauzas	oh man
16:32:56	bauzas	I haven't modified the nova.conf
16:33:14	jianghuaw_	aha.
16:33:17	bauzas	ooops :
16:38:06	openstackgerrit	Claudiu Belu proposed openstack/nova master: POC: tests: fixes mock autospec usage https://review.openstack.org/447505
16:42:04	jianghuaw_	bauzas, I'm also going to add inventory data for VGPU_DISPLAY_HEAD in XenAPI.
16:46:03	openstackgerrit	Stephen Finucane proposed openstack/nova master: DNM: Move handling of legacy compute nodes to conductor https://review.openstack.org/522606
16:46:37	stephenfin	johnthetubaguy: Does that make any sense at all? I've kept it separate in case it's nonsense (I'm not _at all_ familiar with this code)
16:46:47	stephenfin	johnthetubaguy: That being https://review.openstack.org/522606
16:47:17	johnthetubaguy	stephenfin: I would keep it as one patch myself
16:47:39	stephenfin	Oh yeah, it's just separate so I can reason about that change in isolation
16:47:52	stephenfin	I'll fold it in if it's sane
16:52:09	openstackgerrit	Andrey Kurilin proposed openstack/python-novaclient master: [ci] Use pseudo-random names for new resources https://review.openstack.org/479777
16:58:53	openstackgerrit	Merged openstack/nova master: Implement query param schema for volume, snapshot API https://review.openstack.org/521368
17:05:28	openstackgerrit	Merged openstack/nova master: Implement query param schema for quota set APIs https://review.openstack.org/521329
17:20:27	openstackgerrit	Merged openstack/nova master: Implement query param schema for host index https://review.openstack.org/513699
17:40:17	openstackgerrit	Merged openstack/python-novaclient master: [functional] Remove duplication of boot helper https://review.openstack.org/521071
17:44:12	openstackgerrit	Claudiu Belu proposed openstack/nova master: POC: tests: fixes mock autospec usage https://review.openstack.org/447505
17:50:28	bauzas	jianghuaw_: still around ?
17:50:49	bauzas	call me stupid, but when testing w/ devstack, I got a placement 400 because the VGPU RC is not existing
17:57:43	jianghuaw_	bauzas, have you checked if the inventory data is created on the compute node?
17:57:49	bauzas	it's noty
17:58:07	bauzas	well, I'm investigating
17:58:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: DNM: Move handling of legacy compute nodes to conductor https://review.openstack.org/522606
17:59:09	stephenfin	bauzas: Fancy taking a look at that and the preceding patch?
17:59:10	stephenfin	^
17:59:31	jianghuaw_	bauzas, did you see the error at booting VM or it happened early when update inventory to placement?
17:59:36	stephenfin	Tomorrow, of course. Just want to make sure what I'm doing is sane. If it is, I'll squash into one patch
18:00:42	bauzas	jianghuaw_: for the moment, I'm not creating instances
18:00:52	bauzas	so, the latter
18:01:12	bauzas	mmmm
18:01:15	bauzas	strange
18:01:22	bauzas	now, the inventory is created in the DB
18:05:23	jianghuaw_	curious.
18:06:06	jianghuaw_	bauzas, did you invoke any API request when saw 400?
18:06:13	bauzas	nope
18:06:18	jianghuaw_	or you just got that from log?
18:06:27	bauzas	but we call out placement when getting the inventories
18:06:31	bauzas	anyway
18:06:36	bauzas	looks like it's fixed
18:06:41	bauzas	and not related to my change
18:06:48	jianghuaw_	ok.
18:07:34	openstackgerrit	Stephen Finucane proposed openstack/nova master: use extlinks to build series-specific links https://review.openstack.org/491869
18:08:53	jianghuaw_	bauzas, I'm curious which placment API responded with the above 400 error.
18:09:17	bauzas	nevermind
18:09:25	bauzas	if I can reproduce the issue, I'll tell you
18:09:43	bauzas	that's possibly a PEBKAC because it seems restart placement-api solved the problem
18:09:51	bauzas	restarting*
18:10:13	jianghuaw_	Ah. ok.
18:10:30	openstackgerrit	Sylvain Bauza proposed openstack/nova master: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763
18:10:38	jianghuaw_	anyway. that's good. it works for you now:-)
18:12:03	jianghuaw_	bauzas, bye for now. I'm quit.
18:12:10	bauzas	\o
18:12:16	jianghuaw_	bauzas, please help to review my patches at your convenience:-)
18:12:29	bauzas	for sure
18:12:34	jianghuaw_	Thanks.

Earlier   Later