Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-22
15:46:00 mdbooth stephenfin: IIRC the way those classes work is by raising an exception in the constructor if the bdm isn't of the correct type
15:46:31 alex_xu mriedem: btw, there is patch list from bugsmash, some new contributor are submitted patches https://etherpad.openstack.org/p/OpenStack-Bug-Smash-Queens-Wuhan-Bugs-List
15:46:58 mdbooth stephenfin: So is_implemented() is returning True if there is any class which can instantiate an object for the given bdm
15:47:00 kashyap cfriesen: Right, it won't magically catch it
15:47:44 stephenfin mdbooth: And we don't need/want to do that anymore because?
15:47:49 mriedem alex_xu: of course i saw the group photo on wechat
15:48:39 mdbooth stephenfin: Oh, wow, this is my patch
15:48:50 mdbooth stephenfin: I don't recognise this at all :O
15:49:12 stephenfin mdbooth: This is what happens when I skim old bug patches :)
15:49:19 alex_xu mriedem: hah
15:49:20 stephenfin slowly whittling them down
15:49:34 mdbooth Sec, let me get some context
15:50:56 mdbooth stephenfin: Ah... we don't want to do that any more because none of the other almost identical things do that
15:51:04 mdbooth And it's ugly as hell...
15:51:31 mdbooth And inefficient, and we don't need to do that
15:51:33 alex_xu mriedem: thanks for the email
15:52:20 cfriesen kashyap: so is this a nova bug (don't allow live migration between non-HT and HT hosts when using 'host-passthrough') or is it a documentation issue (when using 'host-passthrough' always set HT the same on all the hosts in a given AZ)
15:52:32 mdbooth stephenfin: See is_swap_or_ephemeral, new_format_is_swap, new_format_is_ephemeral
15:54:40 stephenfin That's as good a reason as any
15:54:47 stephenfin mdbooth: +2d
15:55:33 stephenfin mdbooth: This one looks good too, only for the broken UTs https://review.openstack.org/#/c/511218/
16:08:36 openstackgerrit Elod Illes proposed openstack/nova master: Transform instance-live_migration_pre notification https://review.openstack.org/482070
16:13:22 stephenfin sahid: Can you take a look at this? Looks innocuous enough https://review.openstack.org/#/c/522161/
16:18:18 gibi stephenfin, mriedem: Could one of you check back to https://review.openstack.org/482070 it needed a small extra change top of the assert mriedem asked for so I haven't fast approved it yet
16:26:14 openstackgerrit Merged openstack/nova master: rt: Make resource tracker always invoking get_inventory() https://review.openstack.org/518294
16:27:16 melwitt mriedem: skipping the cells meeting today? I think dansmith is out today
16:27:57 mriedem yes, i'm out today too
16:28:08 melwitt k, cool
16:28:51 tssurya okay :)
16:29:25 sahid stephenfin: ok i will
16:37:57 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Deprecate file injection https://review.openstack.org/522027
16:47:20 openstackgerrit Stephen Finucane proposed openstack/nova master: Added PCI NUMA policies https://review.openstack.org/390520
17:14:10 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove old-style quotas code https://review.openstack.org/511689
17:16:08 melwitt stephenfin: did you see my comment on the review? I also forgot to remove the command from the nova-manage doc
17:16:45 stephenfin melwitt: I did not. I agree though - let's keep it separate
17:17:15 stephenfin melwitt: You want to do that or will I?
17:17:34 stephenfin (remove the nova-manage change from the patch)
17:18:00 openstackgerrit Merged openstack/nova master: Use Migration object in ComputeManagerMigrationTestCase https://review.openstack.org/502126
17:20:59 melwitt stephenfin: I can do it. sec
17:25:33 openstackgerrit melanie witt proposed openstack/nova master: Remove old-style quotas code https://review.openstack.org/511689
17:27:54 openstackgerrit Merged openstack/nova master: Moving more utils to ProviderUsageBaseTestCase https://review.openstack.org/499539
17:28:31 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Fix force parameter for os-quota-sets API https://review.openstack.org/522305
17:28:34 mriedem alex_xu: bauzas: jaypipes: ^
17:28:39 mriedem johnthetubaguy: sdague: ^
17:31:20 sdague mriedem: hmmm... this being an admin side API I would be more inclined to fix it and backport it.
17:31:27 johnthetubaguy talking a look
17:32:09 mriedem sdague: that would certainly be easier
17:33:09 mriedem feel free to leave a comment in there; it was regressed in newton, and we still have stable/newton, so we could backport a fix if we decided to go that route
17:33:16 mriedem it's literally a 1 line code fix
17:35:15 sdague mriedem: comment left
17:36:51 mriedem thanks
17:40:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-manage host' and 'nova-manage agent' https://review.openstack.org/521837
17:40:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-manage quota refresh' command https://review.openstack.org/521829
17:40:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-manage account' and 'nova-manage project' https://review.openstack.org/521833
17:40:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-manage shell' command https://review.openstack.org/521835
17:40:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova-manage logs' command https://review.openstack.org/522133
18:08:54 cfriesen got a DB question...why don't we have "cascade='delete'" for "flavor_extra_specs" and "flavor-projects" tables the way we do for aggregates?
18:33:05 frickler nova-conductor seems to sometimes mangle errors it receives from nova-compute and replace them with "CantStartEngineError: No sql_connection parameter is established", is that a known issue?
18:38:27 frickler http://paste.openstack.org/show/627134/
18:51:32 frickler seems to happen quite regularly in CI, too: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Setting%20instance%20to%20ERROR%20state.%3A%20CantStartEngineError%5C%22
18:51:43 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Deprecate file injection https://review.openstack.org/522027
19:04:09 _ix Good afternoon folks. Is there a way to force a sync with the database such that only the nodes that the hypervisors are running are populated in the controller db?
19:04:47 _ix Every now and again, it looks like nova successfully deletes a node, but there's a subsequent error for powering the machine down because the task state of 'deleting' won't allow it.
19:04:57 _ix So, we have a few VMs that are lingering.
19:46:39 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: Implement query param schema for simple_tenant_usage https://review.openstack.org/507480
20:09:37 ildikov mriedem: if you're still around a review before the big Turkey Day on the new attach patch would be nice
20:10:09 ildikov mriedem: so I can fix stuff while most of the people are out :)
20:10:51 ildikov mriedem: if I missed you, then I hope you drive safe and enjoy the long weekend :)
20:15:02 openstack bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] https://launchpad.net/bugs/1469179 - Assigned to melanie witt (melwitt)
20:15:02 cfriesen melwitt: what's the story on https://review.openstack.org/#/c/428481/ and https://review.openstack.org/#/c/428505/ ? Has that been fixed via placement/resource-providers? If so, should bug 1469179 get updated?
20:35:29 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Deprecate file injection https://review.openstack.org/522027
20:35:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove TODO around user_data validation https://review.openstack.org/522383
22:05:44 openstackgerrit Merged openstack/nova master: Use the RequestSpec when getting scheduler_hints in compute https://review.openstack.org/515461
23:06:12 openstackgerrit Merged openstack/nova master: Implement query param schema for simple_tenant_usage https://review.openstack.org/507480
23:24:02 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add aggregates check in allocation canditates https://review.openstack.org/522407
23:27:52 openstackgerrit Matthew Treinish proposed openstack/nova master: Finish stestr migration https://review.openstack.org/522048
23:33:42 openstackgerrit Matthew Treinish proposed openstack/nova master: Finish stestr migration https://review.openstack.org/522048
23:36:08 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add functional test for get_all_with_shared() https://review.openstack.org/522408
#openstack-nova - 2017-11-23
00:07:26 openstackgerrit Merged openstack/nova master: VMware: ensure that provider networks work for type 'portgroup' https://review.openstack.org/358425
00:07:32 openstackgerrit Merged openstack/nova master: api-ref: fix the type on the block_device_mapping_v2 parameter https://review.openstack.org/521217
00:17:06 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409
00:22:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate file injection https://review.openstack.org/522027
00:23:20 tetsuro alex, efiried: sorry for messing up votes comments here. https://review.openstack.org/#/c/519081/ I prepared a patch for the discussion point. We can discuss here. https://review.openstack.org/522409
00:24:16 tetsuro Because of the testcase is
00:24:50 openstackgerrit Merged openstack/nova master: Clean up exception caught in _validate_and_build_base_options https://review.openstack.org/463253
00:25:38 tetsuro I had to fix cross aggregates bug first because testcase messes up...
00:27:49 tetsuro Please feel free to ask me to amend, abondon the patched or amend the patches for yourself.
00:28:48 tetsuro s/patched/patches
01:19:12 openstackgerrit Lei Zhang proposed openstack/nova master: Update Metadata api section of api guide https://review.openstack.org/522137
01:20:09 openstack bug 1730756 in OpenStack Compute (nova) "Creating a VM with a non-ASCII name fails with an Unicode error in libvirt guest create()" [Undecided,In progress] https://launchpad.net/bugs/1730756 - Assigned to Jiang (jiangpf)
01:20:09 openstackgerrit jiangpf proposed openstack/nova master: Encode libvirt domain XML in UTF-8 Creating a VM with a non-ASCII name results in an error. Resolve this by encoding the libvirt domain XML in utf-8. Resolves-bug 1730756 https://review.openstack.org/522161
01:24:11 openstackgerrit jiangpf proposed openstack/nova master: Encode libvirt domain XML in UTF-8 Creating a VM with a non-ASCII name results in an error. Resolve this by encoding the libvirt domain XML in utf-8. https://review.openstack.org/522161
01:27:03 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
01:57:14 openstackgerrit Alex Xu proposed openstack/nova master: Update server query section in the API concept doc https://review.openstack.org/522164
01:59:43 openstackgerrit jichenjc proposed openstack/nova master: mv generate_glance_url to get_image_endpoint_url https://review.openstack.org/511400
02:03:57 openstackgerrit Lei Zhang proposed openstack/nova master: Update server status api guide https://review.openstack.org/522119
02:05:55 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
02:07:41 openstackgerrit Eli Qiao proposed openstack/nova master: Api-guide: Add concept for scheduler hints https://review.openstack.org/522106
02:07:41 openstackgerrit Eli Qiao proposed openstack/nova master: Api-guide: Add Block Device Mapping https://review.openstack.org/522084
02:22:16 openstackgerrit Yikun Jiang proposed openstack/nova master: Handle exception in get_instance_sorted when gather cells' results. https://review.openstack.org/522425

Earlier   Later