| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-22 | |||
| 07:51:39 | openstackgerrit | Merged openstack/nova stable/newton: Update bindep.txt for doc builds https://review.openstack.org/522001 | |
| 07:51:56 | openstackgerrit | Merged openstack/nova stable/pike: Update bindep.txt for doc builds https://review.openstack.org/521999 | |
| 07:57:51 | openstack | bug 1730756 in OpenStack Compute (nova) "Creating a VM with a non-ASCII name fails with an Unicode error in libvirt guest create()" [Undecided,Confirmed] https://launchpad.net/bugs/1730756 - Assigned to Jiang (jiangpf) | |
| 07:57:51 | openstackgerrit | jiangpf proposed openstack/nova master: Creating a VM with a non-ASCII name will failed. Libvirt's XML should be utf8 encoded text. Fixes Bug 1730756 https://review.openstack.org/522161 | |
| 08:07:29 | openstackgerrit | Merged openstack/nova stable/ocata: Update bindep.txt for doc builds https://review.openstack.org/522000 | |
| 08:07:46 | openstackgerrit | jichenjc proposed openstack/nova master: WIP: Remove quota reserve/commit/rollback https://review.openstack.org/521470 | |
| 08:09:13 | openstackgerrit | Alex Xu proposed openstack/nova master: Update server query section in the API concept doc https://review.openstack.org/522164 | |
| 08:21:58 | alex_xu | gmann: we are fixing some todos in the api conept doc, appreciate you can review them https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:fix-api-guide | |
| 08:24:08 | gmann | alex_xu: thanks, i will sure. | |
| 08:24:36 | alex_xu | gmann: thanks! | |
| 08:30:14 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | |
| 08:35:51 | openstackgerrit | Yikun Jiang proposed openstack/python-novaclient master: Use utils.prepare_query_string instead of duplicated code https://review.openstack.org/515640 | |
| 09:11:27 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: update_cell allows more than once cell to have the same db/transport url https://review.openstack.org/518556 | |
| 09:18:34 | kashyap | cfriesen: About that "VM crashing on destination post migration" involving CPU models you posted, in the past _probably_ it would've affected Nova. Nova's CPU compat checks are reasonable enough now. I recall DanPB fixing it explicitly | |
| 09:19:22 | kashyap | cfriesen: Especially, look at this Nova commit: "79a0755" -- libvirt: fix overly strict CPU model comparison in live migration | |
| 09:25:01 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | |
| 09:47:35 | stephenfin | mdbooth: Could you have a look at https://review.openstack.org/#/c/407397/ at some point? | |
| 09:49:24 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 09:49:25 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | |
| 09:50:08 | kashyap | cfriesen: Also check this nova/virt/libvirt/driver.py --> _compare_cpu() | |
| 09:56:57 | openstackgerrit | Forest Romain proposed openstack/nova master: Fix list servers by hypervisor https://review.openstack.org/518699 | |
| 10:06:12 | openstackgerrit | jichenjc proposed openstack/nova master: Remove nova-manage logs command https://review.openstack.org/522133 | |
| 10:15:07 | niraj_singh | I am working on service token implementation for cinder to glance interaction. In cinder there is centralised config file. To create a session using load_session_from_conf_options method we need to provide group name as a parameter which should have config option like {'cacert','insecure','timeout','cert','key'} etc. So in cinder these option can be configured in default group because these options are in global_opt. There is no specific group | |
| 10:15:08 | niraj_singh | If we create a new group then it will have duplicate values. So how can i use these conf option to "load session from conf option". Is there a way? | |
| 10:15:08 | niraj_singh | assign to these config option. In my thinking we cannot use "DEFAULT" as a group name. | |
| 10:31:32 | openstackgerrit | Ghanshyam Mann proposed openstack/python-novaclient stable/pike: Move zuulv3 jobs to project repo https://review.openstack.org/522207 | |
| 10:31:49 | openstackgerrit | Ghanshyam Mann proposed openstack/python-novaclient stable/ocata: Move zuulv3 jobs to project repo https://review.openstack.org/522208 | |
| 10:48:23 | mdbooth | stephenfin: Sure | |
| 10:59:46 | kashyap | cfriesen: Although, the commit ID I pointed above fixes the opposite case (where libvirt was rejecting valid guests) of the current bug discussion. | |
| 11:00:04 | kashyap | cfriesen: You've got a response on the bug | |
| 11:07:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Guard against overwriting a deleting task state https://review.openstack.org/288933 | |
| 11:10:47 | stephenfin | bauzas: Want to take a shot at this? https://review.openstack.org/#/c/288933/ It's been around a long time | |
| 11:11:54 | stephenfin | mdbooth: Left a comment on https://review.openstack.org/#/c/440536/ RE: whether tests were required. Happy to reassess once I know (it's another one of those "bugfixes that have been here too long" ones) | |
| 11:40:34 | stephenfin | mdbooth: Got another one for you, if you could. I was pretty sure you'd resolved the issue they highlight with the mount manager you introduced :/ https://review.openstack.org/#/c/505708 | |
| 11:51:56 | ildikov | johnthetubaguy: Zuul gave its blessings, so one more pretty please: https://review.openstack.org/#/c/330285/ :) | |
| 12:41:18 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051 | |
| 12:42:05 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051 | |
| 12:58:22 | gmann | nova API meeting on openstack-meeting-4 | |
| 13:10:19 | FoXMaN | hello | |
| 13:11:06 | FoXMaN | i need some advice on how to determine what slows down nova-api-os-compute service as i am out of ideas | |
| 13:11:25 | FoXMaN | request takes sometimes more than 50 seconds | |
| 13:12:23 | alex_xu | stephenfin: bauzas I'm in the bugsmash, there are new contributors, and there is the list of patches people are looking for review https://etherpad.openstack.org/p/OpenStack-Bug-Smash-Queens-Wuhan-Bugs-List, appreciate if you can review them! | |
| 13:13:34 | alex_xu | or any core is still working, but I guess not | |
| 13:18:04 | mdbooth | stephenfin: Will try to look at that one, too. Found an issue with the first, btw, but haven't reviewed it properly yet. | |
| 13:35:27 | openstackgerrit | Yikun Jiang proposed openstack/python-novaclient master: Use utils.prepare_query_string instead of duplicated code https://review.openstack.org/515640 | |
| 13:35:45 | mdbooth | stephenfin: Just looking at that second patch. os-brick's remotefs connector avoids a whole class of races because it *never unmounts anything*. | |
| 13:36:14 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | |
| 13:37:04 | jaypipes | morning supernovas | |
| 13:37:05 | mdbooth | Ah, until recently it seems this driver was VZStorageRemoteFSClient | |
| 13:37:34 | mdbooth | morning jaypipes | |
| 13:40:27 | stephenfin | mdbooth: So the manager that's there only cares for connections? | |
| 13:40:33 | stephenfin | *connecting | |
| 13:40:42 | stephenfin | on account of the "never disconnecting" anything | |
| 13:40:50 | mdbooth | Yep | |
| 13:40:50 | stephenfin | *anything" bit | |
| 13:40:57 | stephenfin | Ah, that makes sense | |
| 13:41:04 | mdbooth | Well, not really | |
| 13:41:17 | mdbooth | But it does make the locking simpler | |
| 13:41:55 | mdbooth | The complexity of my patch is in ensuring we never disconnect anything that's still in use. | |
| 13:42:20 | mdbooth | If you never disconnect anything ever, that's a resource consumption issue, but you aren't going to have that kind of race | |
| 13:45:10 | stephenfin | mdbooth: I'm a little confused here so let's recap | |
| 13:45:18 | stephenfin | That driver is using os-brick, and disconnect for that is a no-op for os-brick | |
| 13:46:36 | mdbooth | Yeah, it's using remotefs in os-brick | |
| 13:46:48 | mdbooth | remotefs is basically mount/unmount | |
| 13:46:49 | stephenfin | But I'm guessing the NFS driver does not use that, otherwise you wouldn't have had to add the manager in commit 4aa39c44a4b08ee4e05548d5c258e795089b2bdd | |
| 13:46:54 | mdbooth | Except it doesn't have unmount | |
| 13:47:10 | stephenfin | Well, you would for connect but not disconnect | |
| 13:47:13 | mdbooth | stephenfin: Indeed, NFS doesn't use it. | |
| 13:47:29 | mdbooth | And tbh, I don't think anything should use it, but it's their driver. | |
| 13:47:42 | mdbooth | Not without unmount, anyway | |
| 13:48:34 | mdbooth | The nova mount manager stuff is really generic. If it fit into the os-brick model it should probably live there. | |
| 13:48:36 | stephenfin | OK. So instead of them doing what the do there, would it make more sense for them to change LibvirtVZStorageVolumeDriver to subclass from LibvirtMountedFileSystemVolumeDriver | |
| 13:48:45 | stephenfin | *what they do | |
| 13:48:51 | jianghuaw | bauzas, I created a new patch to enable only one vGPU type on each compute node. So that we will have same behavior for both libvirt and XenAPI befre we switch to use n-rp. https://review.openstack.org/#/c/521769/ | |
| 13:49:04 | mdbooth | I recommended that in a review comment. I won't leave a -1 for that, though. | |
| 13:49:12 | stephenfin | Like you did for the NFS driver in 4aa39c44a4b08ee4e05548d5c258e795089b2bdd | |
| 13:49:23 | stephenfin | OK. To be honest, that sounds like a viable -1 to me | |
| 13:49:42 | bauzas | jianghuaw: ack | |
| 13:49:43 | stephenfin | I mean, we have a good pattern for how to do this. Why not insist we use the same pattern everywhere | |
| 13:49:43 | mdbooth | Well the problem already exists | |
| 13:49:49 | mdbooth | And the patch they've proposed makes it better | |
| 13:49:55 | bauzas | jianghuaw: maybe stacking that with the other changes could help us reviewing ? | |
| 13:50:02 | mdbooth | The time to -1 was a while back | |
| 13:50:42 | jianghuaw | bauzas, That's in the PS stack. I'd like you help to reivew it. | |
| 13:51:17 | jianghuaw | bauzas, note I kept the original logic which will handle multiple gpu group, so it's easy for me to switch to multiple types once n-rp is ready. | |
| 13:51:34 | bauzas | jianghuaw: sure, but I mean squashing | |
| 13:51:58 | stephenfin | mdbooth: I assume it would require significant rework? | |
| 13:52:30 | jianghuaw | bauzas, ok. I see. Will squash it. | |
| 13:52:57 | mdbooth | stephenfin: Well I don't know enough about how it mounts, but if it's basically just a wrapper round 'mount -t vzstorage' or whatever, it should be very simple. | |
| 13:53:26 | stephenfin | Oh, so we'd be doing it ourselves instead of relying on os-brick? | |
| 13:53:52 | mdbooth | Yeah, the existing code doesn't use os-brick because it was replacing code which didn't use os-brick. | |
| 13:54:00 | mdbooth | There's no reason it couldn't, though. | |
| 13:54:09 | mdbooth | That would require a bit of rework, though. | |
| 13:54:43 | stephenfin | Ah, that's where I was confused. I thought it was a case of removing that new code, changing what we subclassed, and one or two other minor things | |
| 13:54:53 | mdbooth | Still, the os-brick connector doesn't implement umount, so I'm surprised anybody would use it. | |
| 13:55:20 | stephenfin | If there's other rework there then it makes sense to not ask for that. It's a nice-to-have for future | |
| 13:55:26 | stephenfin | Agreed. That seems...odd | |
| 13:56:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | |
| 14:06:45 | stephenfin | mdbooth: Overall though, are you happy with that patch? | |
| 14:08:09 | bauzas | jianghuaw: I plan to write some functional tests for verifying our implementations | |