Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-20
15:47:06 maciejjozefczyk jaypipes: Could you please take a look on https://review.openstack.org/#/c/520024/
15:47:18 maciejjozefczyk jaypipes: :) ?
15:48:02 jaypipes maciejjozefczyk: you see the func test failure in that? is it related to your changes?
15:48:24 openstackgerrit ayoung proposed openstack/nova master: Admin API Policy contingent on is_admin_project https://review.openstack.org/384148
15:49:03 maciejjozefczyk jaypipes: yes it fails and my questions are about how to fix it
15:49:25 jaypipes maciejjozefczyk: k, gimme a sec to finish reading the scheduler meeting notes and I'll look into it.
15:49:32 maciejjozefczyk jaypipes: thx
15:50:14 jaypipes efried: "<efried> I see clients finding it useful to be able to do one call and get a single blob with all that information collated." <-- that's kinda like the purpose of GET /allocation_candidates in a way.
15:50:16 mriedem jaypipes: stephenfin: i'm +2 on the placement osc plugin patch for rp inventories https://review.openstack.org/#/c/457533/ - it has some warts which i'll clean up in a follow up patch, but would be good to keep this ball rolling
15:51:55 efried jaypipes I can see that. The difference being the input parameters: GET /allocation_candidates wants me to tell it what resources/traits I need. Versus saying "here's a RP - give me all the information about that guy".
15:52:08 jaypipes efried: yes, understood.
15:52:42 efried jaypipes Which is basically what that new SRC method get_provider_tree is doing. But on the client side, via 2N+1 calls (ish)
15:53:00 jaypipes efried: though one might make the argument that the code in https://review.openstack.org/#/c/521098/4/nova/scheduler/client/report.py only needs to be run once and the client is the appropriate place to put that logic and caching.
15:53:31 efried jaypipes Only once... per what?
15:53:47 jaypipes efried: per instantiation of the report client.
15:54:21 efried jaypipes And then the report client has to keep the local copy of ProviderTree up to date whenever Something Changes?
15:54:38 jaypipes efried: err, that's already exactly what it does...
15:54:51 jaypipes self._provider_tree.
15:55:13 efried jaypipes Hum, which I was *not* planning to pass into the virt driver.
15:55:36 jaypipes efried: I was hoping you'd pass a clone()/deepcopy of self._provider_tree.
15:56:06 efried jaypipes Maybe - need to look into that further. But if I do, self._provider_tree is gonna need to be populated with more stuff than it is today, I think.
15:56:20 jaypipes efried: and do the diff against self._provider_tree when update_inventory() runs and the resulting ProviderTree is sent to reportclient for set_inventory_for_tree() (or whatever that method is named)
15:56:24 efried Also, self._provider_tree very well may be a superset of what the virt driver cares about. But I suppose that's okay.
15:57:11 efried jaypipes I think keeping-local-copy-current may be doable when the compute node owns all the resources. But sharing providers could (and will) be updated from outside. So we'll have to resync those periodically.
15:58:45 jaypipes efried: sure, but that's a relatively rare operation and the compute worker won't be updating inventory records against shared providers (it will delete allocations against shared providers, of course, when terminations happen)
15:59:11 efried jaypipes Actually, I do see virt updating shared provider records.
15:59:24 jaypipes efried: maybe for powervm
16:00:14 efried jaypipes As a specific example, yes, our shared storage provider (confusingly called SSP) is managed by the same hypervisor.
16:00:25 efried It's just that any of the hypervisors attached to the pool are allowed to manage it.
16:00:36 jaypipes efried: that's fine. that's what the generation is for.
16:00:57 efried okay.
16:02:24 sean-k-mooney does anyone know how to check if a compute node is running a specific version of nova from the conductor. is there an rpc call i can use from the conductor to get the version?
16:02:30 openstackgerrit Eric Fried proposed openstack/nova master: placement: Document microversion header in api-ref https://review.openstack.org/521563
16:02:41 efried mriedem ^ That looks a lot more like the compute one now.
16:03:08 jaypipes sean-k-mooney: yeah. nova.objects.Service.get_minimum_version() or something like that. one sec, grabbing link
16:03:42 jaypipes sean-k-mooney: https://github.com/openstack/nova/blob/master/nova/objects/service.py#L405
16:06:16 sean-k-mooney jaypipes: thanks looking at it now.
16:08:40 sean-k-mooney jaypipes: that looks like it returns the minimum version supported by the could rather then for a specific host is that correct
16:09:33 jaypipes sean-k-mooney: yes, correct.
16:10:05 jaypipes sean-k-mooney: if you want a specific compute host's version, use Service.get_by_host_and_binary().version
16:10:29 jaypipes sean-k-mooney: sorry, figured you just wanted to find out if the deployment had been upgraded completely or not...
16:10:48 sean-k-mooney jaypipes: yes that the latter is exactly what i'm looking for
16:10:53 jaypipes cool
16:11:49 sean-k-mooney its for the livemigration with multiple port bindings. during a rolling upgrade we want to allow the new flow if both the source and destination are already upgraded.
16:14:17 jaypipes sean-k-mooney: gotcha.
16:14:18 openstackgerrit Eric Fried proposed openstack/nova master: placement: Document request headers in api-ref https://review.openstack.org/521563
16:14:31 jaypipes sean-k-mooney: might want to run your idea by dansmith but sounds fine to me.
16:26:23 sean-k-mooney how often is the nova-specs repo mirrored to github?
16:28:57 sean-k-mooney it looks like it has not been synced since september
16:32:41 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Address comments from original inventory patch https://review.openstack.org/521578
16:35:23 mriedem sean-k-mooney: looks like an infra problem
16:35:35 mriedem https://specs.openstack.org/openstack/nova-specs/specs/queens/index.html
16:35:39 mriedem if you're looking for the spec
16:39:19 sean-k-mooney mriedem: ya just asked over on the infra channel. apparently the repo is corrupt in some way and github currently does not like it. the git.openstack.org version works fine
16:47:19 openstackgerrit Eric Fried proposed openstack/nova master: placement: Document request headers in api-ref https://review.openstack.org/521563
16:50:41 cdent efried: I just left a potentially relevant link/comment on that ^
16:50:51 efried cdent looking...
16:53:26 efried cdent Good deal. I'll let mriedem decide whether that's reason to keep the words about the Accept header.
16:53:51 cdent ✔
17:05:38 cdent mriedem: your comment on https://review.openstack.org/#/c/518223/1//COMMIT_MSG doesn’t make sense (to me). That paragraph I’m saying “there’s two changes here one fixes a 500, but another changes the content type of existing 400-499 responses so not sure if there is a violation or not"
17:06:38 mriedem ok, i didn't read too deep into that paragraph
17:07:48 dansmith mriedem: see my comment here? https://review.openstack.org/#/c/521186/3/nova/tests/functional/test_servers.py I think a custom hint is probably the best way forward here, so we don't depend on that filter being enabled
17:08:31 dansmith mriedem: we can also use that to make the "is policy" more straight forward, and if we do it customly, we'll be able to enforce host and node equivalence
17:09:39 mriedem didn't see the comment until now, but i was thinking about a custom hint over the weekend too, but forgot about it
17:09:49 mriedem but then we don't need deployers to change anything for the fix
17:09:58 dansmith right
17:09:59 mriedem so would you add a new filter too?
17:10:02 dansmith no,
17:10:09 dansmith I'd just do it in host manager like force_hosts works
17:10:16 mriedem ok
17:10:23 mriedem then tallyho
17:10:34 dansmith this is a real fun one
17:11:53 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763
17:36:13 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient master: [ci] Use pseudo-random names for new resources https://review.openstack.org/479777
17:44:29 openstackgerrit Eric Fried proposed openstack/nova master: placement: Traits ops on ProviderTree https://review.openstack.org/521605
17:44:33 efried jaypipes Reckon we're needing this ^ soon, though I couldn't say what bp to put it under.
17:44:50 jaypipes efried_rollin: k
17:45:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190
19:16:34 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Add cache headers to placement api requests https://review.openstack.org/521640
19:16:34 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Object changes to support last-modified headers https://review.openstack.org/521639
19:19:33 cdent dansmith: that ^ is the last-modified stuff done all in one patch/microversion
19:28:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Add migration_get_by_uuid in db api. https://review.openstack.org/511421
19:28:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644
19:28:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
19:28:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273
19:28:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871
19:28:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
19:36:38 cfriesen does the current master branch scheduler handle working as a hybrid scheduler for baremetal as well as VM compute nodes? I'm mostly wondering about things like the NUMATopologyFilter.
19:37:48 mriedem don't think so
19:37:53 mriedem b/c there are different host managers
19:38:03 mriedem HostManager vs IronicHostManager
19:38:27 mriedem although,
19:38:40 mriedem with resource classes in pike, i'm not sure how much you need the IronicHostManager anymore
19:38:41 cfriesen mriedem: yeah...IronicHostManager mostly calls the superclass functions
19:39:12 mriedem and use_baremetal_filters and baremetal_enabled_filters are deprecated
19:39:38 mriedem so, IronicHostManager should probably be deprecated
19:39:40 cfriesen mriedem: we're making it work on Pike and need to modify some of the filters. was just wondering if this was something that I should propose for Rocky as a spec
19:39:47 mriedem since the related config options for the filters are also deprecated
19:39:52 cfriesen or if it's just bugfix material
19:40:03 mriedem spec for what?

Earlier   Later