Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-14
21:29:43 efried Which is important.
21:29:50 efried In case you're running this script on AIX
21:29:56 mriedem fuck i wish
21:32:06 mriedem updated, thanks for the tip
21:32:11 cburgess mriedem OK sorry... things got.. crazy here. I'm reading what your wrote hours ago now.
21:33:43 efried mriedem Sure thing. But also x=foo is the same as x=$(echo foo)
21:34:22 cburgess mriedem OK so... back to the live migration cancel thing, I think its probably reasonable to be able to cancel queued or running.
21:45:58 mriedem cburgess: ack
21:45:59 mriedem good to know
21:46:10 cburgess I agree there is a bit of race condition though.
21:46:17 mriedem apparently our operators are annoyed that they queue up a bunch of live migrations and can't abort some of them before they hit the hypervisor
21:46:33 mriedem tonyb: ok redoing this newton series with the depends-on
21:46:35 cburgess As in you want the API to fast fail if the state is wrong, but that state can change by the time you hit the compute node.
21:46:43 mriedem and had to slip another funtional test backport in the mix
21:47:04 mriedem cburgess: yeah i think we'd just have to ignore it if we got to the compute and something changed,
21:47:08 cburgess mriedem Yeah that makes sense. So I think queued and running are the 2 states that aren't really transitory. So just block action on the transitory states.
21:47:15 mriedem although if it went from queued->running, we should be able to abort in the compute
21:47:27 mriedem as normal
21:47:38 cburgess mriedem Right thats my thought. Fast fail on the API, and then another check on compute and fail if you aren't in an allowed state on compute.
21:47:52 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Pass requested_destination in filter_properties https://review.openstack.org/516119
21:47:53 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Add security release note for OSSA-2017-005 https://review.openstack.org/519755
21:47:53 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Validate new image via scheduler during rebuild https://review.openstack.org/519684
21:47:54 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Fix non-parameterized service id in hypervisors sample tests https://review.openstack.org/519763
22:09:59 openstackgerrit Merged openstack/nova master: placement: AllocCands.get_by_{filters => requests} https://review.openstack.org/514092
22:16:52 openstackgerrit Merged openstack/nova master: Deduplicate server_group samples https://review.openstack.org/519629
22:20:27 openstackgerrit Merged openstack/nova stable/pike: Add security release note for OSSA-2017-005 https://review.openstack.org/519752
22:20:33 openstackgerrit Merged openstack/nova stable/ocata: Add security release note for OSSA-2017-005 https://review.openstack.org/519753
22:21:01 mriedem i think the devstack hack is working
22:21:07 mriedem tempest is running on that patch now
22:21:10 mriedem so the install was good
22:24:35 openstackgerrit Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
22:24:36 openstackgerrit Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799
22:24:36 openstackgerrit Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
22:24:38 tonyb mriedem: \o/ I +2'd the devstack change
22:25:22 efried jaypipes Addressed the couple of comments remaining in here --^
22:25:39 mriedem tonyb: you don't think that devstack change needs to go on master first and backported?
22:25:58 mriedem ah i see your comment
22:26:08 tonyb mriedem: Yeah that thing
22:27:59 mriedem oh fo sho
22:28:33 mriedem begin preparations for ocata and pike releases
22:37:25 tonyb mriedem: You're just missing a "make it so" or "engage!" in there somewhere
22:37:39 tonyb mriedem: perhaps you could take that as a challenge?
22:37:50 mriedem i thought about it
22:37:56 mriedem sdague said engage earlier today
22:38:14 mriedem oh no he said the other
22:38:15 mriedem make it so
22:38:41 mriedem ok pike release https://review.openstack.org/#/c/519799/ and ocata release https://review.openstack.org/#/c/519808/
22:40:09 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Correct log message when removing a security group https://review.openstack.org/519586
22:41:33 mriedem dansmith: tonyb: want to bless this https://review.openstack.org/#/c/519763/ ?
22:43:59 tonyb mriedem: +2'd
22:44:26 dansmith tonyb: there's one above it too
22:44:42 dansmith (the important one)
22:47:55 tonyb dansmith: Yeah I'm looking that the zuul consoles for that series and the pike/ocata releases
22:48:16 dansmith okay
22:49:11 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/519806
22:51:57 openstackgerrit Merged openstack/nova master: Add error message on metadata API https://review.openstack.org/517152
22:52:56 mriedem thanks - at this hour, i'll just fast re-approve anything that was already approved earlier todya
22:52:58 mriedem once ci is happy
22:54:10 efried jaypipes Taking on the latest merge conflict...
22:57:20 mriedem tonyb: i think the devstack patch isn't actually doing the job
22:57:21 mriedem http://logs.openstack.org/58/519758/3/check/legacy-tempest-dsvm-neutron-full/1676068/logs/devstacklog.txt.gz#_2017-11-14_21_45_19_885
22:57:56 mriedem i'm not sure why the job passed though
22:58:34 tonyb ergh moar debugging
22:58:44 mriedem well, i assume my regex compare in bash is wrong
22:58:48 mriedem i can update to what efried suggested
22:59:00 mriedem although
22:59:01 mriedem http://logs.openstack.org/58/519758/3/check/legacy-tempest-dsvm-neutron-full/1676068/logs/pip2-freeze.txt.gz
22:59:04 mriedem neutron==9.4.2.dev21
22:59:26 mriedem that is newton for neutron
22:59:48 efried mriedem I only glanced at that line, just noticed you were using a regex when a simple glob compare would do.
23:00:54 tonyb Yeah /me is confused
23:01:10 mriedem it clearly shows it not checking out the newton-eol tag though
23:03:09 efried mriedem It appears you need to whack the double quotes around the regex side.
23:03:23 efried mriedem Or change to the simpler form
23:03:38 yankcrime webdev
23:04:50 efried 1
23:04:50 efried efried@efried-ThinkPad-W520:~$ [[ "stable/whatever" =~ "stable/.*" ]]; echo $?
23:04:50 efried 0
23:04:50 efried efried@efried-ThinkPad-W520:~$ [[ "stable/whatever" =~ stable/.* ]]; echo $?
23:05:17 efried then there's
23:05:20 efried efried@efried-ThinkPad-W520:~$ [[ "stable/whatever" == stable/* ]]; echo $?
23:05:21 efried 0
23:05:22 mriedem yup, i copied something from d-g incorrectly
23:06:04 efried I believe they're trying to be helpful with =~ in bash and make it so you can include quotes more "easily" as match tokens in your actual regex.
23:06:38 tonyb mriedem: So http://logs.openstack.org/58/519758/3/check/legacy-tempest-dsvm-neutron-full/1676068/logs/devstacklog.txt.gz#_2017-11-14_21_45_19_892
23:06:59 tonyb shows that for reasons I don't grok you got newton-eol
23:07:21 mriedem yeah i don't either
23:07:26 mriedem but i've updated the devstack patch
23:08:13 mriedem and added efried as co-author since he's fixed all my mistakes
23:08:18 efried :)
23:10:09 openstackgerrit Merged openstack/nova master: Add security release note for OSSA-2017-005 https://review.openstack.org/519738
23:13:51 mriedem ok newton stuff is all rechecked
23:14:49 mriedem this is going to take an hour so i'm gonna be afk for a bit
23:15:40 tonyb okay
23:31:46 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
23:49:08 openstackgerrit Eric Fried proposed openstack/nova master: begin refactor AllocCandidates._get_by_filters() https://review.openstack.org/516778
23:49:09 openstackgerrit Eric Fried proposed openstack/nova master: build alloc request resources for shared resources https://review.openstack.org/516780
23:49:09 openstackgerrit Eric Fried proposed openstack/nova master: build ProviderSummary objects in sep function https://review.openstack.org/516779
23:49:10 openstackgerrit Eric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters() https://review.openstack.org/516782
23:49:10 openstackgerrit Eric Fried proposed openstack/nova master: create allocation request for single provider https://review.openstack.org/516781

Earlier   Later