Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-14
08:54:44 openstackgerrit Saverio Proto proposed openstack/nova stable/newton: Correct log message when removing a security group https://review.openstack.org/519586
09:07:14 openstackgerrit Li Yingjun proposed openstack/nova master: Versioned notifications for service create and delete https://review.openstack.org/519588
09:33:54 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326
10:17:41 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601
10:17:53 openstackgerrit Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
10:18:42 gibi efried: thanks for the rebase of my rp test patch it make sense to move that
10:19:26 gibi efried, jaypipes: I discovered a debatable edge case with shared RPs in https://review.openstack.org/#/c/519601/
10:19:56 gibi efried, jaypipes: it is all about indirectly sharing resources through a non sharing RP
10:20:46 openstackgerrit Rajesh Tailor proposed openstack/nova master: Fix case-sensitivity for metadata keys https://review.openstack.org/504885
10:27:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601
11:06:37 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617
11:08:19 gibi efried, jaypipes: One more set of test case now for CN1 <- SS -> CN2 type of setup. Simple case works but a more complicated one mixes unconnected RPs: https://review.openstack.org/#/c/519617/
11:28:27 jianghuaw bauzas: Can we make this common patch be merged or still need further actions? https://review.openstack.org/#/c/512580/
11:33:00 moshele stephenfin: hi
11:37:53 moshele ramishra
11:51:31 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965
11:51:31 openstackgerrit Jianghua Wang proposed openstack/nova master: vgpu: add enabled white list https://review.openstack.org/512580
11:51:32 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
11:51:32 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217
11:55:16 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
11:58:37 openstackgerrit Merged openstack/nova master: Handle InstanceNotFound when setting password via metadata https://review.openstack.org/472933
11:59:33 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
12:09:19 openstackgerrit Elod Illes proposed openstack/nova master: Deduplicate server_group samples https://review.openstack.org/519629
12:10:33 openstackgerrit Matthew Booth proposed openstack/nova stable/pike: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/519632
12:10:33 openstackgerrit Matthew Booth proposed openstack/nova stable/pike: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/519631
12:22:32 openstackgerrit Matthew Booth proposed openstack/nova stable/ocata: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/519636
12:22:32 openstackgerrit Matthew Booth proposed openstack/nova stable/ocata: libvirt: bandwidth param should be set in guest migrate https://review.openstack.org/519635
12:37:03 openstackgerrit Merged openstack/nova master: block_device_mapping_v2.bus_type is missing from api-ref https://review.openstack.org/499488
12:37:10 openstackgerrit Merged openstack/nova master: Fix test_get_volume_config method https://review.openstack.org/489467
12:37:16 openstackgerrit Merged openstack/nova master: Fix wrapping of neutron forbidden error https://review.openstack.org/508802
12:45:57 efried gibi Thanks for the new tests, will look shortly.
13:03:15 openstackgerrit Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
13:03:15 openstackgerrit Eric Fried proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
13:03:16 openstackgerrit Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
13:03:16 openstackgerrit Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
13:03:17 openstackgerrit Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799
13:03:33 efried gibi ^ includes re-inserting that busted dependency in the middle.
13:06:15 openstackgerrit Eric Fried proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
13:06:15 openstackgerrit Eric Fried proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
13:06:16 openstackgerrit Eric Fried proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
13:06:16 openstackgerrit Eric Fried proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
13:06:17 openstackgerrit Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799
13:06:21 efried Dang, missed a rename, fixed ^
13:08:23 gibi efried: your https://review.openstack.org/#/c/514092 bounced back from the gate as it needs a rebase and a unit test fix
13:09:03 efried gibi Thanks, on it.
13:12:56 openstackgerrit Eric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests} https://review.openstack.org/514092
13:13:00 efried gibi ^ hecho
13:13:05 efried jaypipes Welcome back!
13:13:17 jaypipes efried: heh, thanks :)
13:13:49 alex_xu jaypipes: good morning!
13:13:58 jaypipes alex_xu: is it? :)
13:14:10 efried Friday jaypipes open patches: 13; merge conflicts: 12. Tuesday jaypipes open patches: 13; merge conflicts: 1
13:14:14 efried I'd say that's a good morning.
13:14:29 alex_xu sounds like all of us are wating for you :)
13:14:29 jaypipes efried: oh, excellent :)
13:14:54 jaypipes alex_xu: yeah, had a "lovely" new-hire training session up in Tampa yesterday ...
13:15:12 alex_xu jaypipes: efried, just want to show you this patch https://review.openstack.org/519081
13:15:28 alex_xu new-hire training is always lovely
13:16:43 openstackgerrit Eric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests} https://review.openstack.org/514092
13:16:44 alex_xu jaypipes: efried I didn't some test last week on 1w rps and probably 70% loads on each rp, then I found that sql is faster than the current one. The current one will spend 1.7s in my env, the new sql just spend 0.7s
13:16:52 alex_xu s/didn't/did/...
13:17:33 efried alex_xu It was on my list to look at. I wanted to scrutinize the functional test a bit.
13:17:46 jaypipes alex_xu: what is 1w rps?
13:18:05 alex_xu efried: ok, thanks
13:18:17 alex_xu jaypipes: 10000 resource providers...
13:21:38 jaypipes alex_xu: can you put your DB setup into a pastebin please? # rps, inventory records used per rc, number of allocations used per rp, etc
13:22:22 alex_xu jaypipes: ok
13:26:49 alex_xu jaypipes: here is https://pastebin.com/kPMtEcQb, i just copy the variables from my script
13:27:48 jaypipes alex_xu: k, thank you sir :) I'll run benchmarks later today.
13:29:50 alex_xu jaypipes: cool
13:30:27 alex_xu jaypipes: also a non-shared version at https://review.openstack.org/#/c/516778/6/nova/objects/resource_provider.py@2518
13:31:13 jaypipes alex_xu: k
13:31:18 efried alex_xu I rebased your patch on top of the pending series - the one with all the extra tests in it - and it's failing some stuff.
13:32:28 efried alex_xu There are a number of cases where it's returning zero candidates.
13:32:43 jaypipes alex_xu: sum(invs.resource_class_id) is not what you're looking for there. I believe you're looking for count(distinct invs.resource_class_id)
13:35:18 alex_xu jaypipes: oops, that is true
13:35:30 alex_xu jaypipes: but it shoudl works with count
13:35:36 jaypipes alex_xu: yep.
13:35:47 alex_xu efried: sorry, which patch?
13:35:57 efried https://review.openstack.org/#/c/519081/
13:35:58 jaypipes alex_xu: I'll benchmark later today. I have a dentist appointment shortly and will set up benchmarks after that
13:36:11 alex_xu jaypipes: ok, no problem
13:37:07 alex_xu efried: ok, I will try to debug them
13:37:43 efried alex_xu Note that some of the test cases are highlighting bugs, so the current 'expected' value is wrong - but the correct 'expected' value is in the comments, and it still ain't []
13:38:06 alex_xu efried: got it, thanks
13:42:33 sean-k-mooney jaypipes: o/
13:43:11 gibi efried: thanks for the fix on the get_by_requests refactor patch. I'm +2.
13:43:14 sean-k-mooney jaypipes: can i get you to weigh in on a matter of os-vif policy. specifcally https://review.openstack.org/#/c/484386/ and the extention of our public api.
13:43:54 gibi efried: Do you agree to move https://review.openstack.org/#/c/518633/ top of Jay's series as that will decrease the amount of visible bugs in the patch?
13:44:10 sean-k-mooney jaypipes: i -2'd the previous itteration that added a shared implementation to os-vif.common
13:44:36 sean-k-mooney jaypipes: it has now been split but sahid dislikes the code duplication in tree this causes
13:45:56 sean-k-mooney as a counter proposal the only path i see forward to not extend the publci api and avoid duplication is to have a os-vif.internal and use an assertion to ensure that no one else can import it like this http://paste.openstack.org/show/626267/. toughts?
13:51:34 efried gibi I was just looking at that. In general I'm in favor of moving any test patches on top of that series, as it does seem to be resolving *some* issues.
13:52:31 efried gibi As we were discussing above, I'm also in favor of putting things like refactors on top of that series because the extra tests will flush out more bugs.
13:52:51 efried (refactors of the prod code)
13:52:58 gibi efried: cool. If you move that there I can quickly re-review and +2 it :)
14:19:03 gibi edleafe: welcome back
14:20:45 bauzas edleafe: hope you didn't get sick and your IRC bouncer is fine, unlike me
14:21:15 bauzas oh, and my corp phone died too
14:23:18 edleafe bauzas: znc was humming along nicely in my absence

Earlier   Later