Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-06
19:51:05 jaypipes efried: func tests for the allocation candidates would be great, thanks. FYI, I'm kinda in and out doing chores and helping my wife with her rental property this afternoon.
19:52:39 efried ack
19:56:53 crlb Hello melwitt, are you there?
20:01:26 jaypipes crlb: melwitt is in Sydney
20:04:31 crlb Hi jaypipes, Thank you. I was having trouble with git review after amending a previous review. I'm doing some reading now. May I trouble you if I still have questions?
20:04:44 jaypipes crlb: sure, np
20:05:27 crlb I'm being called away, so maybe 1 to 2 hours from now.
20:10:19 openstackgerrit Merged openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453
20:23:34 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Granular requests to get_allocation_candidates https://review.openstack.org/515811
20:24:00 efried jaypipes Since the dependency was going to be in place anyway, it was trivial to change this ^ to just do the call with the new syntax as well.
21:46:57 mriedem o/
21:48:06 mriedem sdague: can you hit https://review.openstack.org/#/c/517879/ and https://review.openstack.org/#/c/517876/ on stable/pike please? pretty nasty bugs.
21:51:15 sdague mriedem done
21:51:33 sdague hope sydney is treating you well, and you've managed a kangaroo steak
21:53:07 mriedem sdague: thanks. no kangaroo steak yet - actually only interested in sausage form.
21:53:20 mriedem i've been warned that the steak is super easy to overcook
21:54:49 sdague yeh, you have to eat it rare, medium rare at most, otherwise it hardens up
21:58:14 mriedem i did have some tim tams
21:58:25 mriedem and have experienced their oversized coinage
22:12:30 efried sdague You're not in Sydney?
22:15:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle InstanceNotFound when setting password via metadata https://review.openstack.org/472933
22:18:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Add error message on metadata API https://review.openstack.org/517152
22:35:54 mriedem lyarwood: want to take a look at these backports when you get a chance? https://review.openstack.org/#/q/I29fac80d08baf64bf69e54cf673e55123174de2a
22:36:01 mriedem libvirt resize booboo with shared storage
22:36:08 mriedem red hat might care about that for ceph, maybe a little
22:45:46 openstackgerrit C Leavett-Brown proposed openstack/nova master: Modify nova routing table to process null requests https://review.openstack.org/518119
23:26:18 openstackgerrit Eric Fried proposed openstack/nova master: Extract allocation candidates functional tests https://review.openstack.org/518123
23:26:19 openstackgerrit Eric Fried proposed openstack/nova master: Refactor test_allocation_candidates https://review.openstack.org/518124
23:26:41 efried jaypipes ^ No new tests yet; just a 33% reduction in LOC (so I can see an entire test on one screen (sometimes))
23:27:20 jaypipes efried: reviewing your get_by_requests() patch now..
23:27:29 efried jaypipes Cool.
23:27:41 jaypipes efried: couple little niggles, but overall excellent work.
23:27:47 efried jaypipes Thanks :)
23:28:45 jaypipes efried: k, done with review.
23:29:44 efried jaypipes I'd be happy to do that rebase; I'm now used to refactoring these tests.
23:30:05 jaypipes efried: no worries, I can do the rebasing. I'm also quite used to it by now ;)
23:41:30 openstackgerrit Eric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests} https://review.openstack.org/514092
23:41:46 efried jaypipes Done ^ See ya tomorrow.
23:43:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Fix a wrong redirection in placement doc https://review.openstack.org/517163
23:44:06 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Fix a wrong redirection in placement doc https://review.openstack.org/517163
23:51:43 tjones hi can you send me the etherpad on what help you need on k8s?
23:51:52 tjones oops
#openstack-nova - 2017-11-07
00:04:48 openstackgerrit Merged openstack/nova stable/ocata: Functional regression test for evacuate with a target https://review.openstack.org/491000
00:04:53 openstackgerrit Merged openstack/nova stable/pike: Functional regression test for evacuate with a target https://review.openstack.org/516111
00:14:32 openstackgerrit Merged openstack/nova stable/pike: Pass requested_destination in filter_properties https://review.openstack.org/516112
00:14:37 openstackgerrit Merged openstack/nova stable/ocata: Pass requested_destination in filter_properties https://review.openstack.org/491001
00:31:26 openstackgerrit Chris Dent proposed openstack/nova-specs master: Add spec for symmetric GET and PUT of allocations https://review.openstack.org/508164
00:37:48 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
01:06:53 openstackgerrit gengchc2 proposed openstack/nova master: Improved the judgment of the service status in memcache https://review.openstack.org/423754
01:21:23 openstackgerrit Merged openstack/nova stable/pike: Avoid deleting allocations for instances being built https://review.openstack.org/517879
01:47:40 moshele stephenfin: hi
02:19:00 openstackgerrit yangweiwei proposed openstack/nova stable/pike: Fix a bug in libvirt driver https://review.openstack.org/518198
03:09:59 openstackgerrit Merged openstack/nova stable/pike: Clean up allocations if instance deleted during build https://review.openstack.org/517876
04:48:46 openstackgerrit Chris Dent proposed openstack/nova master: [placement] set accept to application/json if accept not set https://review.openstack.org/518223
04:49:36 cdent edleafe: if you have thoughts on the microversion issue on that, that would be good to know ^
05:27:40 openstackgerrit Chen proposed openstack/nova-specs master: This spec is to add support for subnet assignment when creating servers. https://review.openstack.org/518227
05:41:05 openstackgerrit Chen proposed openstack/nova-specs master: Add support for subnet assignment when creating servers https://review.openstack.org/518227
06:18:54 openstackgerrit Vu Cong Tuan proposed openstack/nova master: Do not use “-y” for package install https://review.openstack.org/518238
06:48:04 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
06:51:11 openstackgerrit yangweiwei proposed openstack/nova master: Fix a bug in libvirt driver https://review.openstack.org/518250
07:58:11 openstackgerrit Merged openstack/nova master: check query param for used_limits function https://review.openstack.org/499091
08:09:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: reno for notification-transformation-pike https://review.openstack.org/518018
09:02:52 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Set group_members when converting to legacy request spec https://review.openstack.org/517860
09:50:09 openstackgerrit Merged openstack/nova master: VMware: add support for graceful shutdown of instances https://review.openstack.org/494169
10:16:52 openstackgerrit Yikun Jiang proposed openstack/nova master: WIP: Add cross cell sort support for get_migrations https://review.openstack.org/517273
11:05:18 openstackgerrit Jianghua Wang proposed openstack/nova master: rt: Make resource tracker always invoking get_inventory() https://review.openstack.org/518294
11:06:08 jianghuaw bauzas, ^
11:07:05 jianghuaw bauzas, Please help to check if the change is expected. Thanks.
12:54:53 openstackgerrit Eric Fried proposed openstack/nova master: Refactor test_allocation_candidates https://review.openstack.org/518124
12:55:14 openstackgerrit Yikun Jiang proposed openstack/nova master: WIP: Add cross cell sort support for get_migrations https://review.openstack.org/517273
13:46:42 openstackgerrit Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799
14:04:33 openstackgerrit Mike Lowe proposed openstack/nova master: Take no chance an assigned disk device address will be overwritten during migration https://review.openstack.org/518022
14:28:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: reno for notification-transformation-queens https://review.openstack.org/518018
14:44:32 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
14:55:28 jaypipes efried: not sure what Eric Berglund's IRC nick is, could you clue me in?
14:55:35 efried esberglu
14:55:39 efried jaypipes ^
14:55:54 jaypipes aha
14:55:56 esberglu jaypipes: What's up?
14:56:13 jaypipes esberglu: hey, if you make that one correction on the config drive patch, I'll quick +2 it.
14:56:27 jaypipes esberglu: noticed something on last review that I missed on an earlier revision.
14:58:33 efried jaypipes Nice catch. I believe we're doing that same thing in *all* of our OOT tests.
14:58:51 jaypipes efried: OOT?
14:58:59 efried (Out-of-tree)
14:59:05 jaypipes efried: ah :)
14:59:10 jaypipes you and your TLAs.
14:59:38 jaypipes efried: changing to NoDBTestCase provides a nice little performance boost, FYI.
14:59:47 efried Good deal.
15:00:50 efried esberglu When you get a chance, wanna do a sweep of the nova-powervm test suites and swap all of them over to NoDBTestCase?
15:01:16 esberglu efried: Will do
15:01:19 efried thx
15:01:59 jaypipes efried: one other nice thing about NoDBTestCase is that if any of the test code *does* touch the DB, there is a poison fixture that will blow up, telling the developer that they are stating the test code doesn't touch the DB, but in fact, does touch the DB.
15:02:29 efried jaypipes I really *hope* our virt driver code doesn't touch the DB directly.
15:02:47 jaypipes efried: every once in a while, that poison fixture has been a friend to me identifying places where I had no idea we were touching the DB ;)
15:02:48 efried Though actually I think I saw a case of it the other day...
15:04:04 efried jaypipes https://review.openstack.org/#/c/422512/25/nova/virt/powervm/tasks/network.py@155 <= that's a DB touch, nah?
15:04:18 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
15:04:24 esberglu jaypipes: Done. tx
15:04:32 jaypipes efried: yes, it is. :)
15:05:22 jaypipes esberglu: cool, thanks.

Earlier   Later