| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-11-03 | |||
| 09:43:21 | openstackgerrit | Rong Han proposed openstack/nova master: Fixed the known vcpuset description of CPUPinningUnknown https://review.openstack.org/517592 | |
| 09:51:42 | tomsou_ | openstack: ping | |
| 11:01:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | |
| 11:01:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | |
| 11:01:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860 | |
| 11:01:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820 | |
| 11:01:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples https://review.openstack.org/515745 | |
| 11:01:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples https://review.openstack.org/515740 | |
| 11:01:28 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples https://review.openstack.org/515751 | |
| 11:55:18 | fried_rice | gibi for https://review.openstack.org/#/c/517364/ - I'm just gonna remove the __eq__ method and rebase the other patches to do the equality in the UT modules themselves. That cool with you? | |
| 12:11:17 | fried_rice | leakypipes Good morning! | |
| 12:11:34 | leakypipes | fried_rice: good morning, my non-Sydney colleague :) | |
| 12:12:05 | fried_rice | I would say I'm sad I'm not in Sydney, if that was true. | |
| 12:12:43 | leakypipes | fried_rice: ack | |
| 12:13:45 | fried_rice | leakypipes I'm going to restack the forked series to address gibi's comment on the common RequestGroup thingy. I had some questions for you on https://review.openstack.org/#/c/515151/ if you have a chance to look real quick; then I can do it all together. | |
| 12:14:05 | leakypipes | fried_rice: yup, totes | |
| 12:14:42 | fried_rice | leakypipes BTW, my plan is just to rip out that __eq__ method - it was just for testing anyway, so I'm going to fold it into the UT code itself. You on board with that? | |
| 12:14:59 | leakypipes | fried_rice: absolutely. | |
| 12:15:01 | fried_rice | k | |
| 12:15:09 | leakypipes | gibi's comment made sense | |
| 12:21:32 | openstackgerrit | Eric Fried proposed openstack/nova master: RequestGroup class for placement & consumers https://review.openstack.org/517364 | |
| 12:21:33 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Numbered groupings to GET /allocation_candidates https://review.openstack.org/514092 | |
| 12:21:33 | openstackgerrit | Eric Fried proposed openstack/nova master: placement: Parse granular resources & traits https://review.openstack.org/514091 | |
| 12:21:41 | leakypipes | mikal: as requested. :) https://review.openstack.org/#/c/517617/ | |
| 12:42:55 | leakypipes | alex_xu: not sure if you're around, but if you are, let me know your thoughts on my response to your comment on https://review.openstack.org/#/c/516779/ | |
| 12:45:05 | leakypipes | fried_rice: your opinion on ^ would be great, too | |
| 12:45:17 | fried_rice | leakypipes ack | |
| 12:45:42 | fried_rice | leakypipes Saw the discussion, was staying out of it. But since you asked... | |
| 12:46:03 | leakypipes | fried_rice: staying out of a discussion? that's not like you... | |
| 12:46:38 | fried_rice | Wow | |
| 12:46:46 | leakypipes | fried_rice: :P | |
| 12:51:03 | fried_rice | leakypipes My take on alex_xu's comment is that he was after performance, not LOC. And what you suggest is the same execution-wise (plus a negligible amount of call stack overhead) so I don't see the benefit. | |
| 12:54:41 | mdbooth | Any cores not on a plane, could somebody please restore the +W to https://review.openstack.org/#/c/507202/ after a rebase? | |
| 12:55:42 | mdbooth | Gerrit complained of a merge conflict, but I was still able to use the rebase button... | |
| 12:59:55 | fried_rice | leakypipes ^ (FWIW, the rebase looks clean to me) | |
| 13:01:31 | openstackgerrit | guanzuoyu proposed openstack/nova master: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/517227 | |
| 13:08:21 | gibi | fried_rice: removing __eq__ sound OK to me. I will check back to the review soon | |
| 13:08:31 | fried_rice | gibi Thanks! | |
| 13:10:27 | leakypipes | fried_rice: yeah, and I don't think the performance difference is worth adding the complexity to the object state. | |
| 13:10:40 | leakypipes | fried_rice: and needing to deal with cache coherence issues. | |
| 13:11:21 | fried_rice | leakypipes I can't speak to that (no idea about the performance of versioned objects), which is why I was staying out of it. alex_xu is +2 anyway, so... :) | |
| 13:12:33 | fried_rice | mdbooth - gibi gotcha covered | |
| 13:12:56 | gibi | :) | |
| 13:12:56 | gibi | mdbooth: yep, just +Wd it 10 seconds ago | |
| 13:12:58 | mdbooth | fried_rice: gibi Thanks | |
| 13:26:50 | openstackgerrit | Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223 | |
| 13:26:50 | openstackgerrit | Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151 | |
| 13:26:51 | openstackgerrit | Eric Fried proposed openstack/nova master: ResourceRequest.to_querystring() https://review.openstack.org/515811 | |
| 13:27:09 | fried_rice | leakypipes I just removed the traits check for now; let me know if you want me to muck with the ResourceClass check. ^ | |
| 13:30:31 | leakypipes | fried_rice: k. | |
| 13:30:54 | leakypipes | fried_rice: getting some breakfast and then still trying to fix the dang n-r-p failing func tests... | |
| 13:31:01 | fried_rice | ack | |
| 13:49:50 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/517489 | |
| 13:54:12 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035 | |
| 14:00:15 | openstackgerrit | Eric Fried proposed openstack/nova master: Update contributor microversion doc for compute https://review.openstack.org/517626 | |
| 14:00:22 | fried_rice | mriedem ^ | |
| 14:22:21 | openstackgerrit | Eric Fried proposed openstack/nova master: Update contributor microversion doc for compute https://review.openstack.org/517626 | |
| 14:23:39 | mriedem | mikal: just realized you have a specific session for privsep at the forum http://forumtopics.openstack.org/cfp/details/41 | |
| 14:23:48 | mriedem | so you have to start your own etherpad and add it to https://wiki.openstack.org/wiki/Forum/Sydney2017 | |
| 14:41:22 | leakypipes | fried_rice: +W on bottom two of the placement-side | |
| 14:41:35 | fried_rice | leakypipes Whee! Thanks. | |
| 14:42:43 | fried_rice | leakypipes I think I'm going to change the WIP that's on top there to use the new format like it's doing, but pull out the old-style data, so it stays doing what it's doing. Then do the actual API change with microversion later. (Much later - once the whole refactor and alex_xu's stack is ready.) | |
| 14:42:57 | leakypipes | ++ | |
| 14:54:52 | fried_rice | leakypipes Is there something still needed on https://review.openstack.org/#/c/515151/ ? | |
| 14:55:23 | leakypipes | fried_rice: yeah, gonna do what you suggested in PS3 | |
| 14:56:07 | kashyap | mdbooth: Why is Zuul -2 on this change? Or is it just its way of telling: "Waiting to merge"? | |
| 14:56:10 | kashyap | https://review.openstack.org/#/c/507202/ | |
| 14:56:54 | kashyap | Okay, I take that as a signal for: "Blocked on Verified Label". Ignore me. | |
| 14:56:56 | fried_rice | leakypipes You're talking about https://review.openstack.org/#/c/516781/ ? Cool. I was talking about https://review.openstack.org/#/c/515151/ though. | |
| 14:57:59 | fried_rice | kashyap It's a signal for "post a recheck" :) Which I've just done. | |
| 14:58:10 | fried_rice | kashyap Unrelated moon phase timeout. | |
| 14:58:53 | kashyap | fried_rice: Ah, thanks. (Your Friday nick is making me hungry) | |
| 14:59:11 | fried_rice | kashyap :) I'm always hungry. | |
| 14:59:12 | leakypipes | fried_rice: ah, yeah, sorry. I personally find "if (not valid_this_way and not invalid_that_way)" to be easier to read than "if not (valid_this_way or valid_that_way)" but it's a total preference. | |
| 14:59:24 | leakypipes | fried_rice: and no, nothing left to do on that patch IMHO | |
| 14:59:56 | leakypipes | fried_rice: +2df | |
| 15:00:07 | fried_rice | leakypipes Thanks! | |
| 15:02:53 | fried_rice | leakypipes I'm gonna take cdent's 'symmetric' series and at least resolve merge conflicts FYI. | |
| 15:03:04 | leakypipes | fried_rice: the spec? | |
| 15:03:17 | leakypipes | fried_rice: cuz mriedem had negative comments on the spec | |
| 15:03:34 | fried_rice | leakypipes He updated the spec. I made some minor comments on it, but it's basically good to go. | |
| 15:03:53 | fried_rice | leakypipes I'm talking about the code series starting at https://review.openstack.org/#/c/512420/ | |
| 15:05:49 | fried_rice | leakypipes I'll probably make those spec edits too when I'm done with the code series. | |
| 15:05:54 | leakypipes | fried_rice: k, go for it then :) | |
| 15:06:42 | fried_rice | (I was telling you in case you were looking to do the same, or had already started. But I take it from your reaction that it wasn't on your radar :) | |
| 15:09:43 | leakypipes | fried_rice: correctomundo. | |
| 15:10:30 | openstackgerrit | Eric Fried proposed openstack/nova master: Include project_id and user_id in AllocationList.get_all_by_consumer_id https://review.openstack.org/512420 | |
| 15:10:31 | openstackgerrit | Eric Fried proposed openstack/nova master: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073 | |
| 15:10:31 | openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Symmetric GET and PUT /allocations/{consumer_uuid} https://review.openstack.org/510626 | |
| 15:12:21 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | |
| 15:12:21 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | |
| 15:12:42 | leakypipes | fried_rice: fixed func test issues (friggin case-sensitive HTTP headers...) | |
| 15:12:45 | leakypipes | ^^ | |
| 15:12:53 | fried_rice | leakypipes Ack | |
| 15:14:12 | alex_xu | fried_rice: leakypipes morning | |
| 15:14:22 | leakypipes | alex_xu: good evening, sir! | |
| 15:14:24 | fried_rice | alex_xu Howdy | |
| 15:15:00 | alex_xu | leakypipes: yea, I already +2 on that patch, just throw an idea, actually I don't have mind how much time spend on running those small loop mulitple times, anyway that isn't a blocker | |
| 15:15:25 | leakypipes | alex_xu: understood. I'm still going to add that @property because I think it makes the calling code more readable. | |
| 15:15:51 | alex_xu | fried_rice: in normaly, what kind of response is for 'Howdy' in English? | |