Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-03
01:10:43 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/517489
01:22:50 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
02:16:36 openstackgerrit Moshe Levi proposed openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/505613
02:32:53 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
02:35:11 openstackgerrit Michael Still proposed openstack/nova master: Convert ext filesystem resizes to privsep. https://review.openstack.org/517516
02:40:19 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205
02:54:42 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
02:59:04 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:26:55 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
03:27:46 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
03:46:11 openstackgerrit Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904
03:50:14 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
06:17:10 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205
06:54:20 openstackgerrit Chen Hanxiao proposed openstack/nova master: libvirt: do unicode conversion for error messages. https://review.openstack.org/517555
09:33:12 openstackgerrit Yikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
09:36:14 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/507202
09:41:19 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899
09:43:21 openstackgerrit Rong Han proposed openstack/nova master: Fixed the known vcpuset description of CPUPinningUnknown https://review.openstack.org/517592
09:51:42 tomsou_ openstack: ping
11:01:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819
11:01:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818
11:01:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860
11:01:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820
11:01:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples https://review.openstack.org/515745
11:01:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples https://review.openstack.org/515740
11:01:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples https://review.openstack.org/515751
11:55:18 fried_rice gibi for https://review.openstack.org/#/c/517364/ - I'm just gonna remove the __eq__ method and rebase the other patches to do the equality in the UT modules themselves. That cool with you?
12:11:17 fried_rice leakypipes Good morning!
12:11:34 leakypipes fried_rice: good morning, my non-Sydney colleague :)
12:12:05 fried_rice I would say I'm sad I'm not in Sydney, if that was true.
12:12:43 leakypipes fried_rice: ack
12:13:45 fried_rice leakypipes I'm going to restack the forked series to address gibi's comment on the common RequestGroup thingy. I had some questions for you on https://review.openstack.org/#/c/515151/ if you have a chance to look real quick; then I can do it all together.
12:14:05 leakypipes fried_rice: yup, totes
12:14:42 fried_rice leakypipes BTW, my plan is just to rip out that __eq__ method - it was just for testing anyway, so I'm going to fold it into the UT code itself. You on board with that?
12:14:59 leakypipes fried_rice: absolutely.
12:15:01 fried_rice k
12:15:09 leakypipes gibi's comment made sense
12:21:32 openstackgerrit Eric Fried proposed openstack/nova master: RequestGroup class for placement & consumers https://review.openstack.org/517364
12:21:33 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Numbered groupings to GET /allocation_candidates https://review.openstack.org/514092
12:21:33 openstackgerrit Eric Fried proposed openstack/nova master: placement: Parse granular resources & traits https://review.openstack.org/514091
12:21:41 leakypipes mikal: as requested. :) https://review.openstack.org/#/c/517617/
12:42:55 leakypipes alex_xu: not sure if you're around, but if you are, let me know your thoughts on my response to your comment on https://review.openstack.org/#/c/516779/
12:45:05 leakypipes fried_rice: your opinion on ^ would be great, too
12:45:17 fried_rice leakypipes ack
12:45:42 fried_rice leakypipes Saw the discussion, was staying out of it. But since you asked...
12:46:03 leakypipes fried_rice: staying out of a discussion? that's not like you...
12:46:38 fried_rice Wow
12:46:46 leakypipes fried_rice: :P
12:51:03 fried_rice leakypipes My take on alex_xu's comment is that he was after performance, not LOC. And what you suggest is the same execution-wise (plus a negligible amount of call stack overhead) so I don't see the benefit.
12:54:41 mdbooth Any cores not on a plane, could somebody please restore the +W to https://review.openstack.org/#/c/507202/ after a rebase?
12:55:42 mdbooth Gerrit complained of a merge conflict, but I was still able to use the rebase button...
12:59:55 fried_rice leakypipes ^ (FWIW, the rebase looks clean to me)
13:01:31 openstackgerrit guanzuoyu proposed openstack/nova master: Modify incorrect debug meaasge in _inject_data https://review.openstack.org/517227
13:08:21 gibi fried_rice: removing __eq__ sound OK to me. I will check back to the review soon
13:08:31 fried_rice gibi Thanks!
13:10:27 leakypipes fried_rice: yeah, and I don't think the performance difference is worth adding the complexity to the object state.
13:10:40 leakypipes fried_rice: and needing to deal with cache coherence issues.
13:11:21 fried_rice leakypipes I can't speak to that (no idea about the performance of versioned objects), which is why I was staying out of it. alex_xu is +2 anyway, so... :)
13:12:33 fried_rice mdbooth - gibi gotcha covered
13:12:56 gibi :)
13:12:56 gibi mdbooth: yep, just +Wd it 10 seconds ago
13:12:58 mdbooth fried_rice: gibi Thanks
13:26:50 openstackgerrit Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223
13:26:50 openstackgerrit Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151
13:26:51 openstackgerrit Eric Fried proposed openstack/nova master: ResourceRequest.to_querystring() https://review.openstack.org/515811
13:27:09 fried_rice leakypipes I just removed the traits check for now; let me know if you want me to muck with the ResourceClass check. ^
13:30:31 leakypipes fried_rice: k.
13:30:54 leakypipes fried_rice: getting some breakfast and then still trying to fix the dang n-r-p failing func tests...
13:31:01 fried_rice ack
13:49:50 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/517489
13:54:12 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
14:00:15 openstackgerrit Eric Fried proposed openstack/nova master: Update contributor microversion doc for compute https://review.openstack.org/517626
14:00:22 fried_rice mriedem ^
14:22:21 openstackgerrit Eric Fried proposed openstack/nova master: Update contributor microversion doc for compute https://review.openstack.org/517626
14:23:39 mriedem mikal: just realized you have a specific session for privsep at the forum http://forumtopics.openstack.org/cfp/details/41
14:23:48 mriedem so you have to start your own etherpad and add it to https://wiki.openstack.org/wiki/Forum/Sydney2017
14:41:22 leakypipes fried_rice: +W on bottom two of the placement-side
14:41:35 fried_rice leakypipes Whee! Thanks.
14:42:43 fried_rice leakypipes I think I'm going to change the WIP that's on top there to use the new format like it's doing, but pull out the old-style data, so it stays doing what it's doing. Then do the actual API change with microversion later. (Much later - once the whole refactor and alex_xu's stack is ready.)
14:42:57 leakypipes ++
14:54:52 fried_rice leakypipes Is there something still needed on https://review.openstack.org/#/c/515151/ ?
14:55:23 leakypipes fried_rice: yeah, gonna do what you suggested in PS3
14:56:07 kashyap mdbooth: Why is Zuul -2 on this change? Or is it just its way of telling: "Waiting to merge"?
14:56:10 kashyap https://review.openstack.org/#/c/507202/
14:56:54 kashyap Okay, I take that as a signal for: "Blocked on Verified Label". Ignore me.
14:56:56 fried_rice leakypipes You're talking about https://review.openstack.org/#/c/516781/ ? Cool. I was talking about https://review.openstack.org/#/c/515151/ though.
14:57:59 fried_rice kashyap It's a signal for "post a recheck" :) Which I've just done.
14:58:10 fried_rice kashyap Unrelated moon phase timeout.
14:58:53 kashyap fried_rice: Ah, thanks. (Your Friday nick is making me hungry)
14:59:11 fried_rice kashyap :) I'm always hungry.
14:59:12 leakypipes fried_rice: ah, yeah, sorry. I personally find "if (not valid_this_way and not invalid_that_way)" to be easier to read than "if not (valid_this_way or valid_that_way)" but it's a total preference.
14:59:24 leakypipes fried_rice: and no, nothing left to do on that patch IMHO
14:59:56 leakypipes fried_rice: +2df
15:00:07 fried_rice leakypipes Thanks!
15:02:53 fried_rice leakypipes I'm gonna take cdent's 'symmetric' series and at least resolve merge conflicts FYI.
15:03:04 leakypipes fried_rice: the spec?
15:03:17 leakypipes fried_rice: cuz mriedem had negative comments on the spec
15:03:34 fried_rice leakypipes He updated the spec. I made some minor comments on it, but it's basically good to go.
15:03:53 fried_rice leakypipes I'm talking about the code series starting at https://review.openstack.org/#/c/512420/
15:05:49 fried_rice leakypipes I'll probably make those spec edits too when I'm done with the code series.

Earlier   Later