Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-01
15:57:55 openstackgerrit Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640
15:58:12 dansmith mriedem: lots of test noise in there because of how those tests work, unfortunately
16:00:21 mriedem ok
16:11:29 jaypipes mriedem: k, will look shortly.
16:11:39 jaypipes Nisha_Agarwal: just got back to the office... gimme a few
16:13:10 openstackgerrit Jay Pipes proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027
16:13:21 jaypipes efried, alex_xu: ^
16:13:48 efried jaypipes Ack. I did some refactoring of the bottom patch - do you have local deltas?
16:14:51 jaypipes efried: yes
16:15:01 jaypipes efried: I pulled the latest from this morning.
16:16:16 efried jaypipes k, I'll wait. My deltas are improving the readability of that method. Only one of my tweaks actually changes the SQL that's produced, but the test result is still good, so if that's gonna break something, I'll need a test for it.
16:16:34 efried jaypipes We can discuss this p.m. if you're around.
16:17:10 jaypipes efried: readability of the test method or readability of the _get_provider_ids_no_share() method?
16:17:29 efried jaypipes Of _get_provider_ids_matching_all
16:18:10 efried jaypipes Mainly renaming variables and getting rid of unnecessary ones. But the SQL-changer is that 'jc' doesn't need to be linked to the lastij - it can always just compare against rpt.c.id.
16:18:30 jaypipes efried: ah, sure, ok.
16:18:35 efried jaypipes If that's not true, then I need a test path that brings it out.
16:18:49 efried But I don't see why it shouldn't be okay.
16:18:59 jaypipes efried: yes, like I said, I copied the code from the get_all_with_shared() and just removed things. didn't change anything. so I'm good with a change like that, sure.
16:19:19 efried jaypipes Okay, cool. I'll post it once you've done yours.
16:19:30 efried jaypipes Because I'm all about rebase, 'bout rebase. No trouble.
16:20:08 jaypipes efried: why don't you do that now. I can always stash, stash pop after pulling your latest.
16:20:19 efried Okay.
16:21:28 jaypipes Nisha_Agarwal: ok, done reading back... so, dansmith is correct. We will filter nodes based on traits first, then whatever nodes are leftover from that we will pass to the remaining scheduler filters, including the ComputeCapabilitiesFilter.
16:21:59 Nisha_Agarwal jaypipes, yeah.
16:22:01 jaypipes Nisha_Agarwal: I don't see why you'd have a problem, though. since it's not like the ComputeCapabilitiesFilter and trait strings overlap...
16:22:23 jaypipes Nisha_Agarwal: if you could show me a specific example of what your use case is, that would be super helpful.
16:22:48 openstackgerrit Eric Fried proposed openstack/nova master: begin refactor AllocCandidates._get_by_filters() https://review.openstack.org/516778
16:22:49 openstackgerrit Eric Fried proposed openstack/nova master: build alloc request resources for shared resources https://review.openstack.org/516780
16:22:49 openstackgerrit Eric Fried proposed openstack/nova master: build ProviderSummary objects in sep function https://review.openstack.org/516779
16:22:50 openstackgerrit Eric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters() https://review.openstack.org/516782
16:22:50 openstackgerrit Eric Fried proposed openstack/nova master: create allocation request for single provider https://review.openstack.org/516781
16:22:51 openstackgerrit Eric Fried proposed openstack/nova master: required traits for no sharing providers https://review.openstack.org/517027
16:22:51 Nisha_Agarwal jaypipes, i dont have any example. It was just a query which arose after our call yesterday
16:22:52 efried jaypipes ^ Out for a couple hours...
16:23:14 Nisha_Agarwal jaypipes, i can think of an example and and then reask the question again :)
16:23:47 tomsou_ Hello, can anyone help with the error message "CantStartEngineError: No sql_connection parameter is established" after "/bin/nova-manage cell_v2 list_cells --verbose" command?
16:24:02 tomsou_ mariadb is running
16:24:08 mriedem jaypipes: not sure if you had questions/items you'd like discussed at the placement update session in sydney, but here is the etherpad https://etherpad.openstack.org/p/SYD-forum-nova-placement-update
16:24:19 mriedem jaypipes: the agenda is empty for now, but the abstract has some items that could be moved into agenda
16:24:27 jaypipes efried_rollin: cool, thanks
16:24:41 jaypipes mriedem: rock on. will add shortly.
16:25:16 jaypipes Nisha_Agarwal: cool, thanks!
16:28:00 Nisha_Agarwal jaypipes, dansmith thanks !!
16:38:03 openstackgerrit C Leavett-Brown proposed openstack/nova master: Modify nova routing table to process null requests https://review.openstack.org/516796
16:48:49 dansmith edleafe: mriedem jaypipes: so.. we don't claim in the chance scheduler, and we don't heal allocations in the compute, which means we're not really setting the stage for people to be able to move from chance to filter+placement right?
16:49:01 dansmith there'll need to be some tool and procedure for patching that up prior to a cutover
16:49:28 jaypipes dansmith: by "tool" do you mean "delete the chance scheduler"? if so, then yes ++
16:49:50 dansmith sorry,
16:49:53 dansmith I meant the caching
16:50:13 dansmith although I guess the same goes for chance
16:50:29 mriedem yeah true
16:54:07 edleafe dansmith: yeah, caching scheduler rules out claiming
16:54:39 dansmith it doesn't have to, we just have said we don't want to make it do it right?
16:54:56 edleafe for simple compute nodes it's possible, but not for any that involve shared/nested providers
16:55:30 edleafe well, the only way to claim complex rps is to get the allocation_candidates, which means no caching
17:05:50 stephenfin mriedem: Done
17:17:09 mriedem stephenfin: thanks
17:30:21 mriedem dansmith: tssurya: melwitt: no cells meeting today right?
17:32:36 melwitt +1 to cancel today
17:53:00 dansmith mriedem: ah yep
18:39:38 openstackgerrit Merged openstack/nova master: Functional regression test for evacuate with a target https://review.openstack.org/490997
18:39:39 dansmith mriedem: so, this might be happening more often than we think.. I hit it on one of the runs on the fix patch
18:39:46 dansmith mriedem: what actual failure behavior did this cause?
18:40:46 dansmith also I guess I have to pass exc_info=False when I log.warning in an exception handler?
18:42:09 dansmith not really sure why
18:42:18 dansmith http://logs.openstack.org/09/517009/2/check/legacy-tempest-dsvm-neutron-multinode-full/cf39ab4/logs/screen-n-cpu.txt.gz#_Nov_01_16_51_15_194726
18:44:25 mriedem dansmith: ah on ^ that's the same thing we get with the ComputeHostNotFound_Remote warning on startup since ocata
18:44:35 mriedem i think that's a regression in the log handler stuff in oslo, i was never able to track it down
18:44:49 dansmith okay but exc_info=False will squelch it right?
18:44:52 mriedem i think there was a change in oslo.log such that it auto-traces if you're in an exception context
18:44:57 mriedem dansmith: idk honestly
18:44:59 mriedem it's worth a try
18:45:33 mriedem dansmith: as for the actual failure behavior, resize fails with a 400 (should be a 500)
18:45:48 mriedem because remember at the point in conductor when we are swapping the allocations, we haven't cast off to the compute yet,
18:45:52 mriedem so we're still returning a response from the api
18:46:03 dansmith okay so this was probably a silent leak before
18:46:05 mriedem yup
18:46:06 mriedem definitely
18:46:11 mriedem silent but deadly
18:46:12 dansmith le suck
18:46:17 openstackgerrit Dan Smith proposed openstack/nova master: Avoid deleting allocations for instances being built https://review.openstack.org/517009
18:46:51 dansmith jaypipes: did you see this?
18:51:08 openstackgerrit Merged openstack/nova master: Pass requested_destination in filter_properties https://review.openstack.org/481116
18:51:42 rabel now that i got a +2 from jaypipes, can we finally merge https://review.openstack.org/#/c/494169/ ? :)
18:51:49 jaypipes dansmith: did I see https://review.openstack.org/#/c/517009/?
18:52:16 dansmith jaypipes: yeah, just making sure you saw it
18:52:25 dansmith since we're tweaking that logic
18:52:32 jaypipes k
19:11:07 efried jaypipes Any further thoughts on shared-vs-separate RequestGroup classes? (Not sure if you read the backscroll this morning, but mriedem doesn't feel strongly one way or the other.)
19:11:23 jaypipes efried: what does dansmith think?
19:11:39 jaypipes efried: and no, been heads down on the shared/no-shared refactoring thing.
19:11:45 efried Didn't ask - he seemed kinda swamped today
19:38:10 mriedem stephenfin: do you want me to make the os-vif core team changes from your email now?
19:40:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Flavor.description attribute https://review.openstack.org/514371
19:40:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove compatibility method from FlavorPayload https://review.openstack.org/514943
19:40:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Add microversion to allow setting flavor description https://review.openstack.org/515213
19:40:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FlavorPayload.description for versioned notifications https://review.openstack.org/514782
20:15:57 openstackgerrit Matt Riedemann proposed openstack/nova master: Don't log exception trace with ComputeHostNotFound warnings on startup https://review.openstack.org/517102
20:40:45 mriedem jaypipes: think you need to drop the +2 on this https://review.openstack.org/#/c/517009/3

Earlier   Later