Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-31
20:15:56 efried mriedem Is a similar update needed at https://docs.openstack.org/nova/pike/contributor/microversions.html#other-necessary-changes ?
20:34:39 efried jaypipes Is this series going to have any additional UT?
20:34:51 jaypipes efried: no sir.
20:34:58 efried or functional, more to the point.
20:35:02 jaypipes efried: none of this is unit-tested.
20:35:15 jaypipes efried: nope. true refactoring. no functional changes at all.
20:36:12 efried jaypipes I haven't gone through the whole thing, but if that first thing is truly finding only RPs where *all* resources are satisfied, it's not going to be used yet (not until use_same_provider=True groups come in)
20:36:43 efried unless I'm totally missing something.
20:38:03 jaypipes efried: yes, you're missing something :) that first one is an optimized code path for when the *deployment has no sharing providers*, not for when the *request is for same provider*. :)
20:38:28 efried jaypipes So it'll need to be reworked for nested.
20:38:45 jaypipes efried: it's basically "hey, do we have any sharing providers? no? great, let's not fuck around with non-shared, shared mixology and just do this."
20:39:15 jaypipes efried: well, nested and sharing providers are different complexities, but yes.
20:39:33 efried jaypipes Cause with nested in play, but without shared, the "unnumbered" group ought to be able to get its resources from anywhere in the non-sharing tree.
20:39:58 jaypipes efried: sure, but this patch doesn't touch any of that.
20:40:36 efried jaypipes Cool, that's what I needed to understand. So we're currently assuming no nested, single compute node RP; and this method also assumes no shared.
20:40:58 jaypipes efried: correcto.
20:41:34 efried jaypipes And actually, when that stuff does come into play, we should leave this method alone, precisely for the use_same_provider=True case, and create different methods that handle nested and/or shared.
20:42:18 jaypipes efried: k, Parse granular resources & traits patch reviewed. great work on that. much improved.
20:42:26 mriedem efried: yes probably also need to say something in https://docs.openstack.org/nova/pike/contributor/microversions.html#other-necessary-changes about api-ref
20:42:32 jaypipes efried: you hit the nail on the head :)
20:42:47 efried jaypipes Rockin.
20:43:19 jaypipes efried: hit the nail on the head w.r.t. your description of the "leave this method alone" above.
20:43:38 jaypipes efried: and hit the naail on the head with your patch, too... but still needs a couple minor fixups.
20:43:46 efried jaypipes Onnit.
21:07:04 openstackgerrit Eric Fried proposed openstack/nova master: placement: Parse granular resources & traits https://review.openstack.org/514091
21:07:05 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Numbered groupings to GET /allocation_candidates https://review.openstack.org/514092
21:07:16 efried jaypipes Updated ^
21:07:28 efried (Left the WIP one alone for now)
21:08:30 efried jaypipes The other side still on your radar? https://review.openstack.org/#/c/515151/
21:31:59 openstackgerrit Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159
21:31:59 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
21:32:00 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
21:32:00 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707
21:32:01 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
21:51:34 efried jaypipes Would you be *offended* if I added a functional test for _get_provider_ids_matching_all ?
21:51:41 jaypipes efried: nope
21:51:55 jaypipes efried: looking at your "other side" patch now.
21:51:57 efried jaypipes Can I chuck it in the same change set?
21:52:04 jaypipes efried: of course!
21:52:12 efried (which entails rebasing the series)
21:54:21 jaypipes efried: yup, go for it.
21:55:08 openstackgerrit Eric Fried proposed openstack/nova master: begin refactor AllocCandidates._get_by_filters() https://review.openstack.org/516778
21:55:09 openstackgerrit Eric Fried proposed openstack/nova master: build alloc request resources for shared resources https://review.openstack.org/516780
21:55:09 openstackgerrit Eric Fried proposed openstack/nova master: build ProviderSummary objects in sep function https://review.openstack.org/516779
21:55:10 openstackgerrit Eric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters() https://review.openstack.org/516782
21:55:10 openstackgerrit Eric Fried proposed openstack/nova master: create allocation request for single provider https://review.openstack.org/516781
21:55:12 efried jaypipes ^ -- It works. I don't understand it yet, but it works.
21:55:47 jaypipes heh
22:13:29 openstackgerrit C Leavett-Brown proposed openstack/nova master: Closes-Bug: 1728732 https://review.openstack.org/516796
22:13:31 openstack bug 1728732 in OpenStack Compute (nova) "OpenStack nova service responds with an erroneous httpd redirect to a "GET,version_controller,show" request." [Undecided,In progress] https://launchpad.net/bugs/1728732 - Assigned to Colin Leavett-Brown (crlb-f)
22:18:08 edleafe efried: guess that's better than understanding it, but it doesn't work. :)
22:18:55 efried edleafe I dunno. If more people understand it, but it doesn't work, more than one person could conceivably fix it.
22:19:16 efried edleafe This is assuming, of course, that there are more people on the not-understanding side than on the understanding side.
22:20:15 efried edleafe It may just be that this stuff is hard and I need to study it until it clicks. I'd be curious to see how SQL afficionados such as yourself perceive it.
22:20:33 efried edleafe Talking specifically about the new method in https://review.openstack.org/#/c/516778/
23:33:45 openstackgerrit Eric Fried proposed openstack/nova master: placement: Parse granular resources & traits https://review.openstack.org/514091
23:33:46 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Numbered groupings to GET /allocation_candidates https://review.openstack.org/514092
#openstack-nova - 2017-11-01
01:26:47 openstackgerrit Merged openstack/nova master: [placement] avoid case issues microversions in gabbits https://review.openstack.org/516662
02:17:19 jianghuaw dansmith, alex_xu Could you have a look at this patch when you have time? -
02:17:20 jianghuaw vgpu: add enabled white list : https://review.openstack.org/#/c/512580/
02:19:32 jianghuaw That's common dependent things for libvirt and xenapi on implementing vGPU feature. If that can be merged earlier, less rebasing needed and more easier for the following development work. Thanks.
02:20:03 jianghuaw Thanks in advance.
02:22:37 alex_xu jianghuaw: will try later
02:22:53 jianghuaw alex_xu, thanks:-)
02:23:15 alex_xu jianghuaw: np
03:30:27 openstackgerrit Alex Xu proposed openstack/nova master: Add _get_providers_with_most_resource method https://review.openstack.org/514197
03:30:28 openstackgerrit Alex Xu proposed openstack/nova master: Add _get_traits_by_rp_ids method https://review.openstack.org/511184
03:30:28 openstackgerrit Alex Xu proposed openstack/nova master: Enable _get_usages_by_provider_and_rc not filter on the resource class id https://review.openstack.org/514649
03:30:29 openstackgerrit Alex Xu proposed openstack/nova master: Add ProviderSummaryList object https://review.openstack.org/514198
03:30:30 openstackgerrit Alex Xu proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766
03:30:30 openstackgerrit Alex Xu proposed openstack/nova master: Add AggregatedProviderSummary and AggregatedProviderSummaryList objects https://review.openstack.org/514200
04:26:08 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge flavor extensions controller code https://review.openstack.org/516104
05:04:57 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
06:30:05 openstackgerrit Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
06:32:13 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965
06:36:57 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217
06:44:01 Zoya Hello everyone..In my deployment at one stage nova-compute is being enabled..i.e., one feature is starting nova-compute
06:45:33 Zoya I need to stop this...But I can't touch the feature which is starting nova-compute..Is there any way where we can handle this situation..i.e., nova-compute should not start eventhough our feature tries to start
06:45:56 Zoya Please help me out..
06:46:02 Zoya Thanks in advance..
07:03:21 Zoya Hello everyone..In my deployment at one stage nova-compute is being enabled..i.e., one feature is starting nova-compute I need to stop this...But I can't touch the feature which is starting nova-compute..Is there any way to handle this situation..i.e., nova-compute should not start eventhough our feature tries to start Please help me out.. Thanks in advance..
07:06:00 Sara__ Hi
07:24:57 gmann alex_xu: updated this one - https://review.openstack.org/#/c/516104/3
07:25:51 alex_xu gmann: thanks
07:55:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: [placement] Fix foreign key constraint error https://review.openstack.org/516880
08:40:54 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965
08:54:09 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217
09:04:27 openstackgerrit Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406
09:17:16 openstackgerrit jichenjc proposed openstack/nova master: Remove direct usage of glance.generate_image_url https://review.openstack.org/511397
09:17:16 openstackgerrit jichenjc proposed openstack/nova master: remove glance usage inside compute https://review.openstack.org/511392
09:28:22 openstackgerrit Jianghua Wang proposed openstack/nova master: WIP: XenAPI: create vGPU for instance https://review.openstack.org/516899
09:37:50 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Mention API behavior change when over quota limit https://review.openstack.org/515631
09:53:02 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
10:56:31 Zoya Hello everyone..In my deployment at one stage nova-compute is being enabled..i.e., one feature is starting nova-compute I need to stop this...But I can't touch the feature which is starting nova-compute..Is there any way to handle this situation..i.e., nova-compute should not start eventhough our feature tries to start Please help me out.. Thanks in advance..
10:57:26 openstackgerrit Chris Dent proposed openstack/nova-specs master: Add spec for symmetric GET and PUT of allocations https://review.openstack.org/508164
10:59:08 cdent efried, jaypipes: as I’m not going to be around to do the adjustments to GET /allocation_candidates notes in that ^ spec update for about two weeks, either of you are welcome to adopt the stack at https://review.openstack.org/#/c/512420/
11:28:44 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035
12:19:13 efried cdent ack
12:20:41 jaypipes cdent: ack
12:22:41 efried cdent That one doesn't appear to be part of a series - did you mean the spec and this change https://review.openstack.org/510626 ?

Earlier   Later