Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-31
15:44:16 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860
15:44:16 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820
15:44:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples https://review.openstack.org/515745
15:44:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples https://review.openstack.org/515740
15:44:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples https://review.openstack.org/515751
15:47:40 gibi jaypipes: thanks for the review on the notification sample refactoring patches. I fixed your comments
15:47:55 jaypipes gibi: sweet. will re-review shortly
15:48:22 gibi jaypipes: thanks
15:50:09 jaypipes efried: love the stickers on your wall, Eric. very haut couture.
15:51:00 jaypipes efried: you and mriedem's velvet dobermann should compete :)
15:55:16 efried jaypipes It's my youngest son's room.
15:57:25 jaypipes efried: it's your office, just admit it Eric. :P
15:59:06 efried jaypipes You got me.
16:06:51 mriedem dansmith: commented
16:07:50 liuyulong Enable reset keypair while rebuilding instance https://review.openstack.org/#/c/379128/
16:08:15 liuyulong ^ needs nova cores review : )
16:09:21 dansmith mriedem: ack, will look in about an hour
16:10:48 mriedem edleafe: https://review.openstack.org/#/c/495854/ is failing
16:10:50 mriedem TypeErrors
16:22:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539
16:22:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159
16:22:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: factor out compute service start in ServerMovingTest https://review.openstack.org/503037
16:23:50 edleafe mriedem: looking...
16:26:23 openstackgerrit Balazs Gibizer proposed openstack/nova master: Document the real behavior of notify_on_state_change https://review.openstack.org/516264
17:00:46 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
17:00:47 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707
17:00:47 openstackgerrit Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159
17:00:48 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
17:00:48 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
17:20:41 openstackgerrit Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512
17:20:41 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
17:29:28 openstackgerrit Dan Smith proposed openstack/nova master: Make put_allocations() retry on concurrent update https://review.openstack.org/516708
17:29:29 openstackgerrit Dan Smith proposed openstack/nova master: Refactor claim_resources() to use retries decorator https://review.openstack.org/516709
17:43:41 mriedem dansmith: so i +2ed the bottom change but i think there is a thing in the top change (or two) that we want to do in the bottom
17:44:28 dansmith oh yeah sorry
17:44:37 dansmith was trying to fight through the call brain
17:44:56 mriedem np, i was pushing infra patches during a call this morning, so once those patches land and everything breaks we'll know why
17:45:17 mriedem those patches = my infra patches
17:45:59 dansmith noted
17:46:03 openstackgerrit Dan Smith proposed openstack/nova master: Make put_allocations() retry on concurrent update https://review.openstack.org/516708
17:46:04 openstackgerrit Dan Smith proposed openstack/nova master: Refactor claim_resources() to use retries decorator https://review.openstack.org/516709
17:48:29 mriedem jaypipes: easy peasy ^
17:48:52 jaypipes mriedem: cool. just wrapping up something locally and will look
18:19:03 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: do not remove inst_base when volume-backed during resize https://review.openstack.org/516395
18:19:37 mriedem oomichi: ^ and https://review.openstack.org/516396 in tempest are linked
18:19:58 mriedem verified the failure via the tempest test in the ceph and nfs jobs, now the tempest change depends on the nova fix which will have to go back to pike and ocata
18:27:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FlavorPayload.description for versioned notifications https://review.openstack.org/514782
18:27:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Flavor.description attribute https://review.openstack.org/514371
18:27:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add microversion to allow setting flavor description https://review.openstack.org/515213
18:35:54 dansmith man the gate is some kinda jammed up
18:37:33 jaypipes yeah..
18:46:30 mriedem https://www.youtube.com/watch?v=FcArnepkhv0 ?
18:57:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement power_off/power_on for the FakeDriver https://review.openstack.org/509935
19:03:24 efried mriedem Bringing FakeDriver to parity with the PowerVM in-tree driver, eh?
19:03:30 efried Bout time you caught up.
19:04:13 mriedem :)
19:05:37 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
19:08:39 openstackgerrit Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512
19:09:49 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
19:10:41 mriedem edleafe: cdent: i think i've found a chink in this armor https://review.openstack.org/#/c/508164/
19:10:58 mriedem and precisely why we wanted to include the microversion in the Selection object that the scheduler used to get allocation_candidates
19:11:27 openstackgerrit Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512
19:12:36 cdent mriedem: so the assumption I was making there is that that spec (and the related POST one) makes no demands on what the nova-side is doing, and nova can continue doing its thing at whatever microversion it likes, and we can migration the report client to the newer microversion across the board as required
19:12:57 cdent so while we can change the output of allocation_candidates we don’t have to
19:13:05 mriedem i think they should be consistent
19:13:11 cdent but if we do, we should do it soon
19:13:17 cdent s/should/could/
19:13:41 mriedem the point of GET /allocation_candidates was to return a thing that the caller can re-use for PUT /allocations/{consumer_id},
19:13:52 mriedem so to make those inconsistent with the new PUT /allocations/{consumer_id} would be confusing
19:13:57 cdent right, which it still can, if you use the right microversion
19:14:02 mriedem especially since nova (on the client side) doesn't do any microversoin negotiation
19:14:14 cdent where “right” is the same microversion it is currently using
19:14:34 mriedem we tend to hard-code to the latest in the client side nova code
19:14:37 mriedem which is bad, i realize
19:14:39 cdent it’s _good_ that it doesn’t do negotiation, instead its explicit, right?
19:14:44 cdent no, it’s good
19:14:46 mriedem well, in this case,
19:14:52 cdent it’s always good
19:15:00 cdent it’s a thing we’ve realized during the many microversion discussions
19:15:02 mriedem the client (scheduler/cell conductor) would need to know, do i PUT at version 1.12 or 1.8?
19:15:13 cdent s/discussions/therepy sessions/
19:15:40 edleafe mriedem: how would the client ever get anything other than "latest"?
19:15:45 cdent it would carry on doing whatever it is doing now, until we change it
19:15:54 cdent edleafe: because it always asks for a specific version
19:16:33 cdent mriedem: note, I’m not saying we should fix allocation_candidates (we probably should), just saying we’re not forced
19:16:45 mriedem ok so scheduler does a GET /allocation_candidates at 1.10 and stores the allocation_request in the Selection object which goes to the cell conductor,
19:16:59 mriedem the cell conductor makes a PUT /allocations/{consumer_id} request at 1.10, things should be OK
19:17:01 mriedem because it's old format
19:17:03 cdent right
19:17:27 mriedem now let's say in the future, we add something to GET /allocation_candidates that the scheduler needs, so it starts requesting 1.14
19:17:33 mriedem we shove 1.14 in the Selection object,
19:17:49 mriedem the cell conductor blindly does a PUT /allocations/{consumer_id} at 1.14 which is now the wrong format
19:17:53 mriedem and you get a 400 back
19:18:05 cdent except it would potentially die before then anyway
19:18:08 edleafe wait - why is 1.14 the wrong format for the PUT?
19:18:21 mriedem edleafe: because PUT /allocations/{consumer_id} format is going to change
19:18:26 mriedem per https://review.openstack.org/#/c/508164/5
19:18:39 cdent as it currently has code which modifies the allocation data structures
19:19:11 edleafe So requesting microversion 1.14 will return an alloc_cand that can't be PUT with 1.14?
19:19:12 cdent until we change the report client code that cooks allocations client side, we can’t up the microversion at which allocation_candidates is requested

Earlier   Later